- 23 Sep, 2019 40 commits
-
-
Jiawei Li authored
Previously, bindings_manager_cast target was guarded by is_linux. This should be available for all non-fuchsia builds. Bug: internal b/141398875 Test: CQ Change-Id: I21d95c65040956dd4446eff61dbd50acbb3f4e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815949Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#699041}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I313fd48f7c9384e4ae7af02ffc57dad83591bf7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699040}
-
Peter Kasting authored
Also takes advantage of initializer_list for vectors. Bug: 82078 Change-Id: Ic94d1971254f45fb6ec1925e30622e90f42224ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817414 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699039}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/341482072a19..49fd27d9af5f git log 341482072a19..49fd27d9af5f --date=short --no-merges --format='%ad %ae %s' 2019-09-23 jmadill@chromium.org Fix SwiftShader to use data_deps. 2019-09-23 jmadill@chromium.org Temporarily disable SwiftShader on Windows 7. 2019-09-23 jmadill@chromium.org Disable non-portable include path warning. 2019-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src f7a48b153f2a..973d0e538292 (1 commits) 2019-09-21 jmadill@chromium.org Re-land "Vulkan: SwiftShader integration." Created with: gclient setdep -r src/third_party/angle@49fd27d9af5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:995046,chromium:None,chromium:b/140251624 Change-Id: I0e6bf53898368820c533de9f42964f60e1cc9e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819333Reviewed-by:
-
Alex Cooper authored
When a frame is requested from the runtime, a frame has to be submitted back to the runtime. Even if that frame is a "missing" frame, without any updated data. This change refactors the logic around requesting a frame to ensure that a frame isn't requested unless the callbacks would be serviced. If the state changes in the middle of a frame, then some base layer should still be present to end the frame/submit the missing frame back before it is removed. If these conditions aren't met, the frame loop could stall out and never be in a recoverable state. This change also adds some tests around these conditions. Bug: 1001730 Change-Id: I3b97322a7a8b1c15b37743c873382755fca7ec42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814102Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#699037}
-
Kevin Qin authored
Reverse the order of xrlocatespace so we can get the correct transform from local to stage Bug: 1000808 Change-Id: Ie6aa7b644ea2c6b730a17e5544995051d5f471cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816291Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Zheng Qin <zheqi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699036}
-
Evan Stade authored
Bug: 998625 Change-Id: I239558c07ce10166b82a2b886ef08a1d4ede56f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817333Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#699035}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d166d2e62f3b..b3542d95da65 git log d166d2e62f3b..b3542d95da65 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 scroggo@google.com Rename SkOrientationMarker.cpp 2019-09-23 egdaniel@google.com Fix TEST_BUILDER name in perf recipe. 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-23 brianosman@google.com Minor SkSL cleanup 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-23 nigeltao@google.com Update Wuffs version 2019-09-23 egdaniel@google.com Remove Vulkan Nexus5x bot. 2019-09-23 bsalomon@google.com Make GrGpuResource ref counting atomic. 2019-09-23 fmalita@chromium.org [skottie] Fix motion blur asserts 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-23 brianosman@google.com Interpreter: Add bitwise operators Created with: gclient setdep -r src/third_party/skia@b3542d95da65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I003d226c9c7bb5336de4b8c2cc382a4c766eac58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819647Reviewed-by:
-
Adam Ettenberger authored
|LowestCommonAnchor| is always cheaper than |LowestCommonAncestor| when the ancestor position data is not needed. AXPlatformNodeTextRangeProviderWin::GetChildren does not use the position information, all information is available on the AXNode from calling |LowestCommonAnchor|. Bug: 928948 Change-Id: I48075202dca0172bfd6deea9188d3d636f996ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815224 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699033}
-
Adam Ettenberger authored
|LowestCommonAnchor| is always cheaper than |LowestCommonAncestor| when the ancestor position data is not needed. AXPlatformNodeTextRangeProviderWin::ExpandToEnclosingUnit for TextUnit_Page only needs the |LowestCommonAnchor| to know the result of |AXNode::OwnerTree()->HasPaginationSupport|. Bug: 928948 Change-Id: Ida1926da0c1d54b2a9b57abd1867862daa4b4984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815350 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/770af0ab..37dd8faa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I94e2f86a702f79992a3b5c3c5328c38d187f04c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819596Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699031}
-
Mathieu Binette authored
Updating the celab package - important changes since the last version: - https://crrev.com/c/1808402: Install PackageManagement on all machines. - https://crrev.com/c/1804276: Always install latest sysinternal. - https://crrev.com/c/1738716: Making UI tests work on nested VM. + Removed duplicate webdriver create code in some tests (already in test_util). This fixes all new failing tests after the last WinServer2012 GCE image update: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=celab_tests Before: https://cr-buildbucket.appspot.com/build/8902049557331501056 After: https://cr-buildbucket.appspot.com/build/8901992308375043184 Change-Id: Ia626751ba97b2d54e155bb1cee4ee5fee261dd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808345 Commit-Queue: Mathieu Binette <mbinette@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699030}
-
Ben Kelly authored
In crrev.com/c/1699373 BEST_EFFORT tasks were changed to delay until after browser startup. This unfortunately seems to also delay any storage API access that is managed by quota since quota initialization uses a BEST_EFFORT task. This change modifies the quota sub-system to use a USER_VISIBLE task so that initialize can complete prior to browser startup completing. This is an appropriate priority since storage APIs like cache_storage can block loading which is a user visible action. Bug: 1006546,1005983,1004041 Change-Id: I7fd0659855f26d0f3c1caf0185f2e9723c55c483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819595Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#699029}
-
Ben Joyce authored
When transitioning to androidx, android_core and androidx_core have conflicting manifests, so we need be able to skip including one. Bug: 1006427 Change-Id: I4fc4fac5e27cad7a3574773a62aaf0978f33f4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817335 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#699028}
-
manuk authored
Currently, the doc provider returns at most provider_max_matches_ docs, dropping any additional docs returned from the server. With this CL, the provider returns the remaining docs with a score of 0 so that they are displayed only if deduped with history, shortcut, or bookmark matches. This CL does not affect how many or which suggestions are displayed. It only helps format doc suggestions from other providers (e.g. 'Omnibox doc - 01/01/1991 - Google Docs'). Bug: 941548 Change-Id: I173b3f62d3af33f83a6531e086a0ecd0985db986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819629Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#699027}
-
Toni Barzic authored
With kEnableSearchBoxSelection feature, the focus stays within the search box while the selected result changes (instead of individual search results getting focused as selection changes) - this means that scroll view used by search results page does not handle selection changes automatically. This cl adds a callback to ResultSelectionController that SearchResultPageView can use to detect selection changes, and update the scroll bar to ensure the selected result is visible in the scroll view. Change-Id: Icf24b85174a12cac0b62592a080898cff6375da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819329Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#699026}
-
kylechar authored
Plumb callback and results between viz compositor and gpu threads. Bug: 982842 Change-Id: I1225757d42f4fc80a35ee556a76f401137971ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819621Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699025}
-
Manu Cornet authored
This reverts commit c113475d. Reason for revert: Didn't really serve its purpose. Reverting. Original change's description: > CrOS app list: skip visibility changes in an in valid display > > This is mostly useful for tests where the display ID starts off as this > invalid ID. > > Not adding a unit test in this change because after CL 1814222 at least > two tests will fail if this regresses. > > Bug: 982512 > Change-Id: Ie447aa88fda66794a722d7e9cf478749ff4f8398 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816734 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698656} TBR=xiyuan@chromium.org,newcomer@chromium.org,manucornet@chromium.org Change-Id: I4353f0ee3b10d481de13ab96be4b8c2b0801e8a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 982512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819636Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#699024}
-
Henrique Ferreiro authored
Convert the implementation and all users of the add_supervision::mojom::AddSupervisionHandler interface. Bug: 955171 Change-Id: Ic9acc52ff87ea9950fd782081d90aee9e973eab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805665Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#699023}
-
Peter Kotwicz authored
This CL removes the VIBRATE permission from the WebAPK manifest. The permission was needed for delegating notifications to the WebAPK in Jellybean. See crbug.com/773663 The permission is no longer needed because Chrome no longer supports Jellybean. This CL also: - Increments the minSdkVersion to KitKat - Deletes WebAPK/Webapp Jellybean-specific code BUG=923518 Change-Id: I167867b2ad32e94dd894dea7f2b61279aacdd3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818598 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699022}
-
Matt Menke authored
This code was used to prevent preconnecting multiple times to a proxy server that was known to support H2, but with the advent of storage isolation, this can potentially leak information between NetworkIsolationKeys. This CL removes that code. Another option would be to cache information on a per-NetworkIsolationKey basis, but unfortunately, since what servers support H2 must be scoped within a NIK, that would make the feature much less useful. QUIC proxies don't have this issue, fortunately. Bug: 993517 Change-Id: I55a584c37a929aeb59ca6260ea175b0200072086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815913Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#699021}
-
Andrew Xu authored
|last_visible_index_| of the main shelf view is updated in CalculateAppCenteringStrategy. However, when the scrollable shelf is enabled, |last_visible_index_| may be accessed before that function is called. As a result, an illegal index value may be used. Given that in scrollable shelf, |last_visible_index_| is always the index of the last shelf item. So updates |last_visible_index_| when a shelf item is added/removed. Bug: 1006165 Change-Id: I4bc13e204835828bb1d5f77024ce274b9899ced0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816142Reviewed-by:
-
Piotr Bialecki authored
Start using util::IdType from base. Change-Id: I1419a4a1065d99493e2d51f9e220cf20828716e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795895Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#699019}
-
Lei Zhang authored
Change the GURL parameter from base::Optional to a pointer, per guidance in docs/optional.md. Also simplify some related code and fix lint errors. Change-Id: I899f3877370a916ff8dc30402b2325351390286e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817660 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#699018}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/314adcb844e1..fdb59f0d9088 git log 314adcb844e1..fdb59f0d9088 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 tandrii@google.com Revert "git-cache: don't limit pack files to 2GiB." 2019-09-23 rharrison@chromium.org Add Dawn to projects for my_activity.py 2019-09-23 qyearsley@chromium.org Remove some unused private things in git_cl Created with: gclient setdep -r src/third_party/depot_tools@fdb59f0d9088 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I3c71eb86c8026762ef5fdfd99aec8c7da028a915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819107Reviewed-by:
-
Karan Bhatia authored
This CL enables two currently disabled flaky tests: - ExtensionWebRequestApiAuthRequiredTest.WebRequestAuthRequired - ExtensionWebRequestApiAuthRequiredTest.WebRequestAuthRequiredAsync Additional debugging is added to detect the cause of flakiness. Once we get new failure logs for these, we can hopefully find a fix. Note for sheriffs: This is enabling flaky tests. Please paste failure logs on the bug (from deterministic failures) before disabling the test again. Also, prefer disabling the test to reverting this CL. BUG=1003598 Change-Id: I921bec19f038319e4a530c3437e6582363ef694e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814867 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#699016}
-
Peter Kasting authored
This was really a bounds change listener. Also reorder functions to match View declaration order. Bug: 1005568 Change-Id: Ic69db01b130d0e75f19bab186f6379e4902206d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817362 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699015}
-
Patrick To authored
This is a reland of e475b274 Original change's description: > Update WMR display info when starting session > > I3491d43245bb53100212fd2d0ab38d8f1222e7c9 addresses the issue where the > render width/height is not initially sent back to the render process. > This is accomlpished by updating the display info when the session starts > instead of on the first render frame. > > A subsequent change, I4cf2ab2ed6455963b1f43f8717941e7a0368416a, wraps > this update around the visibility state. Since the visibility state is > initially hidden, the display info isn't updated resulting in > WebVR/WebXR pages using the wrong resolution > > This change explicitly updates the display info and sends it back to the > MixedRealityDevice when the session starts. > > Change-Id: Ifb4516b36203139038aa943d68e8c3ba717003f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810303 > Commit-Queue: Patrick To <patrto@microsoft.com> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698172} Change-Id: I7289fdc18f2d99a0ab29eb86af0b9dbed13ba275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819703Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Manas Verma authored
Toggle switch on settings page that opts in/out the user from using FIDO Auth for card unmasking. Bug: 949269 Change-Id: Idd1a04479c0f7c7a4f085714769e04ee7672ef4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738721 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#699013}
-
Adam Ettenberger authored
This is CL [3/4] in a series of CLs to expose "display: none" elements to the browser process AXTree. 1. Add and improve tests for CSS display and visibility. 2. Introduce new command line flag and chrome://flags entry. 3. Update AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree and relevant logic for the feature to work, disabled using the feature flag. 4. Enable the feature in tests; update expectation files. --- This change hooks up everything required to expose nodes that are "display: none" to be exposed to the browser-side AX tree with the State::kIgnored, but behind a RuntimeEnabledFeatures. Doing so allows elements with "display: none" to be returned from UIA_DescribedByPropertyId and UIA_LabeledByPropertyId. This change can be observed in the update to AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree(). --- There was a bug with AXNodePosition::AsUnignoredTextPosition when a leaf text position was the first or last in a document. It would fail to find the next/previous unignored position because it only searched in one direction. In the case where the last node in a document is ignored, we must search in reverse order if no unignored position can be found in the forward direction. --- In response to AXEventGenerator::Event::IGNORED_CHANGED, we now also need to fire menu opened / closed events for MSAA and UIA. This is because when a menu goes from ignored to unignored it is exposed to the accessibility tree as a new node, similar to if a new unignored menu was added to the DOM via script. --- Modifying AXObjectCacheImpl::HandleRoleChangeWithCleanLayout so that it will create the AXObject if it doesn't exist already. This fixes an invalidation issue when changing the role of an element where the parent object may not be invalidated for a change in its children. This is needed to fix : blink/web_tests/accessibility/is-ignored-change-sends-notification.html I tested |divWithoutRoleContainer| in isolation without my change and it appears that test case was providing a false-positive before. --- Deferring ax::mojom::Event::kBlur and ::kFocus when calling |AXObjectCacheImpl::HandleFocusedUIElementChanged|. I needed to defer this event due to my changes in |AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree|. This is because the following stack will have a DCHECK failure : Check failed: !GetDocument().NeedsLayoutTreeUpdateForNode( *this, true ) ``` blink::Element::EnsureComputedStyle blink::AXObject::IsHiddenForTextAlternativeCalculation blink::AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree blink::AXObject::UpdateCachedAttributeValuesIfNeeded blink::AXObject::AccessibilityIsIgnored blink::AXObjectCacheImpl::GetOrCreate blink::AXObjectCacheImpl::FocusedObject blink::AXObjectCacheImpl::HandleFocusedUIElementChanged ``` --- Bug: 651614 Change-Id: Ieef8e43d19de147beb827139e761085b1d13d0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808430 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699012}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3a8610d6571..112a550769c4 Created with: gclient setdep -r src-internal@112a550769c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9c67890315403d5cc936b6af8277d8771e436dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819135Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699011}
-
Robert Ogden authored
Moves all the remaining logic to the Interceptor. Also renames the GetURL method to something more specific to this preview type. Bug: 1005295 Change-Id: I4a129d1689887d55089f64ffdcc6446047e8e7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818433Reviewed-by:
-
Andrew Xu authored
This CL ensures that the gradient zone shows correctly under RTL. Bug: 1004134 Change-Id: Ie59f7df4242daf2ae5cb13d01e3d9e971d69ed9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805188Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699009}
-
Tom Anderson authored
This CL changes StatusIconLinuxDbus to send the icon as a file instead of as a DBus property. All of the StatusNotifierItem client libraries send icons as files, so some StatusNotifierHosts don't behave well when given an icon property since that codepath wasn't ever tested. gnome-shell-extension-appindicator doesn't scale property icons, but does scale file icons. wingpanel-indicator-ayatana (used on Pantheon) only supports file icons. There's no way using StatusNotifierWatcher to get information about specific StatusNotifierHosts. So the only way we can detect these two hosts is based on the desktop environment. To prevent race conditions involved with cleanup up the icon file, StatusIconLinuxDbus must be made ref-counted, which adds some unfortunate complexity. BUG=10034265 R=thestig Change-Id: I79db4b83f6ab49319069b11ab761bd23985eeba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815055 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699008}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bf5be75f420c..c171a2106b2b git log bf5be75f420c..c171a2106b2b --date=short --no-merges --format='%ad %ae %s' 2019-09-23 thestig@chromium.org Split shading rendering code into its own file. 2019-09-23 nigi@chromium.org Fix the TrueType font not rendered correctly issue. 2019-09-23 thestig@chromium.org Add a test for a checkbox that does not print. Created with: gclient setdep -r src/third_party/pdfium@c171a2106b2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:861842 Change-Id: I3604d12cde621e4abd689d4d48e2c6cdac78adb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819133Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/605c2e3c0ea7..3a762d54f649 git log 605c2e3c0ea7..3a762d54f649 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 dsinclair@google.com Add missing GN dependency (#2899) 2019-09-23 afdx@google.com Employ the "swarm testing" idea in spirv-fuzz (#2890) 2019-09-23 afdx@google.com Fix operand index in spirv-fuzz (#2895) 2019-09-23 dneto@google.com Update DEPS: effcee, re2, googletest (#2881) 2019-09-23 dneto@google.com Add method comment for opt::Function::WhileEachInst (#2867) 2019-09-20 stevenperron@google.com Use OpReturn* in wrap-opkill (#2886) 2019-09-20 afdx@google.com Fix to CMakeLists for spirv-fuzz tests (#2888) 2019-09-20 afdx@google.com Allow validation during spirv-fuzz replay (#2873) 2019-09-20 afdx@google.com Disable long-running fuzzer tests by default (#2887) 2019-09-20 stevenperron@google.com Revert "Use OpReturn* in wrap-opkill" 2019-09-20 stevenperron@google.com Use OpReturn* in wrap-opkill 2019-09-19 ehsannas@gmail.com Fix header include syntax. (#2882) 2019-09-19 stevenperron@google.com Handle OpConstantNull in copy-prop-arrays. (#2870) 2019-09-19 dneto@google.com Fix comment typo found by protobufs linter (#2884) 2019-09-19 dsinclair@google.com Move docs into docs/ folder (#2872) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3a762d54f649 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com,dsinclair@google.com Bug: None Change-Id: I77a97a0a64eb19f82d4d6eb65a8f088c5ee8ffb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819101Reviewed-by:
-
Mandy Chen authored
This CL: * updates parseLocalizableResourceMaps to return maps of localizable resources * removes localizable resources from exports * fixes non-async functions * fixes existing parsing error This CL is in preparation of https://crrev.com/c/1671848. Bug: 941561 Change-Id: Id18faf3086fb8d9d3c75b110733784ba95cf56e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814539 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699005}
-
Oksana Zhuravlova authored
Change-Id: I7ecb680714be3a4459fb49bb8290eec66d5295a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816447Reviewed-by:
-
Matt Mueller authored
Change-Id: I5ff12697f60a2d98f979823f2179aafd5cdc409b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810841 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699003}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eb06d51adc82..d239d4d3493a git log eb06d51adc82..d239d4d3493a --date=short --no-merges --format='%ad %ae %s' 2019-09-23 skyostil@google.com Merge "Disable leak sanitizer tests on debug and embedder builds" 2019-09-23 treehugger-gerrit@google.com Merge "Fix comment referencing GetLastError." 2019-09-23 taylori@google.com perfetto-ui: Fix build 2019-09-23 primiano@google.com Merge "PacketStreamValidator: get rid of libprotobuf" 2019-09-23 hjd@google.com Merge "perfetto-ui: Add search for userland slices" 2019-09-23 nicomazz@google.com Perfetto UI: Fix unresponsive probe clicks 2019-09-21 primiano@google.com Merge "Do clang-format on gpu_counter_descriptor." 2019-09-20 lalitm@google.com trace_processor: remove virtual track table and replace with async track table 2019-09-20 lalitm@google.com Merge "trace_processor: add hint flags indiciating the content of the column" 2019-09-20 treehugger-gerrit@google.com Merge "perfetto-ui: Fix snake_case variable" 2019-09-20 primiano@google.com Enable sanitizer tests only on Linux/Android 2019-09-20 fmayer@google.com Merge "Use trace processor for `trace_to_text symbolize`." 2019-09-20 lalitm@google.com Merge "bazel: expose merged proto to Bazel" 2019-09-20 rsavitski@google.com Merge "Fix build rules in tools" Created with: gclient setdep -r src/third_party/perfetto@d239d4d3493a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I2fd2001d5e318a7e09cc31c403a9576f085645f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819134Reviewed-by:
-
