GitLab

BUG=411056

Review URL: https://codereview.chromium.org/638133003

Cr-Commit-Position: refs/heads/master@{#299813}

Fix an issue where the last-requested display power state
was bound to a delayed task on resume. If a new state was
requested while the task was waiting to run (e.g. due to
exiting docked mode), the task would later restore the old
state.

Instead, add a thunk for the task that always uses the
currently-requested state.

BUG=chrome-os-partner:32393

Review URL: https://codereview.chromium.org/652073002

Cr-Commit-Position: refs/heads/master@{#299812}

The test LastBookmarkResizeBehavior implicitly relied on the default system
font. The system font changed from 10.9 to 10.10, breaking the test. I updated
the test to use a different set of parameters on OSX 10.10+.

BUG=390276

Review URL: https://codereview.chromium.org/659693002

Cr-Commit-Position: refs/heads/master@{#299811}

I expected the mojo_native_viewport_service to use -- as a prefix for its
arguments:

mojo_shell --args-for="mojo://mojo_native_viewport_service/ --use-headless-config"

but prior to this CL, it was expect its arguments without the leading "--".
After this CL, it expects the leading "--".

R=davemoore@chromium.org,hansmuller@chromium.org

Review URL: https://codereview.chromium.org/661513002

Cr-Commit-Position: refs/heads/master@{#299810}

R=enne

Review URL: https://codereview.chromium.org/662473003

Cr-Commit-Position: refs/heads/master@{#299809}

NaCl does not support glibc on ARM so all glibc-related
tests should be disabled on ARM.

BUG=422592
TEST=linux_arm trybot

Review URL: https://codereview.chromium.org/652873002

Cr-Commit-Position: refs/heads/master@{#299808}

Two sets of changes:
. fix gn dependencies
. make views_init work in the static library

The latter means wm_flow_init and demo_launcher only work with gn (not gyp).

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/658753004

Cr-Commit-Position: refs/heads/master@{#299807}

These tests currently fail when run in --site-per-process mode.  They will be reenabled gradually as we do more work on site isolation.

BUG=417518

Review URL: https://codereview.chromium.org/621913002

Cr-Commit-Position: refs/heads/master@{#299806}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL instruments callbacks of TranslateURLFetcher::OnURLFetchComplete:
1. TranslateLanguageList::OnLanguageListFetchComplete
2. TranslateScript::OnScriptFetchComplete

BUG=422577
TBR=andrewhayden@chromium.org

Review URL: https://codereview.chromium.org/656183002

Cr-Commit-Position: refs/heads/master@{#299805}

* Adding handling of connection events to the tracker
* Adding a method sanitizing tokens (removing expired ones)
* Adding relevant account tracker tests
* Making account mapper aware of gcm driver being started
* Making sure ShutdownHandler implementation is safe to
  call RemoveAppHandler (without causing a stack trace due
  to invalid iterator)
* Making sure that account mapper does not count toward
  registered app handlers when deciding to stop GCM Driver
* Updating FakeOAuth2TokenService to allow token request to
  be repeated.

Based of patch: https://codereview.chromium.org/617003005/

BUG=374969
TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/618003002

Cr-Commit-Position: refs/heads/master@{#299804}

Change the method name from can_scroll_orientation() to
CanScrollOrienattion() to comply with the style guide.

This is a follow up to https://codereview.chromium.org/655783004

BUG=370892

Review URL: https://codereview.chromium.org/637283004

Cr-Commit-Position: refs/heads/master@{#299803}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8dfdfff..ae6d622

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/644003003

Cr-Commit-Position: refs/heads/master@{#299802}

BUG=none

Review URL: https://codereview.chromium.org/662493003

Cr-Commit-Position: refs/heads/master@{#299801}

Darin had previously argued that we did not need |url|, as that can be
gotten from response. But we do need a way for content handlers to know
the url of the app connecting to them.

Review URL: https://codereview.chromium.org/638293005

Cr-Commit-Position: refs/heads/master@{#299800}

These bots should run when required by our top-level detection of what
bots are needed. And the GPU bots are in the default sets of bots now.

Review URL: https://codereview.chromium.org/661613002

Cr-Commit-Position: refs/heads/master@{#299799}

It's a convention in unix for programs to first search for a program
specific editor variable. For example, SVN_EDITOR or GIT_EDITOR. This
makes GN follow this same convention.

BUG=none

Review URL: https://codereview.chromium.org/654333002

Cr-Commit-Position: refs/heads/master@{#299798}

BUG=423621

Review URL: https://codereview.chromium.org/657763002

Cr-Commit-Position: refs/heads/master@{#299797}

BUG=

Review URL: https://codereview.chromium.org/647053003

Cr-Commit-Position: refs/heads/master@{#299796}

For File URI, some earlier android versions (<JB MR2) cannot handle it correctly
Convert it to absolute path fixes the issue.
For JB MR2 and above devices, we use content URI, so not affected.

BUG=423338

Review URL: https://codereview.chromium.org/655303002

Cr-Commit-Position: refs/heads/master@{#299795}

Revert of Eliminate silently letting errors pass on pak loading. (patchset #18 id:340001 of https://codereview.chromium.org/537063002/)

Reason for revert:
Causing content_browsertests failures due to pak loading failure.

Original issue's description:
> Eliminate silently letting errors pass on pak loading.
>
> BUG=410411
> TEST=no visible change
>
> Committed: https://crrev.com/03c8c9d936594163d43222a3da0268b3dd9af656
> Cr-Commit-Position: refs/heads/master@{#299717}

TBR=bengr@chromium.org,caitkp@chromium.org,tfarina@chromium.org,tony@chromium.org,avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410411

Review URL: https://codereview.chromium.org/661503003

Cr-Commit-Position: refs/heads/master@{#299794}

BUG=405865,417048,419373
NOTRY=true
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/661653005

Cr-Commit-Position: refs/heads/master@{#299793}

One external invariant of RWHVAndroid is that if it has a valid attached
ContentViewCore, its TouchSelectionController will be non-null. However,
there are no guarantees that these lifetimes hold for methods *internal*
to RWHVAndroid. One such violation came when the frame had a non-zero
lock count when the attached ContentViewCore was changed; releasing the
surface lock caused a frame metadata update, in turn accessing the
TouchSelectionController that had already been reset.

As a workaround, guard against this and possible future violations by
always checking the controller for validity before using it.

BUG=419619

Review URL: https://codereview.chromium.org/653883003

Cr-Commit-Position: refs/heads/master@{#299792}

He's no longer working on chromium, so this confuses people
looking for a reviewer.

R=enne

Review URL: https://codereview.chromium.org/654293004

Cr-Commit-Position: refs/heads/master@{#299791}

In r546e2e69 GetSheetParentBoundsForParentView was added to work around
the presense of dev tools in the view hierarchy when calculating the center
of the web contents view. In an app window there is no dev tools view so
this patch falls back to the parent view's normal bounds.

BUG=

Review URL: https://codereview.chromium.org/659823003

Cr-Commit-Position: refs/heads/master@{#299790}

BUG=394895,412547

Review URL: https://codereview.chromium.org/601333002

Cr-Commit-Position: refs/heads/master@{#299789}

This replaces some copy-pasted snippets of code with a centralized
utility for securely initializing a SecureRandom instance (needed for
Android versions <= 4.3).

BUG=402732

Review URL: https://codereview.chromium.org/624183002

Cr-Commit-Position: refs/heads/master@{#299788}

Revert of [src/chrome/browser/] Declaring the weak_ptr_factory in proper order in ui and prerender (patchset #1 id:1 of https://codereview.chromium.org/612783003/)

Reason for revert:
Author ignored review comments from multiple reviewers and failed to fix or revert his change after repeated inquiries as to why.

Original issue's description:
> [src/chrome/browser/] Declaring the weak_ptr_factory in proper order in ui and prerender
>
> Cleaning up weak_ptr_factory destruction order.
> WeakPtrFactory should remain the last member so it'll be destroyed and
> invalidate its weak pointers before any other members are destroyed.
>
> BUG=303818
>
> Committed: https://crrev.com/5c10e8618bb1c326b18395224b46c41f60867b30
> Cr-Commit-Position: refs/heads/master@{#299059}

TBR=cbentzel@chromium.org,dcheng@chromium.org,kulkarni.a@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=303818

Review URL: https://codereview.chromium.org/658943002

Cr-Commit-Position: refs/heads/master@{#299787}

BUG=418375

Review URL: https://codereview.chromium.org/645763004

Cr-Commit-Position: refs/heads/master@{#299786}

BUG=290407,332328,370206
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/642513003

Cr-Commit-Position: refs/heads/master@{#299785}

These were flaky because we changed to returning profiles in reverse chronological order: https://codereview.chromium.org/600873002

The tests assumed normal chronological order. It only failed sometimes because frequently two items would get inserted with the same timestamp, so ordering fell back to GUID. Thus by placing sleep(1) in between AddProfile calls, the flaky failures become consistent failures.

BUG=420023

Review URL: https://codereview.chromium.org/652193005

Cr-Commit-Position: refs/heads/master@{#299784}

These will be developed in GN only from now on.

BUG=423889

Review URL: https://codereview.chromium.org/647263005

Cr-Commit-Position: refs/heads/master@{#299783}

R=enne

Review URL: https://codereview.chromium.org/657103003

Cr-Commit-Position: refs/heads/master@{#299782}

BUG=407376
TEST=no change

Review URL: https://codereview.chromium.org/659843002

Cr-Commit-Position: refs/heads/master@{#299781}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0e08fc1..8dfdfff

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/655333002

Cr-Commit-Position: refs/heads/master@{#299780}

Only added in API 17:
http://developer.android.com/reference/android/view/View.html#setTextDirection(int)

BUG=411056

Review URL: https://codereview.chromium.org/644283003

Cr-Commit-Position: refs/heads/master@{#299779}

Review URL: https://codereview.chromium.org/662503002

Cr-Commit-Position: refs/heads/master@{#299778}

Adds a missing type that was introduced in
https://crrev.com/55721c1fd3bb640d29491407572c7dbb56975ca5

Review URL: https://codereview.chromium.org/654323002

Cr-Commit-Position: refs/heads/master@{#299777}

This frees ExtensionDownloader of any remaining
dependencies on //chrome in preparation for its
move to //extensions/browser.

The move is left for a follow-up CL.

BUG=398671

Review URL: https://codereview.chromium.org/651403003

Cr-Commit-Position: refs/heads/master@{#299776}

Fix indentation issues to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/657163004

Cr-Commit-Position: refs/heads/master@{#299775}

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3963
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/657933002

Cr-Commit-Position: refs/heads/master@{#299774}