- 21 Sep, 2018 40 commits
-
-
Ben Pastene authored
Turns out it does need it. I think MB and/or isolate has a dependency on this file being written for isolated tests. Bug: 888000 Change-Id: I57f86167f0bafdb1a4d081d6811bbcff3409b551 Reviewed-on: https://chromium-review.googlesource.com/1239253Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#593281}
-
Anne Lim authored
Implemented StrikeSystem Architecture, which includes functions to Get, Add, and Clear strike count Bug: 884817 Change-Id: I3d936dd902213646d6bcd84e9a5fbfe8eee4fbea Reviewed-on: https://chromium-review.googlesource.com/1231988Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#593280}
-
Sammie Quon authored
Test: ash_unittest HomeLauncherGestureHandlerTest.Split* Bug: 887163 Change-Id: Iae804b7c6b318177bfa11a154ce3878f491a5836 Reviewed-on: https://chromium-review.googlesource.com/1235322Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#593279}
-
Nico Weber authored
This reverts commit 8e5ef240. Reason for revert: Relanding with HungRendererController removed as well. Original change's description: > Revert "mac: Remove unused TabDialogsMac/TabDialogsCocoa." > > This reverts commit 50439b88. > > Reason for revert: > Mac bots start failing after this CL on HungRendererControllerTest. > The error logs are below. > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29038 > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934838111834185888/+/steps/unit_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/HungRendererControllerTest.TestKillButton/0 > > Original change's description: > > mac: Remove unused TabDialogsMac/TabDialogsCocoa. > > > > Bug: 832676 > > Change-Id: I0fb8d4b1f0197dab0b988a52741724f63a18ee9f > > Reviewed-on: https://chromium-review.googlesource.com/1236178 > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#592819} > > TBR=ellyjones@chromium.org,thakis@chromium.org > > Change-Id: I6554e741ef31bc99da0c90e3c4fd2bb8826a741f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 832676 > Reviewed-on: https://chromium-review.googlesource.com/1237797 > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593085} TBR=ellyjones@chromium.org,thakis@chromium.org,tzik@chromium.org Change-Id: I5e076b202734c727608279952fad9d1b5657636b Bug: 832676 Reviewed-on: https://chromium-review.googlesource.com/1238595Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593278}
-
Torne (Richard Coles) authored
Update the checks in rules.gni so that _native_libs_file_arg is set in the same cases that it is used; otherwise APKs that contain a loadable module but not a "main" shared library fail. Change-Id: I88e0c169199af9625dcb7750f9bcd0a9b3dca4b7 Reviewed-on: https://chromium-review.googlesource.com/1238781Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#593277}
-
Miguel Casas authored
This CL adds a parameter |is_opaque| to CanvasResourceDispatcher's DispatchFrame{Sync}() and the private PrepareFrame(), and wires it to the (offscreen, normal) Context's IsOpaque(). Two motivations: - offscreen canvas should respect the opacity of the context (they don't do that now on ToT). - |is_opaque| is needed when creating the viz::SharedQuadState and setting viz::DrawQuad::needs_blending. This quad needs to be opaque to promote it to underlay adequately on CrOs (and when promoted to overlay, we can also avoid re compositing what's below). offscreen_canvas_test.cc and html_canvas_element_module_test.cc are extended to test this new code: for that, Mock mojo objects are defined in mock_viz_mojo.h, and plugged in the respective tests so that the CompositorFrames can be inspected for opacity/transparency (tests are parameterised to try the combinations). Made a few vars const and a few const constexpr, removed superfluous {}. Bug: 878801, 705019 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ice1f02adee79b13b9a3f8ae915594b71487bb963 Reviewed-on: https://chromium-review.googlesource.com/1228859Reviewed-by:Stephen White <senorblanco@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#593276}
-
dpapad authored
Bug: None Change-Id: I15ad232b6e8bff08df4fd701db7f23be13fbb053 Reviewed-on: https://chromium-review.googlesource.com/1238993 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#593275}
-
Francois Doray authored
Instead of storing the lifecycle state in a property, store it in a typed member and provided a typed accessor. This will simplify code that empties the working set of renderers in which all frames are frozen (upcoming CL). Bug: 885293 Change-Id: Ic414071efa6c5994501948173600c51a7651b2e9 Reviewed-on: https://chromium-review.googlesource.com/1232016 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593274}
-
Fabrice de Gans-Riberi authored
The Buffer mode is being removed from the FIDL definition. Bug: 874155 Change-Id: If308f2074a35b071f4fa50d087944ece89574142 Reviewed-on: https://chromium-review.googlesource.com/1237135Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#593273}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/96e1c6b7ce91..282087a14c84 $ git log 96e1c6b7c..282087a14 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 theonetruecamper sanitizer: fix unaligned load/stores 2018-09-19 theonetruecamper fix UB when initializing parameterized tests 2018-09-19 angiebird Add feature score for each block 2018-09-19 angiebird Correct mv rows/cols bug in read_frame_dpl_stats 2018-09-17 theonetruecamper Fix stack corruption with x86 and --enable-pic 2018-09-18 huisu Remove unnecessary code 2018-09-18 huisu Remove the SECOND_LEVEL_CHECKS_BEST macro 2018-09-13 jingning Rename set_arf_sign_bias() to set_ref_sign_bias 2018-09-17 jingning Re-work set_arf_sign_bias() 2018-09-17 jingning Update frame index per buffer at encoder 2018-09-17 jzern vpx_mem: allow VPX_MAX_ALLOCABLE_MEMORY to be overridden 2018-09-17 jingning Add a frame_index entry to RefCntBuffer 2018-09-17 jingning Assign GOP frame offset to all the coding frames 2018-09-17 paulwilkins Remove multi_arf_last_grp_enabled flag. 2018-09-17 paulwilkins Remove multi_arf_enabled. 2018-09-17 paulwilkins Remove multi_arf_allowed variable. 2018-08-22 jzern cosmetics: normalize include guards 2018-09-14 pengliu.mail fix a bug of tiny_ssim to handle odd frame sizes 2018-09-14 pengliu.mail fix a bug of tiny_ssim when the bit depth is 8 2018-09-13 angiebird Fix mv_arr assignment (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I2ec850488441a14dd6ee6118f21f0e13c23f33ec Reviewed-on: https://chromium-review.googlesource.com/1238824Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#593272}
-
Zach Helfinstein authored
Bug: 884297 Change-Id: Iff20201277983eed3d851279ed6e7042ae17d250 Reviewed-on: https://chromium-review.googlesource.com/1237554 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593271}
-
Lukasz Anforowicz authored
Bug: 881812 Change-Id: I7e9eddb4386baac05e9292463f9f597132c5c14e Reviewed-on: https://chromium-review.googlesource.com/1222684 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#593270}
-
Sadrul Habib Chowdhury authored
Two notable changes: . Do async targeting even if the target is a browser-plugin. . Check to see if the hit-test result from blink is a BrowserPlugin, and if it is, return the FrameSinkId of that as the target. BUG=880122 Change-Id: I6814161b0795ec2de6f1e28ccb8625008d7b284b Reviewed-on: https://chromium-review.googlesource.com/1237543Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#593269}
-
James Cook authored
TrayBubbleView uses a custom ui::EventHandler to activate the system tray bubble when the user presses the tab key. It was being registered with the wrong aura::Env under SingleProcessMash. Fixing this makes all exo_unittests pass under SingleProcessMash, so eliminate the test filter file. TBR=oshima@chromium.org Bug: 880515 Test: exo_unittests, manually follow steps in bug on veyron_minnie Change-Id: I69cbfd15b8c00499241f9b7ddb683e739ef14018 Reviewed-on: https://chromium-review.googlesource.com/1235117 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593268}
-
Samuel Huang authored
Previously generate_milestone_report.py only creates milestone diff reports. This CL modifes the script to generate reports for single milestones for independent viewing. UI updates will be done as a follow-up. Bug: 880671 Change-Id: I91013d24f4d123292a77d35a4eebea9b9b01bda7 Reviewed-on: https://chromium-review.googlesource.com/1239156Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593267}
-
Tatiana Buldina authored
Enabling ChromeOptionsFunctionalTests.* tests due to fix defect 2572 (https://chromium-review.googlesource.com/c/chromium/deps/webdriver/+/1236222) Bug: chromedriver:2572 Change-Id: I7477da94180a37aa23c713805269cadb78b15a00 Reviewed-on: https://chromium-review.googlesource.com/1238443Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#593266}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/381f401bc444..39707b216ffe Created with: gclient setdep -r src-internal@39707b216ffe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I622d6e53017c0b3f70ce218c15af2bc34865b796 Reviewed-on: https://chromium-review.googlesource.com/1239053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593265}
-
Matthew Denton authored
Bug: 887783 Test: /proc/{network process pid}/status shows no capabilities Change-Id: I08c7d6665c520b361a1a48bcd2f1a5812dadce52 Reviewed-on: https://chromium-review.googlesource.com/1229363Reviewed-by:Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#593264}
-
Artur Khachatryan authored
Disabling testShouldCaptureScreenshotOfCurrentViewport was done by mistake when we run the test on local machine without "--chrome" flag. This test must be run with the flag "--chrome=<path_to_chrome_binaries>" Bug: chromedriver:2480 Change-Id: I21cc8c155a1eec1952eb3e50b2dcd27a8aa450cb Reviewed-on: https://chromium-review.googlesource.com/1238825Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593263}
-
Frank Liberato authored
This reverts commit 6e1bb98a. Reason for revert: https://chromium-review.googlesource.com/1238859 reverted the original CL, tests pass again. Original change's description: > [Build Sheriff] Disable various tests pending fix. > > NOTRY=true > TBR=nohle@chromium.org, dtrainor@chromium.org > > Bug: 887953 > Change-Id: I3a3f3ea828c86873fdea72d75c50a83a83271408 > Reviewed-on: https://chromium-review.googlesource.com/1238377 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593189} TBR=liberato@chromium.org Change-Id: Idf5e5d75ed6087c52d6b70e0e51126ceec000a27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887953 Reviewed-on: https://chromium-review.googlesource.com/1239257Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593262}
-
Brian Osman authored
This was effectively testing the old behavior of makeColorSpace (that it always produces the same color type). We don't want that behavior, and we can't guarantee that color types will be preserved through encoding and decoding). Bug: skia:8382 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibabe3333545d72f9c697c57ee9b1b5ed3a2c4431 Reviewed-on: https://chromium-review.googlesource.com/1238779Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#593261}
-
Frank Liberato authored
This reverts commit 254369a5. Reason for revert: <INSERT REASONING HERE> Original change's description: > bindings: Implement timers with V8Function > > This fixes bug 866610 by using the IDL infrastructure to properly enter > the v8::Context before calling the registered callback. > > Also ensure eager finalization of ScheduledAction in DOMTimer to > prevent a memory leak. Added two more effective DCHECKs to confirm. > > Bug: 866610 > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > Reviewed-on: https://chromium-review.googlesource.com/1220486 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593108} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866610 Reviewed-on: https://chromium-review.googlesource.com/1239216Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593260}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/998ad81680e0..0464dbfe8e21 git log 998ad81680e0..0464dbfe8e21 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 dgarrett@google.com cidb: UpdateMetadata to include branch. Created with: gclient setdep -r src/third_party/chromite@0464dbfe8e21 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0bc2e9f45792ccb3f400e46d88fbf2dad6261b6d Reviewed-on: https://chromium-review.googlesource.com/1238937Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593259}
-
Lei Zhang authored
PDF contents have to be fit into the printable area before the PDF gets flattened for printing. Otherwise some PDFs will not print correctly. r554188 flipped the ordering, so this flips it back. BUG=873840 Change-Id: I68a05d0951caa31080b3b9bb424d458a899b92a7 Reviewed-on: https://chromium-review.googlesource.com/1237719Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#593258}
-
Oystein Eftevaag authored
Some unnoticed debug sizing caused the host-side tracing buffer to be a bit larger than necessary. R=ssid@chromium.org Bug: 886685 Change-Id: I56f3ed15952d7f0d6382b6e939c5386169f672b8 Reviewed-on: https://chromium-review.googlesource.com/1236663Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#593257}
-
Andrey Kosyakov authored
Drive-by: remove references to NetLog. Bug: 877075 Change-Id: I9fa4df67d89793754f8502a4e756f86c84571129 Reviewed-on: https://chromium-review.googlesource.com/1232616Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#593256}
-
Xida Chen authored
This change enables PaintTouchActionRects by default. This is a new implementation of how the blink->cc logic works for the css touch-action feature. The big idea behind PaintTouchActionRects is to compute touch-action rects during paint, in paint order, as part of the background paint phase. With this change we expect better performance (primarily a drop in ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as well as observable bug fixes (e.g., https://crbug.com/826746). Bug: 836905, 881894 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47a26250bad4c9e208b4f9b11e8eea3cf4d182aa Reviewed-on: https://chromium-review.googlesource.com/1233114Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593255}
-
Philip Rogers authored
This change introduces cc::Layer::SetChildLayerList and uses it to avoid re-attaching all layers every frame when using layer lists. This is one step closer to sending a layer list to cc instead of a layer tree. The primary change is to remove the call to RemoveChildLayers in PaintArtifactCompositor::Update. Instead of attaching layers to the root layer incrementally, they are built up using LayerListBuilder and then set on the root layer in a single step. This approach revealed some dependencies that are no longer true. Because the host tracks layers that need to push, it is important that Layer's host is set prior to calling any Layer setters. Layer::SetElementId only worked in layer list mode because the Layer's host was not set; this has been fixed. Bug: 879650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I894297dff3c1cdebacb3485abc3bec1d855e9afc Reviewed-on: https://chromium-review.googlesource.com/1226264Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593254}
-
Dmitry Gozman authored
We don't use the public version anymore, so we now host NavigationState in InternalDocumentStateData instead of DocumentState. This also fixes a bug where we forgot to clone InternalDocumentStateData when cloning DocumentState. TBR=boliu@chromium.org,jochen@chromium.org Bug: none Change-Id: Ieeed9a73ed3791c7adcf831eb832c87b20a55bc5 Reviewed-on: https://chromium-review.googlesource.com/1236341 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#593253}
-
Dale Curtis authored
https://crrev.com/592977 disabled these tests for browser_tests which doesn't even run on Android... Instead they should have been disabled in content_browsertests. This also re-enables the tests elsewhere where they should already be passing due to the browser_tests coverage. BUG=778245 TEST=none TBR=xhwang Change-Id: Iabe79be96f8edb9d5aca3b2dd7e8ed3827c62999 Reviewed-on: https://chromium-review.googlesource.com/1238832Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593252}
-
Tarun Bansal authored
Network Quality Estimator (NQE) encapsulates int32_t as a base::Optional<int32_t> at some of the places. This happens on-the-fly. This is confusing, and may also be the cause of some of the crashes. Change-Id: I66142aa5047d9da577d60e17b3186c37b0c9a149 Bug: 887162 Reviewed-on: https://chromium-review.googlesource.com/1237730Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593251}
-
rbpotter authored
Fix the sizing of the print destinations list so that it is always set to the maximum of the available space and 3 destinations of height. This will ensure there is no double scrollbar unless the dialog is extremely short. Bug: 884741 Change-Id: Ieba1a4e634d667b2e6e5567cf6f80f5962bd0fde Reviewed-on: https://chromium-review.googlesource.com/1235120Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593250}
-
rbpotter authored
2 bugs in the scaling section: (1) Fix a pre-existing bug where the scaling input incorrectly displayed 0 and an error when fit to page was checked for a non-uniform page size PDF (2) Prevent cr-input from expanding to the full row to try to fix a bug with touch on Windows. Bug: 874226, 886854 Change-Id: I8cb8785129f125a17a2ea8715ec85af3b467cad8 Reviewed-on: https://chromium-review.googlesource.com/1237516 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593249}
-
Kyle Milka authored
The flag was enabled by default and no longer needed. Bug: 885301 Change-Id: I84ec4557a1ca4c2f1eb70213c7bc56cd67512611 Reviewed-on: https://chromium-review.googlesource.com/1236287 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#593248}
-
Pavel Shmakov authored
Bug: 871738 Change-Id: Ibdc024e5dce12dc1ca9d8280d4144d3576522016 Reviewed-on: https://chromium-review.googlesource.com/1179895 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#593247}
-
Tommy C. Li authored
This test breaks up OmniboxViewTest.PreserveDisplayTextOnFocusSearch, which was a browser test, into three smaller unit tests. OmniboxViewTest.PreserveDisplayTextOnFocusSearch is flaky, and the whole set of OmniboxViewTest.* browser tests have been flaky for at least a year. Bug: 751031 Change-Id: I6e7a8fc88f55fee706cdfc1ee0617ce4a27f5103 Reviewed-on: https://chromium-review.googlesource.com/1232525Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#593246}
-
Brian White authored
Bug: 882892 Change-Id: I91d2cf5b46b8ef3b790b5e00692a053686ba17d1 Reviewed-on: https://chromium-review.googlesource.com/1236460 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#593245}
-
Dale Curtis authored
This reverts commit 1eee7cc0. Reason for revert: These tests are not run on Android; I meant to change the ones in content/ Original change's description: > Disable FrameSizeChange tests on Android KitKat. They're flaky. > > BUG=778245 > TEST=none > TBR=xhwang > > Change-Id: Ib27cef70fe4519678dfc4b0446ee4c734c31225a > Reviewed-on: https://chromium-review.googlesource.com/1237265 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592977} TBR=dalecurtis@chromium.org,xhwang@chromium.org Change-Id: I7df83977706f0e90affa616b5546e1066f76c429 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778245 Reviewed-on: https://chromium-review.googlesource.com/1239000Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593244}
-
Mike Dougherty authored
With SlimNavigationManager enabled, a placeholder page is rendered at the start of the navigation stack. Prevent this placeholder page from being registered as a frame. Bug: 869884 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I09907135bf48720ef4b25fb7ddaa607db4f03a27 Reviewed-on: https://chromium-review.googlesource.com/1234268 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593243}
-
Alexei Filippov authored
Change-Id: I57c51a878d7d1112e4ed69db0a23008e346e670b Reviewed-on: https://chromium-review.googlesource.com/1237556Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#593242}
-