- 31 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/747a820a7d69..c3794dd52778 2020-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 08a3cc4cfbaa to aa5bd7657e6c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Icf2ee536d0a3960c123dc37a38b5c48a95762806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332384Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793558}
-
chrome://tracingSami Kyostila authored
Use scoped_refptr instead of shared_ptr. Bug: b/158460807 Change-Id: I99a98247bb74b7a1e1743a9f0609185ab2929663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329538 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#793557}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0579e73f. With Chromium commits locally applied on WPT: 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I3da788724b11df2b60f249d611d1084451b65f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331858Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793556}
-
Sami Kyostila authored
Fix a crash when running multiple Perfetto integration tests in the same process. We need to avoid hanging on to task runners from previous task environments between test runs. Bug: 1110847 Change-Id: I26b0274c5cddb37a88292cfa6ad474f17148a402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329893 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793555}
-
Lingqi Chi authored
Non-test code outside "services/network" should not depend on this directory directly. This CL cleans up all such disallowed dependencies from DEPS files in chrome/browser/extensions. But since there is no workaround to replace some private implementations with public ones, this CL also special cases them by adding them to specific_include_rules lists. Tbr: karandeepb@chromium.org Bug: 1049894 Change-Id: I6d47f656ef75c6bf3e907bc4dadc64932d6c2c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322427 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#793554}
-
Alan Cutter authored
Change-Id: If0429ea349a174d4520c59ccf9dc5091707fd6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895016 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#793553}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596160292-be7478816f9ea1c3a3e60ecafceb33fda007c691.profdata to chrome-win32-master-1596167865-32b4d770ba98a451b62d0d6d996f9d383e4ffbb8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I21aa4c1a68477eec5d46ee29ff437024919d0972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332380Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f70087925046..eca19c68df38 2020-07-31 alexrudenko@chromium.org Fix a typo in _normalizePositionData 2020-07-31 changhaohan@chromium.org Add e2e test Computed pane property traces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106251,chromium:1106681 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8a3bf9883d0efbbf58f5d375d1c1ada0c7a2fa65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332382Reviewed-by:
-
Maxim Kolosovskiy authored
This CL adds a new credential layout corresponding to a compromised credential for a website where the password can be changed via a script. This new layout replaces the "Change password" button with 2 buttons: one for automatic change and one for manual. UI mock: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8e7b42d005_0_45 This CL - introduces |hasScript| field in |CompromisedCredential| - introduces new |PasswordCheckProperties.ItemType| - COMPROMISED_CREDENTIAL_WITH_SCRIPT - adds layout for the credentials of the new item type (the new layout contains additional button) - adds strings for the new button's caption and its explanation - tests whether the new layout is inflated. TODOs: - add methods to CredentialsEventHandler to handle clicks on buttons - propagate the data about whether a given domain has script or not. Bug: 1086114, 1092444 Change-Id: I9aae4772e4e529d5510bf0ecb0db3d7127f62b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326570 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793550}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19a1943b27a0..cbd5bee81dc6 2020-07-31 lehoangq@gmail.com Disable shader's pre-rotation code on Metal & non-Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I3a99f163886e88463a7706fc60c539f58af61f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331730Reviewed-by:
-
Monica Basta authored
Change-Id: I05d7202c2fbc7f4a3822d9a57926994c4bc11412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329894Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#793548}
-
Robbie Gibson authored
The new async APIs don't get the actual clipboard content when checking if the clipboard contains a url/image. This prevents them from triggering the new iOS 14 pasteboard access notification at bad times. Bug: 1110845 Change-Id: I8aa3989dae03999a319dc937f23432cff1f9ad81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325173Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#793547}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596088294-d7afac6507733c270f9eabdc2010773cc2ccd03c.profdata to chrome-mac-master-1596174933-7cf492c3635c483cb828a9ec34bd05bd116669be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I66c1c31e616f35c077425afa88bfad89494f4ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331735Reviewed-by:
-
Egor Pasko authored
The comment was describing an aspect of lesser importance. The most important part is that the cache gets cleared by the caller as soon as it finds that CachedMetadataHandler returns nullptr from GetCachedMetadata(). Bug: None Change-Id: I465b9605f3845ae8bab2870d516bdc93c770d6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329536Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#793545}
-
Miriam Polzer authored
Add a policy called ChannelDowngradeBehavior to control whether to powerwash and rollback or wait for new updates on channel downgrade. This policy will be used in Chrome (for UI) and Chrome OS (update engine). Bug: 1110808 Change-Id: I71b91670f2e2fe0f077587a6b8c4b3e80d2e8dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324623 Commit-Queue: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#793544}
-
Hiroki Nakagawa authored
The prefetch can happen before the referrer policy is known, so this CL makes the predictor use a conservertive one (no-referrer) by default. Bug: 1107318 Change-Id: If8c27090d5530edd457c83c23a059a76b90ad446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331599Reviewed-by:
-
Jiewei Qian authored
Users shouldn't be able to specify permissions for WebUIs. This CL treats WebUI URL as invalid web addresses, and prevents users from adding with add-site-dialog. Bug: 1108216 Change-Id: I4ceace41eba753a49642f67d2ad04325a9b4108e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315900Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#793542}
-
Darwin Huang authored
No need to keep dead code :P No functionality changes intended. Bug: 1111591 Change-Id: I8288b9585071ba99f6834c8d8b3309228933237e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331637 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#793541}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8869a24e77e..747a820a7d69 2020-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 03cf7c3eaeaf to fada50119020 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I0a7c240fadc776235be26b2842fb8bfcdb549436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331287Reviewed-by:
-
Ryan Hansberry authored
Rename to reflect the name of the superclass and the behavior of this test object. Bug: b:154849033, b:158848873 Change-Id: I50afc1508f7d1a6401e01b7102ef753339656aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317004 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#793539}
-
Anand K Mistry authored
Since num_handles() is read from the serialised message, if the message is invalid for some reason, num_handles() could be either invalid or result in an out-of-bounds memory access. Bug: 1110302, 1110432 Change-Id: Ia63e78a4131310e1febd87186044dbfe1348fb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326553Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#793538}
-
Victor Costan authored
Building Chromium requires a relatively recent Windows 10 SDK. The workaround should not be necessary. Change-Id: Icf9b9a2975524cfdcd38f54e3dbc7e293f7cca86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324677 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793537}
-
Alice Wang authored
This CL stops repopulating the whole account list for one specific profile data update in account picker. Bug: 1110874c Change-Id: Ie3346eb0d9b2b6b3c5363f0ede24044bae24ac8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324848Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793536}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/13d4daad7486..f70087925046 2020-07-31 alexrudenko@chromium.org Use 2D coordinates for placing line number labels in overlay If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106681 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2a889b3ea993e859e0d7aea64f4b7f98298723b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331722Reviewed-by:
-
Makoto Shimazu authored
TBR=dtseng@chromium.org No-Try: true Bug: 1111686 Change-Id: I926c72b00f1424dadef75fd47dcc652c9dd0e12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332277Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793534}
-
Yuki Shiino authored
For external/wpt/html/dom/idlharness.*, there shouldn't be any platform-specific behaviors, hence there should be no need to have a platform-specific expectation. This patch removes it. Change-Id: I4411431e1687b5defcbffbd106c345530317375f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332097Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#793533}
-
Callistus authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Ig0HjWIcWoctNjm9blQE6JDTvNtCIU_-1VgQkCpc6N4C Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202007300800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I47ce96ab329ac79734b4a0d706841e9f537dd4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331557Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#793532}
-
Johann authored
Redirect usage in render_view_browsertest.cc through RenderFrameImpl and render_view(). Despite the comment on render_view() about it being temporary, this path is much more commonly used than FromWebView(). Move the definition up a level directly to RenderView. Still investigating other uses. The goal is to remove anything which relies on global variables so that RenderViews can be frozen/throttled independently. Bug: 1098157 Change-Id: I9fe0c180f305e6d2fa8a302231be8d4529f48192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259674 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#793531}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596156772-fb5400781a3ee20ba308909e8b9d28b6ec0b05c7.profdata to chrome-win32-master-1596160292-be7478816f9ea1c3a3e60ecafceb33fda007c691.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I04cb8f2b7ed610c2169b009dfb1c450a18619e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331718Reviewed-by:
-
Matthew Mourgos authored
This CL creates the function CreateStandardIconImage() to be used for taking the original icon and returning a standard icon. The general idea of the new function is as follows: 1. Check if the original icon is already circle shaped. If it is, then return the original icon. 2. Find the scale required to resize and fit the original icon inside of a new circle background. 3. Scale down the icon and draw it over a background circle. Return this icon as the generated standard icon. Bug: 1110496 Change-Id: If37fba67a3f937f863c0df2600979fc0e0d02512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300225Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793529}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) Bug: 1105907 Change-Id: Ib9e0314c5c15cf33b86ed98cbd2d46a454a9b719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331856 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#793528}
-
Kent Tamura authored
We're going to ship LayouNGFieldset before LayoutNGBlockFragmentation. We should test LayouNGFieldset without LayoutNGBlockFragmentation. This CL has no behavior changes. Bug: 875235 Change-Id: Ice80abf0fcdd83ed15fb088b76899287aeb88187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331956 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#793527}
-
Sigurd Schneider authored
This CL reports both the parent frame and the blocked from for COEP issues. With those, it is easier to provide informative information in the issues panel. Change-Id: I382412780f382243d426a7fff3cb8e0efb7cb54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326350Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#793526}
-
Hitoshi Yoshida authored
The new code generator will use V8Enum classes for IDL enum members in IDL dictionaries. However, in some cases, implicit conversion of IDL enum to String doesn't work. This CL wraps them with IDLEnumAsString() to make them workable with both of old/new code generator. They will be unwrapped after migrating the code generators. Bug: 839389, 1070871 Change-Id: Ide73bca4fb4f7785b0c243fa1c2e7c8bfc99e6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230588 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Jongmok Kim authored
Bug: 1037992 Change-Id: I19a134d72f72dfbcdc698af907fadaac4cce3be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328093 Commit-Queue: Jongmok Kim <jongmok.kim@navercorp.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793524}
-
Alan Cutter authored
This CL improves link capturing for tabbed web app windows that involve temporary about:blank tabs. If the WebContents hasn't loaded yet or has only loaded about:blank we should reparent it into the app window to avoid leaving behind a blank tab. This behaviour is hidden behind the DesktopPWAsTabStrip and DesktopPWAsTabStripLinkCapturing feature flags. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=458622&signed_aid=mpkhPnvPYdVhH9xUHWrBcw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=458621&signed_aid=AU8z1nowfAzER78yEntc3w==&inline=1 Bug: 1078301 Change-Id: Ia7312894512e01977f5b545307d9ceefea79c8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288915 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#793523}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f3a38d978faa..19a1943b27a0 2020-07-31 kbr@chromium.org Allow GetSystemInfo to return false in CGL and EAGL backends. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I175b3087e40643a6113bc7da450660f13c56c840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331284Reviewed-by:
-
Yuki Shiino authored
It turned out that it's not a good idea to print messages to Ninja's console, and people rather prefer not showing anything to the console. Hence, removes "console" pool of GN, which allows printing messages to Ninja's console. Bug: 839389, 1108111, 1109761 Change-Id: I231dc17ec260db0b5fb2a5781da56493a39a9a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329952Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#793521}
-
Jan Wilken Dörrie authored
This change renames chrome_cleaner::String16EmbeddedNulls to chrome_cleaner::WStringEmbeddedNulls and renames its CastAsStringPiece16 API to CastAsWStringPiece. This is purely a name change and should not have any impact on functionality. Bug: 911896 Change-Id: I268bc7fef5cc8d8f6df9987baeed52eee1fe99ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328667Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#793520}
-
Austin Tankiang authored
Bug: 1105319 Change-Id: Id5f0c7f03bf7360fc1cdef998fb274c528af6535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328397Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#793519}
-
