GitLab

The comment states that although the field is marked as repeated, in practice it
can only contain 0 or 1 values.

BUG=543161

Review-Url: https://codereview.chromium.org/2195043002
Cr-Commit-Position: refs/heads/master@{#408767}

BUG=627607

Review-Url: https://codereview.chromium.org/2194893003
Cr-Commit-Position: refs/heads/master@{#408766}

  In order to roll GN 15e0e74f..da21696c (r407852:r408676) and pick up
  the following changes:

  da21696c GN: only write targets that should be generated.
  1c27131e [GN] Prefer explicit pool to automatic link_pool for link targets.
  8293c354 GN: don't write separate files for non-binary targets

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2193873002
Cr-Commit-Position: refs/heads/master@{#408765}

Revert of Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots. (patchset #1 id:1 of https://codereview.chromium.org/2097923002/ )

Reason for revert:
Regression was reverted, so tests can be re-enabled

Original issue's description:
> Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots.
>
> BUG=623105
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
>
> Committed: https://crrev.com/582209c397ef25fb75bd8fdf58ff74c291172247
> Cr-Commit-Position: refs/heads/master@{#402060}

TBR=eakuefner@chromium.org,sullivan@chromium.org,prasadv@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623105

Review-Url: https://codereview.chromium.org/2191413002
Cr-Commit-Position: refs/heads/master@{#408764}

Previously to this CL the code was only considering the focused window
when calculating scale for the overview mode transform. It needs to
consider the bounding rectangle of the whole transient parent's tree.

BUG=632694

Review-Url: https://codereview.chromium.org/2197773002
Cr-Commit-Position: refs/heads/master@{#408763}

BUG=402536

Review-Url: https://codereview.chromium.org/2188523005
Cr-Commit-Position: refs/heads/master@{#408762}

This patch updates the code to prevent auto deducing to a raw pointer.

R=asvitkine@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2195503002
Cr-Commit-Position: refs/heads/master@{#408761}

BUG=630475

Review-Url: https://codereview.chromium.org/2193933002
Cr-Commit-Position: refs/heads/master@{#408760}

Skia histograms are generating invalid data. Disable them until we have
time to debug further.

Review-Url: https://codereview.chromium.org/2185263002
Cr-Commit-Position: refs/heads/master@{#408759}

This fixes an issue with the source color picker where undo-ing the color text did not
always remove the color swatch. CodeMirror findMarks() is not inclusive, so we also need
to check the line endpoints.

The additional newline added to the string in _updateColorSwatches allows
color text to be matched when it is located at the start of a line.

R=lushnikov

Review-Url: https://codereview.chromium.org/2187173002
Cr-Commit-Position: refs/heads/master@{#408758}

This CL addresses the problem in the bug, i.e. android webview
not finding the Geolocation classes after moving to //device.

BUG=632777

Review-Url: https://codereview.chromium.org/2195783002
Cr-Commit-Position: refs/heads/master@{#408757}

It appears we lost support for --class when we stopped using gtk for our
windowing.  This CL adds that feature back.

BUG=118613

Committed: https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520
Review-Url: https://codereview.chromium.org/2186813002
Cr-Original-Commit-Position: refs/heads/master@{#408709}
Cr-Commit-Position: refs/heads/master@{#408756}

BUG=NONE

Review-Url: https://codereview.chromium.org/2195003002
Cr-Commit-Position: refs/heads/master@{#408755}

Now that RequestFinishedListener doesn't depend on NQE's executor, the
rest of this API can go away.

BUG=618034

Review-Url: https://codereview.chromium.org/2188553002
Cr-Commit-Position: refs/heads/master@{#408754}

R=tommycli@chromium.org
BUG=629604
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2195793003
Cr-Commit-Position: refs/heads/master@{#408753}

NOTRY=true

Review-Url: https://codereview.chromium.org/2193373002
Cr-Commit-Position: refs/heads/master@{#408752}

WebAPK process is not guaranteed to terminate when Chrome gets updated. The
WebAPK code assumes that it is always using the latest version of runtime
library. In order to guarantee this, the ClassLoader must be re-created if Chrome
is updated but the WebAPK is still running.

BUG=627950
TEST=HostBrowserLauncherTest.*
TBR=hanxi (TBR for DEP on testing/ by JUnit test)

Review-Url: https://codereview.chromium.org/2179163002
Cr-Commit-Position: refs/heads/master@{#408751}

Not sure why it is missing. Probably related to this CL: https://codereview.chromium.org/2007133006

This fix is to add a style to .remove-warning-button.

BUG=631975

Review-Url: https://codereview.chromium.org/2197653003
Cr-Commit-Position: refs/heads/master@{#408750}

Credit goes to @dbeam.

BUG=632674
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2194823004
Cr-Commit-Position: refs/heads/master@{#408749}

This CL only changes the default for the --ash-max-previews-to-use-mask
runtime flag to 0 (from 10). Not using masks seems to improve animation.

BUG=632825
TEST=None

Review-Url: https://codereview.chromium.org/2193403002
Cr-Commit-Position: refs/heads/master@{#408748}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/317e984a87db..28aad26a05ee

$ git log 317e984a8..28aad26a0 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2191383003
Cr-Commit-Position: refs/heads/master@{#408747}

BUG=632488

Review-Url: https://codereview.chromium.org/2195773003
Cr-Commit-Position: refs/heads/master@{#408746}

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

Note, most of the changes were done with sed:
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % (\(.*\)))/\.\1(\2, \3)/
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % \(.*\))/\.\1(\2, \3)/

BUG=598897

Review-Url: https://codereview.chromium.org/2188623002
Cr-Commit-Position: refs/heads/master@{#408745}

This change adds a PageLoadMetricsProvider, which implements the new
OnAppEnterBackground hook, and informs all MetricsWebContentsObservers
and in turn all PageLoadTrackers when the app enters the background.

On Android (and iOS), when an app enters the background, it may be
killed without further notifications. Thus, having this callback
will allow us to persist metrics before the app may be killed.
Our page load metrics subsystem isn't used on iOS, so we only target
Android in this change.

Unfortunately, we can't use the existing WebContents hidden callback,
as this gets invoked after the UMA subsystem has already flushed
metrics to disk. Thus, we need to add this explicit callback which
allows us to persist metrics as part of the UMA subsystem handling
the backgrounding callback.

For now, we log a debugging histogram in PageLoadTracker to help
understand how often trackers enter the background, and how often
those trackers are destroyed without running their destructors. In a
subsequent change, we'll add support for informing PLMObservers that
the app entered the background. This will allow any PLMObsevers that
implement OnComplete or OnFailedProvisionalLoad to also get called back
in cases where the tracker may be destroyed before its destructor runs,
due to the application being killed.

BUG=608360

Review-Url: https://codereview.chromium.org/2189543002
Cr-Commit-Position: refs/heads/master@{#408744}

BUG=631162
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2194683003
Cr-Commit-Position: refs/heads/master@{#408743}

We need to clear ScopedPersistents so that V8 doesn't call phantom callbacks
after Oilpan starts lazy sweeping.

BUG=626893

Review-Url: https://codereview.chromium.org/2196543003
Cr-Commit-Position: refs/heads/master@{#408742}

BUG=590369
R=yosin,esprehn

Review-Url: https://codereview.chromium.org/2142903003
Cr-Commit-Position: refs/heads/master@{#408741}

two that seem unused as iOS only.

BUG=none

Review-Url: https://codereview.chromium.org/2197713002
Cr-Commit-Position: refs/heads/master@{#408740}

BUG=none

Review-Url: https://codereview.chromium.org/2071463002
Cr-Commit-Position: refs/heads/master@{#408739}

BUG=632379

Review-Url: https://codereview.chromium.org/2195563002
Cr-Commit-Position: refs/heads/master@{#408738}

In particular, the code was being run on non-data URLs, which caused it
to do weird and exciting things, and it had an incorrect DCHECK.

BUG=632605

Review-Url: https://codereview.chromium.org/2191323005
Cr-Commit-Position: refs/heads/master@{#408737}

This mostly cleans up some routing code in Quick Unlock. It also has a few small fixes in People.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2154213008
Cr-Commit-Position: refs/heads/master@{#408736}

The similar CL for IPC https://codereview.chromium.org/2148303005/

BUG=582434

Review-Url: https://codereview.chromium.org/2189543004
Cr-Commit-Position: refs/heads/master@{#408735}

BUG=616536

Review-Url: https://codereview.chromium.org/2129253002
Cr-Commit-Position: refs/heads/master@{#408734}

Revert of Linux: Support the --class argument (patchset #4 id:60001 of https://codereview.chromium.org/2186813002/ )

Reason for revert:
Change breaks compile on Linux x64: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/12770

Original issue's description:
> Linux: Support the --class argument
>
> It appears we lost support for --class when we stopped using gtk for our
> windowing.  This CL adds that feature back.
>
> BUG=118613
>
> Committed: https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520
> Cr-Commit-Position: refs/heads/master@{#408709}

TBR=thestig@chromium.org,benwells@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=118613

Review-Url: https://codereview.chromium.org/2193393002
Cr-Commit-Position: refs/heads/master@{#408733}

The existing doc (https://sites.google.com/a/chromium.org/dev/developers/design-documents/idl-compiler)
looks old, but it's probably better to keep it next to the code.

R=haraken,yukishiino
BUG=

Review-Url: https://codereview.chromium.org/2195743003
Cr-Commit-Position: refs/heads/master@{#408732}

TBR=sullivan@chromium.org
BUG=630854
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;

Review-Url: https://codereview.chromium.org/2189383002
Cr-Commit-Position: refs/heads/master@{#408731}

Add expired as a logged event in offline-internal page.

BUG=NONE

Review-Url: https://codereview.chromium.org/2191183002
Cr-Commit-Position: refs/heads/master@{#408730}

First of three patches to reject promises if the frame is not connected
or the frame disconnected while the promise was not fulfilled.

Implements:

1. The ActiveAlgorithm set[1] as m_activeAlgorithms in BluetoothRemoteGATTServer
2. gattServer-connection-checking wrapper[2] as GetPrimaryServicesCallback in
   BluetoothRemoteGattServer.cpp
3. Connection check of query bluetooth cache[3] in getPrimaryServicesImpl.

[1] https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver-activealgorithms-slot
[2] https://webbluetoothcg.github.io/web-bluetooth/#connection-checking-wrapper
[3] https://webbluetoothcg.github.io/web-bluetooth/#query-the-bluetooth-cache

BUG=608538

Review-Url: https://codereview.chromium.org/2183903002
Cr-Commit-Position: refs/heads/master@{#408729}

This patch updates the code to prevent auto deducing to a raw pointer.

R=mattm@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2194613002
Cr-Commit-Position: refs/heads/master@{#408728}