- 12 Dec, 2018 14 commits
-
-
Marijn Kruisselbrink authored
Bug: none Change-Id: I531e733601114c9674d45d5d25d341545d5ec5a5 Reviewed-on: https://chromium-review.googlesource.com/c/1372566 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615746}
-
Nigel Tao authored
Image processing includes converting to gray (for disabled extensions) and rounding the corners (for bookmark apps). BUG=826982 Change-Id: Ie49a8928678abd884302eacb7bef5f2c21e46a35 Reviewed-on: https://chromium-review.googlesource.com/c/1366462 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#615745}
-
Karan Bhatia authored
Currently the page at https://developer.chrome.com/extensions/declarativeNetRequest doesn't correctly show the API availability. The API is available on beta but is's shown as being available on trunk only. Increment the server version which should hopefully fix the issue. BUG=696822 Change-Id: I60b526691d582ea0a32d14cb043c9c2cc114e5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1371819Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615744}
-
Alice Boxhall authored
This reverts commit 74d46702. Reason for revert: Seems to be causing build breakage: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux Original change's description: > Dawn: use Dawn's temporary test targets for isolates. > > The plan is to move the actual test targets in Dawn to Dawn's > src/test directory. This change makes Chrome temporarily point at > some intermediate proxy targets, so we can move the real ones > without breaking Chrome. > > Bug: dawn:61 > Change-Id: I166c17f1689e2a2e71b1607af44f6f9a8c14b6af > Reviewed-on: https://chromium-review.googlesource.com/c/1372709 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615715} TBR=thakis@chromium.org,senorblanco@chromium.org,cwallez@chromium.org Change-Id: Iec9120066c23710c4b2dbe22a50813a23ad299a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://chromium-review.googlesource.com/c/1372107Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615743}
-
Alice Boxhall authored
This reverts commit 000208cc. Reason for revert: Causing compile failures: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59549 Original change's description: > assistant: replace most thread task runner with sequenced > > Bug: None > Test: locally build and run > Change-Id: I8e77799bcc4f417faf7dff54f9e40ab7a46f3d1f > Reviewed-on: https://chromium-review.googlesource.com/c/1372722 > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615732} TBR=xiaohuic@chromium.org,wutao@chromium.org Change-Id: Icfc0b925491ee96c6945ffca9bd972be174881b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/1372106Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615742}
-
Charlie Andrews authored
TBR=crouleau@chromium.org CC=ssid@chromium.org Bug: 914092 Change-Id: I57095a320bd561551bbd43025688393199ffbacb Reviewed-on: https://chromium-review.googlesource.com/c/1372725Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#615741}
-
Wenzhao Zang authored
We want to show a visual indicator in the status tray when the language toggle is available (in demo mode). It should show the abbreviation of the locale such as "DA". The only caveat is that the IME indicator may also be shown in the same place, so showing two strings with the same format may confuse users. PM confirms that we want to hide the IME indicator as long as the locale indicator is available. Bug: 877749 Change-Id: Ieca21dd46c846b81147bd44798b2deb25d9d57fa Reviewed-on: https://chromium-review.googlesource.com/c/1370886Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#615740}
-
Emircan Uysaler authored
WebRTC currenty passes only the codec selection to the decoders but not the profile info. This has been working fine so far because we only had different profiles under H264 and initializing the decoder with MAIN was enough to cover all of them. However, this became problematic when we introduce VP9.2, as it is a 10-bit codec that decoder needs to know and initialize in advance. This CL changes the decoder creation methods such that webrtc::SdpVideoFormat is passed and parsed for profile information. This will allow us to enabled VP9.2 HW decoder usage. Bug: 908945,webrtc:9376 Change-Id: I6959c85fe4074ca1644e6fb02d58d10df2ff0cff Reviewed-on: https://chromium-review.googlesource.com/c/1363804 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615739}
-
Tobias Sargeant authored
This exposes a support library feature allowing applications to set a WebViewRendererClient object upon which renderer related callbacks are received. Specifically, these callbacks are: onRendererUnresponsive(renderer) - called when the renderer associated with a webview does not ack an input event, or a navigation does not commit within 5 seconds. The callback will continue to be called at 5 second intervals until the renderer is killed or the unresponsiveness resolves. |renderer| may be null if webview is operating in single process mode. onRendererResponsive(renderer) - called once when an unresponsive renderer becomes responsive again. Bug: 907887 Change-Id: Ic5c74160e293791e3efc051a5727448ee061c9e2 Reviewed-on: https://chromium-review.googlesource.com/c/1361242Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615738}
-
Bruce Dawson authored
Recent versions of the 10.0.17763 SDK have rearranged the redist directory where we find the UCRT DLLs. This change updates the copy_cdb_to_output.py script so that it looks in the new (versioned) directory first, and falls back to the old unversioned directory if that doesn't work. Without this change we still soon start seeing build failures when using the locally installed toolchain on clean installs. See also http://crrev.com/c/1370609 for the depot tools packaging version of this change, and http://crrev.com/c/1371017 for the vs_toolchain.py version of this change. Ideally this change would have been made together with the vs_toolchain.py, but the break was found to late. The try bots have now done full builds with the new SDK layout so this should be the last change needed of this type. Change-Id: I4c965c66296d2f0b6adad672a71c295ffb021c66 Reviewed-on: https://chromium-review.googlesource.com/c/1372222Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615737}
-
manuk authored
Using L and F for query and find input boxes in order to be similar to browser shortcuts for focusing the omnibox and find dialog respectively. Using I, D, and P for 'show incomplete results', 'show details', and 'show per provider' display checkboxes respectively. Using C, A, and K for 'lock cursor', 'prevent autocomplete', 'keyword mode' input checkboxes respectively. Using U for 'current page' dropdown. Bug: 891303 Change-Id: Id715fb6c3db5787a8e676f2497578128a2810fd9 Reviewed-on: https://chromium-review.googlesource.com/c/1372243 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#615736}
-
John Delaney authored
Cleanup an unused argument. Make function definition match the declaration. Change-Id: I5361ebcc56e660b4e697f50a866798ea5c89fad6 Reviewed-on: https://chromium-review.googlesource.com/c/1372429 Commit-Queue: John Delaney <johnidel@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#615735}
-
Collin Baker authored
This testing configuration shouldn't have been added until after an experiment in canary and dev has been run. This change removes it. Change-Id: I27546ef7e4b49f6f155678f3db14856bd7f5340f Reviewed-on: https://chromium-review.googlesource.com/c/1372409 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615734}
-
Fabrice de Gans-Riberi authored
Ordinals have been deprecated. This also fixes some minor indentation issues in FIDL files. Change-Id: I687b2d35e11b56401771ce9aeea8465735d7ffb9 Reviewed-on: https://chromium-review.googlesource.com/c/1372659 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615733}
-
- 11 Dec, 2018 26 commits
-
-
Xiaohui Chen authored
Bug: None Test: locally build and run Change-Id: I8e77799bcc4f417faf7dff54f9e40ab7a46f3d1f Reviewed-on: https://chromium-review.googlesource.com/c/1372722Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#615732}
-
Collin Baker authored
Bug: 909747 Change-Id: I4f7f9d6a34242d7dec8b343ff38aaa2b05019cec Reviewed-on: https://chromium-review.googlesource.com/c/1362190Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#615731}
-
Dan Sanders authored
These refactorings were removed from https://crrev.com/c/1362005 to reduce the size of the patch. This change also fixes a previously unknown issue in PictureBufferManager whereby show_existing_frame picture buffers could be destroyed while there are still outstanding video frames using the textures. Bug: 906623 Change-Id: I0a243684c9a6d44dec5a5f279cf28f51b79c99c0 Reviewed-on: https://chromium-review.googlesource.com/c/1368780 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615730}
-
John Rummell authored
BUG=611224 TEST=new media_unittest passes Change-Id: I7feadd34ca77bcacd406b61783e43143bb593f7f Reviewed-on: https://chromium-review.googlesource.com/c/1338323 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615729}
-
Dominic Mazzoni authored
It was awkward that BrowserAccessibilityManager and AutomationAXTreeWrapper had to inherit from AXEventGenerator. Now they can each own an AXEventGenerator but also be AXTreeObservers, themselves. TBR=halliwell@chromium.org Bug: none Change-Id: Iac577b5ddcca892e809a9c02ce38d193297ecb80 Reviewed-on: https://chromium-review.googlesource.com/c/1357831Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615728}
-
Kenneth Russell authored
ContextLost_WebGLBlockedAfterJSNavigation ContextLost_WebGLUnblockedAfterUserInitiatedReload Both are flaking due to the same root cause. Tbr: jonross@chromium.org Bug: 900948 No-Try: True Change-Id: Ic527ce1914bacd539222c7a8e8c9265be404aff2 Reviewed-on: https://chromium-review.googlesource.com/c/1372350 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#615727}
-
Dana Fried authored
Current code does not cause a problem with this order of operations, but changes we want to make for the attached bug uncovers a situation where the action is still popped out after its view is removed, which causes an error. Bug: 898632 Change-Id: I73d14a61cddd4b052c9dbf774864f68036a93b4c Reviewed-on: https://chromium-review.googlesource.com/c/1372710Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#615726}
-
Jeremy Roman authored
Change-Id: I6f21ff35ef36e908da88356223a52b413e8b93ca Reviewed-on: https://chromium-review.googlesource.com/c/1372717Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615725}
-
Sonny Rao authored
We are putting our most used text into a region that can be backed by huge pages, however we can lose those pages when we encounter memory pressure, so we should be locking them into place to avoid that. R=llozano@chromium.org Bug: 913700 Change-Id: If9ae32ae046a21d5bf7af4e43624323b3429d9f8 Reviewed-on: https://chromium-review.googlesource.com/c/1371206Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#615724}
-
Sunny Sachanandani authored
These have been flaking for a while on both Debug and Release: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl_conformance_tests&tests=WebglConformance_conformance_extensions_oes_texture_float_with_video Bug: 913969 Change-Id: I2506a9f112e6b539e2831772421d5df72b676750 Reviewed-on: https://chromium-review.googlesource.com/c/1372532Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#615723}
-
Dana Fried authored
Current code does not cause RAF in tests, but changes we want to make for this bug uncovers a potential order-of-operations issue that can cause read of uninitialized memory (specifically, the extension can be programmatically deleted while the "extension installed" bubble is visible). Bug: 898632 Change-Id: I4bdf9e5fbb8fac1bc1a30a0b2a629655a77de9e7 Reviewed-on: https://chromium-review.googlesource.com/c/1372276Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#615722}
-
edchin authored
This CL creates a private header for BVC methods that should only be exposed to BrowserCoordinator. Change-Id: Iadea8a77ca9b9e2acc98c473401c4c5292fa694d Reviewed-on: https://chromium-review.googlesource.com/c/1366860 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615721}
-
Kenneth Russell authored
conformance/glsl/functions/glsl-function-min-gentype.html conformance/glsl/implicit/add_ivec3_vec3.vert.html Flaking on Nexus 5X. Tbr: ynovikov@chromium.org Tbr: crouleau@chromium.org Tbr: perezju@chromium.org Bug: 912161 Change-Id: I62854de75db2ba50524cbc8f4150080be87ea47a Reviewed-on: https://chromium-review.googlesource.com/c/1372473Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615720}
-
dpapad authored
Usage of neon-animatable is unnecessary now that neon-animation-pages has been removed. Bug: 902959 Change-Id: I7cbad2e8a2ba1f56234cc77ed9a40b4ef9aea314 Reviewed-on: https://chromium-review.googlesource.com/c/1343657 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615719}
-
Alexey Baskakov authored
Make notification_registrar_ shared between old and new implementations. No behaviour change - feature is hidden behind the flag. Drive by: Remove unused header in bookmark_app_installation_task.cc Bug: None Change-Id: I4e1f735a60a2befe61f427741d3db820dd528091 Reviewed-on: https://chromium-review.googlesource.com/c/1370241Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#615718}
-
Aran Gilman authored
Change-Id: I672f96bdaeb1d3c4955260c5460bdc5326e68f92 Reviewed-on: https://chromium-review.googlesource.com/c/1370281Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#615717}
-
Yiming Zhou authored
Bug: 885350 Change-Id: If7e100dafc6203bdd9ea86aa7c05bfbe1342e03f Reviewed-on: https://chromium-review.googlesource.com/c/1372176Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#615716}
-
Stephen White authored
The plan is to move the actual test targets in Dawn to Dawn's src/test directory. This change makes Chrome temporarily point at some intermediate proxy targets, so we can move the real ones without breaking Chrome. Bug: dawn:61 Change-Id: I166c17f1689e2a2e71b1607af44f6f9a8c14b6af Reviewed-on: https://chromium-review.googlesource.com/c/1372709Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#615715}
-
Sergey Berezin authored
The main build always runs with a timeout of 7h. Make sure the individual shards always complete sooner, so any failed or timed out shards are correctly indicated on the build UI. Bug: 907852 Change-Id: I1580ee0a92f371536f1435e56596ee3d8aeb861b Reviewed-on: https://chromium-review.googlesource.com/c/1372533Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615714}
-
Miguel Casas-Sanchez authored
Use BindOnce to placate the presubmit warning. Bug: 714018 Change-Id: I5b268640b8b9ad48c3a3f0fc25a3f7b1dbd7adea Reviewed-on: https://chromium-review.googlesource.com/c/1371903Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#615713}
-
Kevin Strohbehn authored
This prevents ChromeVox from reading a hierarchy of inactive results. Bug: 910348 Change-Id: I393c7a347c63393890ed84b81647828ccc8f547d Reviewed-on: https://chromium-review.googlesource.com/c/1369127Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#615712}
-
Max Moroz authored
Also switch libFuzzer UBSan buildbot (using us_ubsan_security config) to the component build. Otherwise, the build is failing with the errors of the following form: ./libblink_core.so: undefined symbol: _ZTIN5blink15LargeObjectPageE ./v8_context_snapshot_generator failed with exit code 127 ninja: build stopped: subcommand failed. $ c++filt _ZTIN5blink15LargeObjectPageE typeinfo for blink::LargeObjectPage R=bpastene@chromium.org, kbr@chromium.org Bug: 701825, 868612, 911856 Change-Id: I482ecf28d06cc95c2c9d43dd310311acd3249c5b Reviewed-on: https://chromium-review.googlesource.com/c/1372267 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615711}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/be607ad63609..611bbaabb28c git log be607ad63609..611bbaabb28c --date=short --no-merges --format='%ad %ae %s' 2018-12-11 syoussefi@chromium.org Vulkan: Convert vertex attributes in compute Created with: gclient setdep -r src/third_party/angle@611bbaabb28c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ic998f990b6e9e0f1478d46a396bf934ade155654 Reviewed-on: https://chromium-review.googlesource.com/c/1372654Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615710}
-
Matt Wolenetz authored
Updates one of the subtests to be less tightly bound to one implementation's scheduling of append error algorithm versus readyState transitions to HAVE_METADATA when one appendBuffer could potentially cause both. Change-Id: I50f98c2815014aacd67cb27bfc3d71ba50a16ab4 Reviewed-on: https://chromium-review.googlesource.com/c/1371166Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615709}
-
danakj authored
This code was copied over from WebViewImpl when adding the HidePopups call in order to have a pinch zoom or scroll tap outside the current popup in a non-main-frame-local-rooted iframe hide the current popup. This is modifying state on WebViewImpl meant to track between TapDown and Tap, to avoid the Tap showing a popup that was hidden by TapDown. WebFrameWidgetImpl does not show popups on Tap, and if it did, it should track this transient state locally not on WebViewImpl. Also remove the undocumented FALLTHROUGH which was not explained in 671732 as it now goes to nothing. R=dcheng@chromium.org Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db Bug: 912193, 671732 Reviewed-on: https://chromium-review.googlesource.com/c/1372539Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615708}
-
Zhongyi Shi authored
No behavior change, just prepare the connectivity probing manager to probe for server preferred address. Bug: 913733 Change-Id: Ib4bb47c80cdc42edf8241bf63369b1e6e0e50c14 Reviewed-on: https://chromium-review.googlesource.com/c/1370952Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615707}
-