GitLab

Implement MediaDrmStorageImpl using PrefService.

TBR=sdefresne@chromium.org
BUG=493521
TEST=New unit tests added.

Review-Url: https://codereview.chromium.org/2791903004
Cr-Commit-Position: refs/heads/master@{#462929}

The tests raced because each test case was changing a global flag potentially in parallel.
Instead of having separate test cases that each set the flag, have
separate tests objects for each value of the flag, and set the flag in the constructor to avoid races.

BUG=709112
TBR=hbos@chromium.org

Review-Url: https://codereview.chromium.org/2805903002
Cr-Commit-Position: refs/heads/master@{#462928}

In an OOPIF process with a remote main frame, currently the size of
the WebViewImpl is not set, because it is not relevant when there is
no main frame to render. However, the VisualViewport size is required
so OOPIF resizes set it appropriately.

This has caused a problem during printing because it saves and then
restores the WebViewImpl size, which unfortunately also wipes out the
VisualViewport size. This CL sets the WebViewImpl size along with
the VisualViewport in order to keep them consistent.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=705867

Review-Url: https://codereview.chromium.org/2801143002
Cr-Commit-Position: refs/heads/master@{#462927}

Per localization request, increasing the character limit of Request
Mobile Site messageto 25em.

BUG=

Review-Url: https://codereview.chromium.org/2797923009
Cr-Commit-Position: refs/heads/master@{#462926}

Currently a call to |GestureRecognizerImpl::TransferEventsTo()| can lead
to an incorrect state for touch events. Specifically, the event ACKS are
getting routed to a different reference of GestureProvider from the one
where the original events were routed to.

This patch stores a mapping of every event that was dispatched along
with its corresponding GestureProvider. This allows the event ACKS to be
routed correctly despite a call made to |TransferEventsTo()|.

BUG=698843
COMPONENT=Gesture Recognizer, Touch Gestures, Drag and Drop

Review-Url: https://codereview.chromium.org/2789203006
Cr-Commit-Position: refs/heads/master@{#462925}

Manually converted test to use new Audit.

BUG=704967
TEST=BiquadFilter/biquad-automation.html

Review-Url: https://codereview.chromium.org/2785703003
Cr-Commit-Position: refs/heads/master@{#462924}

The two methods that fetch the currently selected image can
be collapsed into one.

BUG=655359

Review-Url: https://codereview.chromium.org/2804913003
Cr-Commit-Position: refs/heads/master@{#462923}

BUG=708861
TBR=sebsg@chromium.org

Review-Url: https://codereview.chromium.org/2806693003
Cr-Commit-Position: refs/heads/master@{#462922}

BUG=704579

Review-Url: https://codereview.chromium.org/2802143002
Cr-Commit-Position: refs/heads/master@{#462921}

This test is flaky on Linux

BUG=709524
TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2804313002
Cr-Commit-Position: refs/heads/master@{#462920}

- Remove mDisableTextAccessibilityEvents and replace it by
mIgnoreTextChangeFromAutocomplete which is renamed from
mIgnoreAutocomplete
- Change the scope of setIgnoreTextChangesForAutocomplete() to be
  exactly the code that should be affected.
- Remove unused methods and fields

BUG=539536

Review-Url: https://codereview.chromium.org/2802803002
Cr-Commit-Position: refs/heads/master@{#462919}

Previously, if the promo text parameter was not found in the
localization lookup table, the promo would be considered valid and the
text would be displayed as is. With this CL, it is now required that
the text parameter exist in the lookup table in order for the promo
to be valid. The CL also does general NTP Promo cleanup and adds
unit tests.

BUG=703440

Review-Url: https://codereview.chromium.org/2799383002
Cr-Commit-Position: refs/heads/master@{#462918}

Spec available at: https://github.com/WebAssembly/design/blob/master/Web.md#webassemblycompile

This CL introduces the WebAssembly.compile overload in Blink.

Notably, we do not currently check the mime type (chromium:707149).

The V8 side is still under development. We currently exercise a skeleton API with a
trivial implementation. Once the full implementation is implemented, we will enhance
the blink side of the feature - for instance, we can introduce back pressure
information.

BUG=chromium:697028

Review-Url: https://codereview.chromium.org/2780693003
Cr-Commit-Position: refs/heads/master@{#462917}

Link to original CL: https://codereview.chromium.org/2769543002/

PatchSet 1 is state as reviewed previously.
PatchSet 2 applies a fix for the issue described below.

This was reverted because it caused a test flakiness for test
MediaDevicesDispatcherHostTest.GetVideoInputCapabilities on Windows.

Analysis of the issue:
The CL created a race condition that could cause the test method to exit
before the exercise had finished executing. What made the difference is that
VideoCaptureSystem::GetDeviceInfosAsync() invoked by VideoCaptureManager
now actually runs asynchronous, i.e. it posts invocation of its
|result_callback| to the end of a message queue. Before this CL,
VideoCaptureManager directly called
VideoCaptureDeviceFactory::EnumerateDeviceDescriptors which, despite its
asynchronous-looking API invoked its callback synchronously. The test code was
relying on this being the case. After the CL, the following bad sequence could
happen:
1.) Test calls |host_->GetVideoInputCapabilities()| which eventually kicks of
asynchronous work A on the "device thread".
2.) Test method reaches statement
|media_stream_manager_->FlushVideoCaptureThreadForTesting()| and blocks until
the already posted work A on the device thread finishes.
3.) Work A posts new work B to the device thread.
4.) Work A finishes.
5.) FlushVideoCaptureThreadForTesting() returns and the test method exits before
work B has run.

Description of fix:
The way that the test was waiting for the asynchronous exercise to complete was
based on dangerous (and now incorrect) assumptions of how and where the
implementation under test internally posts task. The fix is to eliminate these
assumptions and, instead, block the test method until the waited-for callback
arrives.

Original CL description:

This CL is supposed to be a pure refactoring. There should be no changes to
existing behavior.

This is part of a series of CLs with the goal of separating the class
VideoCaptureManager from knowledge of things that are going to be private
implementation details of the video capture service. The end goal is to have
VideoCaptureManager talk to an abstraction that can be implemented by either the
video capture Mojo service or the existing (legacy) in-process implementation.

Changes in this CL:
* Move nested struct VideoCaptureManager::DeviceInfo to struct
  media::VideoCaptureDeviceInfo.
* Create abstraction VideoCaptureSystem and move caching of
  VideoCaptureDeviceInfo to there. This allows us to use this functionality in
  both InProcess and MojoService code paths.
* Simplify BuildableDeviceCallbacks interface. With the mapping from device_id
  to descriptor being moved into VideoCaptureSystem, BuildableDeviceCallbacks no
  longer needs to offer a LookupDeviceDescriptor() method.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL18.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2805533002
Cr-Commit-Position: refs/heads/master@{#462916}

Adds a custom message displayed in a toast when the user taps on
a pinned home screen shortcut for the disabled static 'New
incognito tab' launcher shortcut.

BUG=708743, 707446

Review-Url: https://codereview.chromium.org/2807613002
Cr-Commit-Position: refs/heads/master@{#462915}

In preparation for back-porting UIViewControllers in the NTP, add support for
loading contentViewControllers inside the clean NTP's scroll view.

This also adds stubs for the NTP mediator and consumer, as well as fix
some navigation errors when loading and unloading the NTP.

BUG=

Review-Url: https://codereview.chromium.org/2785893003
Cr-Commit-Position: refs/heads/master@{#462914}

This fixes a regression where the scroll position changed after closing the
sidenav, and is more correct, since the container is the scroll target.

BUG=708960
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2802073002
Cr-Commit-Position: refs/heads/master@{#462913}

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801073005
Cr-Commit-Position: refs/heads/master@{#462912}

https://chromium.googlesource.com/webm/libvpx.git/+log/32b3d2f174f6..6af42f5102ad

$ git log 32b3d2f17..6af42f510 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 jianj Fix compile warnings with enable-internal-stats flag.
2017-04-06 marpan vp9; Move the denoising condition for speed 5.
2017-04-04 jianj vp9: speed 8: Compute y sad without int_pro_motion_estimation.
2017-04-05 marpan vp9: Temporal denoising: avoid denoising for speed <= 5.
2017-03-31 jianj Refactor: Clean memory allocation for copy partition.
2017-04-05 linfengz Update 32x32 high bitdepth idct NEON optimization
2017-04-04 jianj vp9: Remove legacy comments for avg_source_sad.
2017-04-04 marpan vp9: Adjust condition of golden update with cyclic refresh.
2017-03-29 marpan vp9: 1 pass CBR: cleanup to cyclic refresh.
2017-03-22 ranjit.tulabandu Fix for out of range motion vector bug in sub-pel motion estimation
2017-03-28 yunqingwang Enhance the row mt sync read to accept the sync_range greater than 1
2017-03-30 marpan vp9: SVC: Fix issue with artifact for svc-denoising.
2017-03-29 jzern vpxdec: silently ignore -frame-parallel
2017-03-29 jzern vp9: make VPX_CODEC_USE_FRAME_THREADING a no-op
2017-03-29 jzern rtcd,unit tests: fix ppc64 build
2017-03-29 marpan vp9: SVC: fix to allow output of denoised result.

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Review-Url: https://codereview.chromium.org/2804593006
Cr-Commit-Position: refs/heads/master@{#462911}

Allows the command buffer client to unpack the pixels without any code
changes when it knows which rows and columns were written to.

Roll ANGLE fe48632..bf67aa8
https://chromium.googlesource.com/angle/angle.git/+log/fe48632..bf67aa8
BUG=angleproject:1354
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2787123002
Cr-Commit-Position: refs/heads/master@{#462910}

https://pdfium.googlesource.com/pdfium.git/+log/03c5e1725be9..1e8c39f18df6

$ git log 03c5e1725..1e8c39f18 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 tsepez Remove the "old way" of performing FlateUncompress.

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2799933004
Cr-Commit-Position: refs/heads/master@{#462909}

Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (patchset #3 id:40001 of https://codereview.chromium.org/2803073002/ )

Reason for revert:
Unexpected compilation error from buildbot Android Builder.

Original issue's description:
> Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio
>
> This CL is the second part of the conversion. It manually replaces:
>
>  - RELEASE_ASSERT() with CHECK().
>  - ASSERT(...args) with one or more DCHECK_op(arg).
>
> With this CL the following script returns 0 result.
>
> ```
> cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
> grep -rnw . -e 'ASSERT('
> ```
>
> BUG=707655
>
> Review-Url: https://codereview.chromium.org/2803073002
> Cr-Commit-Position: refs/heads/master@{#462904}
> Committed: https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea37ce7f6a801d5

TBR=rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707655

Review-Url: https://codereview.chromium.org/2807593003
Cr-Commit-Position: refs/heads/master@{#462908}

This test executes code path which is not used in the real app and hence
is not useful.

BUG=709290

Review-Url: https://codereview.chromium.org/2802163002
Cr-Commit-Position: refs/heads/master@{#462907}

Add the ability to:
- Remove attribution
- Remove the settings button

BUG=571056

Review-Url: https://codereview.chromium.org/2799343003
Cr-Commit-Position: refs/heads/master@{#462906}

This CL fixes the fallback_opts parameter for favicon server once again
(after CL 2790113002).

BUG=644102

Review-Url: https://codereview.chromium.org/2804293003
Cr-Commit-Position: refs/heads/master@{#462905}

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG=707655

Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462904}

Review-Url: https://codereview.chromium.org/2800863006
Cr-Commit-Position: refs/heads/master@{#462903}

StructTraitsTest for events and latency were removed from the build by
accident in https://codereview.chromium.org/2783973002.

BUG=686865

Review-Url: https://codereview.chromium.org/2802923002
Cr-Commit-Position: refs/heads/master@{#462902}

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This CL takes the pile of small classes that I've written so far and
wraps them in a single "context" object.

It also changes the classes to accept a pointer to the context instead
of several pointers to individual dependencies.

It *also* creates a ReportingTestBase class that provides a properly
configured context for all of the existing unittests to use, and
switches the tests over.

BUG=704259

Review-Url: https://codereview.chromium.org/2751103002
Cr-Commit-Position: refs/heads/master@{#462901}

Also, re-enables switching from sw to accelerated canvas.

BUG=704571

Review-Url: https://codereview.chromium.org/2799033002
Cr-Original-Commit-Position: refs/heads/master@{#462706}
Committed: https://chromium.googlesource.com/chromium/src/+/2f0fa56eb8fc2eee27d437e7b6c8038ba5a52d87
Review-Url: https://codereview.chromium.org/2799033002
Cr-Commit-Position: refs/heads/master@{#462900}

While we work on being able to relay all response headers from the
download system to the created Response object for Background Fetch,
these two will enable some minimum experimentation.

BUG=692579, 709489

Review-Url: https://codereview.chromium.org/2805813006
Cr-Commit-Position: refs/heads/master@{#462899}

We explicitly pass that in official builds now, and after we've built and
rolled in a compiler with this change here, we'll no longer ask the linker
to generate a build id in unofficial builds (where it's not needed), which
should speed up links a bit.

BUG=622775

Review-Url: https://codereview.chromium.org/2784423003
Cr-Commit-Position: refs/heads/master@{#462898}

By having BucketRanges keep a reference to where the data can be found
in persistent memory, the existing de-dup of the BucketRanges object
also serves to avoid duplicating the data in persistent memory.

Simple testing shows allocated persistent histogram memory in the
browser is reduced by about 22%.  This should be similar in all
processes though somewhat less as the number of histograms held goes
down.

BUG=705342

Review-Url: https://codereview.chromium.org/2794073002
Cr-Commit-Position: refs/heads/master@{#462897}

about_flags.cc today opt in/out configurations manually, rather
than using the existing ENABLE_NATIVE_NOTIFICATIONS build flag.

This fixes the OZONE/Linux build.

BUG=676220
R=thomasanderson@google.com

Review-Url: https://codereview.chromium.org/2802243002
Cr-Commit-Position: refs/heads/master@{#462896}

Disabling tests:
 - CrSettingsNonExistentRouteTest.All
 - SettingsSiteSettingsPageBrowserTest.labels
 - SettingsBasicSubPageBrowserTest.SubPages

BUG=709442
TBR=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2808473002
Cr-Commit-Position: refs/heads/master@{#462895}

This test (and possibly the others in this set) are
flaky on Mac.

BUG=709504
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2805533006
Cr-Commit-Position: refs/heads/master@{#462894}

Due to complexity between user gesture and vibrate, we decided to remove vibrate from V1 feature policy.

Review-Url: https://codereview.chromium.org/2801153002
Cr-Commit-Position: refs/heads/master@{#462893}

input image.

The pixels that are chosen are evenly distributed throughout the image.

This proved to be more effective than limiting the color space (i.e. the
number of unique colors).

On at least one large sample wallpaper and my workstation, this reduces
runtime from hundreds of ms to <10ms.

BUG=687852

Review-Url: https://codereview.chromium.org/2797033002
Cr-Commit-Position: refs/heads/master@{#462892}

For LargeIconService, we need to access Content-Location header for
images fetched by ImageFetcher. This CL reveals HttpResponseHeaders* in
image_fetcher::RequestMetadata.

BUG=644102

Review-Url: https://codereview.chromium.org/2793983002
Cr-Commit-Position: refs/heads/master@{#462891}

The previous implementation of nativeValue() for IDL interfaces and callback
functions simply called implTypeWithCheck() (or create() for callback
functions) and returned its value. This meant it was not possible for
callers to easily distinguish a nullptr returned here (meaning the
conversion failed) from nullptr being returned by a nativeValue() call for
another type (which can just be a nullptr).

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2802223002
Cr-Commit-Position: refs/heads/master@{#462890}