- 29 Jun, 2018 40 commits
-
-
Colin Blundell authored
IdentityProvider currently has baked-in knowledge of OAuth2TokenService for functionality that is shared between ProfileIdentityProvider and DeviceIdentityProvider. However, as we will be converting ProfileIdentityProvider to talk to IdentityManager rather than OAuth2TokenService, this baked-in knowledge needs to be moved out of IdentityProvider; ultimately, it will end up only in DeviceIdentityProvider. As the last step of removing this knowledge from IdentityProvider, this CL moves IdentityProvider's observing of OAuth2TokenService into its two derived classes. ProfileIdentityProvider is now ready to be converted to use IdentityManager; that work will shortly follow. Bug: 809452 Change-Id: I9beaae509b2aae22308c0bd47f962a42cba93f8d Reviewed-on: https://chromium-review.googlesource.com/1114855 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#571458}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb21219e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20355 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=kereliuk No-Export: true Change-Id: I3a79c0ad52836e825f2ba59fc2943810fb4d1d94 Reviewed-on: https://chromium-review.googlesource.com/1120145 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571457}
-
cathiechen authored
In order to compute the intruded float width, we find opportunity for marker, and compare it to ListItem content_rect. If direction:ltr, compare the left side, if rtl, compare the right side. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3901ac5e758497b2503a5b9fefa71ec0a4ca57e5 Reviewed-on: https://chromium-review.googlesource.com/1116895Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#571456}
-
Adam Rice authored
Replace the remaining 7 uses of #include <v8.h> in Blink with the modern- style #include "v8/include/v8.h". Bug: 688155 Change-Id: I6b28c0f94275f9e461fedf68d48edc1ebd7c7b74 Reviewed-on: https://chromium-review.googlesource.com/1119951 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571455}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d3714bb8..b5ad7b8d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I26e21d7aa8255fcfb55a412a1a89a3a8327b6a76 Reviewed-on: https://chromium-review.googlesource.com/1119854Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571454}
-
Oscar Johansson authored
The macro CACHE_UMA_BACKEND_IMP_OBJ is defined in: net/disk_cache/blockfile/backend_impl.cc net/disk_cache/blockfile/entry_impl.cc When building using jumbo these end up in the same scope and conflict. This commit solves the issue by undefining the macro at the end of the file. Bug: 772146 Change-Id: Ib888216156c3054616f6e906e6c23a648154d2d9 Reviewed-on: https://chromium-review.googlesource.com/1118273Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571453}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kBeta in: net/third_party/quic/core/congestion_control/cubic_bytes.cc net/third_party/quic/core/congestion_control/rtt_stats.cc This commit solves the issue by renaming kBeta in net/third_party/quic/core/congestion_control/cubic_bytes.cc to kDefaultCubicBackoffFactor to avoid the conflict and to give the variable a more descriptive name. Bug: 772146 Change-Id: Ibc2e6732d2c5fa70672a73e7b6669d8b71f581d1 Reviewed-on: https://chromium-review.googlesource.com/1119691Reviewed-by:
-
Colin Blundell authored
This CL adds APIs to IdentityManager for obtaining the set of all accounts with refresh tokens and querying whether the primary account is available with a refresh token. The design follows that of IdentityManager's caching of the primary account information: - IdentityManager initializes its state with the current state of ProfileOAuth2TokenService. - IdentityManager updates this state in response to notifications from PO2TS that an account's refresh token was updated/removed. TBR=bsazonov@chromium.org Bug: 806774 Change-Id: Idc4a37a15ced2e7d32f012a50e4e0d1fdb1aecdf Reviewed-on: https://chromium-review.googlesource.com/1098668 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#571451}
-
Oscar Johansson authored
The macro RETURN_STRING_LITERAL is defined in namespaces in: net/third_party/quic/core/crypto/crypto_utils.cc net/third_party/quic/core/quic_error_codes.cc net/third_party/quic/core/quic_utils.cc net/third_party/quic/core/quic_versions.cc When building using jumbo these end up in the same namspace and conflict. This commit solves the issue by undefining the macro inside the namespace. Bug: 772146 Change-Id: Ibb07acd829f8ad2867748d1db8aba5aa59a39e47 Reviewed-on: https://chromium-review.googlesource.com/1118222Reviewed-by:
-
chrome://policyA Olsen authored
cloud_policy_generated.cc parses JSON for certain policies in a function called DecodeJSON - however, if the JSON is invalid, it simply drops the invalid policy with no visible warning. This CL wires errors through by adding an error field to PolicyMap. The different possible designs are compared internally at go/decodejsonfix Bug: 853719 Change-Id: I98979183ac54278710f1ac57e5a48f2a9eee0b59 Reviewed-on: https://chromium-review.googlesource.com/1104354Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571449}
-
Tanja Gornak authored
FCMSyncInvalidationListener aims to substitude SyncInvalidationListener for the Tango->FCM migration. Bug: 801985 Change-Id: Ib2907b8d5431e4730e42947744c84036050cd253 Reviewed-on: https://chromium-review.googlesource.com/1111714 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571448}
-
Yuichiro Hanada authored
zcr_input_method_surface_v1 is an interface implemented by wl_surface that hosts IME windows. Bug: 845079 Change-Id: I3c2ef1927781afd4c6d6532135430b1bbda39311 Reviewed-on: https://chromium-review.googlesource.com/1118403 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571447}
-
Henrik Grunell authored
TBR=reveman@chromium.org Bug: 859020 Change-Id: I0fa9cfa276acf2f39e3e635cf5d0023a6b4986a2 Reviewed-on: https://chromium-review.googlesource.com/1120172Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571446}
-
stkhapugin@chromium.org authored
iPad multitasking UI should match iPhone or normal iPad depending on size class: * in RxR size class, it should show the suggestion icons and align to the icon in the omnibox * in other size classes, it should be left-aligned and have no suggestion icons However, pre-UI Refresh UI should remain the same. Bug: 821817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibeed9ecf4f4b1058e80e7e4d45523b1d1f0d4ee8 Reviewed-on: https://chromium-review.googlesource.com/1118225 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571445}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 335864`. Contains two notable changes: - lld now increases section layout to 16 bytes for sections that are CFG targets, which makes CFG more precise on x86 and works around a crash bug in Microsoft's x86 emulator on arm. - Wconstant-logical-operand now fires more often and finds more bugs. We fixed all new instances of this warning on all bots we know about. Bug: 857012,857393 Change-Id: I9396f5bae9750a1abcb9f0b256e9caed7b6ccc71 Reviewed-on: https://chromium-review.googlesource.com/1118531Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571444}
-
Henrik Grunell authored
TBR=noel@chromium.org Bug: 859008 Change-Id: Icb0689a7390ea62ee5904e9b91d0efee8a478ce6 Reviewed-on: https://chromium-review.googlesource.com/1120026Reviewed-by:
-
Greg Thompson authored
BUG=856995 Change-Id: I9083ebef835ca9980aa08aa31fb77e675917ba9f Reviewed-on: https://chromium-review.googlesource.com/1119919Reviewed-by:
-
Ned Nguyen authored
This reverts commit 681ba107. Reason for revert: break uploading on Mac (https://ci.chromium.org/buildbot/chromium.perf/mac-10_13_laptop_high_end-perf/167) Original change's description: > Parallelizing perf dashboard uploads > > This change also update the oauth token to generating > ne per run to one per benchmark > > Bug:713357,854162 > Change-Id: If06e71c53fe8083f82307584a6e92104e33b2f65 > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:obbs_fyi > > Change-Id: If06e71c53fe8083f82307584a6e92104e33b2f65 > Reviewed-on: https://chromium-review.googlesource.com/1114690 > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#571212} TBR=nednguyen@google.com,eyaich@chromium.org Change-Id: Icc0093c203e0fa335c550c8af5686af1786d6625 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 713357, 854162 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Reviewed-on: https://chromium-review.googlesource.com/1120125Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571441}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/776199a55a22..c54f706993be git log 776199a55a22..c54f706993be --date=short --no-merges --format='%ad %ae %s' 2018-06-29 buildbot@webrtc.org Roll chromium_revision ecf8a613..a88423ac (569618:571410) 2018-06-29 mbonadei@webrtc.org Revert "Pull GN via CIPD package." Created with: gclient setdep -r src/third_party/webrtc@c54f706993be The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id8612bf3c8f15c8fc5f01dbf0cc21d98c6f1718d Reviewed-on: https://chromium-review.googlesource.com/1119926Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571440}
-
Egor Pasko authored
Introduce 'experimental.startup.mobile' aiming to replace 'experimental.startup.android.coldish'. For a more detailed plan see the toplevel comment in tools/perf/benchmarks/startup_mobile.py This is basically a copy+rename of third_party/catapult/telemetry/examples/benchmarks/android_go_benchmark.py to agree on the naming, the plan, and serve as a base for incremental improvements. With both of these changes the benchmark runs end to end and emits the same metrics as experimental.startup.android.coldish. Though some polish is still needed to produce more representative metrics at lower noise. Bug: 760498 Change-Id: I79e12e306f829fcc3c075b9466cb2d6330cf4fe7 Reviewed-on: https://chromium-review.googlesource.com/1113546 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Currently, Chromium disregards Accept-CH-Lifetime header on iframe navigation responses. This CL changes Chromium behavior to accept ACL header on iframe navigation responses provided the origin of the response matches the origin of the main frame navigation. This behavior is compliant with the updated client hints spec. WPT tests will come in a subsequent CL. Change-Id: I5603cad33f77d8e413b402b8a6c184497d87aec6 Bug: 856700 Reviewed-on: https://chromium-review.googlesource.com/1117859 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#571438}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e2327b133db..723b1f6ef941 git log 7e2327b133db..723b1f6ef941 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@723b1f6ef941 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Icfc758485b0dd0dd775fa71d0fea86723b2277e2 Reviewed-on: https://chromium-review.googlesource.com/1119709Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571437}
-
Oscar Johansson authored
LogSeverity is a typedef in base/logging.h and a macro in the Windows header setupapi.h. When building using jumbo this causes a conflict. This commit solves the issue by undefining LogSeverity after importing setupapi.h. Bug: 850484,856964 Change-Id: I3e56c1a06357d8e03dbc98e01e51b18ae05e94dc Reviewed-on: https://chromium-review.googlesource.com/1116790Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571436}
-
Greg Kraynov authored
Also make RealTimeDomain internal. Bug: 783309 Change-Id: I142aa6f9c13bd6f5ce2211b95dd84a234fc71e0d Reviewed-on: https://chromium-review.googlesource.com/1118554 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571435}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f1ba1dcd5882..da32244d8116 git log f1ba1dcd5882..da32244d8116 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 michaschwab@google.com Create Canvas Wrapper Created with: gclient setdep -r src/third_party/perfetto@da32244d8116 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7763e761b37c4efba08707c7c3388cfcc1fb57b5 Reviewed-on: https://chromium-review.googlesource.com/1119927 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571434}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5fbb98122c59..20c3677acc37 git log 5fbb98122c59..20c3677acc37 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 thestig@chromium.org Revert "Simplify CPDF_PageOrganizer::UpdateReference method." Created with: gclient setdep -r src/third_party/pdfium@20c3677acc37 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:858921,chromium:858952 TBR=dsinclair@chromium.org Change-Id: Idb479ee7ece0b0393389cbc86fe1a187b091207e Reviewed-on: https://chromium-review.googlesource.com/1119710Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571433}
-
Thomas Tangl authored
The following strings are updated as part of the transition to Unity: - the title of the sync setup and personalization page - sync section title and description - personalization title - unity master toggle title - Sign-in prompt title Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr68-mD5nfi-3ML6EZ2WWTC08 TBR=dpapad@chromium.org Bug: 853187 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3184c5e9c8614a1d7bdd900f346b19769e2c985d Reviewed-on: https://chromium-review.googlesource.com/1102501 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571432}
-
Takuto Ikuta authored
Now if we specify -fdebug-compilation-dir, clang-cl emits obj files independent from build directory. So this flag will allow to sharing build cache when engineers use goma on different build directory. To debug executable with this flag, we need to specify 'debug source files' property in visual studio. Some goma backend preparation for build cache sharing is on-going yet, but I will ask windows developer to try the flag to confirm it does not break their workflow. This is windows version of below proposal. https://docs.google.com/document/d/1OX4jY_bOCeNK7PNjVRuBQE9s6BQKS8XRNWGK8FEyh-E/edit?usp=sharing Bug: 712796 Change-Id: I65e6da67614839e5dde408038cad33a63dc28ac1 Reviewed-on: https://chromium-review.googlesource.com/1118200 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571431}
-
Henrik Boström authored
This is in preparation for get/setParameters[1] and RTCRtpTransceiver[2]. Tests are updated to use promise_test and async/await to make them easier to write and to execute sequentially. Tests are updated to set up a call before getParameters() because many parameters are defined as "that has been negotiated". If we want to test what is returned before negotiation we should add that as separate tests. For now, this is necessary for the tests to run on [1][2]. Some tests are removed because they no longer reflect the spec. Because get/setParameters() and RTCRtpTransceiver has not landed yet, the tests are still expected to fail. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1102436 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1025771 Bug: 803494, 777617 Change-Id: I3f14a37925837576a602d91bb67e48181c56a946 Reviewed-on: https://chromium-review.googlesource.com/1102502Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#571430}
-
David Roger authored
When loading a token fails, kInvalidRefreshToken is used instead of the empty token. For such accounts, RefreshTokenIsAvailable() and RefreshTokenHasError() now return true. Change-Id: I0f206a183027162153b5a8de52e4c87c3462e84c Reviewed-on: https://chromium-review.googlesource.com/1107979Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Erik Språng authored
The bitrate allocation class needs to be serialized in order to be passed over ipc. Also optimize the VideoBitrateAllocation to make it cheaper to get the sum, which is now being called in more and more places. Bug: chromium:853185 Change-Id: Id61fcfa5c5fe448cea0b1fef3283f3c414c7c5a4 Reviewed-on: https://chromium-review.googlesource.com/1102470Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Språng <sprang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571428}
-
Matthew Cary authored
Uses the new WritableUnalignedMapping class, which changes the ownership semantics. See the bug for details on the overall plan. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie8da3246a5c7036322e72e120c4925cebc451f0e Reviewed-on: https://chromium-review.googlesource.com/1117685Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#571427}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/82d171c82469..776199a55a22 git log 82d171c82469..776199a55a22 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 mbonadei@webrtc.org Enable PeerConnectionEndToEndTest.CallWithLegacySdp on ASan. Created with: gclient setdep -r src/third_party/webrtc@776199a55a22 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1157cc6050b31b1867dea0575cf72c768a579fe1 Reviewed-on: https://chromium-review.googlesource.com/1119711Reviewed-by:
-
Joel Hockey authored
Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iafe64af611275d2a434ad533c3c615a9ccb8abf5 Reviewed-on: https://chromium-review.googlesource.com/1119739 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#571425}
-
Javier Fernandez authored
Flexible tracks should be considered as content-sized if the grid is laid out under indefinite size constraints. We only know this while running the track sizing algorithm for each direction, hence we should apply the same pattern for the Baseline Alignment offsets computation. Bug: 855568 Change-Id: Icfc9f3cefc70ab87004a772ac97b60e97b97249d Reviewed-on: https://chromium-review.googlesource.com/1113933 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#571424}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/898687843450..525fc9fdb588 git log 898687843450..525fc9fdb588 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 vapier@chromium.org cros_portage_upgrade: kill it for now 2018-06-29 vapier@chromium.org cros_portage_upgrade: switch to main repo for now Created with: gclient setdep -r src/third_party/chromite@525fc9fdb588 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:858925,chromium:858925 TBR=chrome-os-gardeners@chromium.org Change-Id: I9dc9d0b60f1aca280990bf58057f3e67a44fe37f Reviewed-on: https://chromium-review.googlesource.com/1119708Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571423}
-
Martin Kreichgauer authored
This changes the CredentialMetadata::EncodeRpId method to allow an RP ID to be recovered from the encoding, given the secret key; and it adds a CredentialMetadata::DecodeRpId method to do so. This is necessary because we need an effective way to test whether a given credential in the macOS keychain "belongs" to a given profile (i.e. was the metadata sealed/encoded under that profile's secret key), when performing browsing data deletion for that profile. This was previously impossible: Unsealing the credential ID requires the correct RP ID, with which the credential id ciphertext is authenticated. The other two fields (RP ID + user handle, and RP ID) are encoded with HMAC-SHA-256, so they are not reversible without the RP ID either. This CL changes the kSecAttrLabel field, which previously stored HMAC-SHA-256(rp_id), to store a deterministic encryption of rp_id instead. The cipher is AES-GCM-SIV with a fixed nonce. This makes the encoding reversible (because you can retrieve the RP ID by decrypting), while maintaining easy lookup of all credentials for a given RP (because the encoding is deterministic) and confidentiality (because you need the key to decrypt). Bug: 678128 Change-Id: I2e34ca5c7f28a2bd14a953539de6e0ac90568bec Reviewed-on: https://chromium-review.googlesource.com/1117609 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#571422}
-
Ke He authored
This is the last step of servicification of geolocation. The whole //device/geolocation folder is moved to //services/device. The public files in //device/geolocation/public are moved to //service/device/public accordingly. BUG=800659 Change-Id: Id0413058874e20158f733e77c2eaed62f168f8ff Reviewed-on: https://chromium-review.googlesource.com/1102190 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571421}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: I15325bda1464dbcb9c2ec247943e2eca4fa5d7ee Reviewed-on: https://chromium-review.googlesource.com/1119423Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571420}
-
Tetsui Ohkubo authored
This CL moves remaining mojom::SystemTray implementation in SystemTrayController to SystemTrayModel, and changes SystemTrayModel to bind mojom::SystemTray interface directly. TEST=trybot pass BUG=none Change-Id: Ie73cd257e19a5230387058f45c57a771a32310cf Reviewed-on: https://chromium-review.googlesource.com/1107582 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571419}
-
