- 27 Nov, 2018 40 commits
-
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/716f2896c6ba..67223a304e09 $ git log 716f2896c..67223a304 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 wtc decoder_get_frame() should use output frame index. 2018-11-21 wtc Declare pbi->output_frame_index as an array of int Created with: roll-dep src/third_party/libaom/source/libaom R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org Bug: 906381 Change-Id: I8f80378c1608761310a273ecdb3556d401e71cc2 Reviewed-on: https://chromium-review.googlesource.com/c/1351715Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#611282}
-
Peter Kasting authored
This will allow enabling a previously disabled test for Windows. Bug: none Change-Id: I58a0a62db1228e303de71519914a6b744711ce97 Reviewed-on: https://chromium-review.googlesource.com/c/1338945 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611281}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62e154db..73bc258c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia4995cb05698c10d9f36cf23de05e4fc7d2193d4 Reviewed-on: https://chromium-review.googlesource.com/c/1351934Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611280}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 903957 Change-Id: I461f534870c60e1fc6b9c1c441d388cc99646c10 Reviewed-on: https://chromium-review.googlesource.com/c/1338483Reviewed-by:Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#611279}
-
Christian Dullweber authored
"Clear & reset" used GURL::DomainIs() to check if a cookie belongs to a specific domain. This doesn't handle cookies that are scoped to a domain and all subdomains correctly. E.g. a cookie for ".example.com" would not be removed if "example.com" is cleared. This is fixed by using CanonicalCookie::IsDomainMatch() instead, which correctly determines if a cookie is visible to a domain. Bug: 908364 Change-Id: If01fde74845c6c8a547ec86b0a3be8b9076b2d61 Reviewed-on: https://chromium-review.googlesource.com/c/1350634Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#611278}
-
Marc Treib authored
This is a followup to https://crrev.com/c/1350984. In particular, this moves the code from /components/browser_sync/ into /components/sync/, where autofill code can actually access it. Bug: 903290 Change-Id: Id7b90cf5c1344cb4404d9a672d057a67e74d35b9 Reviewed-on: https://chromium-review.googlesource.com/c/1352160Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#611277}
-
Dan Elphick authored
Fixes uses of deprecated Object::Set and FunctionTemplate::GetFunction to use Context version that return Maybe values. Bug: v8:7283, v8:7295, v8:8238, chromium:883496 Change-Id: Ia400ec8b36d138b9f6b87c4a91f7ccb12c2eeefa Reviewed-on: https://chromium-review.googlesource.com/c/1352314 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611276}
-
Eric Robinson authored
See also go/chromerulesetservicemerge. This CL removes the delegate file from core, and changes it as well as the ContentRulesetService to the more appropriate name of RulesetPublisher and RulesetPublisherImpl. It also splits the header files appropriately. The final step will be to split the source files, which will be done in a follow-up CL. Change-Id: I2f5b077c9564c81586861b0ecae99f089b2237f3 Reviewed-on: https://chromium-review.googlesource.com/c/1340644Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611275}
-
Becca Hughes authored
Move the action buttons to using the MediaSessionAction enum now that it is available. BUG=893296 Change-Id: I174d7f9aadc0b1cf89b0b1a2f01d8e2a5269aead Reviewed-on: https://chromium-review.googlesource.com/c/1320653 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#611274}
-
Pedro Amaral authored
Make tab switcher bottom toolbar clickable to prevent clicks from going through the bottom bar and selecting a tab. Bug: 905077 Change-Id: Iae34cd43f6f82aef1c8d62cdcdad20e38b075d5b Reviewed-on: https://chromium-review.googlesource.com/c/1351753Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#611273}
-
Daniel Rubery authored
.desktop files act as shortcuts on Linux, allowing arbitrary code execution. We should send pings for these files. Bug: 904182 Change-Id: Ibc26141fb180e843e1ffaf3f78717a9109d2fa9a Reviewed-on: https://chromium-review.googlesource.com/c/1344552Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#611272}
-
Xianzhu Wang authored
- Allow infinite cull rect to be properly clipped and expanded through scroll translation. This can prevent SPv2 performance regression when painting scrolling contents when some ancestor uses infinite cull rects. This achieves the similar results of SPv1 painting composited scrolling contents. - Copy and adapt the interest rect tests from composited_layer_mapping_test.cc into paint_layer_painter_test.cc - Add infinite cull rect unit tests Bug: 792577 Change-Id: Ia784416557e10a3193cd677ad8d31101fd077bc6 Reviewed-on: https://chromium-review.googlesource.com/c/1347354Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611271}
-
Eric Willigers authored
Keywords size, layout, style, paint now serialize in that order for the 'contain' property. https://drafts.csswg.org/css-contain/#contain-property Bug: 908353 Change-Id: Ifde635f2d313add887dd43a0a0d98249e45bff4b Reviewed-on: https://chromium-review.googlesource.com/c/1350562 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#611270}
-
Vlad Tsyrklevich authored
SafeStack support has been abandoned. Bug: 908597,889532 Change-Id: I989dbf90bab522c6a4c50117de64a85509b4932f Reviewed-on: https://chromium-review.googlesource.com/c/1351585 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#611269}
-
David Grogan authored
Meaning: column containers, ortho children, and non-horizontal writing modes Bug: 845235 Change-Id: Iba6525752d0c14a77bc9a13cc75a484cdf3a711d Reviewed-on: https://chromium-review.googlesource.com/c/1332247 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#611268}
-
Tao Bai authored
To be consistent with Android native view, this patch make WebView always show AUTOFILL menun in the overflow menu. Bug: 907698 Change-Id: Ibe9e8bfd3850177339cfd969488649b44b5524d5 Reviewed-on: https://chromium-review.googlesource.com/c/1347000 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611267}
-
Andrew Luo authored
Bug: 816708 Change-Id: I0477ba7d3c93bef726c9bf0bc9879882ebedbfd9 Reviewed-on: https://chromium-review.googlesource.com/c/1290144Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611266}
-
Eric Stevenson authored
Change-Id: Iefb439e6437a8589599155097365d9dd9cb17bb3 Reviewed-on: https://chromium-review.googlesource.com/c/1349853 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#611265}
-
Vladimir Levin authored
This updates the layout test and some code changes to make those tests pass to be mode 2 tests (ie append after lock). R=chrishtr@chromium.org Bug: 882663 Change-Id: I44554d486c5af0db1c680d5be719d687fd2745d2 Reviewed-on: https://chromium-review.googlesource.com/c/1344263Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611264}
-
Yaron Friedman authored
P is now being build with SDK code 28 and we're moving to targeting Q. BUG=908821 Change-Id: I316883e0b1bf6cad2157a73a68c0ee567263c543 Reviewed-on: https://chromium-review.googlesource.com/c/1351479Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611263}
-
Philipp Hancke authored
Firefox does not support addTrack(track). Add a track whereever it makes sense. The addTrack tests itself might rightfully use this. The following grep shows most affected places: git grep addTrack *.html | grep -v , | grep -v "\.\.\." Bug: None Change-Id: Ib225e6d51184c3ccc446ccf93447e2ac7be080c3 Reviewed-on: https://chromium-review.googlesource.com/c/1346394Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#611262}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df4ad0d1e00a..05744b47d94a git log df4ad0d1e00a..05744b47d94a --date=short --no-merges --format='%ad %ae %s' 2018-11-27 lalitm@google.com trace_processor: fix bugs with Chrome scoped slices Created with: gclient setdep -r src/third_party/perfetto@05744b47d94a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I01252b69b066f0534de69f1fb4b9936d56bf6dce Reviewed-on: https://chromium-review.googlesource.com/c/1352242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611261}
-
Aaron Leventhal authored
Do not suppress events on descendants of leaf nodes on Android, otherwise necessary events are not fired. This is because Android treats a lot more nodes as leaves. Bug: 907866 Change-Id: If93d55747249d9084c57a091647f8d4860df6d3c Reviewed-on: https://chromium-review.googlesource.com/c/1351494Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611260}
-
Shuotao Gao authored
This reverts commit 03982f12. Reason for revert: Caused compile failure on code coverage bot https://bugs.chromium.org/p/chromium/issues/detail?id=908937 Original change's description: > base: Make TraceEvent a movable class. > > This is a small cleanup of the TraceEvent class performed > which is part of a larget bug allowing cleaning up and > reducing the generated machine code for TRACE_EVENTXXX() > macro calls (see related bug). > > A first CL to perform this refactor was submitted as [1], but > later reverted because it made some tests fail mysteriously > (see http://crbug.com/899813). So the original CL was split into > several independent ones. > > A first CL was submitted as [2], which actually fixed some > potential dangling pointer issues that were created from the > Initialize() and MoveFrom() methods. > > This second CL removes this methods by making TraceEvent a > proper C++11 movable type, which should prevent (or at least > make it more difficult) introducing invalid states for its > instances. The goal is to see if this introduces new unexpected > test failures (which would indicate that there are still invalid > instance states used in the code base). > > The third CL is [3] and re-introduces the TraceArguments helper > class on top of this one. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1318919 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1340308 > [3] https://chromium-review.googlesource.com/c/chromium/src/+/1318919 > > BUG=898794 > R=primiano@chromium.org,oysteine@chromium.org,alexilin@chromium.org,chiniforooshan@chromium.org > > Change-Id: I2b36885e2485d23cca199c48b2bd07d5745b00c5 > Reviewed-on: https://chromium-review.googlesource.com/c/1346305 > Commit-Queue: David Turner <digit@chromium.org> > Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org> > Reviewed-by: Alexandr Ilin <alexilin@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611185} TBR=digit@chromium.org,primiano@chromium.org,chiniforooshan@chromium.org,oysteine@chromium.org,alexilin@chromium.org Change-Id: I73d85745e3b67cbcecddd25cb78a8e22ba031965 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898794 Reviewed-on: https://chromium-review.googlesource.com/c/1351557Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611259}
-
Fredrik Söderquist authored
Don't create a Pattern just to have it create a PaintShader - just create the PaintShader directly. Change-Id: I85b96ed9becea31e93d62191baac263f08f53f91 Reviewed-on: https://chromium-review.googlesource.com/c/1352258 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#611258}
-
Eric Willigers authored
Test parsing, serialiation and computed values for properties defined in CSS Fragmentation Module Level 3 https://drafts.csswg.org/css-break/ Blink has expected failures for keywords relating to CSS Regions. Change-Id: Ie5a930ba2d805c7bd45aa84c293bc8ff5922da98 Reviewed-on: https://chromium-review.googlesource.com/c/1351190 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#611257}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/f241a59dcca617c5b9d9880a8a9fd92996a654be..6965d25602754bc419c5f757d008ba1f4da49ae4 The following commits have Chromium bugs associated: 4f746a907 Move ARM cpuinfo functions to the header. 09f5a040d No longer set CQ-Verified label on CQ success/failure. This additionally includes some manual follow-up tweaks to BUILD.gn for 4f746a907. Bug: 906576, 907115 Change-Id: If066a9fdd873edbad773cc8db7a8aadd679f269b Reviewed-on: https://chromium-review.googlesource.com/c/1347096 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#611256}
-
Leszek Swirski authored
Check for an edge case where a ScriptResource may have a null resource buffer without having been loaded. As part of this, extract the inspector's logic for accessing a ScriptResource's text into the ScriptResource, as it relies on ScriptResource internal state. Bug: 865098 Bug: 899217 Change-Id: I5ceb6f105e21e4eeb7ce5f9bc82c7d7c7f7f6aad Reviewed-on: https://chromium-review.googlesource.com/c/1352183 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#611255}
-
Eric Stevenson authored
For secondary abis the thinlto-cache directory is a sub-directory of the secondary abi directory. Change-Id: I1a87df0aec52f0550efa203be3ff0abb00a770d3 Reviewed-on: https://chromium-review.googlesource.com/c/1349852Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611254}
-
Roberto Carrillo authored
R=stgao,liaoyuke,jbudorick Change-Id: Ib6b8e78e90511cd5699194adba1414fbbf8985e3 Reviewed-on: https://chromium-review.googlesource.com/c/1350884Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611253}
-
Scott Violet authored
AFAICT gpu_process_transport_factory is not compiled on android, (see https://chromium.googlesource.com/chromium/src/+/master/content/browser/BUILD.gn#2454 ), yet it has some ifdefs for android. This removes the ifdefs as well as moving an include to match where gpu_process_transport_factory is compiled. BUG=none TEST=none Change-Id: I005fb4db009b36383079faf2c41bb19d89e20e84 Reviewed-on: https://chromium-review.googlesource.com/c/1350981Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611252}
-
Jered Gray authored
The task runner being used in PreviewsOptimizationGuide was UI, but it was named IO. The name has been updated to reflect the actual task runner passed in. Change-Id: Iab6e07c148ca087194d9b876dff4f4f5b285a153 Reviewed-on: https://chromium-review.googlesource.com/c/1338727Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#611251}
-
Henrique Nakashima authored
This is a reland of a061c829 Reverted due to being a suspect in crbug.com/906242, but after reverting the bug persists and was bisected to another CL. Original change's description: > Flatten UpdateMetricsUsagePrefs - skip Metrics and Reporting service. > > UpdateMetricsUsagePrefs() is a chain of calls: > - ChromeDataUseMeasurement::UpdateDataUseToMetricsService() > -> UpdateMetricsUsagePrefs() > -> MetricsService::UpdateMetricsUsagePrefs() > -> ReportingService::UpdateMetricsUsagePrefs() > -> DataUseTracker::UpdateMetricsUsagePrefs() > > It can be reduced to: > - ChromeDataUseMeasurement::UpdateDataUseToMetricsService() > -> UpdateMetricsUsagePrefs() > -> DataUseTracker::UpdateMetricsUsagePrefs() > > This removes the dependency from ChromeDataUseMeasurement to > MetricsService and ReportingService. > > Bug: 902791 > Change-Id: I38a6d22d1ff823134c79bc342ea32be0f89cda77 > Reviewed-on: https://chromium-review.googlesource.com/c/1334267 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608567} Bug: 902791 Change-Id: I27abaac1d265e63ae5a921ab2839a77ae8582720 Reviewed-on: https://chromium-review.googlesource.com/c/1348249Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#611250}
-
Christos Froussios authored
Subprocesses set their encryption key by getting it from the browser with GetRawEncryptionKey and setting it locally with SetRawEncryptionKey Since GetRawEncryptionKey may return an empty string (e.g. because the lookup into Keychain failed), SetRawEncryptionKey should not expect that the key is never empty. Bug: 908431 Change-Id: Id9eece1bdf4492778c18178efc97380b800f5034 Reviewed-on: https://chromium-review.googlesource.com/c/1350915 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#611249}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/webui. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 589840 Change-Id: I047edb54ce7991b4aefd3af99a89affaa53f7a56 Reviewed-on: https://chromium-review.googlesource.com/c/1351956Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611248}
-
Daniel Nicoara authored
When creating a video frame for the video hole, the compositor creates a TextureDrawQuad. This is generic enough that the overlay strategy can't distinguish between a video frame and a EXO texture. Add a hint to the TextureDrawQuad that the video frame requires an overlay and use that to differentiate the video hole quad. TBR=kaznacheev@chromium.org hole. correctly. Bug: 899246 Test: Ran on device and ensured EXO content doesn't trigger the video Test: Ran updated viz_unittests to verify new strategy filters content Change-Id: I4e275550efa287fd2b491d31028a1dead9fbc053 Reviewed-on: https://chromium-review.googlesource.com/c/1316088 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#611247}
-
Scott Violet authored
This reverts commit e45a6ef0. Reason for revert: This triggers DCHECKs on device, so reverting. Here's the stack: [13255:13255:1127/111259.548287:FATAL:tray_bluetooth_helper.cc(50)] Check failed: !timer_.IsRunning(). #0 0x5abde8c02cef base::debug::StackTrace::StackTrace() #1 0x5abde8b586cb logging::LogMessage::~LogMessage() #2 0x5abdeb50f0a5 ash::TrayBluetoothHelper::StartOrStopRefreshingDeviceList() #3 0x5abde9b4ac48 device::BluetoothAdapter::NotifyAdapterPoweredChanged() #4 0x5abde9b55a5f bluez::BluetoothAdapterBlueZ::SetAdapter() #5 0x5abde9b7d3d5 bluez::BluetoothAdapterClientImpl::ObjectAdded() #6 0x5abde9a471be dbus::ObjectManager::AddInterface() #7 0x5abde9a46d2e dbus::ObjectManager::UpdateObject() #8 0x5abde9a457fb dbus::ObjectManager::OnGetManagedObjects() #9 0x5abde505efdc _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos14BiodClientImplEFvPN4dbus6SignalEEJNS_7WeakPtrIS4_EEEEEFvS7_EE3RunEPNS0_13BindStateBaseES7_ #10 0x5abde9a486bf dbus::ObjectProxy::OnCallMethod() #11 0x5abde9a4cb43 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEESD_NS_12OnceCallbackIFvPNS3_8ResponseEEEESG_PNS3_13ErrorResponseEEJ13scoped_refptrIS4_ESB_SB_SI_EEEFvSG_SK_EE7RunOnceEPNS0_13BindStateBaseESG_SK_ #12 0x5abde9a49074 dbus::ObjectProxy::RunResponseOrErrorCallback() #13 0x5abde9a4db5e _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvNS3_19ReplyCallbackHolderENS_9TimeTicksEPNS2_8ResponseEPNS2_13ErrorResponseEEvE6InvokeISB_13scoped_refptrIS3_EJS4_S5_S7_S9_EEEvT_OT0_DpOT1_ #14 0x5abde9a4da80 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS4_19ReplyCallbackHolderENS_9TimeTicksEPNS3_8ResponseEPNS3_13ErrorResponseEEJ13scoped_refptrIS4_ES5_S6_S8_SA_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #15 0x5abde8bd218b base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() #16 0x5abde8bd260b _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #17 0x5abde8c28597 base::debug::TaskAnnotator::RunTask() #18 0x5abde8b6242f base::MessageLoopImpl::RunTask() #19 0x5abde8b62ae2 base::MessageLoopImpl::DoWork() #20 0x5abde8c24189 base::MessagePumpLibevent::Run() #21 0x5abde8b61f05 base::MessageLoopImpl::Run() #22 0x5abde8b8c576 base::RunLoop::Run() #23 0x5abde86a22e5 ChromeBrowserMainParts::MainMessageLoopRun() #24 0x5abde5eebb04 content::BrowserMainLoop::RunMainMessageLoopParts() #25 0x5abde5eee503 content::BrowserMainRunnerImpl::Run() #26 0x5abde5ee828f content::BrowserMain() Original change's description: > bluetooth: Query for devices every second in TrayBluetoothHelper > > Before TrayBluetoothHelper would get notified of any changes to devices. > This caused problems in busy environments because TrayBluetoothHelper > would get notified hundreds or even thousands of times per second of > devices changes. > > This CL changes to a "pull" pattern where TrayBluetootHelper queries > for devices every second. The devices are then cached so that clients > of TrayBluetoothHelper can access them synchronously. > > TrayBluetoothHelper queries for devices as long as the state is > kPoweredOn. If the state changes, the device list is cleared. > > Bug: 882346 > > TEST=The following actions should be performed: > > 1. Turn bluetooth on and off in system tray. > 2. Open device list in system menu. > 3. Connect to a device. > 4. See that the pod feature button in the system tray indicates a > device is connected when connected to a device. > > Change-Id: Id9028546a627f260527aa737f51c032f74a447ec > Reviewed-on: https://chromium-review.googlesource.com/c/1347638 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611069} TBR=ortuno@chromium.org,tetsui@chromium.org Change-Id: I5b5ca3f227ab7616321047b3a8ade17bfa30b29a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882346 Reviewed-on: https://chromium-review.googlesource.com/c/1352340Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611246}
-
David Bokan authored
If we have a candidate implicit root scroller, we should only promote it if it doesn't have a scrollable ancestor. The reason for this is that we end scroll chaining at the root scroller. This is necessary as the root scroller consumes all scroll in the form of overscroll effects. A (user) scrollable ancestor would be broken in this case, as shown in the example on the attached bug. Note: overflow in an ancestor is still allowed, as long as its overflow style is hidden or visible. Bug: 837007 Change-Id: Ied7a9f02eab76c4ea59fced94d0804ba47ef4e4a Reviewed-on: https://chromium-review.googlesource.com/c/1351590Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611245}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/translate. This CL was uploaded by git cl split. R=toyoshim@chromium.org Bug: 589840 Change-Id: Ia199152845344221db491b895f44ea5a885046f1 Reviewed-on: https://chromium-review.googlesource.com/c/1351080Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611244}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/115df409efa1..bd884bbd8385 git log 115df409efa1..bd884bbd8385 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 yueherngl@google.com octopus: add firmware branch builder Created with: gclient setdep -r src/third_party/chromite@bd884bbd8385 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4ce842c0195caca7a5bba293c2d54fd67526303e Reviewed-on: https://chromium-review.googlesource.com/c/1352240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611243}
-