- 03 Nov, 2020 40 commits
-
-
tby authored
Strings of size 1 don't have their single token picked up by TokenizeWords, which is causing a crash in the LauncherSearchProvider. Bug: 1140380 Change-Id: Ifb2815a1e9da79ffc0b51671d30ca87418e3170e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515425 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823763}
-
Alexander Timin authored
Add flow events to blink::AsyncTask to be able to see the connection between the place requesting task execution and the task execution itself for tasks like requestAnimationFrame. This patch also adds TRACE_EVENT_{BEGIN,END}_WITH_FLOW{0,1,2}, which are needed to implemented trace events for AsyncTask. This patch also adds a helper GetGlobalUniqueFlowId(), which helps to generate a unique flow id for tasks like these. Note that a similar set of events exists in devtools categories, but it uses different of set events, which are displayed in devtools UI, but not in chrome://tracing. R=eseckler@chromium.org,haraken@chromium.org BUG=1142207 Change-Id: Id87bdb574a52752c4735a2a056d3d0a3d23ec342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494877 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#823762}
-
Jeffrey Kardatzke authored
This reverts commit a656f852. Reason for revert: Broke build, media_notification_controller_impl includes media_session_service_mojom.h which was deleted in this CL Original change's description: > Reland "[Media Session] Convert interface from mojo to CPP" > > This is a reland of 530c8fd2 > > The fix is to remove the include for media_session_service.mojom > that has been deleted. > > Original change's description: > > [Media Session] Convert interface from mojo to CPP > > > > Context: https://crrev.com/c/2485850 > > > > This converts the MSS interface to CPP since it does > > not need to be mojo. > > > > BUG=1140215 > > > > Change-Id: I595bef21cddf755bc0fb423f87db9e620227d3e6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503393 > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823358} > > Bug: 1140215 > Change-Id: I23a4043529e236174f44377402a8e1fbc5a23600 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518085 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823718} TBR=avi@chromium.org,xiyuan@chromium.org,dcheng@chromium.org,beccahughes@chromium.org Change-Id: Ia9a84fa6efc4aae2e83d96c6f16ccfa282e5eef9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518781Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#823761}
-
Sophey Dong authored
Bug: 1143957 Change-Id: I60455afdfc375fc6a5d27e9c941acff96e70b6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509002Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823760}
-
Oksana Zhuravlova authored
This change adds code to enable background tracing in WebView under the following conditions: - system tracing is configured - the config specifies system tracing mode. Bug: b/170513316 Change-Id: I5a38255a0098d3d91bbdd33facb23df5c9c8f2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508312 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#823759}
-
Lily Chen authored
SchemefulSite was added in https://crrev.com/c/2458466. This adds an equivalent mojo struct and StructTraits for SchemefulSite. Change-Id: Iec7f4b99df90a00eccdf240dcdf345fb7255d852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514464 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823758}
-
Piotr Bialecki authored
Changes: - mojo - session creation request now distinguishes between required and optional features - devices should report which features are enabled on a returned session Specifically: - ARCore interface now returns an optional initialization result struct or nullopt on failure - GVR & VR on windows report that all requested features are enabled since feature support check happens in the browser, prior to session creation on the device side - VRServiceImpl::SessionRequestData no longer accepts feature collection explicitly - the unordered sets are populated based on contents of the collections passed in XRSessionOptionsPtr - ArCoreDevice methods / callbacks changed to accept optional collection of features instead of a `success` boolean - nullopt is equivalent to failure - Add session configuration helper in ArCoreImpl - it negotiates which features are going to be enabled on a session based on what ARCore SDK reports while taking into account optional features - currently only depth API support is not available across ARCore-capable devices so it can be disabled if it is listed as optional Possible follow-ups: add a typemapping from mojom's `array<XRSessionFeature>` to `std::unordered_set<XRSessionFeature>` or `HashSet<XRSessionFeature>` (for blink), add a class to represent required & optional features (`XRFeatureRequest`?). Bug: 1138551 Change-Id: If966b712f0ae66d28dd4a900cfed2de75538b9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500270Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#823757}
-
Harkiran Bolaria authored
At the moment, the only relevant tasks will be posted to the default task queue in the MainThreadScheduler, as this is where IPCs that might not be associated with specific frames will be handled. Only tracked if all pages are in the BFCache, as this represents a deliberate case where IPCs are known to be posted to frozen documents. Bug: 1110344 Change-Id: I207f96aa67f13d4787840b9f58408d42a674d7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380200 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011030600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/a-mVYHQdDcugi0PwA01OR7_M-_sf2i9Xhvf0bT67HjkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/170162419,b/171158139 Tbr: help-app@grotations.appspotmail.com Change-Id: Ia7fdc848b840ddf0dbd190abbfaf1531644f1c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516915Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823755}
-
Liquan (Max) Gu authored
Changes: * Moved the method broken down in CL[1] into PRService unchanged. * Moved initAndValidate() from CPRService into PRService#initAndValidate() [1] https://chromium-review.googlesource.com/c/chromium/src/+/2514699 Bug: 1144527 Change-Id: Ieab4064ab02ead6c9ff3b6a8c8ac7f867437dd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511880 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823754}
-
Adrienne Walker authored
This was confusing about why the leveldb database was deleted in one place but the blob directory was deleted in another. New databases will always need to clean up their blob directory, so it always must be done there. Additionally, the blob directory (although we could guess it) is a property of an open database, and so is hard to plumb through to this point to delete as well. Change-Id: I33de3a30910b931c2edf7765cf797e02ed8f46eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518198 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#823753}
-
Yue Li authored
Bug: b/149758492 Test: Manual Test Change-Id: I66fe3baa162659f22ae4e756ac364861d60f12b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516390 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823752}
-
Andrey Lushnikov authored
Currently, headless can dismiss beforeunload dialogs, but the target page will still proceed to close since default implementation in content/ disregards BeforeUnload results: https://source.chromium.org/chromium/chromium/src/+/master:content/public/browser/web_contents_delegate.cc;l=64?q=BeforeUnloadFired%20f:content&ss=chromium%2Fchromium%2Fsrc This patch changes this. Change-Id: I2c1a04dde390dbb90ac8c547187405fa513d0723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516217 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#823751}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2e411e2f8478..d529e880053d 2020-11-03 jalyn@microsoft.com Reland "Settings: Add e2e tests for shortcuts tab" 2020-11-03 cpinnamaneni@microsoft.com Adding telemetry for service worker feature c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137050,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I61d42c78a77aa96a97516394e6e9a291b6c4227e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518503Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823750}
-
Josh Nohle authored
In cl/339905938, the Nearby server started returning both reachable and unreachable contacts in the ListContactPeople RPC response. The ContactRecord proto message now has a field denoting the contact's reachability. In this CL, we filter out unreachable contacts, counting the number of removed unreachable contacts. This count is communicated to observers. It may be useful to inform the user in the contacts UI that a certain number of contacts are not being shown because they are not associated with a GAIA account, and that Nearby Share requires this association. This information is already present in the Android Nearby Share UI. Note: This CL should not be submitted until cl/339905938 reaches prod; otherwise, all contacts will be filtered out due to the default-false |is_reachable| field. After cl/339905938 hits prod but before this CL lands, unreachable contacts will not be filtered out. Bug: 1143837 Change-Id: I439469e02e9694e5853c807928dd687eaf7f3f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514176Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#823749}
-
Jan Wilken Dörrie authored
R=chromium-metrics-reviews@google.com Fixed: 1140091 Change-Id: I91396a0be8deb6914e941b77f7aa2d7a32bdef52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490011 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#823748}
-
Andrew Xu authored
This CL provides the correct a11y name for each multipaste menu item. Bug: 1145220 Change-Id: Ibbc41cd36eca6f713154d2c360479661edaf2efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513526 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#823747}
-
Kevin Ellis authored
Divided the rotation tests into two groups: one for common axis, second for interpolated axis + angle (SLERP). By separating in this way, it is easier to match up the tests with the corresponding images. The 0 -> 90 degree tests for common-axis rotations were changed to 30 -> 90 since a zero degree rotation matches any non-zero counterpart. Tests added to both groups to verify the following: * rotation with scaled axis * rotate -> rotateZ * special case of a zero rotation angle * counter-rotation with negative angle * counter-rotation with inverted axis * axis+angle interpolation (SLERP) Bug: 998175, 929841 Change-Id: Iefcfa9bf0d55b6df7f459f51c8b900dd991ab890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513796Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#823746}
-
ckitagawa authored
It is possible capture params don't exist when they were modified here. Make sure that they exist. This is causing a very low volume of crashes on Canary. I think when the directory fails to be created. Change-Id: I8481e19b927f6dd4a8c8b8740aacb6faa1b31744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518031Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#823745}
-
Francois Doray authored
Traces collected through Slow Reports show that acquiring the GpuChannelHost lock from threads running at different priorities can cause priority inversions. In particular, it can cause jank on the renderer main thread through this chain of dependency: > Main thread: cc::ProxyMain::BeginMainFrame > Compositor Thread: TileManager::FlushAndIssueSignals > CompositorTileWorkerBackground (slow): OneCopyRasterBuffer::Playback This CL adds trace events to make contention on the GpuChannelHost lock more obvious in traces, and an assertion to ensure that the GpuChannelHost lock is never acquired at background thread priority. Bug: 1072756 Change-Id: I2a25efe2e3f6e9bf5d980ca351a990f9c7d256b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157659 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:Victor Miura <vmiura@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#823744}
-
Istiaque Ahmed authored
This CL changes PermissionsApiTest.OptionalPermissions and PermissionsApiTest.OptionalPermissionsAutoConfirm tests to use fetch API instead of XHR. This CL also defers removeOrigin() sub-test's permission removal to after the first request/fetch's completion: - This makes the test "theoretically" correct, as the permission should not be removed before the first request/fetch is issued. - This ensures that the test is correct after it uses fetch API. This is probably because fetch is async (compared to XHR). This CL will let SW based version of these tests easy to implement. Bug: None Test: None Change-Id: I139888953f30f0430d558ccce3cd9331af624fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516391Reviewed-by:David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823743}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/52f3a2ddb18e..c5bd41121e18 2020-11-03 bsheedy@chromium.org [typ] ResultSink improvements If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1104252 Tbr: sadrul@google.com Change-Id: Ie14cbbac778cfc2b9e004cf1345d6911b1498696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518079Reviewed-by:
-
ckitagawa authored
This CL restricts the maximum image size to avoid memory expensive copy and encoding operations. It also limits the total amount of image data to be <= the max on disk size. Bug: 1144768 Change-Id: Ic01f68ba6c35cfaa53d499b18052b647917c647b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515179 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
Joe Downing authored
This CL adds the class which consumes the ETW events from Windows. The class is fairly straight-forward but there is one interesting bit as the call to consumer events blocks us from running tasks on that thread. In order to receive events and not block any of the existing threads, we create a new AutoThread which we use to listen for and handle events on. When it is time to clean up, we unblock the listening thread by stopping the trace session. Future CLs will add the logic needed to parse the events and redirect the output to a new location (likely based on registry settings). I've kept that out of this CL to keep its size on the smaller side. Bug: 1144185 Change-Id: Iadfb2f73dc6f713face4117fc269bded85e182dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518087 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#823740}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9db3cefbc07ffd4d9103be0e4341961435d63eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518122Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#823739}
-
Nicholas Hollingum authored
We will be implementing vm shutdown in the UI, the most expedient way is to have a means of telling the context_manager to reset its state. This proves somewhat complicated, so we submit this refactoring initially which does not change anything functional. How this works: - we make the context a unique_ptr so that we can easily reset state by deleting it. This is easier than reinitializing it in place. - I removed several redundant fields of the context_manager_impl which were used to track state. The state of the manager is now implicit in the state of some of its members (particularly, the context and the task queue) rather than explicit in those variables. Bug: b/172006764 Change-Id: I8f897f125beee6dd5eb55c784c310f133094c180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507234 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#823738}
-
Thomas Tellier authored
Bug: 1066489 Change-Id: I5fe83470640a2e17b1ae20e99189e7995724459d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438350 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823737}
-
Lukasz Anforowicz authored
This CL is similar to r820840, but handles fields initialized not in constexpr constructors, but instead in constexpr variables. After this CL, the rewriter will detect fields that are initialized with non-nullptr value in an initializer of a constexpr variable. Such fields will be emitted as candidates for exclusion via --exclude-fields cmdline parameter. Bug: 1069567 Change-Id: I35a901276752b21b4b4826e8447381d5647f7d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514763 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Wei Li authored
Button class has its own focus ring. When a custom focus ring is installed, remove the stock one. Bug: 1107498 Change-Id: I5342e41eba04042c921868a22181fdfb9ff3d9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511470Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#823735}
-
Kenneth Russell authored
Rotation has been moved to go/rotations tool. Bug: 1145319 Change-Id: I9ebf6b383398c218e326c5275130a7c6972b55f3 Tbr: kainino@chromium.org Tbr: jdarpinian@chromium.org Tbr: shrekshao@google.com No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518092Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#823734}
-
Jesse Schettler authored
Add the page number to the progress callback so that clients know which page the progress update corresponds to. Bug: 1059779 Change-Id: I22b445f9a671c2e0b21b4549242a784c3757553a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518205 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#823733}
-
Dave Tapuska authored
WebViewImpl and WebFrameWidgetImpl have typically implemented very similar things. The goal is to remove WebViewFrameWidget and have a single frame widget class move more implementation into the base class. BUG=1097816 Change-Id: Ic534892b9879f66146acd17b87d20d4ef0a3e485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517630Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#823732}
-
Xianzhu Wang authored
In the following case <div style="will-change: transform; width: 300px; height: 300px; background: blue"> <div style="width: 250px; height: 250px; background: green"></div> </div> we'll use green as the background color instead of blue. Though the green background is smaller than the blue background, green affects more area than blue. Bug: 1143099 Change-Id: I5032c0448a827c8ddf9e97d460147227e8a0fed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508292Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823731}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I696e35be95121112cf9ce1e401ca13ff188ca488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518195 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#823730}
-
Bailey Berro authored
Currently uninitialized and would cause a segfault if any clients attempted to observe memory usage. Bug: 1128204 Change-Id: I3bb584aa4d69f142dea93372c3322be27b528bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518116Reviewed-by:
-
Chris Hamilton authored
This hooks up the V8ContextTracker to actual v8::Context / ScriptState lifetimes in renderers by introducing IPC. It also migrates the V8ContextTracker data structures to mojom equivalents. BUG=1080672 Change-Id: I7f88e40c64faf183d2fcc31fc05b8e59c92e21a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487702 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#823728}
-
Dirk Pranke authored
This reverts commit 7ba203c1. Reason for revert: reverting since the src-internal roll hasn't landed yet. Original change's description: > Roll GN from e002e68a..f5f465b5 > > Generated by //tools/gn/roll_gn.py > > https://gn.googlesource.com/gn/+log/e002e68a..f5f465b5 > > f5f465b5 Fix runtime_deps for elided targets > 3d165b90 Correct the `gn format --dump-tree=json ...` command to write to stdout instead of stderr. > ad0a7ada Remove support for set_sources_assignment_filter function > e1ac69b1 Add a command line to define/overwrite "root" in ".gn" > 7b2a04d5 VS: Use most recently installed Windows 10 SDK. > 132588e1 Revert "gn recipe: Link GN with rpmalloc to speed it up." > 3281c669 Add "framework_dirs" and "frameworks" to syntax highlighting rules > 4323e701 gn recipe: Link GN with rpmalloc to speed it up. > c808630c Move runtime_deps file for phony targets to /obj > 8855c522 Update Clang and Xcode SDK to 12B5025f > 76f9b6ad Use fetch instead of cherry-pick for Gerrit changes > a3d69e87 Don't return if package is up-to-date > 36ff17cb Switch back to the older Clang version > 7bcc0eb3 Revert "Update Xcode SDK to 12B5025f" > e5f1f587 Update Xcode SDK to 12B5025f > 6453c5de Support cross-compiling GN for other targets > 42d6de6e Don't classify Rust static libraries as final > a9eaeb80 Switch remaining stamp targets to phony targets > ff45cf2a Show config.visibility in `gn desc` > de5a8348 [rust project] removing obsolete std libraries > 4c684398 Fix "gn outputs" for bundle data. > 99f72f88 Switch source_set stamp targets to phony targets > 5233fa13 Remove extra * in gn output docs > > As of 99f72f88 and a9eaeb80, GN's usage of stamp files for intermediate > steps in the build graph have been replaced with phony aliases. As a > result, this CL also updates the MB tool to look for ".runtime_deps" > files instead of ".stamp.runtime_deps". > > This is a reland of 7f3e4855 > > Change-Id: I5bf18f1529b0969b8c79d768e9b3f377b8dee8cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514460 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#823725} TBR=dpranke@google.com,rjascani@google.com Change-Id: Iebf4e78bd9e7550de3b025a997d4f792c3f80b1b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518755Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#823727}
-
Robert Kroeger authored
This reverts commit 4ff93eee. Reason for revert: broke linux/ozone/wayland on non-exo compositors. Original change's description: > [ozone/wayland] Use linux_explicit_synchronization_protocol for in-fence > > If linux_explicit_synchronization_protocol is implemented by wayland > server, submit access fence together with buffers. Otherwise, wait for > fences in gpu process. It is preferred to defer waiting for buffer > content ready in Wayland server, because waiting for access fences in > client can be time-consuming. > > The access fence for primary plane should be inserted by the buffer queue. > > This is 7/? CL for overlay forwarding using wl_subsurface. > > Change-Id: I8a031c1941591c48eac8a51d12af195c345002e2 > Bug: 1063865 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365994 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Maksim Sisov (GMT+2) <msisov@igalia.com> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822813} TBR=rjkroege@chromium.org,tsepez@chromium.org,msisov@igalia.com,fangzhoug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1063865 Change-Id: Id3fffcf4e06f2757cb7352177f0acca280c2ee7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517626Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#823726}
-
RJ Ascani authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/e002e68a..f5f465b5 f5f465b5 Fix runtime_deps for elided targets 3d165b90 Correct the `gn format --dump-tree=json ...` command to write to stdout instead of stderr. ad0a7ada Remove support for set_sources_assignment_filter function e1ac69b1 Add a command line to define/overwrite "root" in ".gn" 7b2a04d5 VS: Use most recently installed Windows 10 SDK. 132588e1 Revert "gn recipe: Link GN with rpmalloc to speed it up." 3281c669 Add "framework_dirs" and "frameworks" to syntax highlighting rules 4323e701 gn recipe: Link GN with rpmalloc to speed it up. c808630c Move runtime_deps file for phony targets to /obj 8855c522 Update Clang and Xcode SDK to 12B5025f 76f9b6ad Use fetch instead of cherry-pick for Gerrit changes a3d69e87 Don't return if package is up-to-date 36ff17cb Switch back to the older Clang version 7bcc0eb3 Revert "Update Xcode SDK to 12B5025f" e5f1f587 Update Xcode SDK to 12B5025f 6453c5de Support cross-compiling GN for other targets 42d6de6e Don't classify Rust static libraries as final a9eaeb80 Switch remaining stamp targets to phony targets ff45cf2a Show config.visibility in `gn desc` de5a8348 [rust project] removing obsolete std libraries 4c684398 Fix "gn outputs" for bundle data. 99f72f88 Switch source_set stamp targets to phony targets 5233fa13 Remove extra * in gn output docs As of 99f72f88 and a9eaeb80, GN's usage of stamp files for intermediate steps in the build graph have been replaced with phony aliases. As a result, this CL also updates the MB tool to look for ".runtime_deps" files instead of ".stamp.runtime_deps". This is a reland of 7f3e4855 Change-Id: I5bf18f1529b0969b8c79d768e9b3f377b8dee8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514460Reviewed-by:
-
Mikel Astiz authored
This implementation is consistent with the documentation in histograms.xml. Change-Id: Ib85a290def5f09ef07f4a0740d4cc6f3ab9a7224 Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517943 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#823724}
-
