- 24 Jan, 2019 40 commits
-
-
A Olsen authored
Particularly migrating away from calls to ReplaceDeviceSettingsProviderWithStub. They are not ideal for the following reasons: 1. They are not straightforward calls to make - they need to be made after initialization and should be matched with RestoreRealDeviceSettingsProvider. Because of this, the stub cannot be used until initialization is finished. So putting test data in the stub has to be done carefully: not too early, before initialization is finished, and not too late, after it is already read. 2. Both a real and a stub DeviceSettingsProvider are initialized, even though the real one is not be needed for the test. The real one depends on the local state, which may also not be needed for the test. Test helpers that depend on local state makes separating code into packages more difficult, since in test packages inside chrome/browser, the local state used should be the browser local state, but in packages outside the browser, there should be no dependencies on chrome/browser. For more details, see the bug Bug: 909635 Change-Id: Ia6c8c0f2f9b22f82aceed565158f050c9a6e4b9e Reviewed-on: https://chromium-review.googlesource.com/c/1400684 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625668}
-
Ian Clelland authored
This adds a method to return the names of all policy-controlled features supported by the browser. Because this list is determined by the set of features implemented by Chrome, rather than conformance to any particular spec, the tests are in /webexposed/ rather than WPT. (Existing IDL tests in WPT cover the existence of the new method and the data types that it returns, without depending on the exact values returned.) Bug: 917070 Change-Id: I35ccbdce794e236500d15afe5419057a8f162ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1387151 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#625667}
-
Daniel Vogelheim authored
This also removes TrustedDOMTypes from workers since we had difficulty bringing it into the origin trial. They will be re-added later. Bug: 739170 Change-Id: Iec6206f1c3c8121f30d7fbdb13054e4e30255fd2 Reviewed-on: https://chromium-review.googlesource.com/c/1411775 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#625666}
-
Vladislav Kuzkokov authored
Bug: 660612 Change-Id: Ieea560a5fbd4118c69e31e24f37e2f80593ac842 Reviewed-on: https://chromium-review.googlesource.com/c/1417593Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#625665}
-
Dominic Farolino authored
This CL adds support for Priority Hints on the <script> element, gated by the Priority Hints Origin Trial. It also adds the necessary tests. The "importance" is only set for classic scripts and top-level module scripts, as the effect of importance on a script's imports, if any, has not been decided yet. Furthermore, ResourceFetcher currently makes it difficult to down-prioritize a ResourceRequest whose priority is already set. https://crbug.com/882344 describes this problem. Since module scripts already have their priority set to kHigh before reaching ResourceFetcher, they are currently exempt from the effects of importance="low". It is also true that importance="high" will not raise the priority of module scripts any higher than their default, so after this CL, only top-level classic scripts are affected by Priority Hints. This should enable us to collect better data during the Origin Trial, as people are interested in <script async importance="high">. R=kinuko@chromium.org, kouhei@chromium.org, yoavweiss@chromium.org Bug: 821464 Change-Id: If3665bddcbd10842071cd91627f18bfb67ba1e98 Reviewed-on: https://chromium-review.googlesource.com/c/1433393Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#625664}
-
Alan Cutter authored
This CL adds a missing null check for GetBrowser in RenderViewContextMenu when opening the emoji panel. If no browser is found default to opening the emoji panel in the current process instead of crashing. Bug: 924439 Change-Id: Idabcc6e4da022d1fbfee9e76260479b87953d2a9 Reviewed-on: https://chromium-review.googlesource.com/c/1433375 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625663}
-
Peter Beverloo authored
Bug: 860467 Change-Id: I2f46596d842a2720aeac5ba41d5b5ccea9f2b4a6 Reviewed-on: https://chromium-review.googlesource.com/c/1429967 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#625662}
-
Ian Kilpatrick authored
We were performing an unnecessary layout of a relative positioned element, and as a result creating a new ng_paint_fragment which caused the additional invalidation. This checks if we can safely re-use the layout result, and clears layout if needed. Bug: 635619 Change-Id: I3b5f9056cd8b3447c36b6bbc20f55108b937a3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1427452Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#625661}
-
Elly Fong-Jones authored
This change: 1) Introduces ui::CaptionStyle, which represents a text caption style; 2) Introduces ui::NativeTheme::GetSystemCaptionStyle, which retrieves the system's configured text caption style; 3) Adds a command-line flag '--force-caption-style' which overrides the system-supplied caption style (also useful for testing); 4) Wires up WebPreferences members and IPC struct members to pass caption style information into renderers. The overall flow of information is: 1) ui::NativeTheme produces a ui::CaptionStyle from the system settings and/or a command-line override flag; 2) ChromeContentRendererClient fills WebPreferences' newly-added text style members in from the NativeTheme-provided CaptionStyle; 4) WebPreferences are sent over IPC to renderers; 5) RenderView uses the WebPreferences text style members to configure a blink Settings object; 6) The Blink WebVTT code converts the blink Settings text style members into CSS rules applied to the WebVTT caption container HTML elements. Next steps: * Add Mac and Windows implementations of ui::NativeTheme::GetSystemCaptionStyle() which fetch the system settings * Add more caption style options based on which system options are already implemented at the OS level on desktop platforms * Support the macOS "default" / "mandatory" tri-state caption settings * Figure out how to add test coverage for WebVTT captions Important testing notes: WebVTT caption files are ignored on file:// origins - make sure that a video that you are testing with and its caption file are both served from web origins. Also, beware that chromium builds lack many common video codecs - the best format to test with is a .ogv video. The Blender foundation published the trailer for their open-source movie "Sintel" here <https://download.blender.org/durian/trailer/>, which is a decent test data file. Bug: 897730 Change-Id: Id909e650a3c284b47f787635481d75157651f469 Reviewed-on: https://chromium-review.googlesource.com/c/1418399Reviewed-by:
-
Oskar Sundbom authored
It seems broken on ChromeOS. Bug: 924976 Tbr: aleventhal@chromium.org Change-Id: I9f4c0e44f234fe118193563885ff36994f36f75d Reviewed-on: https://chromium-review.googlesource.com/c/1433767Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625659}
-
Tim Dresser authored
Bug: None Change-Id: I6631573a82e0c75cb84bf4683a9e871d7888e300 Reviewed-on: https://chromium-review.googlesource.com/c/1431532Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#625658}
-
Anna Malova authored
Bug: 924118 Change-Id: Ib57cc3eda841c0b24352d972b9341ae4b03a5998 Reviewed-on: https://chromium-review.googlesource.com/c/1432845Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#625657}
-
Fabio Tirelo authored
Also removes code that will no longer be executed. Bug: 923960 Change-Id: I1fdc63c8e9737501bb793c221bce7ea134d3bc93 Reviewed-on: https://chromium-review.googlesource.com/c/1426165Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#625656}
-
Andrew Grieve authored
More appropriate than Test>Android I think. Change-Id: Ic6bcf691b60ac20b77cfa4d27474bfdf74605339 Reviewed-on: https://chromium-review.googlesource.com/c/1434094Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#625655}
-
Maksim Sisov authored
ClipboardOzone needs to depend on ui/ozone in order to call OzonePlatform::GetPlatformClipboard, but as long as all the base::clipboard classes are part of ui/base source set, and ui/ozone depends on ui/base, it's impossible to depend on ui/ozone. And that creates a circular dependency. Thus, factor out clipboard source files and make appropriate source sets, which will be used by clients on their needs instead of depending on everything. Bug: 922465 Change-Id: I97cd4013be096a1dd1af8e1da4678aa83f93ca42 Reviewed-on: https://chromium-review.googlesource.com/c/1369933Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#625654}
-
Rohit Rao authored
This will enable us to move TabModel creation directly into Browser in a future CL. BUG=783777 Change-Id: Id42f9f825e1179d7b932b376454ed0c9335179bd Reviewed-on: https://chromium-review.googlesource.com/c/1431212Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625653}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d2052fde8d4..c683e1e6a3aa Created with: gclient setdep -r src-internal@c683e1e6a3aa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7bec44aed87a466ef6b04730f9be06b0a6b17519 Reviewed-on: https://chromium-review.googlesource.com/c/1433915Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625652}
-
Findit authored
This reverts commit e4f65702. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625626 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZTRmNjU3MDI1OGFlZTI3Nzc3YTk5ZTliNmUyOGJmNDc2YjI4NTBlMgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/75269 Sample Failed Step: webkit_layout_tests Sample Flaky Test: http/tests/html/validation-bubble-oopif-clip.html Original change's description: > [Validation bubble][OOPIF] Do not show cut-off validation bubble on OOPIF > > If a validation bubble is shown on an element in a remote frame, we > adjusted its position with the main frame viewport, and rendered the > bubble at a position at which the remote frame can't render. > > In a remote frame, we should refer to 'remote viewport intersection', > which is a visible rectangle of a remote frame. > > Bug: 910979 > Change-Id: I1497f6980c6e5d3758689b4b7fd8ac89113f8540 > Reviewed-on: https://chromium-review.googlesource.com/c/1433638 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625626} Change-Id: I2e5349472982a087a0c498cc1032457262469991 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910979 Reviewed-on: https://chromium-review.googlesource.com/c/1434214 Cr-Commit-Position: refs/heads/master@{#625651}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3432970f. With Chromium commits locally applied on WPT: bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard" f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 05cdb4d1 "Add tentative WPT tests for stale while revalidate handling." 875e732f "Revert "Add tentative WPT tests for stale while revalidate handling."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jrummell@chromium.org: external/wpt/encrypted-media NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Icd948d64a54d4f484b18ff7dc77b2bbf2efbfb84 Reviewed-on: https://chromium-review.googlesource.com/c/1433855Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625650}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e402437aad51..970cd8e6beba git log e402437aad51..970cd8e6beba --date=short --no-merges --format='%ad %ae %s' 2019-01-24 treehugger-gerrit@google.com Merge "UI: make shadow disappear" Created with: gclient setdep -r src/third_party/perfetto@970cd8e6beba The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7e8f5f313035d9e45f5c30bfc29d9e4176f72229 Reviewed-on: https://chromium-review.googlesource.com/c/1433836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625649}
-
Lei Zhang authored
Switch to std::make_unique or base::MakeRefCounted. Fix some nits and lint errors as well. Change-Id: I2a75aa2c626ad3ea6523159edf4b981336771c8f Reviewed-on: https://chromium-review.googlesource.com/c/1433595 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#625648}
-
Mario Sanchez Prada authored
Use IdentityManager's API instead and only use the AccountTrackerService instance to construct instances of classes still depending on it. Bug: 922777 Change-Id: Ib21cb594a208b7ee5f15f3777f61dda570a11113 Reviewed-on: https://chromium-review.googlesource.com/c/1433617Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#625647}
-
Kush Sinha authored
|AccountManagerMigrator| migrates accounts to the new Chrome OS Account Manager. During this migration it asserts that the Primary (Device) Account is a valid (Google or Active Directory) account. This assertion is not triggered for ephemeral sessions (Guest / Incognito etc.). Unfortunately a lot of browser tests on Chrome OS run with an invalid (AccountType::UNKNOWN) account type. Fix this by removing the assertion. Bug: 915628 Change-Id: Ie6e73e7128ec57ac9b5239b534d185c4758a17e7 Reviewed-on: https://chromium-review.googlesource.com/c/1433623Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#625646}
-
Bence Béky authored
Make WebSocketStreamRequestImpl keep a WeakPtr of WebSocketHandshakeStreamBase subclasses instead of a raw pointer to avoid use-after-free. While weak pointers are generally avoided in //net, this is so much cleaner and less error-prone than making WebSocketStreamRequestImpl and WebSocket{Basic,Http2}HandshakeStream notify each other of destruction, see https://crrev.com/c/1391298. Make WebSocketHandshakeStreamBase::GetWeakPtr() pure virtual and implement it in subclasses to avoid valid weak pointers pointing to partially destroyed instances. Bug: 850183 Change-Id: Ib1995b076e0fb57bd8a7fbec392fa3283b52120c Reviewed-on: https://chromium-review.googlesource.com/c/1431132Reviewed-by:Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#625645}
-
Matt Falkenhagen authored
Follow-up to r625066 to address post-commit review comments at https://chromium-review.googlesource.com/c/chromium/src/+/1420508 Bug: 901082 Change-Id: Id222087320ade9a10f4ffc67d4769e2610b8df75 Reviewed-on: https://chromium-review.googlesource.com/c/1433896Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#625644}
-
chrome://invalidationsTanja Gornak authored
Before this patch, the debug information available on chrome://invalidations didn't contain the instance_id token. Displaying the token there helps to debug several issues with subscription requests which are currently observed in dev/canary experiment. Bug: 801985 Change-Id: I1ade4bc28ee117ce77dc0167b9219a6aed14817b Reviewed-on: https://chromium-review.googlesource.com/c/1412024Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#625643}
-
Finnur Thorarinsson authored
When the property list doesn't include one of 'email', or 'tel', we should not show that data in the dialog. Also made sure to remove blank entries. NOTRY=true TBR: twellington Bug: 860467 Change-Id: Idb488f61168e4036d7acb0f1f144d10caf70510a Reviewed-on: https://chromium-review.googlesource.com/c/1433759 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625642}
-
Anna Malova authored
Bug: 924118 Change-Id: I19611361435e142e06440faa1a241c1a45dd76e5 Reviewed-on: https://chromium-review.googlesource.com/c/1433244Reviewed-by:
-
Rayan Kanso authored
Remove check in renderer and add WP test for uploads. Bug: 871174 Change-Id: Id225cc05b6f3c065962e1481c98562ca96d87322 Reviewed-on: https://chromium-review.googlesource.com/c/1424821 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@google.com> Reviewed-by:
-
Tim Volodine authored
Ensure that headers and status line can be modified by the loader's delegate. Ensure that "Client-Via: shouldInterceptRequest" header is always present. BUG=922074,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I54f5cd4035bb3b56fd1364f0778c15f9eda2df3b Reviewed-on: https://chromium-review.googlesource.com/c/1425721Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#625639}
-
Jan Krcal authored
This CL fixes an omission in the Wallet data bridge so that it actually reports DB errors that happen when writing sync metadata to the web data DB. This is an improvement on its own but it may also help to understand recent traffic issues. The CL omits failures from data DB writes as the current AutofillTable API does not support reporting them. Bug: 924447 Change-Id: I2136aafa5f452b23268afb2ac52c16f63769b3ad Reviewed-on: https://chromium-review.googlesource.com/c/1429641 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#625638}
-
Vadym Doroshenko authored
In CL https://chromium-review.googlesource.com/c/chromium/src/+/1384258 the generation in the new architecture was implemented. 2 things were missing: 1.Marking generation element for rater extension was missing in this implementation. This CL fixes that. 2. Setting aria-aucomplete attribute (it looks that it's important for screen readers). This CL fixes both of them. Bug: 866444 Change-Id: I49b459d390ee36540ed1b9b2d118930e99f86e6d Reviewed-on: https://chromium-review.googlesource.com/c/1432855Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#625637}
-
Oskar Sundbom authored
Bug: 924954 Tbr: ekaramad@chromium.org Change-Id: I6e85f34064d2f251dd38731cb37d7c512014d9c2 Reviewed-on: https://chromium-review.googlesource.com/c/1433619Reviewed-by:
-
Daniel Bratell authored
Attempts to use ui/gfx code in content failed because of variable/enum shadowing. The main problem is fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1424799 This fixes the remaining problems and enables the shadowing warning to prevent future problems of the same kind. All the problems are of the trivial kind, with inner blocks reusing either the name of a variable or the name of an argument, be it |cluster|, |font|, |i|, |path|, |alpha| or |line|. In one case the fix was to delete an unused local variable. Bug: 923078,794619 Change-Id: Iae8bb768c49332cbe610860e06fea9d7aebc7a4b Reviewed-on: https://chromium-review.googlesource.com/c/1421104 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#625635}
-
jonross authored
We would like to get coverage of browser_tests and content_browser tests when using --enable-features=VizDisplayCompositor,UseSkiaRenderer This adds those configurations to the FYI bot Linux Viz Test=skia_renderer_browser_tests, skia_renderer_content_browsertests Bug: 914491 Change-Id: I523fbace668477686e4279a3d2df4a7254caccee Reviewed-on: https://chromium-review.googlesource.com/c/1432094Reviewed-by:
-
Rayan Kanso authored
Update the upload data pipeline by adding a specific DatabaseTask. The previous methodology asssumed unique urls. Bug: 871174 Change-Id: Ib078ca84fb29e2de61422371fee859e74be31ab8 Reviewed-on: https://chromium-review.googlesource.com/c/1422017 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Armando Miraglia authored
Two constraints have been missing for a long time in applyConstraints in that the constraint per-se was never applied. This was caused by a check in media_stream_track.cc that would verify whether the set of constraints was empty. The constraints are also overlapping with goog* constraints, hence we needed renaming of the properties, so that the signaling to the information to the application level is correct. This change now adds testing for OverconstrainedError for these constraints, as well as fixing the check. BUG=923828 Change-Id: I26a72d8aef4f749f7309092787f7929de2239978 Reviewed-on: https://chromium-review.googlesource.com/c/1426679Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#625632}
-
Rayan Kanso authored
Migrate cache entries using the old format to the new one on startup. This allows for caches to store duplicate requests. Bug: 871174 Change-Id: Ie4f4fef0bd2e928680b8a9f5ff34dfd3a744db43 Reviewed-on: https://chromium-review.googlesource.com/c/1417870 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Sam Maier authored
Since we are calling .get() right away anyways, it's better to just do this inline. Also, it appears that at least in some of the ways to arrive at this code, we are already running on a background thread. Bug: 878529 Change-Id: Ic9612edf5e24f09ecd22c68d16513c122d0579a6 Reviewed-on: https://chromium-review.googlesource.com/c/1427577 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#625630}
-
Thomas Tangl authored
- The 'Drive search suggestions' toggle is moved to the settings-personalization-options element. This means it is under the 'Other Google services' section. - A test setup for non-offical builds is added to the settings_personalization_options tests. - The frequently failing test 'displaying toggles depending on unified consent' is removed from the official tests. Reason: This test is not part of the CQ tests and oftentimes forgotten. Since there is no big value in keeping this test, it is removed. Bug: 916191 Change-Id: I1ab1c876f1cedcaf22c167c3a2d0b238223e42b5 Reviewed-on: https://chromium-review.googlesource.com/c/1425607 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625629}
-
