- 25 Feb, 2020 40 commits
-
-
Robert Liao authored
BUG=1034666 Change-Id: I18336ab0f3d36adbe2b47f0784baed6e4ac9f2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072577 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744316}
-
Ana Salazar authored
We assumed that TransitionEnded() would happen almost every time we interact with the page switcher, but some edge cases don't animate a transition, particularly after a scroll. For this edge cases, we delete the mask layer when ScrollEnded(). We also check if the mask layer still exists when TransitionEnded() to reset it if needed (i.e. when no scroll is involved in page switching) Bug: 1049275 Change-Id: I8bdebd6a0b0776f202ac5ee6af8990f41bb22ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070795Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#744315}
-
Sahel Sharify authored
This cl changes the remaining payments PlatformBrowserTests to use utility functions from the newly added PaymentRequestPlatformBrowserTestBase rather than redefininig them for each test class. Bug: 1052169 Change-Id: I1e621d8ef00e34e55419b51890b79cfe7d83f8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063666Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744314}
-
rajendrant authored
Bug: 1055573 Change-Id: I435be1e417a25ef922d81a53571c75cbff7679f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071777Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#744313}
-
Jose Lopes authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I25bbcdd96b395a9e5b2fe90c5b509f383845327d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070237 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744312}
-
Julian Pastarmov authored
The policy is now ready for prime time. BUG=1034641 Change-Id: I302b6ca48c0745f0c356205c7591b41706e35b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071267 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744311}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 90dcda95. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mek@chromium.org: external/wpt/webmessaging NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I9f423ae2ae23b6db05d2cd27fd3ac20b9807c5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070870Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744310}
-
Bettina authored
Previously, the code assumes that if there's no primary account, that the profile is still signed in. This may not be the case. Bug: 946605 Change-Id: I4b19d0c2c57f8a8b7107075522b979163401f415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071578Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#744309}
-
Fredrik Söderquist authored
In all callsites but one the default value of "true" is passed. In that single remaining instance, the argument will also never be false, so just drop the argument entirely and hardcode the "true" behavior. Bug: 1028063 Change-Id: I827e63eeaa3f0f66ab74cb024b2a8186beedd6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072160 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#744308}
-
Kurt Horimoto authored
This test is obsolete and is covering functionality that is no longer handled by OverlayContainerCoordinator. This has since been moved to OverlayPresentationContextFullscreenDisabler, which has its own unittest. A test for OverlayContainerCoordinator's actual functionality is added in a follow up CL (crrev.com/c/2038252). Bug: none Change-Id: I9de42b765837c2679249771f6b9b7ebd205f4cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070691 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#744307}
-
Xi Han authored
When a field trial parameter doesn't exist in ChromeFeatureList, querying ChromeFeatureList#getFieldTrialParamByFeature() will return an empty string. This CL changes to cache the default value of this field trial parameter when the parameter doesn't exist. Bug: 1041865 Change-Id: I2d13a4c349e554d903e004e805dd8ce9d2f691f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072119Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744306}
-
Alex Ilin authored
Chrome profiles must always be located inside the user data directory. Using "profile-directory" command line flag, the user can violate this requirement. Initialization of a profile outside of the user data directory would eventually fail. But it would happen after a profile object and all files inside of the profile are created. This CL adds a check to profile creation functions that will return nullptr if a profile directory is disallowed. A profile directory is allowed if its direct parent is the user data directory. This CL also extends the expiration date of Profile.InitProfileUserPrefs.OutsideUserDir and Profile.GetProfileInfoPath.OutsideUserDir histograms to verify that they are no longer recorded after this fix. Bug: 981374, 1053107 Change-Id: I2201874c18963c3210c77c56a077f2a2a790954f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066840Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744305}
-
Andrew Grieve authored
Noticed this during code inspection. Not fixing a known bug. Change-Id: Ic4ad70dc478e8162818b69d8d71e5b635b6d0c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068933 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<BitmapImage> and DynamicTo<BitmapImage> as new downcast helper 2. Use IsA<BitmapImage>(element) in place of IsBitmapImage(element) Bug: 891908 Change-Id: I1534b601cfae0f99adb15355f7f1042d1c889552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019644Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#744303}
-
Ben Joyce authored
These changes were generated by android-studios migrate androidx refactor tool. Bug: 1052460 Change-Id: Ic631e5d4ad1f4d4ce50d4f5d741d91f4850fd552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067196 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744302}
-
Morten Stenshorne authored
Change-Id: Ibe62dcbc3f17bf175186a5e67925da2c2cf8d145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072180Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744301}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec2fa5bb56bb..8f89b6c850ab Created with: gclient setdep -r src-internal@8f89b6c850ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094 Tbr: jbudorick@google.com Change-Id: I685d361d6ef32743a79e6378604fdc833db3f4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072438Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744300}
-
Lan Wei authored
This reverts commit 3d6903ce. Reason for revert: <INSERT REASONING HERE> KioskTest.LaunchAppUserCancel is still flaky on Builder linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg Original change's description: > [Kiosk] Reenable previously flaky KioskTest.LaunchAppUserCancel > > The test was flaky in the race condition when we were trying to perform > a user exit, while creating a new user. > It is fixed here https://crrev.com/c/2066717. > > Bug: 964333 > Change-Id: I124c48c1c7d55b69ae9c998a34ffed796207134c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070410 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744250} TBR=rsorokin@chromium.org,apotapchuk@chromium.org Change-Id: I091490b85c4da75908837900682ce6dd12ee2c7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 964333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072133Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#744299}
-
Yann Dago authored
Use the IPolicyStatus COM interface to fetch the Google Update policies and show then on chrome://policy Visual: http://screen/GipT81x0igj Bug: 1033573 Change-Id: Ib41c17b977fc6bfef40f2d8fb78333786ad167ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032796Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#744298}
-
Igor Bukanov authored
As WebContentsViewAura::EndDrag can be arbitrary delayed waiting for the renderer process to perform asynchronous targetting, it should use a weak pointer for the RenderWidgetHostImpl argument. Bug: 1034519 Change-Id: Ib8c785d3c54b448dc4b020b11112b65ced3d4261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978000Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744297}
-
Joshua Pawlicki authored
Key 10 is available as of 2020-02-10. Bug: None Change-Id: I7c2c093ac0b871ac02d8bfe793b22f72db81f4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049910 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#744296}
-
Nico Weber authored
Nothing sets `is_official_build && !is_clang` anymore. Once we do use LTO with clang on Win, we'll likely use the existing use_thinlto codepath instead of these configs. Bug: 598772,1053958 Change-Id: I58992b86ab395e7cd5119847139aedc446f95b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072417 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#744295}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aec8893e..57083a22 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9323f07395fe62f891190ea38b6811f4693cd426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071958Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744294}
-
Elly Fong-Jones authored
The active tab now gets a check mark, by analogy with the active window in the Window menu. Bug: 990838 Change-Id: I2589913a271eaffe0b03ff200d06cc14d7a958b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071045 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#744293}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c8d092a060ad..9f00494951f9 git log c8d092a060ad..9f00494951f9 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 bsalomon@google.com Add test that SWPathRenderer GenIDChange listeners get removed. Created with: gclient setdep -r src/third_party/skia@9f00494951f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I4ce96dcd2d3a35fb0db16867d607260d7e2fe126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072315Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744292}
-
Nico Weber authored
It only has an effect when not using clang and lld, and the default build setup is to use clang and lld. Also, goma has dropped support for non-clang compiles, and a main use case for is_win_fastlink was being able to use goma. Finally, is_win_fastlink never worked well. Bug: 1053958 Change-Id: Ida8079da90157e3f02acf6b056fea3bef667f5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071243 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aa09ca69e417..b185002d559b git log aa09ca69e417..b185002d559b --date=short --first-parent --format='%ad %ae %s' 2020-02-25 xinyi.he@arm.com Fix the condition of glOrtho{fx} validation 2020-02-25 pmberube@google.com Fix a GCC 10 build failure. 2020-02-25 b.schade@samsung.com Vulkan: prevent volk reloading on null instance and devices 2020-02-25 jmadill@chromium.org Trace/Replay: Add uniform locations map. Created with: gclient setdep -r src/third_party/angle@b185002d559b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I5bce1edb5cc56c063956de25d20a9670d2e2d60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072313Reviewed-by:
-
Michael Thiessen authored
This is just cleanup/readability. No functional changes intended here. Bug: 783819 Change-Id: I8f0d3a2f812398c3c2cd070aa8b8cc8f9716244d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070841 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#744289}
-
Renato Silva authored
- Replace the dialog on the reset screen with the oobe-help-dialog that complies with UX specs and reuses available code. - Refactor the confirmation dialog logic so that it lives in the main element 'oobe-reset'. - Remove the intermediate oobe_reset_screen by using LoginScreenBehavior - Add a waiter to test::OobeJS for waiting upon the presence of an attribute. Such as waiting on the 'open' attribute of dialogs. - Add constants and modifications to the browser tests of the reset screen. Fixed: 933310 Change-Id: I54001745326b60ab5a0a19519923c54dffa5baec Bug: 933310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041474 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#744288}
-
Istiaque Ahmed authored
This allows ContentVerifier::ShouldVerifyAnyPaths to compare relative paths against indexed ruleset's relative path in future. This will obviate the need to construct full path (which can be tricky some times). Note that this will be done in a follow up. Bug: 796395 Test: No behavior changes expected. Change-Id: I05febe27eb52c2c823e6e609f1be6d9803b471bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071335Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#744287}
-
Mikel Astiz authored
A bookmark's GUID must be unique and otherwise BookmarkModel's invariant can be considered violated. In this patch, the invariant is enforced via DCHECKs upon node creation, which is sufficient because GUIDs are inmutable. Change-Id: Ia3f48e98027ae9a8468bd0dc578843047af79712 Bug: 978430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031024 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744286}
-
Omar Morsi authored
SECItem is used a lot for performing NSS operations and it was documented that to free a SECItem structure, SECItem_FreeItem should be used. SECItem was usedin platform keys for NSS operation without SECItem_FreeItem. For more information, please refer to: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/SSL_functions/ssltyp.html#1030620 This CL utilizes crypto::ScopedSECItem instead of SECItem. Memory Leaks: CheckSystemTokenAvailability/EnterprisePlatformKeysTest.Basic/0 Before this change: 10 After this change: 6 CheckSystemTokenAvailability/EnterprisePlatformKeysTest.Basic/1 Before this change: 8 After this change: 6 CheckSystemTokenAvailability/EnterprisePlatformKeysTest.Basic/2 Before this change: 8 After this hange: 6 CheckSystemTokenAvailability/EnterprisePlatformKeysTest.Basic/3 Before this change: 5 After this change: 3 Bug: chromium:1054911 Test: Manual and browser_tests --gtest_filter=*EnterprisePlatformKeysTest* Change-Id: Ife95c0f84185d0bde9e9c564ba04c30da8aecab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071017Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#744285}
-
Xiyuan Xia authored
Smoothness is not calculated correctly when underlying Layer is attached to a Compositor after the animation starts. One such case is the "Show" animation of WindowCycleView. It is always report as 100% incorrectly. Smoothness metric depends on frame number from Compositor. |start_frame_number_| is captured when the animation starts. However, if Layer is not attached, the frame number could be be obtained and stays as 0. As a result, smoothness is always reported as 100% when the animation finishes. Bug: 1053732 Change-Id: I60c750afaf5b4820ad17aebfa9809178399c50f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067674 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744284}
-
Elly Fong-Jones authored
TakeNamedLock has a "waiting" mode that works like this: for (int i = 0; i < 10; i++) if (TryLock()) break; usleep(i * 100); which means that in "waiting" mode, if the lock is unavailable for the duration, this function will block the calling thread (with the message loop not spinning) for up to 4.5 seconds. However, there are two problems with this design: * The caller has no way to know whether "waiting" is appropriate or not * The caller has to handle failure to acquire the lock either way If retries are needed to deal with external conditions changing that might have freed the lock up (another process exiting, e.g.) those retries should be done at higher levels with more context. More concretely, the only actual production use of this function is in CloudPrintServiceProcessMain: std::unique_ptr<ServiceProcessState> state(new ServiceProcessState); if (!state->Initialize()) return 0; This change has TakeNamedLock make a single non-blocking attempt to take the lock, and moves the retry logic up into CloudPrintServiceProcessMain. Since I was here anyway, I converted the API to use unique_ptr, since it returns ownership of the lock if it succeeds. Bug: 1052430 Change-Id: Ib87b23cc821fe59e69b76ffb3875917027bfdc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057530Reviewed-by: -
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e162b023f539..b1dd9acac569 git log e162b023f539..b1dd9acac569 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 swiftshader.regress@gmail.com Regres: Update test lists @ e162b023 Created with: gclient setdep -r src/third_party/swiftshader@b1dd9acac569 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If55689095438d18f0410582f6ac66d56ca84d5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072308Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/038955dfc94d..5c63cc2bc39b git log 038955dfc94d..5c63cc2bc39b --date=short --first-parent --format='%ad %ae %s' 2020-02-25 treehugger-gerrit@google.com Merge "client api: Fix a comment in TracingSession." 2020-02-25 ddrone@google.com Merge "Add support for repeated fields" 2020-02-25 fmayer@google.com Merge "Check if app is still running after test." 2020-02-25 hjd@google.com Merge "ui: Fix open trace via File with extensions" 2020-02-25 hjd@google.com Merge "Clean-up packet_writer_unittests.cc" Created with: gclient setdep -r src/third_party/perfetto@5c63cc2bc39b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icee90b73232605d2d9aa797d2ff0abf5334270be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072310Reviewed-by:
-
David Grogan authored
All the cases that needed content_size were short-circuited when https://chromium-review.googlesource.com/c/chromium/src/+/1599691 made {min,max}-height: {min,max,fit}-content behave as auto. Change-Id: Icafee2c35598d92c95703c3eb16e0d43eecde48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069506Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744280}
-
Olivier Li authored
This class simplifies the process of running tests with a feature both activated and deactivated. Change-Id: I9a4b0457c8e48fd7ba0a8a2f9ef3ff6e271de000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050829Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#744279}
-
Maksim Ivanov authored
This adds a Polymer property to the <cr-button> element that allows the host to specify the custom value of the "tabindex" attribute. Before this CL, the <cr-button> element was handling this attribute itself: it was forcing it to "-1" when the button is disabled and to "0" when the button is re-enabled. Also a few already existing examples in the code base are configuring the "tabindex" directly at the <cr-button> element, but it's fragile (and buggy in some cases), because this value gets overwritten as soon as the "disabled" property gets changed. After this CL, the more robust alternative appears: <cr-button custom-tab-index=...> Bug: 1043194 Test: add element '<cr-button custom-tab-index="-1">' to a Polymer page, verify that it's not tabbable Change-Id: Id5e79737f2bc9ac049ea1f2372ec160aac36d9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069144 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#744278}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/384e239655c4..0fc949c8b168 git log 384e239655c4..0fc949c8b168 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 wolfi@chromium.org Delete local overrides via context menu button 2020-02-25 szuend@chromium.org Prepare various test utilities for asynchronous source mapping Created with: gclient setdep -r src/third_party/devtools-frontend/src@0fc949c8b168 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1016501,chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib25ce193daeedf0a5a100376ef1f2a262fa27450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072304Reviewed-by:
-
