- 21 Sep, 2018 40 commits
-
-
Olivier Robin authored
- Known bugs: navigation buttons do not work in iframes. - Payment Request is only enabled in main frame. - This CL does not enable autofill in iFrame by default. Bug: 881364, 792642 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia18b8a0543d0c754a22d3ee9287171f6807f5f5c Reviewed-on: https://chromium-review.googlesource.com/1233575Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593196}
-
Kush Sinha authored
- Actual value of |maximum_backoff_ms| for |kBackoffPolicy| in |GaiaCookieManagerService| is 4 hours but the documentation/comment claims that it is 15 minutes. Fix the comment. - Fix lint error for an if-else statement. Change-Id: If957966b754e8a33ab0531eef7d64ee871bdf5a0 Reviewed-on: https://chromium-review.googlesource.com/1238440Reviewed-by:David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#593195}
-
Javier Ernesto Flores Robles authored
Observe the last focused field to validate it is secure before filling a password Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ide4407ea51b315c68c50fa010f256cde93f5eb26 Reviewed-on: https://chromium-review.googlesource.com/1221217 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#593194}
-
Dave Tapuska authored
The background can be painted underneath occasionally. When we have a fullscreen element indicate the backdrop's color. BUG=886544, 785001 Change-Id: I17d2533779abc68b14bc8af732f182dd32e963f0 Reviewed-on: https://chromium-review.googlesource.com/1234232 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#593193}
-
John Budorick authored
Bug: 794372 Change-Id: Ic68afc2f66f340cf807406c3446567f886cd005e Reviewed-on: https://chromium-review.googlesource.com/1237409Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#593192}
-
Etienne Pierre-Doray authored
Use case: An expensive function wants to make sure it's not running on the UI thread so the expensive operations don't block that thread. This assertion fails on threads other than scheduler workers. Bug: 879181 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2a7ec2442c2020da4d68605c2476a01d25a45a33 Reviewed-on: https://chromium-review.googlesource.com/1221787Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#593191}
-
Tibor Goldschwendt authored
The ModuleInstaller goes into the new component module_installer, which hosts code necessary to install dynamic feature modules. It is used by Chrome to install the AR module (and other modules in the future). See go/chromevr-dfm-design-proposal for more information. Bug: 863068, 862690 Change-Id: Ib7fb7451fbd9ce08cd57e96f923a81f7327a8ddb Reviewed-on: https://chromium-review.googlesource.com/1228308 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#593190}
-
liberato@chromium.org authored
NOTRY=true TBR=nohle@chromium.org, dtrainor@chromium.org Bug: 887953 Change-Id: I3a3f3ea828c86873fdea72d75c50a83a83271408 Reviewed-on: https://chromium-review.googlesource.com/1238377Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593189}
-
Jan Krcal authored
This CL deals properly with the root node for wallet data. This node is sent (at least) in integration tests for migration to USS. Bug: 853688 Change-Id: I94f38e38a4f7db7a7e960e5205c64d7ad6cf49e7 Reviewed-on: https://chromium-review.googlesource.com/1238541 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#593188}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0664f0cf..980ce54f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I11d36cfe3b3e16e3be373688aa3b35ef44febb92 Reviewed-on: https://chromium-review.googlesource.com/1238374Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593187}
-
Anthony Vallee-Dubois authored
TBR= collinbaker@chromium.org,pkasting@chromium.org Bug: 887815 Change-Id: Iff08fcfe7efeac0363d40302c57a08005b069bbb Reviewed-on: https://chromium-review.googlesource.com/1237863 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#593186}
-
Greg Kraynov authored
Aimed to avoid ref-counted lifecycle of TaskQueueImpl. SingleThreadTaskRunnner implementation will be dropped from TaskQueue shortly. See bug for details. TBR=gab@chromium.org Bug: 865411 Change-Id: I92a3965299cb1c829e8a385f4bb2690383436107 Reviewed-on: https://chromium-review.googlesource.com/1234474 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593185}
-
Jan Krcal authored
This CL refines the way the wallet data bridge notifies about changes it writes to the local database. This CL required a minor extension in the AutofillWebDataBackend interface. The changes are not guarded behind a feature flag for wallet_metadata uss migration as they are backwards compatible for all current implementations of AutofillWebDataServiceObserverOnDBSequence. Bug: 853688 Change-Id: I3f9bd3e48c4591dddf3f645edef63d51cc8fbff8 Reviewed-on: https://chromium-review.googlesource.com/1236693Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593184}
-
Anthony Vallee-Dubois authored
TBR=tapted@chromium.org Bug: 887811 Change-Id: I0ea74b31942f50ad2f3ffc463de60f48060f1639 Reviewed-on: https://chromium-review.googlesource.com/1237865Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5eacf83622c..553230386b67 git log f5eacf83622c..553230386b67 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 hjd@google.com Merge "Add linenoise to trace_processor" Created with: gclient setdep -r src/third_party/perfetto@553230386b67 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8a7c2d0ddcaba43fdec4e44f8229456e38919667 Reviewed-on: https://chromium-review.googlesource.com/1238323Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593182}
-
Stefan Zager authored
Scrollbar::Maximum is used by the theme paint code to determine whether to disable the scroll arrows, based on whether the current scrollbar position is all the way at the beginning or end of its range. The rounding code used to set the visible size and overflow size for the scrollbar behaves differently from that used by ScrollableArea to clamp scroll offsets. The CL makes Scrollbar fall back to using values computed by the ScrollableArea. BUG=769615 R=skobes@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I982e71b485cc402972cb7ac1f5f482c1f84e1a70 Reviewed-on: https://chromium-review.googlesource.com/1237390Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#593181}
-
Etienne Pierre-Doray authored
While OpenFile/CloseFile are already covered by ScopedBlockingCall, this function does file reading operations (fread), which may block. ScopedBlockingCall serves as a precise annotation of the scope that may/will block for the scheduler. Since it supports nesting, there is no problem calling CloseFile() in the same scope. Bug: 874080 Change-Id: Id65de018cc20a2788d42d408c1c49052eed813c0 Reviewed-on: https://chromium-review.googlesource.com/1236393 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593180}
-
Greg Thompson authored
BUG=none R=eyaich@chromium.org Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I54cc409664aaa53c0164f5a572f09e179602dd35 Reviewed-on: https://chromium-review.googlesource.com/1237654 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#593179}
-
chrome://discardsSigurdur Asgeirsson authored
Bug: 874968 Change-Id: Id87498398908bfe8cf7e6c7ab596074b0575325a Reviewed-on: https://chromium-review.googlesource.com/1236499 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
-
Etienne Pierre-Doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /dbus. This CL adds ScopedBlockingCall(MAY_BLOCK) for each scope containing a dbus_* call, assuming all of those calls may block. I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=satorux@chromium.org Bug: 874080 Change-Id: Ib90b59280bd22cb671a64bacabe299c02c6d6081 Reviewed-on: https://chromium-review.googlesource.com/1190930Reviewed-by:Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#593177}
-
Antonio Gomes authored
In [1], iOS' URLDownloader switched from URLFetcher to SimpleURLLoader. However, it was observed during the migration that its existing unit test SingleDownloadPDF does not actually exercise the actual fetch/load code path. This CL fixes SingleDownloadPDF so that it actually loads a testing PDF file through SimpleURLLoader and URLLoaderFactory machinery. [1] https://crrev.com/c/1234635 BUG=None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6b3006f8e021bb97c8d839307c741f7071708683 Reviewed-on: https://chromium-review.googlesource.com/1236855Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#593176}
-
Hayato Ito authored
We might want to move some perf tests from perf_tests/dom to perf_tests/bindings, which would be done in another CL later. See http://crbug.com/887204 for the context. Bug: 887204 Change-Id: Idd818d23337dfb015e3643ffc4780be764858eb1 Reviewed-on: https://chromium-review.googlesource.com/1237897Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#593175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/217056c04885..f610bae66163 git log 217056c04885..f610bae66163 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 ethannicholas@google.com fixed spelling of 'preferred' Created with: gclient setdep -r src/third_party/skia@f610bae66163 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ifc277c98e6dbd78d4ea1f63e9165be5274ad1c85 Reviewed-on: https://chromium-review.googlesource.com/1238325Reviewed-by:
-
Mathias Carlen authored
Move the tree building interface one layer lower to the web controller. The actual implementation using devtools will follow. R=gogerald@chromium.org Bug: 806868 Change-Id: Ib7bcc031bf86e939db99ae8e844202065c5ab923 Reviewed-on: https://chromium-review.googlesource.com/1234153Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593173}
-
chrome://discardsSigurdur Asgeirsson authored
Bug: 874968 Change-Id: Ie7b655ece8e9a98c73bb529181a79e3d9a7b7586 Reviewed-on: https://chromium-review.googlesource.com/1231922 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#593172}
-
Majid Valipour authored
Worklet animation compositing state should be updated when a zoom or viewport resize changes css pixel to dip ratio. The fix is to simply match what we already do for regular animations for worklet animations. TEST=virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html Bug: 879107 Change-Id: I0b74bd8297e83b18afd087247f09339aedcc618b Reviewed-on: https://chromium-review.googlesource.com/1237133Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#593171}
-
Valeriya Sinevich authored
Also retry fetching access token if it failed but count retries for all tokens together. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1c8d131faa7fba5a6d4c43714b998bc140642864 Reviewed-on: https://chromium-review.googlesource.com/1199424 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
-
Mario Sanchez Prada authored
This isn't strictly needed since iOS will always use net-in-process, but is good for consistency with the rest of the code that ios shares with chrome that has switched to SimpleURLLoader. Bug: 879770 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I49665d4b6054c1a882a42d4661f03162bfceebc7 Reviewed-on: https://chromium-review.googlesource.com/1235722 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#593169}
-
Rune Lillesveen authored
We used a separate SetChildNeedsReattachLayoutTree() before calling MarkForWhitespaceReattachment() for the ancestors which meant we passed a dirty_node/common_ancestor a level higher up the chain which caused the layout_tree_rebuild_root_ to update incorrectly. Instead use an arbitrary child to invoke MarkForWhitespaceReattachment() on. Note that none of the children are actually dirty after a node removal. We only need to make sure we traverse down to the siblings of a removed node to check if its whitespace siblings need reattachment. Since the arbitrary child may be a text node, we have to handle that in RootElement(). Bug: 884456, 884449 Change-Id: I06c50f6f996e41b813f7e847351fc87d42336857 Reviewed-on: https://chromium-review.googlesource.com/1235997 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#593168}
-
Adrienne Porter Felt authored
This reverts commit 2b3cf454. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove the SPKI fingerprint for auth.impulse.com from captive portals list > > Bug: 870038 > Change-Id: I856efd083382cb27f01ea37abbfcbb04941ec0c4 > Reviewed-on: https://chromium-review.googlesource.com/1176582 > Commit-Queue: Adrienne Porter Felt <felt@chromium.org> > Reviewed-by: Adrienne Porter Felt <felt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593084} TBR=felt@chromium.org,meacer@chromium.org Change-Id: I0c158c192ebd88c3cd586da3fca7cd6963f594f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870038 Reviewed-on: https://chromium-review.googlesource.com/1238375Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#593167}
-
Kyoko Muto authored
In this CL, We add the functions that support to call slotchange event when nodes are assigned from assign function. Previous implementation CL: crrev.com/c/1201513 Bug: 869308 Change-Id: I44cfc94c26141630aa82ea725566a8c7273eacf5 Reviewed-on: https://chromium-review.googlesource.com/1226477 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593166}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9bfe0eb25e3d..575af7ecfc21 git log 9bfe0eb25e3d..575af7ecfc21 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 antiagainst@google.com [kokoro] Add test job for disabling effcee (#1911) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@575af7ecfc21 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iee584865c392206d1036571c480491894e8114c5 Reviewed-on: https://chromium-review.googlesource.com/1238321Reviewed-by:
-
Rayan Kanso authored
Update the BackgroundFetchDownloadClient to handle the new DownloadService contract. The Background Fetch scheduler will attempt to start all active downloads on start-up. The ones that are actually resuming will be ignored by the client. Since the response metadata and the actual response are propagated in different calls, the response metadata will be propagated twice to account for restarts. This will be fixed in a follow-up CL where all of the information associated with the response will be sent once to the Background Fetch scheduler. Bug: 881314 Change-Id: I4d806c0eec2cb9c35a42da568613fb2d5ede856e Reviewed-on: https://chromium-review.googlesource.com/1227995Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#593164}
-
Christian Biesinger authored
(ListGrid::Cell takes 12.09% of total time when running the large-spanning-grid-item.html perf test with LayoutNG enabled; with this patch, that's down to 4.92%) R=rego@igalia.com Change-Id: Ibd0da807622824892227326844e5f4c19faa9bb0 Reviewed-on: https://chromium-review.googlesource.com/1237380Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#593163}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05cf051f0252..217056c04885 git log 05cf051f0252..217056c04885 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 kjlubick@google.com [CanvasKit] Implement some basic Canvas/Surface things. 2018-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a977acc85769..ab5fb5edb186 (4 commits) Created with: gclient setdep -r src/third_party/skia@217056c04885 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I783462f5177e8eaf173e7ce03b8dbbb9fa694637 Reviewed-on: https://chromium-review.googlesource.com/1238319Reviewed-by:
-
Jan Krcal authored
This CL fixes an omission in integration tests for autofill wallet that different credit cards / addresses served by the server still had same ids in the specifics. This in particular fixes a test failure for CL 1236693. Bug: 853688 Change-Id: Iecb050ceb56f709004b16f6712196b71d0be56b0 Reviewed-on: https://chromium-review.googlesource.com/1238536 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
Olivier Robin authored
This CL does not add support to autofill in iFrames. Unittests may fail with the Autofill in iFrame flag enabled. This will be solve in a future CL. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I38cd09b7aec31d8e47eea8e756ef937bcdde7b1b Reviewed-on: https://chromium-review.googlesource.com/1230062 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
David Tseng authored
Change-Id: I76f06b801e6fdd71a89af55f7acca68c9d1bb4bd Reviewed-on: https://chromium-review.googlesource.com/1236508 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593159}
-
Sylvain Defresne authored
As a followup to https://crrev.com/c/1233702, KeyedService takes the factory as a base::Callback instead of a function pointer. Convert BrowserStateKeyedServiceFactory to base::Callback, thus allowing binding some state to the factory. Bug: 809610 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie563d9b76190b384660cd314fb0e6d8eede324e4 Reviewed-on: https://chromium-review.googlesource.com/1235718 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes the button visibility of the legacy toolbar which has been removed in a previous CL. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7d847599d4720fa6d5a920baa9b5ad468e6e4d32 Reviewed-on: https://chromium-review.googlesource.com/1236654Reviewed-by:
-
