GitLab

This is a large improvement from the previous duplicated lists of
source files in WebRTC. This moves over to using the GYP/GN targets
in third_party/webrtc instead, which has become possible after landing
https://codereview.webrtc.org/1924663003/ and
https://codereview.webrtc.org/2037983002/.

BUG=webrtc:4256
TESTED=Local builds passing for Linux and Android.

Review-Url: https://codereview.chromium.org/2022833002
Cr-Commit-Position: refs/heads/master@{#408931}

BUG=526892
TEST=manually

Review-Url: https://codereview.chromium.org/2195283002
Cr-Commit-Position: refs/heads/master@{#408930}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d0caa399..6c53c6c7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2198793002
Cr-Commit-Position: refs/heads/master@{#408929}

Revert of Fold compositing display items into contained drawings if the drawing is a singleton. (patchset #7 id:110001 of https://codereview.chromium.org/2186643002/ )

Reason for revert:
This CL seems to break layout tests on bot.
An example of failure is:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__dbg_/results/layout-test-results/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-crash-log.txt

STDERR: [4:4:0731/203155:3802475433:FATAL:PaintController.cpp(554)] Check failed: false.
STDERR: #0 0x7f109c38b99e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f109c3f2fef logging::LogMessage::~LogMessage()
STDERR: #2 0x7f1097594655 blink::PaintController::checkUnderInvalidation()
STDERR: #3 0x7f1097592e64 blink::PaintController::processNewItem()
STDERR: #4 0x7f1097583d52 _ZN5blink15PaintController15createAndAppendINS_18DrawingDisplayItemEJRKNS_17DisplayItemClientERKNS_11DisplayItem4TypeEN3WTF10PassRefPtrI9SkPictureEERbEEEvDpOT0_
STDERR: #5 0x7f1097583af1 blink::DrawingRecorder::~DrawingRecorder()
STDERR: #6 0x7f109422f925 base::internal::OptionalStorage<>::~OptionalStorage()
STDERR: #7 0x7f109422f8c5 base::Optional<>::~Optional()
STDERR: #8 0x7f109422ed83 blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder()
STDERR: #9 0x7f109423e187 blink::BoxPainter::paintBoxDecorationBackgroundWithRect()
STDERR: #10 0x7f109423dcde blink::BoxPainter::paintBoxDecorationBackground()
STDERR: #11 0x7f10943f34f5 blink::LayoutBox::paintBoxDecorationBackground()
STDERR: #12 0x7f109422dbcd blink::BlockPainter::paintObject()
STDERR: #13 0x7f10943b1bd5 blink::LayoutBlock::paintObject()
STDERR: #14 0x7f109422d25c blink::BlockPainter::paint()
STDERR: #15 0x7f10943b1b55 blink::LayoutBlock::paint()

Original issue's description:
> Fold compositing display items into contained drawings if the drawing is a singleton.
>
> BUG=628831
>
> Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd
> Cr-Commit-Position: refs/heads/master@{#408725}

TBR=fmalita@chromium.org,wangxianzhu@chromium.org,wkorman@chromium.org,chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628831

Review-Url: https://codereview.chromium.org/2197903002
Cr-Commit-Position: refs/heads/master@{#408928}

DCHECK in PlainTextRange's constructor causes a crash when start > end, but
the test passes, probably because it's a renderer crash and we call it at
the end.

In this case, we'll swap start and end just like BaseInputConnection does.

Also adds some tests to fix the behavior and prevents a crash in the future.

BUG=

Review-Url: https://codereview.chromium.org/2179943006
Cr-Commit-Position: refs/heads/master@{#408927}

Currently chrome reports HTTP response code to UMA and it always -1 when
the HTTP connection is failed.
The CL let chrome report net status error instead if the response code
is -1.

BUG=539608
TEST=Sync multiple files in Files.app.

Review-Url: https://codereview.chromium.org/2163903002
Cr-Commit-Position: refs/heads/master@{#408926}

If WebView has an active IME but the Android app calls
InputMethodManager#hideSoftInputFromWindow() on a non-UI thread,
then a deadlock may happen.

One example case is when JavaScript triggers it through JavascriptInterface
(therefore, on JavaBridge thread.)

The deadlock scenario is as follows:

1) InputMethodManager#hideSoftFromWindow() calls
   ThreadedInputConnectionProxyView#getWindowToken() on JavaBridge thread
   while holding InputMethodManager#mH.
   Then getWindowToken() waits for UI thread to become available.
2) At almost same time, InputMethodManager#restartInput() was waiting for
   InputMethodManager#mH on UI thread

This deadlock can be avoided by caching return values as atomic objects.

Alternative approach I've tried: check the current thread and block
it only when it's IME thread - this may still leave room for deadlock
between IME thread and UI thread.

BUG=630937

Review-Url: https://codereview.chromium.org/2175263002
Cr-Commit-Position: refs/heads/master@{#408925}

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to build on and easier
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.

BUG=602624

Review-Url: https://codereview.chromium.org/2191873002
Cr-Commit-Position: refs/heads/master@{#408924}

Use nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables
to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13

BUG=none

Review-Url: https://codereview.chromium.org/2196553003
Cr-Commit-Position: refs/heads/master@{#408923}

Reland of Further reduction of feature_compiler.py generated code (patchset #1 id:1 of https://codereview.chromium.org/2201653003/ )

Reason for revert:
Not this either

Original issue's description:
> Revert of Further reduction of feature_compiler.py generated code (patchset #5 id:80001 of https://codereview.chromium.org/2193693003/ )
>
> Reason for revert:
> Suspect for widespread Win7 NaCl failures starting with
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55503
>
> Wasn't r408782, r408787 or r408781
>
> Original issue's description:
> > Further reduction of feature_compiler.py generated code
> >
> > Use raw pointers instead of unique pointers to reduce size. See linked
> > bug for size details.
> >
> > BUG=631416
> >
> > Committed: https://crrev.com/2026cea7fa1b2146d7113dc31f2a2969d9ec58e3
> > Cr-Commit-Position: refs/heads/master@{#408788}
>
> TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,scottmg@chromium.org
> NOTRY=true
> NOTREECHECKS=true
> BUG=631416
>
> Committed: https://crrev.com/132a21ca3dedb4b2942737a3e947c772c81743aa
> Cr-Commit-Position: refs/heads/master@{#408917}

TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631416

Review-Url: https://codereview.chromium.org/2199683002
Cr-Commit-Position: refs/heads/master@{#408922}

Cr-Commit-Position: refs/heads/master@{#408921}

Only affects URLs with strong right-to-left characters.

This fixes the case where the URL contains RTL characters, causing the
components of the URL to be rendered from right to left. The display is
now consistent with the Omnibox display of URLs and compliant with RFC
3987.

BUG=630481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2176463002
Cr-Commit-Position: refs/heads/master@{#408920}

Revert of Use MediaRecorder to capture video for quality test. (patchset #1 id:1 of https://codereview.chromium.org/2183873002/ )

Reason for revert:
Performance numbers regressed a bit too much after landing this, example:
https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxozpqQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICght-9qAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxuK2sgkM

Original issue's description:
> Use MediaRecorder to capture video for quality test.
>
> Retrite the WebRTC video quality test to use the MediaRecorder API
> instead of recording from a canvas.
>
> BUG=631458
>
> Committed: https://crrev.com/0204f3d64d8472a25d93312356d2a1c4acbb600e
> Cr-Commit-Position: refs/heads/master@{#408633}

TBR=phoglund@chromium.org,mcasas@chromium.org,ehmaldonado@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=631458

Review-Url: https://codereview.chromium.org/2199653002
Cr-Commit-Position: refs/heads/master@{#408919}

When a simple cross-origin request has been made and then blocked,
a log message of "blocked from loading" may sound confusing since we've
loaded the resource from the server but just prevented the response
from being delivered to the page.

When a redirect has been blocked, the error message should say that the
redirect has been blocked and the reason (e.g. whether the redirect location
is bad or the response didn't pass the CORS check) clearly.

BUG=417786
R=sof

Review-Url: https://codereview.chromium.org/1196423003
Cr-Commit-Position: refs/heads/master@{#408918}

Revert of Further reduction of feature_compiler.py generated code (patchset #5 id:80001 of https://codereview.chromium.org/2193693003/ )

Reason for revert:
Suspect for widespread Win7 NaCl failures starting with
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55503

Wasn't r408782, r408787 or r408781

Original issue's description:
> Further reduction of feature_compiler.py generated code
>
> Use raw pointers instead of unique pointers to reduce size. See linked
> bug for size details.
>
> BUG=631416
>
> Committed: https://crrev.com/2026cea7fa1b2146d7113dc31f2a2969d9ec58e3
> Cr-Commit-Position: refs/heads/master@{#408788}

TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,scottmg@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=631416

Review-Url: https://codereview.chromium.org/2201653003
Cr-Commit-Position: refs/heads/master@{#408917}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e689c4714834..f3881da3d75a

$ git log e689c4714..f3881da3d --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2196173002
Cr-Commit-Position: refs/heads/master@{#408916}

Remove the core/css/properties/ folder, since it's currently dead code.
Will re-add when the Ribbon project starts up again.

This is a revert of crrev.com/1431773002.

BUG=545324

Review-Url: https://codereview.chromium.org/2202453002
Cr-Commit-Position: refs/heads/master@{#408915}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/462f4bd5..d0caa399

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2200623002
Cr-Commit-Position: refs/heads/master@{#408914}

Revert of Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types (patchset #3 id:40001 of https://codereview.chromium.org/2181443002/ )

Reason for revert:
This patch has broken compiling on the MSan bots.

Due to memory waterfall shenanigans I haven't had time to investigate why, but I do know that locally reverting this change fixed compile.

Sample failure output:
FAILED: obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DMEMORY_SANITIZER -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=274369-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DENABLE_OILPAN=1 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src=. -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -O2 -fno-ident -fdata-sections -ffunction-sections -g1 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -gline-tables-only -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins=2 -fsanitize-blacklist=../../tools/msan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc -o obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o
In file included from gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc:15:
In file included from gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.h:37:
In file included from gen/mojo/public/interfaces/bindings/tests/rect.mojom-blink.h:37:
In file included from ../../mojo/public/cpp/bindings/wtf_array.h:15:
In file included from ../../mojo/public/cpp/bindings/lib/wtf_clone_equals_util.h:13:
../../third_party/WebKit/Source/wtf/Vector.h:196:32: error: call to deleted constructor of 'mojo::ScopedHandleBase<mojo::Handle>'
            new (NotNull, dst) T(*src);
                               ^ ~~~~
../../third_party/WebKit/Source/wtf/Vector.h:323:62: note: in instantiation of function template specialization 'WTF::VectorCopier<false, mojo::ScopedHandleBase<mojo::Handle> >::uninitializedCopy<mojo::ScopedHandleBase<mojo::Handle> >' requested here
        VectorCopier<VectorTraits<T>::canCopyWithMemcpy, T>::uninitializedCopy(src, srcEnd, dst);
                                                             ^
../../third_party/WebKit/Source/wtf/Vector.h:1004:21: note: in instantiation of member function 'WTF::VectorTypeOperations<mojo::ScopedHandleBase<mojo::Handle> >::uninitializedCopy' requested here
    TypeOperations::uninitializedCopy(other.begin(), other.end(), begin());
                    ^
../../buildtools/third_party/libc++/trunk/include/memory:1740:31: note: in instantiation of member function 'WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>::Vector' requested here
            ::new((void*)__p) _Up(_VSTD::forward<_Args>(__args)...);
                              ^
.... snip

TBR=rockot@chromium.org,yzshen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
NOPRESUBMIT=true
BUG=624136,631415

Review-Url: https://codereview.chromium.org/2199623002
Cr-Commit-Position: refs/heads/master@{#408913}

This patch hides the following member functions of SpellChecker as
private because they are only used by SpellChecker itself:

bool markMisspellings(const VisibleSelection&);
void markBadGrammar(const VisibleSelection&);
bool markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling);
void markMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, bool markGrammar, const VisibleSelection& grammarSelection);
void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);

This patch is a preparation for cleaning up grammar checking code from
SpellChecker.

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2198733003
Cr-Commit-Position: refs/heads/master@{#408912}

* Remove 'Psst' notice from delete confirmation dialog
* Increase line-height of 'other forms of history' notice to 20px

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2195263002
Cr-Commit-Position: refs/heads/master@{#408911}

Reland of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #1 id:1 of https://codereview.chromium.org/2196143002/ )

Reason for revert:
Didn't work. NaCl still crashing. Sadness :(

Original issue's description:
> Revert of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #5 id:80001 of https://codereview.chromium.org/2181163003/ )
>
> Reason for revert:
> Suspect (not the first) for widespread NaCl test failures since
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
>
> Errors like
>
> [4224:3200:0729/162247:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
> ...
>   Actual: "Plugin crashed. 'NaCl module crashed'"
>
> Wasn't r408782 or r408787. Running out of candidates..
>
> Original issue's description:
> > [Presentation API] Convert presentation.mojom to new wrapper types.
> >
> > This converts presentation.mojom to use the new (std::) Mojo wrapper types:
> > mojo::String => std::string
> > mojo::Array => std::vector
> >
> > No behavior changes should ensue.
> >
> > Optional values are represented as base::Optional<Foo> with the new wrapper
> > types requiring some additional changes.
> >
> > This work will simplify further changes for crbug.com/627655.
> >
> > BUG=627655
> >
> > Committed: https://crrev.com/59e7b40948030815a49af887b922b370ba048b8b
> > Cr-Commit-Position: refs/heads/master@{#408781}
>
> TBR=dcheng@chromium.org,imcheng@chromium.org,mfoltz@chromium.org
> NOTRY=true
> BUG=627655
>
> Committed: https://crrev.com/43c746be32b2bfce5c3fd654894e4b7f7bf6387f
> Cr-Commit-Position: refs/heads/master@{#408905}

TBR=dcheng@chromium.org,imcheng@chromium.org,mfoltz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627655

Review-Url: https://codereview.chromium.org/2197053002
Cr-Commit-Position: refs/heads/master@{#408910}

If we sync the ARC opt-in prefence we may cause unintentional data loss
when the user opts-out of ARC on one device.

BUG=633017
TEST=Manually test by opting out of ARC on one machine and observing a
second (opted-in) machine's state.

Review-Url: https://codereview.chromium.org/2198733002
Cr-Commit-Position: refs/heads/master@{#408909}

Fixed ParentVisibilityChecker in CSSVisibilityInterpolationType to store
the EVisibility enum, rather than a double.

Review-Url: https://codereview.chromium.org/2195233002
Cr-Commit-Position: refs/heads/master@{#408908}

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2190293004
Cr-Commit-Position: refs/heads/master@{#408907}

BUG=633026, 619103
TBR=wangxianzhu@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2194123002
Cr-Commit-Position: refs/heads/master@{#408906}

Revert of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #5 id:80001 of https://codereview.chromium.org/2181163003/ )

Reason for revert:
Suspect (not the first) for widespread NaCl test failures since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504

Errors like

[4224:3200:0729/162247:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
...
  Actual: "Plugin crashed. 'NaCl module crashed'"

Wasn't r408782 or r408787. Running out of candidates..

Original issue's description:
> [Presentation API] Convert presentation.mojom to new wrapper types.
>
> This converts presentation.mojom to use the new (std::) Mojo wrapper types:
> mojo::String => std::string
> mojo::Array => std::vector
>
> No behavior changes should ensue.
>
> Optional values are represented as base::Optional<Foo> with the new wrapper
> types requiring some additional changes.
>
> This work will simplify further changes for crbug.com/627655.
>
> BUG=627655
>
> Committed: https://crrev.com/59e7b40948030815a49af887b922b370ba048b8b
> Cr-Commit-Position: refs/heads/master@{#408781}

TBR=dcheng@chromium.org,imcheng@chromium.org,mfoltz@chromium.org
NOTRY=true
BUG=627655

Review-Url: https://codereview.chromium.org/2196143002
Cr-Commit-Position: refs/heads/master@{#408905}

Cr-Commit-Position: refs/heads/master@{#408904}

Disable element visibility check only on Android.

BUG=632561

Review-Url: https://codereview.chromium.org/2201703002
Cr-Commit-Position: refs/heads/master@{#408903}

Reland of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2200593002/ )

Reason for revert:
No dice - NaCl still crashing in
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55553

Original issue's description:
> Revert of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2197783002/ )
>
> Reason for revert:
> Suspected for widespread NaCl plugin failures on waterfall since
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
>
> Crashes with "Actual: "Plugin crashed. 'NaCl module crashed"
>
> It wasn't r408782, so I think it's gotta be this or r408781.
>
> Original issue's description:
> > Fix bug with blank pages during navigation
> >
> > This bug started after r408172.  In some situations when navigating, the
> > SetNeedsBeginFrame messages that is sent from the
> > CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is
> > received by the RenderWidgetHostImpl while the RenderViewHost is swapped
> > out and before it has swapped back in.  In these cases, if this message
> > is dropped, the renderer will never tick new frames and the tab will
> > freeze.  This appears to be racy, as the renderer finds out that it is
> > visible and sends this message before the view host is swapped in.
> >
> > To fix this race, always allow the SetNeedsBeginFrame message to be
> > received while being swapped out so that the RenderWidgetHostView can be
> > in the correct state when it is swapped in.
> >
> > R=sievers@chromium.org
> > BUG=632276
> >
> > Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20
> > Cr-Commit-Position: refs/heads/master@{#408787}
>
> TBR=kenrb@chromium.org,sievers@chromium.org,enne@chromium.org
> NOTRY=true
> BUG=632276
>
> Committed: https://crrev.com/ad648d7d920843e226b5f0aee2cf8e9662412413
> Cr-Commit-Position: refs/heads/master@{#408899}

TBR=kenrb@chromium.org,sievers@chromium.org,enne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632276

Review-Url: https://codereview.chromium.org/2195253002
Cr-Commit-Position: refs/heads/master@{#408902}

Also switch from scoped_refptr to unique_ptr, as we only have one owner.

Savings:
SafeJsonParserStub::AcceptWithResponder: 42 bytes
SafeJsonParser_Parse_ForwardToCallback: 44 bytes

We lose a few bytes (but come out positive in the end) due to fixing the incorrect Ninja template expansions in the error messages.

BUG=597125

Review-Url: https://codereview.chromium.org/2188143002
Cr-Commit-Position: refs/heads/master@{#408901}

Calculating composition bounds is not a light-weight operation.
On the other hand, few IME uses this information.
To skip this unnecessary calculation on certain environment, propagate
cursor update mode from browser to the renderer.

BUG=624714

Review-Url: https://codereview.chromium.org/2121953002
Cr-Commit-Position: refs/heads/master@{#408900}

Revert of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2197783002/ )

Reason for revert:
Suspected for widespread NaCl plugin failures on waterfall since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504

Crashes with "Actual: "Plugin crashed. 'NaCl module crashed"

It wasn't r408782, so I think it's gotta be this or r408781.

Original issue's description:
> Fix bug with blank pages during navigation
>
> This bug started after r408172.  In some situations when navigating, the
> SetNeedsBeginFrame messages that is sent from the
> CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is
> received by the RenderWidgetHostImpl while the RenderViewHost is swapped
> out and before it has swapped back in.  In these cases, if this message
> is dropped, the renderer will never tick new frames and the tab will
> freeze.  This appears to be racy, as the renderer finds out that it is
> visible and sends this message before the view host is swapped in.
>
> To fix this race, always allow the SetNeedsBeginFrame message to be
> received while being swapped out so that the RenderWidgetHostView can be
> in the correct state when it is swapped in.
>
> R=sievers@chromium.org
> BUG=632276
>
> Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20
> Cr-Commit-Position: refs/heads/master@{#408787}

TBR=kenrb@chromium.org,sievers@chromium.org,enne@chromium.org
NOTRY=true
BUG=632276

Review-Url: https://codereview.chromium.org/2200593002
Cr-Commit-Position: refs/heads/master@{#408899}

BUG=633016
TBR=alokp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2197003002
Cr-Commit-Position: refs/heads/master@{#408898}

Reland of Try yet again to flip official win builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2196993002/ )

Reason for revert:
Didn't help - NaCl still crashing.

Original issue's description:
> Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ )
>
> Reason for revert:
> All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
>
> This seems to be the most likely cause :(
>
> There's also an outstanding issue with win-pgo (see BUG=)
>
> BUG=632864
>
> Original issue's description:
> > Try yet again to flip official win builders to GN.
> >
> > TBR=brettw@chromium.org
> > NOTRY=true
> > BUG=623659
> >
> > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3
> > Cr-Commit-Position: refs/heads/master@{#408782}
>
> TBR=brettw@chromium.org,dpranke@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=623659
> NOTRY=true
>
> Committed: https://crrev.com/30fbb2688486ee1534b3035c9c89a6003181c2f8
> Cr-Commit-Position: refs/heads/master@{#408896}

TBR=brettw@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632864

Review-Url: https://codereview.chromium.org/2192393003
Cr-Commit-Position: refs/heads/master@{#408897}

Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ )

Reason for revert:
All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504

This seems to be the most likely cause :(

There's also an outstanding issue with win-pgo (see BUG=)

BUG=632864

Original issue's description:
> Try yet again to flip official win builders to GN.
>
> TBR=brettw@chromium.org
> NOTRY=true
> BUG=623659
>
> Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3
> Cr-Commit-Position: refs/heads/master@{#408782}

TBR=brettw@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659
NOTRY=true

Review-Url: https://codereview.chromium.org/2196993002
Cr-Commit-Position: refs/heads/master@{#408896}

NetBSD is BSD and POSIX-like OS.

BUG=

Review-Url: https://codereview.chromium.org/2195203002
Cr-Commit-Position: refs/heads/master@{#408895}

This correctly matches the GYP behavior.

R=brettw@chromium.org, sebmarchand@chromium.org
BUG=632563

Review-Url: https://codereview.chromium.org/2199603002
Cr-Commit-Position: refs/heads/master@{#408894}

Also, add a watchlist entry for modifications to gyp files.

R=brettw@chromium.org
BUG=432967

Review-Url: https://codereview.chromium.org/2194043004
Cr-Commit-Position: refs/heads/master@{#408893}

TBR=smut@google.com
BUG=

Review-Url: https://codereview.chromium.org/2195213002
Cr-Commit-Position: refs/heads/master@{#408892}