GitLab

We will shortly be componentizing //chrome's detection of captive
portals as part of componentizing SSLErrorHandler for sharing with
WebLayer. This CL takes a first step by componentizing the
enable_captive_portal_detection feature and buildflag.

The (internal-only, apologies) design doc showing how the
componentization of captive portal detection fits into the larger
effort is here:

https://docs.google.com/document/d/1ab_zZ6TF6tMZE54IJ2dz8LSwsIp6XEwky9yzH7WPFqk/edit#heading=h.llthcowp07o0

Bug: 1030692
Change-Id: If71557f5c67516a2be13319d589f9bbb622710af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991626Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733279}

In preparation for componentizing this blocking page, this CL moves
it to be created via ChromeSecurityBlockingPageFactory and thereby
cleaned of its //chrome-level dependencies.

Bug: 1030692
Change-Id: Icb2693512d04fa504e4ac059b06761b287212502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000743
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733278}

::marker pseudo-elements are originated by elements whose computed
'display' is 'list-item'. This usually means that they are list items,
that is, they are laid out as LayoutNGListItem (or LayoutListItem).

However, this is not always the case. E.g. a <fieldset> is laid out as
LayoutNGFieldset (or LayoutFieldset) even with 'display: list-item'.
This was the only problematic case in LayoutNG that I found in r731964,
so I just prevented <fieldset> from originating a ::marker. But this was
a fragile approach since there could be other cases. Actually I have
noticed other cases in legacy when working on implemententing markers
as pseudo-elements in legacy.

This patch adds a condition in PseudoElement::AttachLayoutTree to
prevent a ::marker from being laid out if it's originated by an element
which isn't laid out as a list item.

BUG=457718

Change-Id: I60fd774d6de79189b2871c98594d8bee397e4064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007457Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#733277}

Change-Id: Ia29e88514bf46733cb730098620e705df59d1f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000450
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733276}

This CL uses new downcast helpers for DocumentAllNameCollection,
DocumentNameCollection and DocumentResource classes.

Bug: 891908
Change-Id: I1e10bc7fa908090cf13e4c271bac010b43d42bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999964Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#733275}

This reverts commit e094969c.

Reason for revert: crbug.com/1043279

Original change's description:
> Manually roll perfetto 11c11a1a891c..d092437b81ea
>
> Also includes manual modification to switch to perfetto's EventContext.
>
> https://android.googlesource.com/platform/external/perfetto.git/+log/11c11a1a891c..d092437b81ea
>
> 2020-01-17 fmayer@google.com Merge "Cleanup of profile related trackers."
> 2020-01-17 eseckler@google.com Merge "client lib: Add an EventContext constructor for Chrome"
> 2020-01-17 lalitm@google.com Merge "bazel: Disable warning about unused system_header pragma"
> 2020-01-17 lalitm@google.com Merge "trace_processor: fix overflow in bitvector"
> 2020-01-17 taylori@google.com Merge "Make selection default behaviour"
> 2020-01-17 treehugger-gerrit@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead."
> 2020-01-17 eseckler@google.com Merge "processor: Only fall back to legacy tracks for legacy events"
> 2020-01-17 treehugger-gerrit@google.com Merge "TrackEvent: Add initial legacy macro support"
> 2020-01-17 fmayer@google.com Merge "Function for on-demand flamegraph for heap graph."
> 2020-01-17 treehugger-gerrit@google.com Merge "Turn ingestion DFATALs into DLOG."
> 2020-01-17 khokhlov@google.com Merge "Exclude targets depending on sqlite from embedder builds"
> 2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated"
> 2020-01-16 eseckler@google.com Merge "processor: Export pid/tid as signed integers into JSON"
> 2020-01-16 lalitm@google.com Merge "trace_processor: fix compile and build on fuzzer"
> 2020-01-16 joelaf@google.com Merge "Fix precision errors by explicit casting"
> 2020-01-16 lalitm@google.com Merge "Revert "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead.""
> 2020-01-16 chiur@google.com Merge "Add VulkanApiEvent.VkQueueSubmit message"
> 2020-01-16 khokhlov@google.com Merge "trace_processor: Run metrics on Windows"
> 2020-01-16 primiano@google.com Merge "gn: Fix issue with finding llvm when using python3"
> 2020-01-16 hjd@google.com Merge changes Ic6800bd0,I29636316
> 2020-01-16 treehugger-gerrit@google.com Merge "processor: Fix handling of 0 timestamp in TrackEventTokenizer."
> 2020-01-16 rsavitski@google.com Merge "heapprofd producer: use sigqueue(si_value: 0) instead of kill"
> 2020-01-16 taylori@google.com Merge "perfetto-ui: Toggle sidebar on ctrl/cmd + b"
> 2020-01-16 eseckler@google.com Merge "client lib: Support building in Chrome using a fake platform"
> 2020-01-16 eseckler@google.com Merge "processor: Translate duplicate pids/tids during json export"
> 2020-01-16 buss@google.com Merge changes I1bb0e215,I498ed990
> 2020-01-16 treehugger-gerrit@google.com Merge "processor: Support pid reuse in ProcessTracker without Start/EndThread"
> 2020-01-16 primiano@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead."
>
> Created with:
>   gclient setdep -r src/third_party/perfetto@d092437b81ea
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> Bug: 1043059
> Change-Id: I37e4964f76d212bcfef69c8715ac7521521e82a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007750
> Reviewed-by: ssid <ssid@chromium.org>
> Reviewed-by: Stephen Nusko <nuskos@chromium.org>
> Commit-Queue: ssid <ssid@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732907}

TBR=skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org,nuskos@chromium.org

Change-Id: I8c7dba484b81bdd85b67443956808722e44a7c5f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1043059, chromium:1043279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008421
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733274}

This reverts commit 7832cb0b.

Reason for revert: crbug.com/1043279

Original change's description:
> Roll src/third_party/perfetto d092437b81ea..2e5c7edf368f (3 commits)
>
> https://android.googlesource.com/platform/external/perfetto.git/+log/d092437b81ea..2e5c7edf368f
>
> git log d092437b81ea..2e5c7edf368f --date=short --first-parent --format='%ad %ae %s'
> 2020-01-17 lalitm@google.com Merge "trace_processor: allow selecting rowmaps with smaller rowmaps"
> 2020-01-17 buss@google.com Merge "Fix compilation on Windows/VSC."
> 2020-01-17 hjd@google.com Merge "ui: Remove small gap in pinned track container"
>
> Created with:
>   gclient setdep -r src/third_party/perfetto@2e5c7edf368f
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> Bug: None
> Tbr: perfetto-bugs@google.com
> Change-Id: Ib8ceb5de792d61f42929d30e6f411fb3435d8238
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008168
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#732942}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: Ia82d45f04e13ad0ff1face565633d1b65ded43b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007459
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733273}

This reverts commit 728991c5.

These settings are now set in builder.star.

R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org

Bug: 1040754
Change-Id: I4e3bb46fd65705c09a6cc02fa62749b1a274e7df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010510Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733272}

We used to stop propagation of text-decoration into elements rendered
with UA shadow trees in general. Instead we should list the specific
cases where we need to do this. This is currently for media elements
which has a special rendering where the media controls do not use a
proper containing block model.

This fixes text-decoration propagation for elements like, summary,
details, object, and marquee.

TEST=fast/table/backgr_layers-opacity.html
TEST=fast/table/backgr_layers-opacity-collapsed-border.html
TEST=media/controls-styling.html

Bug: 1042760
Change-Id: Ice2681e4ac93b1a96ec598bcb614b6a8f57e0b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007629
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733271}

Changes ShelfConfig and LoginShelfView so that the correct colors
are set for the buttons during the OOBE session state.

Fixed: 1023788
Change-Id: If4150449354575a648417f9aecfdb74a1d2bbfa2
Bug: 1023788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003316
Commit-Queue: Renato Silva <rrsilva@google.com>
Auto-Submit: Renato Silva <rrsilva@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733270}

Bug: 873178
Change-Id: I3896e14dbbc63667a7b4fbba3737ea66ba07eb8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002876
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733269}

This CL disables a test so a hotfix CL (https://crrev.com/c/2009107)
can land. The hotfix fixes DevTools console so we prioritize landing it
in favor of investigating one failing web test.

Bug: chromium:1043151
Change-Id: Id1e8cded7bcc847e08886a59df2ce27613bb73f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007579Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733268}

This CL continues the refactor of drag'n'drop on Linux.  Here the most
part of code that doesn't depend on Aura and views is moved.

Bug: 1014860
Change-Id: I47380c8ab0291485b2de544ba12342c09163e2a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007573Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Cr-Commit-Position: refs/heads/master@{#733267}

System web app can specify |include_launch_directory| in registry to
receive the launch directory (in addition to launch files) on launch.

Fixed: 1030988, 1043006

Change-Id: Ia6fbc48d2412f00430c52a8fc0667decb65c2a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905031
Commit-Queue: Jiewei Qian  <qjw@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733266}

Add type check to file_manager/background.js in integration tests.

Currently integration tests have many Closure markup however this isn't
checked at all, this CL starts to add check for File Manager integration
tests.

Bug: 778674
Change-Id: Iff0b7e4ac1185abaf248939bb00b8468cd20a1ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007796Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733265}

Change getAvailableTasks in quick_view_controller.js to use new helper
getEntryFileTasks instead of getFileTasks.

Previewing a PDF file in Quick View is done through a "task".
The function getFileTasks in task_controller.js returns the tasks
that can be performed for all files that are selected when in
check-select mode. (eg, when two image files are selected in
check-select mode, one of the tasks is to open them both in Gallery).

However, when a PDF and another file type are selected, there are no
tasks for that combination of file types. This causes getFileTasks to
return with no tasks, and renders the PDF file un-viewable in Quick
View.

getEntryFileTasks returns the tasks for a given FileEntry rather than
the entire current selection, making PDFs viewable in Quick View in
check-select mode.

Tests coming in a future patch.

Bug: 1038799
Change-Id: Iab860f697c3a7f9dcb0fc76c994de35bcccecab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010228Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733264}

Undefined errors in the console are expected when for example, the user
mashes an arrow key. This causes getAvailableTasks_ to reject a promise
with undefined as it tries to throttle access to the metadata system.

Improve this: Only log errors to console that are defined, and add a
stack trace.

Bug: 1038799
Id: I843660a87456a92c3b73548cb5d5dbbde686d6e2
Change-Id: I843660a87456a92c3b73548cb5d5dbbde686d6e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009602
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733263}

https://skia.googlesource.com/skia.git/+log/e79897c42389..3322aafc36d4

git log e79897c42389..3322aafc36d4 --date=short --first-parent --format='%ad %ae %s'
2020-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 41f6150edb16..579c59400f86 (12 commits)
2020-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2cb1db08e5f1..11cb891a01a2 (4 commits)

Created with:
  gclient setdep -r src/third_party/skia@3322aafc36d4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: I528755c8c0730147691d2c98c7549adf79d6ad79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010261Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733262}

This CL splits ServiceWorkerStorage::GetAllRegistrationsInfos()
into two parts:
* ServiceWorkerRegistry::GetAllRegistrationsInfo()
* ServiceWorkerStorage::GetAllRegistrations()

The former uses the latter to read registration data from storage
then constructs in-memory representation of service worker
registrations. The latter is effectively a wrapper of
ServiceWorkerDatabase::GetAllRegistrations().

Bug: 1039200
Change-Id: I0ba265010df495d51a68243179f3a672dd631011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006894
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733261}

*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not
*** revert this CL. Instead, please disable the offending test(s) and
*** add them to the crbug.com/1035582 section of TestExpectations. I
*** will then take care of them as I fix up the remainder of these
*** tests. Feel free to cc me if you create a bug. Thanks!

Prior to this CL the 2px inner padding was used for all the elements.
Because of issues where due to content overlapping the focus ring is
not seen completely, the inner 2px padding is changed to be used just
for small controls (checkbox, radio) and links.

Bug: 1026553, 1043054, 1043064
Change-Id: I11994e9bfbba6a9764130e314a38e5505808df42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008282
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733260}

This CL splits ServiceWorkerStorage::GetRegistrationsForOrigin() into
two parts:
* ServiceWorkerRegistry::GetRegistrationsForOrigin()
* ServiceWorkerStorage::GetRegistrationsForOrigin()

The former uses the latter and is responsible for constructing in-memory
representation of registrations (ServiceWorkerRegistration). The latter
is responsible for reading registration data from storage.

Bug: 1039200
Change-Id: Icc26b057c7fc120c6b256d4886157fd419806db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006441
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733259}

This CL moves 29.0 kB of "long tail" resources to the Developer WebUI
Dynamic Feature Module (DevUI DFM), for 6 chrome://pages whose
resources were in content_resources.pak. The pages moved are:

  appcache-internals (IDR_APPCACHE_INTERNALS_*)
  gpu (IDR_GPU_INTERNALS_*)
  indexeddb-internals (IDR_INDEXED_DB_INTERNALS_*)
  network-errors (IDR_NETWORK_ERROR_LISTING_*)
  process-internals (IDR_PROCESS_INTERNALS_*)
  serviceworker-internals (IDR_SERVICE_WORKER_INTERNALS_*)

For chrome://gpu, IDR_VULKAN_* remain in content_resources.pak (and the
base module) since they're aliased in shared_resources_data_source.cc.

Also rename target //content:resources to //content:content_resources
to improve naming consistency.

Bug: 927131
Change-Id: Icbc159637e5986438a05de918443ec1fa40d2dce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992012
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733258}

Bug: None
Test: None
Change-Id: I8e125462d0e7d15a38843f587b6011f29ab993ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010224
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733257}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f033551d4237..7a8dfb9c2acd


Created with:
  gclient setdep -r src-internal@7a8dfb9c2acd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ica95ed8e618ef0880077943d61cb6eebc436c1ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010260Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733256}

chrome/browser/resources/chromeos/camera/camera_resources.grd depends
upon a file from //components/arc/mojom:camera_intent_js, yet it has
no dependency on it. This makes for a flaky build.

This patch adds the dependency.

BUG=none
TEST=none

Change-Id: I1b6fc534ffff6abc440a973824a0706d9b265940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008414
Auto-Submit: Scott Violet <sky@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733255}

We will look at the following metrics with timeline to quickly find whether blink leaks the objects or not.

Memory.Experimental.Renderer2.Small.
- NumberOfNodes

Memory.Experimental.Renderer2.Tiny.
- NumberOfAdSubframes
- NumberOfAudioHandler
- NumberOfContextLifecycleStateObserver
- NumberOfDetachedScriptStates
- NumberOfDocuments
- NumberOfFrames
- NumberOfJSEventListener
- NumberOfLayoutObjects
- NumberOfMediaKeys
- NumberOfMediaKeySession
- NumberOfResourceFetcher
- NumberOfResources
- NumberOfRTCPeerConnection
- NumberOfUACSSResource
- NumberOfV8PerContextData
- NumberOfWorkerGlobalScope

Change-Id: I46af244057ba13f001f05d7a3b20505c264eacfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000403Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#733254}

Change-Id: Ib11d9edc4258aa807721daea78c2528709cf99d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995107Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#733253}

https://skia.googlesource.com/skia.git/+log/e8fc3ffdada3..e79897c42389

git log e8fc3ffdada3..e79897c42389 --date=short --first-parent --format='%ad %ae %s'
2020-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 870bcafd..6c56a01a (544 commits)

Created with:
  gclient setdep -r src/third_party/skia@e79897c42389

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: I262e2f8ec6619f9054283cf82ed89420dcb10411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010256Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733252}

|PositionForPoint| needs different logic for block children,
inline formatting context, and for inline boxes. Currently
we have separate logic in |NGPaintFragment|.

This patch ports the inline box logic to |NGFragmentItem|
from |NGPaintFragment::PositionForPointInInlineLevelBox|.
Other logic will be ported in following patches.

Fixes 8 tests, turns 1 crash to failure.

Bug: 982194
Change-Id: Ibd10e272d1e4e1c9e6e2433f12f1c9252f2fabf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007327Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733251}

This reverts commit c70db549.

Reason for revert: It is causing crashes:
Bug: 1043484

Original change's description:
> [Global Media Controls] Hide sender page media items while casting
> 
> When a Cast session is initiated from a web page and the page doesn't
> get rid of its media session, we generally get duplicate media
> notification items: one for the sender page and the other from the
> receiver. This CL hides the former in such cases.
> 
> Bug: 1038447
> Change-Id: Icfa3487a9c101aa185b5ec7e41f5981da23a64df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955086
> Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732894}

TBR=mfoltz@chromium.org,takumif@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1038447
Change-Id: Ib4cc19d3e4a96995cbeea0eaea7e6724278a02e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010325Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733250}

Using wpt-import in Chromium 5a5addf8.
With Chromium commits locally applied on WPT:
62f8d5f0 "Enable Scroll To Text by default"
363313c0 "Sort the registrations returned by getRegistrations() by registration ID."
8a985066 "[Trusted Types] Implement require-trusted-types-for"
0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I4b4277094b226a8e54140bef9c5d3b6833deab9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008651Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733249}

This CL has goal to remove unused DEFINE_LAYOUT_OBJECT_TYPE_CASTS from
third_party/blink/renderer/core/layout

Bug: 891908
Change-Id: I7158ba61477bbb88b8cb9ac1be84566ac5043e1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009166Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#733248}

Add a helper function to task_controller.js that retrieves the tasks
for a specified FileEntry. To be used to retreive the tasks of the
file currently open in Quick View.

Rewrite existing function executeEntryTask in terms of new helper.

Test: covered by testExecuteEntryTask in task_controller_unittest.js
Bug: 1038799
Change-Id: I290135f00744973451e84cf08f19a341a52aacc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007795Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733247}

This CL does two things to fix wrong behaviors for handing metadata:
1. Don't fill 3A metadata in reprocess request
2. Use the result metadata from the reprocess source as the metadata of
reprocess request rather than using the template metadata for preview

Bug: b/147863878
Test: Manually tested on krane and nocturne and the focus is unlocked
after taking photos under portrait mode.

Change-Id: I42a512a5def4d7ae725d5b1064487bebe0e52d51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006999
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Auto-Submit: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733246}

Using terminalPrivate in webui is not supported yet,
so we are going back to not gzipping resources and
using the builtin extension.

Bug: 1022250
Bug: 1040999
Change-Id: I8a533b5f03541d441a4da202c3d46f04369632c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010225Reviewed-by: Julian Watson <juwa@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733245}

The results we get from the Drive API contain *absolute* paths, where
the path root is the the root of user's Drive. We use these as
*relative* paths within the device's DriveFS mount, and so we need
to reparent the paths on top of the mount path.

For example, if we get the result:
  /root/my_drive_file.gdoc
And DriveFS is mounted at:
  /home/chronos/u-.../my/drive/mount/
We want to produce the path:
  /home/chronos/u-.../my/drive/mount/root/my_drive_file.gdoc

But right now we don't account for the absolute-ness of the result
path, so we actually produce:
  /home/chronos/u-.../my/drive/mount//root/my_drive_file.gdoc

These paths are still valid and so don't cause bad behaviour (POSIX
paths ignore duplicate slashes in the middle of a path), but it causes
a DCHECK in the file path code.

This CL just strips the leading separator from the result to fix the
issue.

Bug: 1022150
Change-Id: Ic024af205967000f0d8d8f68304cc131ad6f41b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007798Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733244}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org

Change-Id: I1fce237a198c88c67b27e54c65582dd8fc5f65bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010025Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733243}

Bug: 778674
Change-Id: Ib990dd2eefb05d082c443c69f29fc35563ae966d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006445Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733242}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65e58ed9eb79..f033551d4237


Created with:
  gclient setdep -r src-internal@f033551d4237

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I9052383cf5b7a41bc41176ae48c31c0754b8c48c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008337Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733241}

In all of LayoutObject subclasses for from controls, now only
LayoutMenuList::UpdateFromElement() has non-empty content. This CL
moves the code for UpdateFromElement() in HTMLFromControlElement to
HTMLSelectElement.

This CL has no behavior changes.

Bug: 1040828
Change-Id: Ib56e48458f228fe23ed09fb6a60fdd997c7d26e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009588Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733240}