- 20 Nov, 2017 40 commits
-
-
Takeshi Yoshino authored
Bug: 786626 Change-Id: I8a5a3d5673f7a1fc57bb87791fb93411ae16adf2 Tbr: qinmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/778342Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#517780}
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. Bug: 289619 Change-Id: Ibc473af04b1e28f59ebcec8a4e1cb5616d4eb8cb Reviewed-on: https://chromium-review.googlesource.com/771091Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#517779}
-
Xiaocheng Hu authored
LayoutText::CaretMaxOffset() requires clean layout, but currently can be called from DeleteSelectionCommand when layout is dirty. This patch adds layout update before the call sites to fix it. Bug: 781698 Change-Id: I17b7596e93f025d61836e39cca4bf736713d3422 Reviewed-on: https://chromium-review.googlesource.com/778050 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517778}
-
Takeshi Yoshino authored
Bug: 754679 Change-Id: Icabfdc8f753595cd9b586b721ac58c607e7b660d Tbr: qinmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/778646Reviewed-by:
-
Takeshi Yoshino authored
This reverts commit 1e2e99ef. Reason for revert: Suspected to be the cause of fast/mediastream/MediaStreamTrack-gc-no-crash.html failure Original change's description: > Enable video capture service by default on platforms where it is rolling > out with M61. > > Bug: 721812 > Change-Id: I1de0f625a1fb106e2dea664675e94267e66fc2fd > Reviewed-on: https://chromium-review.googlesource.com/719416 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517761} TBR=emircan@chromium.org,chfremer@chromium.org Change-Id: Icdb2af1cf68e1774d57c1d8b3c529e86e0a2a48e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721812 Reviewed-on: https://chromium-review.googlesource.com/778603Reviewed-by:
-
François Degros authored
Made ObserverListBase's iterator and const_iterator the same type. ObserverListBase::iterator doesn't allow to modify the collection anyway. There was no good reason for const_iterator and iterator to be different types. Making them the same type just makes the code simpler. Inlined ObserverListBase methods. Removed unnecessary friend declarations. Removed old MSVC workarounds. In the end: less code to do exactly the same thing. Change-Id: I0448a8a52f904635a2e30d094bcc2b48780e4d64 Reviewed-on: https://chromium-review.googlesource.com/773758 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#517775}
-
Xiaocheng Hu authored
IsTabSpanElement() checks the 'white-space' style of an element, but may be called with dirty style, and hence causing crash. This patch adds a style update in the function to stop the crash. Bug: 778901, 779527 Change-Id: I0c0d22f1a94ce06abd5fd146421cf00e4dbf6ac1 Reviewed-on: https://chromium-review.googlesource.com/772832Reviewed-by:
-
Mike West authored
This aligns Blink's behavior with Firefox and the Mixed Content spec, and updates web platform tests accordingly. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/x0ROz-Io2bc/B9-sd6_dBwAJ Bug: 785287 Change-Id: Ic50a23419b95709bab0abd370df6c2e16c3bb7b7 Reviewed-on: https://chromium-review.googlesource.com/771192Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#517773}
-
Xiaocheng Hu authored
The construction of offset mapping used to have some hacks to work around the LayoutText writeback. The hacks are no longer necessary if fragment painting is enabled. This patch makes the hacks disabled when fragment painting is enabled, so that we can remove the hacks easier in the future. Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I57e28f32f318d118e8ebe4a89999e3f07a9a806a Reviewed-on: https://chromium-review.googlesource.com/777964Reviewed-by:
-
Xiaocheng Hu authored
Bug: 761254 Change-Id: I6d85d36bd47b845da8e904f2c2f0999f8b958a70 Reviewed-on: https://chromium-review.googlesource.com/777591Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Before we would keep same origin navigations in the browser, but that would mean that navigating from https://www.google.com/ to https://www.google.com/maps wouldn't open the app. Now, we compare the app for the current URL with that of the target app and if they don't match we open the app, otherwise we keep the navigation in the same context. Bug: 783487 Change-Id: I0ecafbf006b502f60c665d91b9f3c838a4157dc2 Reviewed-on: https://chromium-review.googlesource.com/778401 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#517770}
-
Xiaocheng Hu authored
Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4588bad36c3b38e1722bf4b8ef8b33d313cbe1d2 Reviewed-on: https://chromium-review.googlesource.com/777732Reviewed-by:
-
Daichi Hirono authored
The event is dispached before OnSurfaceFocusing is invoked, and used by DataDevice to send selection wayland message. Bug; 773978 Test: exo_unittests Change-Id: I2a2edc659e23c381059585d30395c3cfe4304087 Reviewed-on: https://chromium-review.googlesource.com/776534 Commit-Queue: Daichi Hirono <hirono@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517768}
-
Sriram authored
According to the spec [1] we need to include optional components and add leading zeros if required for timestamp construction. [1]: https://w3c.github.io/webvtt/#dom-construction-rules Bug: 786382 Change-Id: I2b7320bd6b187cb3b85a5532c0a0fd398b3888cf Reviewed-on: https://chromium-review.googlesource.com/773763 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#517767}
-
Xiaocheng Hu authored
This patch moves the atomic inline handling code before the block flow handling code, so that there is no longer fall through from block flow to atomic inline. Bug: 771398 Change-Id: Idb4013e5616a2e81a13f4c6829c3afb2b86faa68 Reviewed-on: https://chromium-review.googlesource.com/775550 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
tzik authored
As a follow up of http://crrev.com/c/765611 and http://crrev.com/c/763029, this CL removes no-longer-needed SoftwareReleaseCallback, and updates users of it for OnceCallback migration. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I95df100e141710fbe5fedec4f033e1186475e75e Reviewed-on: https://chromium-review.googlesource.com/776475 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#517765}
-
Hajime Hoshi authored
This CL adds an argument for listener task runner to IPC::ChannelMojo:: Create{Server,Client} so that we can have more flexible task scheduling. Now all arguments are base::ThreadTaskRunnerHandle::Get() and this CL doesn't change the behavior. This CL is just a preparation. Doc: https://docs.google.com/document/d/1yOhE6-1HLb3aeNWmoa9O2LlnegWjd4awYUn2OhUL4vk/edit# Change-Id: I2f5c70ff3af499766e7b42de8e33f13dafcefbff Reviewed-on: https://chromium-review.googlesource.com/756821Reviewed-by:Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#517764}
-
Chris Watkins authored
We want to deprecate ListHashSet in favor of LinkedHashSet. The main difference between them is that ListHS iterators remain valid after modification of the container, whereas LinkedHS iterators do not. These usages of ListHashSet don't rely on iterators remaining valid after modification, so it's a straightforward replacement. Bug: 614112 Change-Id: I31839044b2267cd0a9749b1907e6237686909f65 Reviewed-on: https://chromium-review.googlesource.com/778639Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#517763}
-
Maajid authored
AddKeyEx now takes AuthorizationRequest and AddKeyRequest directly. Bug: 741274 Change-Id: I200b7bd8255010b51376d15bcff3e190b651fb13 Reviewed-on: https://chromium-review.googlesource.com/776518 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517762}
-
Christian Fremerey authored
out with M61. Bug: 721812 Change-Id: I1de0f625a1fb106e2dea664675e94267e66fc2fd Reviewed-on: https://chromium-review.googlesource.com/719416 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517761}
-
Takeshi Yoshino authored
Bug: Change-Id: Ia32d500ba42bdd485f0c35e1a34659332002a162 Reviewed-on: https://chromium-review.googlesource.com/648909 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517760}
-
Takashi Toyoshima authored
Update TestExpectations to mark fetch-request-fallback.https.html as [ Crash Failure ] rather than [ Crash ]. This is a reland of 0326c088 Original change's description: > Plumb extra errors from ResourceRequestCompletionStatus to Blink > > This patch plumbs CORSError and HTTP response headers > from ResourceRequestCompletinoStatus to Blink's ResourceError. > > Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors > Bug: 736308 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I20e4ec9a2e7ca93ce692a5a8312dadf59eb0f345 > Reviewed-on: https://chromium-review.googlesource.com/749024 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517388} Bug: 736308 Change-Id: I8439662f9363e180839060c5245d2327324d1583 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Tbr: kinuko@chromium.org, tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org Reviewed-on: https://chromium-review.googlesource.com/778220Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#517759}
-
Patti authored
The "Cookies", "Certificate" and "Site settings" links are all buttons in Harmony mode, so update the Page Info bubble to match. Screenshot - https://drive.google.com/open?id=1DdlG3W-a7K5E73PRLCo0u_9cT5I_JYbV Bug: 535074 Change-Id: I4f715ccae231dbadfdbceee2408753671e17829c Reviewed-on: https://chromium-review.googlesource.com/754468 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#517758}
-
Timothy Loh authored
This CL fixes some comments in permission_context_base.h which are outdated or incorrect, and moves PermissionDecided from protected to private. Change-Id: I62ed3d82f46dc8680656c6072d9e45f4585197dd Reviewed-on: https://chromium-review.googlesource.com/776493Reviewed-by:
-
Xiaocheng Hu authored
This patch prunes the deprecated function from EditorCommand.cpp, which is safe because layout is already clean at the call sites, updated in Editor::Command::Execute() before calling the ExecuteFoo() functions. Bug: 698633 Change-Id: I011cb5dbc95a8b2a5d2b9289db6610471688094a Reviewed-on: https://chromium-review.googlesource.com/777476Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Maajid authored
This change should make it easier to make HomeDirMethods completely pass-through, and eventually the method should live with CryptohomeClient. Bug: 741274 Change-Id: I478f0de229cda544121fa57de870a6082f603961 Reviewed-on: https://chromium-review.googlesource.com/776533 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |LayoutObject::EnclosingNGBlockFlow()| to return |nullptr| if LayoutNG runtime feature enabled without calling |EnclosingBox())|, which requires traversing ancestors, for ease of writing LayoutNG enabled code and improving readability. Before this patch, we should write: if (RuntimeEnabledFeatures::LayoutNGEnabled()) { if (LayoutBlock* block_flow = EnclosingNGBlockFlow()) { ... code for LayoutNG return; } } ... code for legacy layout After this patch, we can write: if (LayoutBlock* block_flow = EnclosingNGBlockFlow()) { ... code for LayoutNG return; } ... code for legacy layout } This patch also changes |LayoutInline::DirtyLinesFromChangedChild()| as demonstration of shorter code and correctness of |EnclosingNGBlockFlow()| change. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/768599: [LayoutNG] Make LayoutInline::LinesBoundingBox() to work with fragments Change-Id: Ic36f84d3f5a1e65ac432ff0df65fe2449d8830a9 Reviewed-on: https://chromium-review.googlesource.com/776413Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
oka@chromium.org authored
The new demo app uses chromeosInfoPrivate API (only) to get the board name. BUG=782139 Change-Id: I92504073044d3b0f2b963d0acdbb4a8d67a2cd7b Reviewed-on: https://chromium-review.googlesource.com/771450Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#517753}
-
Samuel Huang authored
Previously Supersize archive for binaries linked with LLD (no LTO) did not support string literals, and required '--no-string-literals' to avoid triggering assert. This CL fixes this this by adding preliminary support for merged strings. Wrinkles: - LLD .map files does not discern string literals from data literals (and testing align=1 seems insufficient), so we count everything as string literals for now. - llvm-readobj (AKA llvm-readelf)'s dump for .a files is missing 'File: libray.a(file.o)' output. For now we work around this by using regular readelf instead. Bug: 723798 Change-Id: Ic0c9a48dfd9ab157ed19471127a5216ee98b8d65 Reviewed-on: https://chromium-review.googlesource.com/777441 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#517752}
-
Vasilii Sukhanov authored
It was caused by dereferencing an invalid URL during parsing. Bug: 770734 Change-Id: I4fedd3f310aaf7e1e1d2384aa64939d46b8b2a5a Reviewed-on: https://chromium-review.googlesource.com/773902 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#517751}
-
Takeshi Yoshino authored
This reverts commit 26bf6f9f. Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=722928#c52 Original change's description: > Adjust RenderFrameHostManagerTest to use mojo input. > > SetFocus for non-proxy frames are sent input message over mojo. > RenderFrameProxyHost based messages are still sent via > InputMsg_SetFocus chrome IPC since there is no widget input handler > for these situations. > > In order to grab the mojo input message we are required to subclass > the RenderWidgetHostImpl to be able to provide a mock interface. > > BUG=722928 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ieb34b0e1948583c433891edb9bfc5618b03952ad > Reviewed-on: https://chromium-review.googlesource.com/762156 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517505} TBR=creis@chromium.org,nick@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 722928 Change-Id: Iec95771149743822ba653dc6d1c5125abf0aed19 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/778619Reviewed-by:
-
Takeshi Yoshino authored
Bug: 674329 Change-Id: Ia815eb26487c09b69dabf61db018eb075c6b19e1 Reviewed-on: https://chromium-review.googlesource.com/773759 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
-
Bugs Nash authored
This is preparation for moving generated style builder methods to property class header files for properties that use the 'border-image-modifier' template. These style buider methods are unique to each property and therefore require separate property classes. Created new property classes for the following previously grouped properties: - WebkitMaskBoxImageWidth - WebkitMaskBoxImageSlice - WebkitMaskBoxImageRepeats - WebkitMaskBoxImageOutsets Bug: 751354 Change-Id: Iaf2f782086b13b4f4d84a3e3f16890aa264badd2 Reviewed-on: https://chromium-review.googlesource.com/775913Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#517748}
-
Blake O'Hare authored
Currently the callback will run immediately at the end of the function when RespondNow is encountered. There's still work to pass the callback through to the KeyboardController animation. Bug: Change-Id: Ie732ce933987b1cfb2303e1e3e1c67961ee112c4 Reviewed-on: https://chromium-review.googlesource.com/776296Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
Zhongyi Shi authored
this in particular controls migration with platform notification. Bug: 774622 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I410bcc3f5ee0280465b3c592cbf81cb0fea15c27 Reviewed-on: https://chromium-review.googlesource.com/776331 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#517746}
-
Maxim Podgorodskiy authored
On mac_views_browser fix bugs: 1. Return focus to location_bar throught "TAB"(key) pressing. 2. Saving focus on tabs(in tab_strip_model) swithing. By handle associated methods in ChromeWebContentsViewDelegateViewsMac. Make all focus changes in WebContentsView: 1. Move FocusThroughTabTraversal realization from WebContentsImpl to WebContentsView. 2. Remove SetInitialFocus realizaton from WebContentsViewDelegate. Reset stored focused view on any web_contens focus changing. R=tapted@chromium.org Bug: 782715 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I1ec95b655f7b5ee52fcc3a8cfea617a1ccab6f02 Reviewed-on: https://chromium-review.googlesource.com/758401Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#517745}
-
Peter Kotwicz authored
This CL: - Plumbs the version of EmbeddedTestServer::GetURL() which takes a host name to Java - Switches WebappNavigationTests from navigating to live www.google.com to navigating to a page hosted on the test server. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I28bf48914d77acd7033ee858fc7794da4875bc6d Reviewed-on: https://chromium-review.googlesource.com/771539Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#517744}
-
Daichi Hirono authored
Seat is corresponding to wl_saet and will be used to synchronize wl_data_device#selection and wl_keyboard#enter events Bug: 773978 Change-Id: Iaca10177f95aebac3822e6e534b9e640852e4ead Reviewed-on: https://chromium-review.googlesource.com/770453Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Ben Wells authored
This was only used for plugin settings, which are not needed any more. Bug: 754178 Change-Id: I24a9d1d08fd5a00fca088ed7ac212148af6c30e0 Reviewed-on: https://chromium-review.googlesource.com/773898 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517742}
-
Raymes Khoury authored
Records creation of the broker resource and calls to the Connect function. Bug: 756138 Change-Id: Ib5624a6469123e156677d75d7dfe59c5b3a70677 Reviewed-on: https://chromium-review.googlesource.com/773919Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#517741}
-
