GitLab

Adjust expectations, and parameterize test for RLS.

BUG=490942
R=skobes@chromium.org,pdr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2575663002
Cr-Commit-Position: refs/heads/master@{#438684}

54/74 tests had the annotation and more flaky tests needed the annotation.
Annotate the class rather than each individual test.

BUG=
TBR=donnd@chromium.org

Review-Url: https://codereview.chromium.org/2576173002
Cr-Commit-Position: refs/heads/master@{#438683}

https://skia.googlesource.com/skia.git/+log/e305cc1f2a44..56ff9a1c9dfd

$ git log e305cc1f2..56ff9a1c9 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 kjlubick Add Galaxy Tab3 Test
2016-12-14 herb Remove tombstones from SkTHash.
2016-12-14 liyuqian Change FLAGS_analyticAA's default to true
2016-12-14 reed remove PLAIN_ENUM flag for SkClipOp
2016-12-14 bsalomon Update rect ops to use "op" in their name and return sk_sp.
2016-12-14 mtklein switch to libstdc++ for standalone Android builds.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2576033002
Cr-Commit-Position: refs/heads/master@{#438682}

currently it's impossible to build clang packages due to this.

BUG=674274
R=hans@chromium.org

Review-Url: https://codereview.chromium.org/2579573002 .
Cr-Commit-Position: refs/heads/master@{#438681}

BUG=

Review-Url: https://codereview.chromium.org/2576053002
Cr-Commit-Position: refs/heads/master@{#438680}

Replace Android pause and pending images with UX-provided ones.

BUG=671686,671130

Review-Url: https://codereview.chromium.org/2570403002
Cr-Commit-Position: refs/heads/master@{#438679}

Although the value gMapBlendOpsToXfermodeModes[WebBlendModeNormal] is never
used by WebCoreCompositeToSkiaComposite() with an early branch. As a matter
of principle we should not allow such footgun. This CL doesn't change behavior.

Review-Url: https://codereview.chromium.org/2571953003
Cr-Commit-Position: refs/heads/master@{#438678}

Configure the ClipRectsContext for the root layer to treat it as a
composited scrolling layer by not applying an overflow clip.

BUG=490942
R=chrishtr@chromium.org,skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2576883002
Cr-Commit-Position: refs/heads/master@{#438677}

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2573993003
Cr-Commit-Position: refs/heads/master@{#438676}

This patch adds some perftests to measure RTree performance.
Sample run (on z620):

[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from RTreePerfTest
[ RUN      ] RTreePerfTest.Construct
*RESULT rtree_construct: 100= 346091.53125 runs/s
*RESULT rtree_construct: 1000= 36854.61328125 runs/s
*RESULT rtree_construct: 10000= 3392.330322265625 runs/s
*RESULT rtree_construct: 100000= 369.79052734375 runs/s
[       OK ] RTreePerfTest.Construct (8040 ms)
[ RUN      ] RTreePerfTest.Search
*RESULT rtree_search: 100= 2992395.5 runs/s
*RESULT rtree_search: 1000= 507624.9375 runs/s
*RESULT rtree_search: 10000= 32956.60546875 runs/s
*RESULT rtree_search: 100000= 3477.254638671875 runs/s
[       OK ] RTreePerfTest.Search (8020 ms)
[----------] 2 tests from RTreePerfTest (16060 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (16060 ms total)
[  PASSED  ] 2 tests.

R=danakj@chromium.org, dskiba@chromium.org
BUG=674169
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2576793002
Cr-Commit-Position: refs/heads/master@{#438675}

Windows versions after 10.0.14393.0 have EnableNonClientDpiScaling,
performing the same function as EnableChildWindowDpiMessage for us.

EnableChildWindowDpiMessage was also removed in 10.0.14393.0 if not
earlier.

This change also allows delegates to handle the WM_NCCREATE message,
required to properly call EnableNonClientDpiScaling.

BUG=642956, 658787

Review-Url: https://codereview.chromium.org/2574933002
Cr-Commit-Position: refs/heads/master@{#438674}

[Mojo Video Capture] Replace method OnIncomingCapturedVideoFrame() with OnIncomingCapturedBufferExt()

In interface media:VideoCaptureDevice::Client, replaced the method
OnIncomingCapturedVideoFrame() with OnIncomingCapturedBufferExt(). Compared to
method OnIncomingCaptureBuffer(), the VideoFrame parameter in
OnIncomingCapturedVideoFrame() was only used for passing along a bit of extra
information, namely a custom |visible_rect| as well as some
|additional_metadata|. The new method makes the intent clear and eliminates the
need for passing a media::VideoFrame that is partly redundant with the also
passed media::VideoCaptureDevice::Client::Buffer.

This CL breaks the video_capture_unittests, because current implementation of
the video_capture service wants to use VideoCaptureDeviceClient with buffers
that are backed by MojoSharedMemoryBufferTracker instances instead of the "regular" shared memory buffers. With this CL, VideoCaptureDeviceClient is
dropping support for this. We are working towards making the video_capture
service work with the regular buffers. To keep CLs small, we defer changes
to the service to after refactorings of VideoCaptureController and
VideoCaptureManager are complete and deactive the video_capture_unittests
temporarily. This is acceptable for the time being, since they are not run on
the bots yet. The CL that re-enables them is currently labeled CL1.9.22 in the
design doc.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.9

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*",
  video_capture_unittests,
  Apprtc loopback on Debug,
  Desktop Capture Example extension on Release

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2566983007
Cr-Commit-Position: refs/heads/master@{#438673}

Setting use_drm_atomic to true and compiling chrome is broken.
|gfx| namespace is not defined in hardware_display_plane_atomic.h.

This CL fixes that.

TEST=use_drm_atomic=true and compile.

Review-Url: https://codereview.chromium.org/2575213002
Cr-Commit-Position: refs/heads/master@{#438672}

BUG=673031

Review-Url: https://codereview.chromium.org/2569783002
Cr-Commit-Position: refs/heads/master@{#438671}

After looked into several paint property update issues, I feel that
the flag has little use. Most of situations needing paint property
update can't be derived from only style difference. It seems better to
keep needsPaintPropertyUpdate in layout and paint modules.

BUG=645667

Review-Url: https://codereview.chromium.org/2571283002
Cr-Commit-Position: refs/heads/master@{#438670}

The regular (non-ToT) UBSanVptr Linux buildbot runs
this test already.

BUG=

Review-Url: https://codereview.chromium.org/2577823002
Cr-Commit-Position: refs/heads/master@{#438669}

BUG=None

Review-Url: https://codereview.chromium.org/2573243002
Cr-Commit-Position: refs/heads/master@{#438668}

This CL implements the device policy to allow the domain admins to
set a device level policy controlled wallpaper for an enterprise
managed device. The device policy wallpaper will display on the login
screen all the time without requiring a user to log in. The device
policy wallpaper is also set as a user's wallpaper if there is no user
policy controlled wallpaper and the user hasn't changed his default
wallpaper in a user's session.

Detailed description of the expected behavior is described as below:

- In the login screen, if the device wallpaper policy present, use the
device policy wallpaper, otherwise, check if user-selected wallpaper
exists, if so, use the user-selected wallpaper, otherwise use OEM
default wallpaper.

- Within a user session, if the user wallpaper policy present, user the
user policy wallpaper, otherwise, check if user has changed his default
wallpaper before, if so, use user-slected wallpaper, otherwise, check
if the device wallpaper policy present, if so, use the device policy
wallpaper, otherwise, use OEM default wallpaper.

This is a follow-up CL of https://codereview.chromium.org/2544693002/.

BUG=475998

Review-Url: https://codereview.chromium.org/2572793003
Cr-Commit-Position: refs/heads/master@{#438667}

I tried this out by running an instance of python.exe in one cmd window, and tried interrupting it elsewhere with os.kill(pid, signal.CTRL_C_EVENT), which didn't work, but os.kill(pid, signal.SIGINT) did end the process.

Review-Url: https://codereview.chromium.org/2568703003
Cr-Commit-Position: refs/heads/master@{#438666}

Previously tombstones are saved as a long string test result object.
Tombstones are usually huge, so we have decided to write tombstones to
logdog and save the url, instead of the whole tombstones, as part of
test result object.

BUG=605572

Review-Url: https://codereview.chromium.org/2577463003
Cr-Commit-Position: refs/heads/master@{#438665}

Reason: Using symbolic names helps to make it clear what is disabled.

BUG=643937

Review-Url: https://codereview.chromium.org/2569153003
Cr-Commit-Position: refs/heads/master@{#438664}

Remove the --ash-enable-tablet-power-button switch and
instead enable tablet-style power button behavior whenever
the --enable-touchview switch is set. This matches the logic
for enabling the old "quick lock" power button behavior that
was replaced by tablet-style behavior.

BUG=674176,633304

Review-Url: https://codereview.chromium.org/2575183002
Cr-Commit-Position: refs/heads/master@{#438663}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/285b9f5a..b55ff5c9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2576043002
Cr-Commit-Position: refs/heads/master@{#438662}

NetworkSecurityPolicy allows apps to disallow cleartext requests,
globally (starting from M) or by hostname (starting from N). This CL
adds support for this feature in URLRequestHttpJob, and a flag on the
URLRequestContext to enable it. It's off by default and only prevents
requests using the "http" and "ws" schemes. Uses will be added in future
CLs.

BUG=474197, 473848

Review-Url: https://codereview.chromium.org/2546213003
Cr-Commit-Position: refs/heads/master@{#438661}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6a5ce5c1dff4..788644ef37e7

$ git log 6a5ce5c1d..788644ef3 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 eakuefner [Telemetry] Un-break HTMLOutputFormatter

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2576063002
Cr-Commit-Position: refs/heads/master@{#438660}

Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset #9 id:160001 of https://codereview.chromium.org/2546423002/ )

Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238

Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect.  Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}

TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2574363002
Cr-Commit-Position: refs/heads/master@{#438659}

Review-Url: https://codereview.chromium.org/2565793002
Cr-Commit-Position: refs/heads/master@{#438658}

Redefining these primitive types can cause problems; e.g. the definition of
|UINT32| is redundant, and conflicts with that in windows.h, if windows.h is
included before fips181's owntypes.h. These types are already available under
standardized names in stdbool.h and stdint.h.

BUG=

Review-Url: https://codereview.chromium.org/2571113002
Cr-Commit-Position: refs/heads/master@{#438657}

https://pdfium.googlesource.com/pdfium.git/+log/0d73909e89a5..6597391975cd

$ git log 0d73909e8..659739197 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 dsinclair Remove unused CFWL_Form flags
2016-12-14 dsinclair Remove unused CFWL_Edit flags.
2016-12-14 dsinclair This CL removes some of the unused CFWL widget flags.
2016-12-14 dsinclair Remove unused CFWL_ListBox code
2016-12-14 rbpotter Add inline JPEGs.

BUG=534945,550205,480628

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2571403002
Cr-Commit-Position: refs/heads/master@{#438656}

BUG=674226

Review-Url: https://codereview.chromium.org/2572983003
Cr-Commit-Position: refs/heads/master@{#438655}

BUG=673530

Review-Url: https://codereview.chromium.org/2574733003
Cr-Commit-Position: refs/heads/master@{#438654}

An InkDropHostView may manipulate layers in response the Widget::Hide().
A Hide() occurs synchronously in Widget::Close(), followed by tear down
that occurs asynchronously. Mac's BridgedNativeWidget (and
aura::Window::~Window()) suppress repaints during a close.
BridgedNativeWidget does this by clearing out the compositor. We
shouldn't try to subsequently recreate the compositor (there's a DCHECK
for that).

Manipulating Layers may call Widget::ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003

Review-Url: https://codereview.chromium.org/2577593002
Cr-Commit-Position: refs/heads/master@{#438653}

"For the purpose of calculating [the minimum height of a row],
descendants of table cells whose height depends on percentages
of their parent cell's height are considered to have an auto
height if they have overflow set to visible or hidden or if
they are replaced elements, and a 0px height if they have not."

This CL does two things re this rule:

- It ensures we respect it for replaced elements, including ones that aren't
  LayoutReplaced or isReplaced() objects. This is covered by the table-percent-
  height-* tests.
- It ensures we always obey it for hidden/visible overflow elements.

The CL also does two other things:

- If the cell doesn't have a specified height then treat it as auto for the
  purposes of calculating percent heights of its children. See bug
  671010 for the discussion that leads to this approach - soon to be specified
  we hope.
  Note that this results in the new behaviour of the form control elements in
  table-percent-height-* tests: they size as they would if they were in auto-
  sized <div>. Again, see bug 671010.
  We introduce a 'regression' in the behaviour of radio/select elements when
  percent-sized inside a cell that has no specified height - they now behave
  the same as radio/select elements when inside a div with auto height, they
  get a zero height. This is covered specifically in input-radio-height-inside-auto-container.html.
  It can also be seen in the updates to table-percent-height.html.

- If we've computed the height of a cell's child using the height made available
  by the cell, then be sure to respect content-/border-sizing of the child. We
  were just assuming that children were always content-sized. These are covered
  by the percent-height-border-box-content-* tests and are the main fall-out
  in 669867.

BUG=669867, 671010

Review-Url: https://codereview.chromium.org/2535173006
Cr-Commit-Position: refs/heads/master@{#438652}

frame_size_in_dip is a function of surface_size and scale, so in order
to simplify the API, this CL removes it from the parameter list of
Layer::SetShowSurface

Review-Url: https://codereview.chromium.org/2575503003
Cr-Commit-Position: refs/heads/master@{#438651}

ImageHijack canvas can currently hit a DCHECK when we try to process
images from SkImageShaders, as it handles them even if they are
non-lazy. Non-lazy images should be skipped.

BUG=673981
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2572783005
Cr-Commit-Position: refs/heads/master@{#438650}

When Blink is asked to provide what actions an accessibility object supports, instead of returning a string with an action verb, it now returns a value from the |WebAXSupportedAction| enumeration.
This change allows different platforms to localize the actions in any way they please. More specifically, on Windows we now expose two APIs: one for returning the localized action verb and one that returns the verb in English. This is a requirement dictated by the IAccessible2 Spec.
BUG=640043
TESTED=By changing Chrome's language to something other than English and trying to read a clickable element with NVDA
R=dmazzoni@chromium.org, sky@chromium.org, avi@chromium.org

Review-Url: https://codereview.chromium.org/2518183002
Cr-Commit-Position: refs/heads/master@{#438649}

When moving an NTP (very specific to the NTP URL) across
CTA instances, it would put the ref in AsyncTabParams, but
would not use it when creating the tab in the second window.

This was bad because it kept a reference to the incognito
tab forever (preventing the profile from being deleted and
the notification from going away).

This also changes the PendingIntent flag to allow the
notification to take an action as long as it is visible
(then if cleaning up the incognito tabs fails the first
time, the second click might succeed).

BUG=673582, 673489

Review-Url: https://codereview.chromium.org/2574143004
Cr-Commit-Position: refs/heads/master@{#438648}

BUG=673961
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2575673002
Cr-Commit-Position: refs/heads/master@{#438647}

This patch migrates a few more instances of icons onto UI.Icon:
- console's expand stack trace triangle
- styles sidebar pane's expand triangle for longhands
- blockedURL's "remove" button

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2570783006
Cr-Commit-Position: refs/heads/master@{#438646}

Revert of Android: Switch to thread pool executor (patchset #7 id:120001 of https://codereview.chromium.org/2562643004/ )

Reason for revert:
BackgroundSyncLauncherTest#testNewLauncherDisablesNextOnline fails.

Original issue's description:
> Android: Switch to thread pool executor.
>
> Switches BackgroundSyncLauncher to the thread pool executor and add
> comments explaining why AsyncTask is necessary.
>
> BUG=601053
>
> Committed: https://crrev.com/ad3ee42510afda09e00cb73c694bfa4626980d1d
> Cr-Commit-Position: refs/heads/master@{#438573}

TBR=iclelland@chromium.org,mariakhomenko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601053

Review-Url: https://codereview.chromium.org/2580503002
Cr-Commit-Position: refs/heads/master@{#438645}