- 18 Nov, 2019 40 commits
-
-
Cherie Cheung authored
If host root filesystem is writable and guest system image is EXT format, then the guest root filesystem should also be writable and StartArcVmRequest.rootfs_writable is set to true. This CL is a part of the change for b/144154973. Bug: 144154973 TEST=1. On host, 'mount -o remount,rw /' 2. Make sure guest system image is EXT4 3. On host, 'restart ui' 4. On guest, 'mount -o remount,rw /' 5. Guest root filesystem should be writable Change-Id: Id58ab406ca74f240aeadcfef2888c6578a6c5857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916523 Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Reviewed-by:Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#716097}
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: I5d86962e4dcdd3a95058efef86735a11a75ac8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908531 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#716096}
-
Roger Johannesson authored
https://codereview.chromium.org/2700663002 added key event listeners on the media element to improve keyboard accessibility. Element::SupportsSpatialNavigationFocus() checks if elements has key event listeners when deciding if a element should be focusable by spatial navigation. Element::SupportsSpatialNavigationFocus() is called by Element::SupportsFocus(). So, the CL above makes the media element default focusable if --enable-spatial-navigation is used. This CL modifies Element::SupportsSpatialNavigationFocus() to only consider elements with javascript based key and click event listeners as focusable. BUG=1023287 Change-Id: I254a6e2d1968f9bc1042a3ecaabc81ff3d99eb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913411 Commit-Queue: Roger Johannesson <rogerj@vewd.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#716095}
-
Miyoung Shin authored
This change converts DocumentCoordinationUnit mojom interface client in components to use BrowserInterfaceBroker. Since DocumentCoordinationUnit is a WebContentsObserver and a static helper function is used to register its binder. Bug: 936482 Change-Id: I146d28c81a39b4f977f53c92b567f6409e727553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895026Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#716094}
-
Mirko Bonadei authored
Starting from [1], WebRTC supports the Chromium component build and direct dependencies on //third_party/webrtc are disallowed. A dependency on //third_party/webrtc_overrides:webrtc_component is required instead. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 Bug: webrtc:9419 Change-Id: I8a09d9d2c9a54ff45950b03779832e231213d215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917204Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#716093}
-
Ella Ge authored
Change-Id: I4fa313c41fc3ed776b2e2c0f1370c0a006533824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914347 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716092}
-
Hiroki Sato authored
In ARC++ accessibility, some nodes of generic container or heading role can have a selected state, but it was not announced by ChromeVox. This CL adds an output of selected status. Bug: b:130186975 Test: still passes browser_tests --gtest_filter="ChromeVoxOutputE2ETest*" Change-Id: I53d9babacb5696802dc36b2adaf212d1116d0047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905291Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#716091}
-
sandromaggi authored
Before this change the model created the profiles on load and added it into the required field. The APIs being used were triggering JNI calls that are now being used directly. The sorting logic has been moved to keep the current behaviour. This change requires exposing some previously "hidden" functionality to create Java profiles from the c++ data in the personal_data_manager_android. These functions do not need any additional information and can be made static (similar to other already existing functionality). Bug: b/144005336 Change-Id: Ic12465f2270ebd877ac380d724bfaa1b460dc7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900986Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#716090}
-
Noel Gordon authored
CL:1449472 added some invalid rules for removable volumes||partitions see for example @line 474 which begins ... tree .tree-item > .tree-item > .tree-row > [volume-type-icon='removable'] { ... } But .tree-item > .tree-item matches nothing in FilesApp: a .tree-item is never a direct child of its parent .tree-item. So remove this rule and now try to understand @line 466 of CL:1449472 tree .tree-item[selected] > .tree-row > .tree-row[selected] [volume-type-icon='removable'][volume-sub... Which might be a transcription error, and then the rule runs onto the next line .tree-row > .tree-row[selected], but once again .tree-row > .tree-row never matches anything in FilesApp. Remove and replace this rule with an approximation of CL:1449472 intent. Bug: 992819 Change-Id: I552890e021c02d1dd304e51a49b772eaf7f13546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921595Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#716089}
-
Christopher Lam authored
Bug: 1018654 Change-Id: I538746e3650bfb21a12092b8fb550c5d74eb7fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913944Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#716088}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc2fd0f3b97c..e6cccd1fb9ad git log fc2fd0f3b97c..e6cccd1fb9ad --date=short --no-merges --format='%ad %ae %s' 2019-11-18 vapier@chromium.org paygen: utils: drop psutil usage Created with: gclient setdep -r src/third_party/chromite@e6cccd1fb9ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I492f8e3a0e5ce5ea04c0e5efe82af5119852fec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716087}
-
Chih-Yu Huang authored
This CL adds ImageProcessorWithPool class, which is a simple client of ImageProcessor. By injecting a DmabufVideoFramePool for allocating output frames and a callback for receiving processed frames, the caller could process input frames by Process() without managing output buffer. BUG=chromium:1004727 TEST=ninja image_processor_test Change-Id: I472366e4bf9460a304fcc8c4d43277c21e16c2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918917Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716086}
-
Alan Cutter authored
This CL enables PWA manifest updating to detect when sites update the scope field. Bug: 926083 Change-Id: Ib304ef830c215f564c64cf55c0d978308e2524e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921012 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#716085}
-
Shik Chen authored
If we use the prod key, the app id would collide with the built-in component app when using "load unpacked" with the build/camera directory. Bug: 1019581 Test: Check the app id is correct after "load unpacked". Change-Id: I8ff8413c96318979165188c3d633c00d0feaef86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921598 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#716084}
-
Hiroki Nakagawa authored
Bug: 931087 Change-Id: I10beb004d9b557ea6db67099eb090ea9898a8130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921592 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#716083}
-
Glen Robertson authored
Web apps installed through external sources (ie. default, policy, or system installed) could fail to install due to redirects, making the install process flaky. This was also unexpected for admins setting policy. Bug: 1015650 Change-Id: I616da7b9f68098591c63818be0467c69428350a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914139 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#716082}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I5dbb980bc4bcc99938fb8328aa5a74e6ddd463d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913230Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#716081}
-
Dominick Ng authored
This flag will likely be able to be removed soon as new improvements to devtools are made. For now, keep it around. BUG: None Change-Id: I8cb531cbcea8260582fce5cbde4cae0ad3e22611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921018 Commit-Queue: Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Auto-Submit: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#716080}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/48fbf27a09fb..473984fca427 git log 48fbf27a09fb..473984fca427 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 dberris@chromium.org Pinpoint: Support jobs with no 'chart' argument 2019-11-18 dberris@chromium.org Update OWNERS Created with: gclient setdep -r src/third_party/catapult@473984fca427 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:1025229 Change-Id: Ia4c98d112ea39ec1b95bd1ad4a3609662930e69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920844Reviewed-by:
-
Dominick Ng authored
Bug: None Change-Id: I9d6b7d776db410f2dc4c7128cd378e71c6d2db42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916534Reviewed-by:
-
Hajime Hoshi authored
This reverts commit 684024dd. Reason for revert: crbug.com/1025632 test failures Original change's description: > [Switch Access] Respond to changes in the accessibility tree > > When the accessibility tree changes, events are fired on the > automation API. This change updates the Switch Access tree when those > events are received. > > Bug: 1023035 > Change-Id: I88e208b8ed9d10653db2395dd4424194c3ef3248 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907550 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Auto-Submit: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715896} TBR=anastasi@google.com,akihiroota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1023035 Change-Id: Ie2c4a038272973da9b34a1c08960fb763d1824f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921587Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#716077}
-
Julie Jeongeun Kim authored
This CL converts network::mojom::URLLoaderClientPtr to new Mojo types using PendingRemote and Remote. It also uses pending_remote for URLLoaderClient parameter from mojom::URLLoaderFactory::CreateLoaderAndStart() and updates its implementations with new Mojo types. Bug: 955171 Change-Id: Ie93e96885628488df2d8a88929224cb43ad1ab53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901010 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Archie Pusaka authored
When a person sign in with an @google account, a bluetooth logging process will be started in the background which writes to a file. This particular file has a size limit, so upon reaching the limit, it will stop logging. To improve the condition, bluetooth team introduces two-file log rotation system. Therefore, we now have two log files instead of just one. This patch adds the second log file into feedback report. BUG=b:143118775 TEST=Do the following. 1) Observe that there is already a bluetooth log file, located in /var/log/bluetooth/log.bz2 2) Create another bluetooth log file /var/log/bluetooth/log.bz2.old 3) Send feedback with 'bluetooth' as the keyword and choose to attach bluetooth logs 4) Observe in listnr that both logs are attached. Change-Id: I79e498ec2086f0ca92249292c6731fe868a79e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913231Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#716075}
-
Hajime Hoshi authored
This reverts commit 73f7019b. Reason for revert: crbug.com/1025599: browser test failures Original change's description: > cros: Always use in-app shelf for work area insets in tablet mode > > Avoid using the shelf size used for home launcher and overview > when home launcher is showing. This should prevent the work area from > needlessly changing (only system ui is shown when HomeLauncher is shown, > so updating the work area only causes unnecessary calculations. > > Bug: 1019531 > Change-Id: Ief65e7ccfddc5ad81cb0084a649e5e34c74848b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914838 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715983} TBR=xdai@chromium.org,newcomer@chromium.org,manucornet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1019531 Change-Id: Id8cf83b4db7984bc6ad3f0f35c76e695897259c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921020Reviewed-by:
-
Chris Hall authored
'SetAccessiblityState' -> 'SetAccessibilityState'. R=jennyz,jamescook Change-Id: I695a6bd6d5f4905bb06b6158084076f6c3fed3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918909Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#716073}
-
Nicholas Verne authored
This distinguishes it from the new WebUI-based upgrade dialog that upgrades a container's Linux distribution. Bug: 1025629 Change-Id: Ic84f566f7ebe482da40df227222d42d4a1de7c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921024Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#716072}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a6bbfb935a25..48fbf27a09fb git log a6bbfb935a25..48fbf27a09fb --date=short --no-merges --format='%ad %ae %s' 2019-11-18 dberris@chromium.org Pinpoint: Treat grouping_label as optional Created with: gclient setdep -r src/third_party/catapult@48fbf27a09fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:1024520 Change-Id: Icc27a6a9e81638f19aa7287f215161d093025ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919761Reviewed-by:
-
Fergal Daly authored
Previously it was marked flaky for Mac but it's also flaky for Win and Linux. https://test-results.appspot.com/data/layout_results/Linux_Tests__dbg__1_/79264/webkit_layout_tests/layout-test-results/media/video-played-ranges-1-actual.txt Also update the bug number in TestExpectations. TBR=chcunningham@chromium.org Bug: 931533 Change-Id: I81d5a2e68e950b5063ed94136b9922c2d9330cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921025 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#716070}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a930e599e17c..e0eeef4b34ff git log a930e599e17c..e0eeef4b34ff --date=short --no-merges --format='%ad %ae %s' 2019-11-18 yunchao.he@intel.com code refactoring: const color values Created with: gclient setdep -r src/third_party/dawn@e0eeef4b34ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I3b97e5685d84547df0911592fe9c4dc4bf2d17a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920719Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 55f44515. With Chromium commits locally applied on WPT: 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." 6e3e930c "Change `sec-fetch-mode` from `no-cors` to `navigate` for <embed> / <object>." c8b6e1ce "Chromedriver] Fix PerformAction to support multi touch points cases" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id4d7410090549c9fea506d571ad4b2af6ee6b867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916643Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716068}
-
nancy authored
InstanceUpdate's Window method is used to get the pointer of window in OnInstanceUpdate callback. If const, it prevents the operation on the window, e.g window->SetProperty in ui, so remove the const. BUG=1011235 Change-Id: I14deed57307a6dd465f0c0f3cae30c86cce6279e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921008Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716067}
-
Chris Hall authored
R=sammiequon Change-Id: I1ded7b5ca3db14c4593c95e55d0edbc70fb43ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918908 Auto-Submit: Chris Hall <chrishall@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#716066}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ib11628ca0700e5f469d1a575a7bce6c57474d2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921451Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716065}
-
Austin Tankiang authored
This allows the Drive Web interface to talk to DriveFS on Chrome OS via the native messaging api. Bug: 1020954 Change-Id: I450e8ad46cc601e0b0d8df2c19dd4e255f963391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910982 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#716064}
-
Keith Lee authored
Forgot to verify that the API caller had to have knowledge of the contextId when calling finishComposing. (See crrev/c/1885149) The parameter has been added. Change-Id: I47772d67860eae385104a31c1e5a3672a70e9898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916536 Auto-Submit: Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#716063}
-
Hirokazu Honda authored
Add two av1 bitstreams for av1_decoder_unittest. av1-svc-L2T2.ivf has temporal and spatial layers. It is copied from test vectors in libaom project [1]. av1-show_existing_frame.ivf has frames with existing_show_frame=1. It is copied from Timothy's av1 samples [2]. [1] https://aomedia.googlesource.com/aom/+/master/test/test_vectors.cc [2] https://people.xiph.org/~tterribe/av1/samples-all/ Bug: 1000988 Test: media_unittests on chromeos Change-Id: I533fa9e7722182f9fa060ae73e7eff1f3fdb292c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918906Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#716062}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7b1daab931553a9dec6e8cf08515bc210147951b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921331Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a2d2c86d683b..fc2fd0f3b97c git log a2d2c86d683b..fc2fd0f3b97c --date=short --no-merges --format='%ad %ae %s' 2019-11-17 andrewlamb@chromium.org Call options.Freeze in replication_util. Created with: gclient setdep -r src/third_party/chromite@fc2fd0f3b97c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib69fa5e4b3eae8d920704e15dc22a82333e324e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921332Reviewed-by:
-
nancy authored
Different with the App structure, when app window is destroyed or closed, Instance should be deleted. This CL adds kDestroyed status, and when the instance's state is kDestroyed, it is deleted from the 'sum' state. InstanceRegistry's observer should be notified for each updates, not only the latest result, so 'DoOnInstances' is updated: deltas_in_progress_: Save the 'latest' result from 'DoOnInstances', so that 'ForEachInstance' can check the 'latest' result from 'deltas_in_progress_', which is similar with the App structure. So deltas_in_progress_ can't point to the delta, and change the delta's object, as delta is used to keep each updates to notify the user. Therefore, update deltas_in_progress_'s value to the smart pointer, and clone the object for deltas_in_progress_. states_: The same as before, keeps the 'sum' of instances. 'DoOnInstances' checks for every delta, if different with state_, notifies the observer with InstanceUpdate. Unit tests have been updated, and added to test both the Destroy status, and the update logic for each delta. BUG=1011235 Change-Id: I0aec66e5e572eead29955184625204ed6b52c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909668Reviewed-by:
-
Austin Tankiang authored
This is needed to support upcoming work to allow the Drive Web interface to talk to DriveFS on Chrome OS via the native messaging api. A new built-in native message host will be added to bridge the gap between Drive Web and DriveFS, and that message host will need a profile object in order to connect to DriveFS. This profile object will be obtained from the passed in BrowserContext. Bug: 1020954 Change-Id: I0bbd39107e5b0189c2f8f69fcafe488aa7ab57aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905035 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
