- 03 Nov, 2020 40 commits
-
-
Yicheng Li authored
This behavior is approved in UI concept review. So we also remove the cancel button. Bug: b/156258540 Change-Id: I9604d15cb7db7f379c96c692d25bf51d14b2ca10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505443 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823449}
-
Xinghui Lu authored
The Safe Browsing check blocks the URL loader when the URL loader starts to process the response. We'd like to know how often that happens and how long does the Safe Browsing check block the URL loader. Metrics added in this CL: SafeBrowsing.BrowserThrottle.IsCheckCompletedOnProcessResponse SafeBrowsing.BrowserThrottle.TotalDelay Bug: 1144265 Change-Id: I7a14548170458e04fe9452647b347a84780819b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510742 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823448}
-
Thomas Lukaszewicz authored
Bug: 1099917 Change-Id: I66d7495b7c79d80501424c42432f447671442775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514805Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#823447}
-
Josh Nohle authored
CryptAuth v2 DeviceSync is currently rolled out to 65% on stable channel (cl/339923041). According to best practices, the flag should be enabled by default once stable population is at 50% or higher. We also clean up the field trial testing configs for v2 DeviceSync as well as v2 Enrollment which already launched. Bug: 951969 Change-Id: I0b6293000da8f45018984b1ea3cdfc48ed7cd9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515842 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#823446}
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: Ib5ee5262e8dc6bc759dad9eb7737a04e89a0de3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505263 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823445}
-
Yicheng Li authored
This change sets the bounds of the in-session auth dialog according to the parent window bounds and the contents view's preferred size. This also fixes a bug introduced in http://crrev/c/2441963 where the dialog was not shown because no bound was specified and the contents view uses FillLayout. Bug: b/156258540 Change-Id: I30f863ded3eb1a7b6ec20c88a0bb46c1d23cd4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504638 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
-
Bo Majewski authored
In order to avoid conflic with resource names used by Files App, we append _SWA suffix to IDR_FILE_MANAGER_. Both Files App and File SWA use IDR_FILE_MANAGER_ prefix, as they both reside in file_manager directories. Bug: 1113981 Change-Id: I903f9e7eaf2587b13a362b96aa2f75fcecce4439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503992 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#823443}
-
Richard Chui authored
This CL adds a feedback button for users to submit feedback regarding the screen capture feature. This button will only exist for M-88 dog food, and will be removed in M-89. By default, the template is pre-populated with "#ScreenCapture" to allow us to search easily in Listnr/. Included is also some minor refactoring to make capture mode buttons more generic, as well as adding an optional |description_template| parameter to the chrome OpenFeedbackDialog method. Test: manual, added minor test Change-Id: Ie04c30664744187d363765c43b60b955febf0d0a Fixed: 1142948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508402 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#823442}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ie94114cbeb0dea6bffdba4484111236a7e38de0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515092Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823441}
-
mlcui authored
Fixes some typos and clarifies some behaviour. Change-Id: I5fc6383c7390f908bbe8b33e0b883e704461f0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512489Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Michael Cui <mlcui@google.com> Cr-Commit-Position: refs/heads/master@{#823440}
-
Xianzhu Wang authored
This is to workaround under-invalidation of GraphicsLayer property tree state. Bug: 1139839 Change-Id: I8f4540c9d323578f619483e6fe67c3f948c30592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512517Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823439}
-
Michael Hansen authored
This updates the device visibility dialog to add a subtitle and adjust the font weight of the title to match the specs. Screenshot: https://screenshot.googleplex.com/3MnGaYgLuaT4L7H.png Strings spec: https://docs.google.com/document/d/1s-KjC1mM4ZPYeYAO7oI8lXltS_1FaYYfMMnNDdbfRag Bug: b:168841167 Change-Id: Ied28371e97bc196ba051c95d0a8a4ee12b7400c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515144Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#823438}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/888c272811ad..52f3a2ddb18e 2020-11-02 bsheedy@chromium.org [typ] Re-enable ResultSink integration 2020-11-02 dproy@chromium.org Start using polyfill for tracing ui tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111537,chromium:1143021 Tbr: sadrul@google.com Change-Id: I0ca9130e788d2c0ff30fa9ff50dc0bfa00dd6280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515345Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823437}
-
Andrey Kosyakov authored
Originally regressed by https://chromium-review.googlesource.com/c/chromium/src/+/2412799 Bug: 1143221 Change-Id: I8323b97ecf556d6ad27d1b34d1357479bb208843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511749 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823436}
-
Yicheng Li authored
In WebAuthn, we want the in-session auth dialog to be the child of window that initiated the WebAuthn request. To do this, we register the source window with a request_id. The request_id is passed all the way through DBus. When the in-session auth dialog receives the request_id, it validates that there's a corresponding window and uses that window as the parent. Bug: b/156258540 Cq-Depend: chromium:2487542 Change-Id: If0eab5a261a5423f74b3bad1718353184333cd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488360Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#823435}
-
Yu Su authored
0-RTT for idempotent request is enabled here: https://chromium-review.googlesource.com/c/chromium/src/+/2508299 Here an idempotency setter is added in java UrlRequest builder to enable 0-RTT for idempotent request on Android. Change-Id: Ia9a366605f178221438d1c161714d3be1061203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511911 Commit-Queue: Yu Su <yuyansu@google.com> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#823434}
-
Takumi Fujimoto authored
For Cast SDK sessions, a strong VC is made for the cast source's sender ID, and for mirroring sessions, one is made for CastMessageHandler's sender ID. This CL ensures that for mirroring started via Cast SDK, the latter is strongly established. Bug: 1144364, b/172094267 Change-Id: Ibf2eb3dc893d92b8f3de1e1f244354a35ff71e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514673 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#823433}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests and browser_tests. Change-Id: I4936ffc317d1790194aa5de56858a03d7931946d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505395 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604339911-22c5796f1ee7929b52f85640391db819ccf5f295.profdata to chrome-linux-master-1604361545-eddf887b8e48f98791a455ee84436440e457a8ca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I233ab0febd8478e324ac58f98b4aea5b5af30e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515561Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/753c1b336802..5f3f8a08b776 2020-11-03 csmartdalton@google.com Qiet ASAN warnings about ieee float division 2020-11-03 csmartdalton@google.com Fix the grvx_approx_angle_between_vectors test 2020-11-02 tdenniston@google.com [svg] New layer for image filter if one is set 2020-11-02 csmartdalton@google.com Add GrPathUtils::findCubicConvex180Chops 2020-11-02 herb@google.com update build for Apple Silicon 2020-11-02 csmartdalton@google.com Use uint4 instead if int4 in grvx test 2020-11-02 brianosman@google.com Avoid infinite inverse inner-radii in eliiptical rrect op 2020-11-02 bungeman@google.com Declare FontConfig not threadsafe. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1139750 Tbr: bsalomon@google.com Change-Id: I53ea417e54120b0fce5394e2abbc7d9b040d420b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515349Reviewed-by:
-
Xinghui Lu authored
Bug: 1144940 Change-Id: Icbc8084ca209b121388f5910a52b0735681ad1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515207Reviewed-by:
-
Ian Struiksma authored
This gives us better control over win10 version for migrations. In practice, once whole pool is migrated, it won't change anything, but while pool is split makes specific version deterministic. Also changed a small tab indent. Bug: 1124829 Change-Id: I2bfaee767e0ccb2d549ba35256d23770cb79aedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514657Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#823428}
-
Zhenyao Mo authored
It seems minidumps fail to include "reason". My guess is it's due to its if-else-clause local scope. Declare these variables at function level, hoping they will be included in minidumps. BUG=1060785,1077725 TEST=bots R=rafael.cintron@microsoft.com Change-Id: I0a81aee1134c4c69c1d444b6b445b07dc99d9ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515223 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823427}
-
Alex Turner authored
Currently, it is a bit confusing that the function is not static, given its render_frame argument. Additionally, it currently violates the rule against virtual methods in constructors. We add an extra layer of indirection: GetInheritedActivationStateForNewDocument(). This can then be overridden by the test harness without affecting the constructor. Bug: 1134747 Change-Id: I0db55c7fdaaf52992dc23ee9a568f82a22d0161b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495911Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#823426}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68ff27c5daea..bc186f0ead79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1084659,chromium:1142554,chromium:1142775 Tbr: meredithl@google.com,tommycli@google.com Change-Id: I0882d33c1c7d9b783a799f8d2836163e65de58fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515124Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823425}
-
Minju Kim authored
This CL is a precursor of https://crrev.com/c/2419056. Bug: 1126828 Change-Id: I629123a6eae153825355b6b2820ac6ce924f05f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490913 Commit-Queue: MINJU KIM <mkim@igalia.com> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#823424}
-
Dominik Röttsches authored
Also removes exception for web-tests so will now target Win10-18363. These should go together so that the change is atomic. Generated using the rebaseline script generated from failed results in [1] plus blink-tool.py optimize-baselines with tests copied using "Copy test names" from the same page. [1] https://test-results.appspot.com/data/layout_results/Win10_Tests_x64_1909/907/blink_web_tests/layout-test-results/results.html Bug: 1125612,1124829 Change-Id: I1df907d54b7c7a7645ac4b90f4afdb54b85a8ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396138 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Demetrios Papadopoulos authored
Specifically: - Pass "More options" label as a <slot> to cr-expand-button. - Change md-select's aria-label to aria-labeledby This results in better screen reader (VoiceOver) behavior where the label is not read twice when navigating with Ctrl+Alt+RightArrow. Bug: 1055829 Change-Id: I31dadd2e13ca8ce50e75050f0f580b06183bcfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510329 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#823422}
-
Francois Doray authored
Intensive wake up throttling limits wake ups from Javascript timers to 1 per minute for pages that have been backgrounded for 5 minutes. A side-effect of this change is that pages that used to cause frequent extension messages (e.g. navigation commit) now cause extension messages only once per minute. Because extension processes can be terminated after 15 seconds of inactivity, keeping most pages idle for 1-minute intervals *increases* extension process churn (extensions processes that were kept alive permanently by frequent messages are now recreated every minute). This CL adds a feature param to control the inactivity delay to terminate an extension page. We plan to experiment with a 65 seconds delay (slightly longer than the intensive wake up throttling delay) and assess impact on resource consumption (CPU + memory + power). Bug: 1144166 Change-Id: If7b797f375b4ad37c753b8b43e32898e197a91ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510431 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#823421}
-
Nicholas Hollingum authored
Discussed with the DLC team, we're tracking these two FRs from DLCservice, so ive added TODOs in the relevant parts of the code. Bug: b/172284265, b/172279567 Change-Id: If46949016defd403f266d3fb766488089657e7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515804 Auto-Submit: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#823420}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604339911-496ad7cd0b2f151b52bf1dbd6e77aab393c02169.profdata to chrome-mac-master-1604361545-d42c7d02d03a39b634140e180e06bf71d35a67fd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib1305525d98c9698275bae07ba98eb90a25428ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515230Reviewed-by:
-
Raymond Toy authored
The fix for issue 1125635 and 1115901 causes a deadlock because pulling on the audio graph that has a ScriptProcessorNode calls the main thread to do the processing. If the context goes away, the destructor needs tries to get the lock which is being held by the audio thread, waiting for the ScriptProcessorNode to return so the lock can be released. Hence a deadlock. We revert this fix. Local tests indicate that the repro case from 1125635 no longer triggers for whatever reason when it was very reliable before. While the deadlock is gone, this is also a speculative revert for 1125635 and 1115901. Bug: 1136571, 1125635, 1115901 Change-Id: I7de5cd8e764272a7a320c4b89d2c187663f0ff5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514806Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823418}
-
Evan Stade authored
Bug: 790766 Change-Id: I85fe845d3aa8b2584e7bd4877b7d80f1ee5ca3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511878Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#823417}
-
Yue Zhang authored
This CL hides TabStrip IPH when bottom sheet shows and reshows IPH right after bottom sheet hides. This CL is gated by Finch parameter "enable_launch_bug_fix" under flag "enable-tab-grid-layout", with gate function TabUiFeatureUtilities#isLaunchBugFixEnabled. Bug: 1135926 Change-Id: I97c80177b3fabf82aab751c6bf95a1c9b1e27432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506618Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#823416}
-
Daniel Libby authored
It is possible for the scrollable area that is targeted for a scrollbar scroll to have a layout box, but the parent hosting iframe does not. In these cases we should just return a null target since we should not attempt to scroll something that will not be visible. This is really hard to repro outside of using eventSender, since getting code to run between the queuing of a GSB targeted at a scrollable area and the GSB executing happens as the stack unwinds, but fixing this will fix the clusterfuzz test case. R=bokan@chromium.org Bug: 1140886 Change-Id: I65675ac565bb5d860d2b1fd7209a58ff835d27bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511860 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#823415}
-
Daniele Castagna authored
Canvas can have an "image-rendering: pixelated" css property. In those cases, nearest neighbor filter will be used instead of bilinear. Since we don't do nearest neighbor filter when scanning out buffers via HW overlays, this CL simply rejects the HW overlay path in those cases and always falls back to GPU compositing. Test: SingleOverlayOnTopTest.RejectNearestNeighbor Change-Id: I907998f5a23ed2888ff0b3c53b9d7a938164acdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510649Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#823414}
-
Bo Liu authored
Hook up SkiaRenderer to webview's secondary command buffer skia draw context. Introduce SkiaOutputDeviceSecondaryCB for this case. Still need to refactor SkiaOutputSurfaceImplOnGpu. Eg SecondaryCB does not have access to a SkSurface so anything that uses SkSurface needs to be abstracted by SkiaOutputDevice. Also need to refactor draw context submit and swap buffer calls since webview does not call submit itself, and instead gets a callback after android calls submit. Also add a way to get a SkSurfaceCharacterization from SkiaOutputSurfaceDependency, since the SkDDL has to use the exact characterization from the GrVkSecondaryCBDrawContext. Add a check if there is a readback from the root surface. WebView currently does not use this for any production features so should be ok for now. Bug: 1141683 Change-Id: I3a0ad5b0f3a99070ffe773f35ea69d0ba5eca036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513784Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823413}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9396c2b0646a..655afebfcd13 2020-11-02 brucedawson@chromium.org Support autoninja -o/--offline to disable goma If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib0d6b4f15a2386de4554b8c95c1a48eafdcd346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515082Reviewed-by:
-
Shik Chen authored
The seek operation is required for non-fragmented mp4 recording. This CL adds the seek support for the underlying file writers, except the Android intent writer. Bug: 1140852 Test: Pass camera.CCAUIRecordVideo and camera.CCAUIIntent Change-Id: I1e111f9776b1c44905a5de203dbe8c95570ce490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513961Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#823411}
-
Matthew Denton authored
The Network Service previously used concrete net::CertVerifier implementations, but is now switching to use the CertVerifierService. When creating a NetworkContext, a remote to a CertVerifierService needs to be included in the NetworkContextParams. Some unit tests don't do this, which is fixed in this CL in preparation for enabling the CertVerifierService by default. Since there's no need to test cert verification in most of these unit tests, just add a pipe to a fake CertVerifierService that always passes cert verification. Bug: 1015134, 1111472 Change-Id: I378ff0930148bcc229b774c1bec1f7020ce97082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509429Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#823410}
-
