GitLab

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: Ia60a35c3a34147d84d366fad26e6a75f4859b015
Reviewed-on: https://chromium-review.googlesource.com/c/1286099Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#600677}

This reverts commit b90f388e.

Reason for revert: After enabling this in main waterfall following tests keep failing in single_process_mash_interactive_ui_tests:

TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1
LoggedInSpokenFeedbackTest.KeyboardShortcutViewer

Original change's description:
> Run single_process_mash_interactive_ui_tests in main waterfall
>
> It seems this is stable recently with the current filter.
> Let's run under the main waterfall.
>
> BUG=883523
> TEST=none
>
> Change-Id: Ia14281c1e5a276c5057ae7653547086347c3ee0c
> Reviewed-on: https://chromium-review.googlesource.com/c/1285055
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600462}

TBR=mukai@chromium.org,sky@chromium.org

Change-Id: I511a0b6101a5574b154981cd1aaac76c7d5d088f
No-Tree-Checks: true
No-Try: true
Bug: 883523
Reviewed-on: https://chromium-review.googlesource.com/c/1288158
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600676}

BUG=775054

Change-Id: I08746100815d3c7b05f6c181253841942481a629
Reviewed-on: https://chromium-review.googlesource.com/c/1285316
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600675}

Previously the runner script was copying packages to /data when
installing them. On some devices (e.g. VIM2) /data is significantly slower
than /tmp. On VIM2 This change reduces media_unittests installation delay
from more than 45s to less than 5s.

Change-Id: Iea4a25abede1f41b28c7194969eb62286f476bbc
Reviewed-on: https://chromium-review.googlesource.com/c/1284392Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600674}

Looks like this one's really flaky on multiple bots.

TBR=falken@chromium.org

Bug: 896230
Change-Id: I2e2ca10912d7a75ed52e1e668110444fb0817f6c
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1288159
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600673}

IsConnected checks if the anchor node is connected in DOM/FLAT
tree, while IsValidFor check if the position is in the same
document.
HandleGeneralDelete can cause DOM mutation and hence
can move out of the document. Therefore we should use
IsValidFor.
This CL changes IsConnected to IsValidFor to cover
all the scenarios.

Bug: 794282
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I72268bfe1e275e40768aaf7f8e875e20b99f6460
Reviewed-on: https://chromium-review.googlesource.com/c/1286242Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#600672}

This patch changes inline item and block-level replaced handling in
Element#innerText for improving interrop with adding test cases to WPT test
file.

Examples:
 * abc <img> def => "abc  def"; not collapse spaces around <img>
 * <canvas></canvas> abc => " abc"; not collapse space after <canvas>
 * abc <img style="display:block"> def => "abc\ndef"; recognize block with style

This patch also updates of layout test expectations since existing expectations
were produced by Element#innerText with bug fixed by this patch.

Bug: 894701
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I72d7eec3436d0cfa0226b5efa3adbc4c990f06c5
Reviewed-on: https://chromium-review.googlesource.com/c/1277802
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600671}

The primary motivation is to save memory usage. It may
improve memory locallity, but will make reversed-
iteration slower.

This is in company with using one-way linked list for
NGPhysicalFragment in http://crrev.com/c/1284469.

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie17e566d3c66bd4a2f6f1f24e575e7a1494c1639
Reviewed-on: https://chromium-review.googlesource.com/c/1284469
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600670}

Bug: 888904
Change-Id: I5be3ea82fed659cb0fc3ddbe13e308eb9e8c1f38
Reviewed-on: https://chromium-review.googlesource.com/c/1286009
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600669}

This reverts commit b03ffb6b.

Reason for revert: b117901291

Original change's description:
> [VK] Clarify KeyboardUI interface.
> 
> Currently, KeyboardUI has a weird interface where |GetKeyboardWindow|
> will start loading the keyboard web page if it is called the first time.
> So this resulted in a lot of places where we were calling
> GetKeyboardWindow and didn't know whether it would cause a load or not.
> 
> We change the KeyboardUI interface a bit to explicitly state when we
> are creating / loading a keyboard window, vs just getting an already
> loaded one.
> 
> This removes ChromeKeyboardUIWebContent's dependency on
> KeyboardController as well.
> 
> We tried to keep the same behaviour for existing KeyboardUI subclasses.
> 
> Bug: 845780
> Change-Id: I3178c81c382f2c3cd8217eda5a0c9b9d489df5be
> Reviewed-on: https://chromium-review.googlesource.com/c/1264336
> Commit-Queue: Darren Shen <shend@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599772}

TBR=jamescook@chromium.org,stevenjb@chromium.org,shend@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 845780
Change-Id: Ifb9f421d12eccfc0f6208a952025b84df087228b
Reviewed-on: https://chromium-review.googlesource.com/c/1288094
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600668}

This CL fixes the bug that the scroll position is wrong in such cases:
1. Initially there's no notification.
2. Open SystemTray
3. Press CapsLock
4. Bottom position of notification is wrong

TEST=NewUnifiedMessageCenterTest.AddAndRemoveNotification
BUG=769219

Change-Id: I362b2497da1b89c9decca9cca8e8e2d735d1293d
Reviewed-on: https://chromium-review.googlesource.com/c/1286011
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600667}

Change-Id: I276ee26927af91971e8dd54af455ac55c93b8731
Reviewed-on: https://chromium-review.googlesource.com/c/1286131
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600666}

Following bot results are included.
10768 10769 10772 10780 10784 10792 10795

0 lines were removed and 1 lines were deflaked by consecutive
results since 10701.

There seems to be a flake run, which adds several [ Failure
Pass ] lines. They should be cleaned up once stabilized for
two or more days.

Also includes rebaselines of new text/image failures due to
console log changes and document marker changes for the
following tests, by reviewing 10795 test results manually.

  fast/frames/sandboxed-iframe-plugins.html
  http/tests/security/xss-exception.html
  paint/markers/ellipsis-ltr-text-in-ltr-flow-with-markers.html
  paint/markers/ellipsis-ltr-text-in-rtl-flow-with-markers.html
  paint/markers/inline-spelling-markers-hidpi-composited.html
  paint/markers/inline-spelling-markers-hidpi.html
  paint/markers/markers-zoomed.html
  virtual/outofblink-cors-ns/http/tests/security/xss-exception.html

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I711aee2a51548825012f821edbd7da11762cdf8c
Reviewed-on: https://chromium-review.googlesource.com/c/1286107
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600665}

Using wpt-import in Chromium 9e927f2c.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26380

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-scoping

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I20e50ae5fa35ca070d3bea072dfd16caa4a21250
Reviewed-on: https://chromium-review.googlesource.com/c/1287892
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600664}

https://pdfium.googlesource.com/pdfium.git/+log/785a26dc649a..ec885bad72ef


git log 785a26dc649a..ec885bad72ef --date=short --no-merges --format='%ad %ae %s'
2018-10-17 tsepez@chromium.org Remove CPDFSDK_Annot::GetMinWidth() and GetMinHeight().
2018-10-17 tsepez@chromium.org Nest CJS_GlobalData_Element in CJS_GlobalData.
2018-10-17 thestig@chromium.org Optimize appends in CFX_XMLNode::InsertChildNode().
2018-10-17 thestig@chromium.org Add FORM_OnLButtonDoubleClick().
2018-10-17 tsepez@chromium.org Add CPDF_{Array,Dictionary}Locker to catch illegal iteration patterns.


Created with:
  gclient setdep -r src/third_party/pdfium@ec885bad72ef

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:895234
TBR=dsinclair@chromium.org

Change-Id: I3491a433f5e1dbb57578a26fce3394fa69e253ca
Reviewed-on: https://chromium-review.googlesource.com/c/1286085
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600663}

This is a reland of 90b4fddc

Early out from DirectComposition path if it cannot possibly be supported
even if command line flags force it on.  This is needed to make pixel
tests which force enable DirectComposition work on Windows 7/2008 bots.

Original change's description:
> Use DirectComposition only if hardware overlays are supported
>
> Before this change, we were using DirectCompositionSurfaceWin on most
> newer systems, but it's not needed unless hardware overlays are
> supported.
>
> The disable_direct_composition workaround increases crash rates because
> it's applied before GLSurfaceEGL decides to use direct composition with
> ANGLE native EGL surfaces.
>
> This change moves all direct composition logic from GLSurfaceEGL to
> DirectCompositionSurfaceWin, and removes use of direct composition with
> ANGLE surfaces.
>
> Bug: 894675
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I2e9c7c8a7ff36fe7b24868544c03aad0e0b7dad6
> Reviewed-on: https://chromium-review.googlesource.com/c/1278529
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600529}

TBR=zmo@chromium.org,piman@chromium.org,dcheng@chromium.org

Bug: 894675
Change-Id: Ie4322ad2cfceac2156a241b5affbc962dde24088
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1287254Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600662}

Bug: 895970
Change-Id: I2787f9760e9db84b5160823407899361bfef5a37
Reviewed-on: https://chromium-review.googlesource.com/c/1287090Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600661}

1. Blink is no longer a separate repository from Chromium. Update the
   related documentation.

2. State that marking tests for rebaseline must not use platform
   condition

TBR=kbr@chromium.org,sunnyps@chromium.org

Change-Id: Ib101f417a30ea2e2f91973ad4ddddc75e9d62ecc
Reviewed-on: https://chromium-review.googlesource.com/c/1288269Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600660}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08faab99d41b..488362624b6d


git log 08faab99d41b..488362624b6d --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ehmaldonado@chromium.org metrics: Add a mechanism to notify users when we want to collect additional metrics.
2018-10-18 tandrii@chromium.org git cl land: remove Rietveld-only options.
2018-10-18 tandrii@chromium.org Reland "git cl: delete no longer used Rietveld methods."
2018-10-18 ehmaldonado@chromium.org Use lowercase machine architecture.
2018-10-17 jbudorick@chromium.org bot_update: stop failing with a KeyError in the recipe on failure.


Created with:
  gclient setdep -r src/third_party/depot_tools@488362624b6d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:770408,chromium:770408,chromium:895784,chromium:896355
TBR=agable@chromium.org

Change-Id: I0a0fc6c3a5b488b1480c808f4b0d2f5d791cfa38
Reviewed-on: https://chromium-review.googlesource.com/c/1288015Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600659}

Bug: 888904
Change-Id: I4531f45b3b5cc6da3deaae06955a30150e762e36
Reviewed-on: https://chromium-review.googlesource.com/c/1286089Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#600658}

Bug: 892852
Change-Id: Iaca2e20497edb4317c9e628afc398845decca54b
Reviewed-on: https://chromium-review.googlesource.com/c/1266758Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600657}

BUG=chromium:894919
TEST=none

Change-Id: I03c7f9332ca2fcf33e908a3ad42f9651d5406cba
Reviewed-on: https://chromium-review.googlesource.com/c/1279288Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Stephen Barber <smbarber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600656}

This mitigates pixelisation in the Tux logo when rendered in the Crostini
installer.

Bug: 896540
Change-Id: I1f96206701dcfccef4f806a67adbdb5af9f6fa12
Reviewed-on: https://chromium-review.googlesource.com/c/1288109Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600655}

Fix leak in RemoteFontFaceSource where a temporary SimpleFontData
instance was not de-referenced and hence never destroyed.

The leak was introduced by the refactorings made in this commit:
https://chromium-review.googlesource.com/c/chromium/src/+/691475

Change-Id: I6473702a53e83f5fdfbe0fe84ede675c41c5ddad
Reviewed-on: https://chromium-review.googlesource.com/c/1286451Reviewed-by: Anders Ruud <andruud@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600654}

Some a11y related source files were put directly under ash/system
or ash/system/unified while there's ash/system/accessibility.

TEST=trybot pass
BUG=none

Change-Id: I779b7791c582422451d0f8ef1d63ccadc0d40952
Reviewed-on: https://chromium-review.googlesource.com/c/1272918
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600653}

Some pages could perform same-document navigations e.g. push/popState
while we download icon. Since these navigations are still in the same
document it should be safe to ignore them and continue with the
installation.

Changes WebAppIconDownloader to ignore same-document navigations and
continue downloading the icons.

Bug: 889660
Change-Id: I120ba6f38a5aa0a803fa82615cd8bd73412bbb67
Reviewed-on: https://chromium-review.googlesource.com/c/1287330
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600652}

We can detect that they stopped behind our backs (e.g. via crosh commands).

Bug: 896387
Change-Id: I38147f836fce54a34ddb7a792137a007fca145c2
Reviewed-on: https://chromium-review.googlesource.com/c/1288089
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600651}

Add support for /drive/Computers in volume_info and directory_tree,
for displaying a users backed up Computers, if they have any. The
logic here is very similar to the logic for team drives, where we will
only display the '/Computers' entry if there is a sub-directory under
it. Hence a lot of the code is cargo culted from the team drives
implementation.

Potentially come back and refactor the common code between Computers
and Team Drives once this stabilizes.

Bug: 884020
Change-Id: I1ebf52ba64e5cb5bd809b64cc52bf182e3d11f19
Reviewed-on: https://chromium-review.googlesource.com/c/1255084
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600650}

Using wpt-import in Chromium 25073f6c.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26379

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org:
  external/wpt/css/css-conditional

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Id4c12bedcda6324aac7d435cbac41c9514bafc19
Reviewed-on: https://chromium-review.googlesource.com/c/1287436
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600649}

Clears all strikes in a profile's StrikeDatabase when Autofill
data is wiped out from Chrome Settings (chrome://settings ->
Clear Browsing Data -> Advanced -> Autofill Form Data).

Bug: 884817
Change-Id: I15cab8ab6812b1367d386c7bf321be24b1a0086c
Reviewed-on: https://chromium-review.googlesource.com/c/1277842
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600648}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: If9a3f9d7a8b52148f6d39247e712bbe8bc177565
Reviewed-on: https://chromium-review.googlesource.com/c/1287317Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600647}

This reverts commit 1eeaf562.

Reason for revert: The culprit CL is this one here: crrev.com/c/1282517 which is already reverted: crrev.com/c/1287729.


Original change's description:
> Revert "ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_"
> 
> This reverts commit 0ad9fe79.
> 
> Reason for revert: speculative revert, will revert the revert if not a root cause.
> 
> Bunch of Video/file-manager related tests started to fail:
> OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive_DriveFs
> OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads
> VideoPlayerBrowserTest.OpenSingleVideoOnDrive
> VideoPlayerBrowserTest.OpenSingleVideoOnDownloads
> VideoPlayerBrowserTest.ClickControlButtons
> OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads_GuestMode
> VideoPlayerBrowserTestInGuestMode.OpenSingleVideoOnDownloads
> VideoPlayerBrowserTest.CheckInitialElements
> OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive
> 
> Failures:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9115
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9116
> 
> Original change's description:
> > ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_
> > 
> > Appliy ES6 features to the DirectoryModel.onVolumeInfoListUpdated_ and
> > FileManager.setupCurrentDirectory_.
> > 
> > ES6 styles:
> > - Change var to const or let.
> > - Change anonymous functions+bind(this) to arrow functions.
> > 
> > Remove a TODO that linked to a closed bug.
> > 
> > Move comment to be before queue.run() to match the style of the
> > previous lines.
> > 
> > Apply the formatting from git cl format, which is slightly uglier, but
> > at least automatic. :-)
> > 
> > Test: No change in behaviour.
> > Change-Id: I5564263d44f8639d97fc86d7add5a59e8938be6d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1286239
> > Reviewed-by: Joel Hockey <joelhockey@chromium.org>
> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600312}
> 
> TBR=joelhockey@chromium.org,lucmult@chromium.org
> 
> Change-Id: I5f4aa388d2b88c5914c705c71b0fcc70904a42fe
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1288169
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600640}

TBR=kinuko@chromium.org,joelhockey@chromium.org,lucmult@chromium.org

Change-Id: I7ce79f80a47367a2e5547e1bb3d5b227c40e77dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1288091Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600646}

This CL adds 2dip padding between tray icons & fix WiFi icon padding.
WiFi icon is also used in network detailed view, so we have to set the
custom padding by checking IconType.

TEST=manual
BUG=885233

Change-Id: I5848007a1c71af54bba29105bcef7e063f7b6cf0
Reviewed-on: https://chromium-review.googlesource.com/c/1286237
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600645}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/451dc721b571..324e0418e810


git log 451dc721b571..324e0418e810 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ihf@chromium.org chromeos_config: run test on eve-arcnext PFQ.
2018-10-17 bhthompson@google.com Add bvt-inline HW tests to nocturne-paladin


Created with:
  gclient setdep -r src/third_party/chromite@324e0418e810

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I819c58c3eb55d9c1d4c4bc94ff2640b6f193431f
Reviewed-on: https://chromium-review.googlesource.com/c/1288010Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600644}

PWA windows are intended to appear stand alone from the main
browser so they should not adopt the main browser's theme colors.
This CL provides a default theme getter to be used by hosted app
(and PWA) windows.

This CL also removes the quick fix for this issue done by
https://chromium-review.googlesource.com/c/chromium/src/+/1275466.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=363145&signed_aid=TMzuMVlMKC2dm6ppdYp9PQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=363146&signed_aid=Og46P66KeV7iP-mnBHO3cA==&inline=1

Bug: 891560
Change-Id: I2d94bff9f72bfca59fcf7d6cb940f42e4a25cc70
Reviewed-on: https://chromium-review.googlesource.com/c/1272896
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600643}

This reverts commit c4d25f5b.

Reason for revert: This made some tests for Video and Audio players flaky crbug.com/896529

Original change's description:
> Unify JSErrorCounter for Files, Audio, Video and Gallery apps.
>
> Bug: 893430
> Change-Id: I4cb8149eaec9c9ab22700905dae804ac893fdb6c
> Reviewed-on: https://chromium-review.googlesource.com/c/1282517
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600308}

TBR=tapted@chromium.org,noel@chromium.org,lucmult@chromium.org

Change-Id: I676ef1e26b98ff842158501ebf1221520db18bc9
Bug: 896529
Reviewed-on: https://chromium-review.googlesource.com/c/1287729
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600642}

This is similar to https://crrev.com/c/1256384 but for subresource
loading.

Design doc:
https://docs.google.com/document/d/16K2X5k6hUq7lZSee-KXR9FUeSTEEypDXCjYbu_CvkT0/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Bug: 877972
Change-Id: Iba9c82b4de08862699eb1ba318f5710fe0264d86
Reviewed-on: https://chromium-review.googlesource.com/c/1264335
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600641}

This reverts commit 0ad9fe79.

Reason for revert: speculative revert, will revert the revert if not a root cause.

Bunch of Video/file-manager related tests started to fail:
OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive_DriveFs
OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads
VideoPlayerBrowserTest.OpenSingleVideoOnDrive
VideoPlayerBrowserTest.OpenSingleVideoOnDownloads
VideoPlayerBrowserTest.ClickControlButtons
OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads_GuestMode
VideoPlayerBrowserTestInGuestMode.OpenSingleVideoOnDownloads
VideoPlayerBrowserTest.CheckInitialElements
OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive

Failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9115
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9116

Original change's description:
> ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_
> 
> Appliy ES6 features to the DirectoryModel.onVolumeInfoListUpdated_ and
> FileManager.setupCurrentDirectory_.
> 
> ES6 styles:
> - Change var to const or let.
> - Change anonymous functions+bind(this) to arrow functions.
> 
> Remove a TODO that linked to a closed bug.
> 
> Move comment to be before queue.run() to match the style of the
> previous lines.
> 
> Apply the formatting from git cl format, which is slightly uglier, but
> at least automatic. :-)
> 
> Test: No change in behaviour.
> Change-Id: I5564263d44f8639d97fc86d7add5a59e8938be6d
> Reviewed-on: https://chromium-review.googlesource.com/c/1286239
> Reviewed-by: Joel Hockey <joelhockey@chromium.org>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600312}

TBR=joelhockey@chromium.org,lucmult@chromium.org

Change-Id: I5f4aa388d2b88c5914c705c71b0fcc70904a42fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1288169Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600640}

This CL adds sliding out animation to NewMessageListView when
notifications are removed. Animation on removal consists of two stages:
SLIDE_OUT and MOVE_DOWN. Previously, MOVE_DOWN was implemented in
https://crrev.com/c/1280087 .

Video: http://shortn/_HiEcuNpheU

UnifiedMessageListView will replace MessageListView. It's behind a flag:
--enable-features=NewMessageListView

Design doc: go/chrome-popup-refactoring

TEST=UnifiedMessageListViewTest
BUG=769219

Change-Id: I8abe9eedeeb7bd1bcef09e5cb5a072a0ab88fee2
Reviewed-on: https://chromium-review.googlesource.com/c/1282628
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600639}

This CL updates the EME requestMediaKeySystemAccess() stack to support
AV1. For library CDMs, it needs to be signaled during CDM registration.

In the next CL, ClearKeyCdm will be updated to actually support AV1
playback.

TBR=sorin@chromium.org
Windows.

Bug: 884898
Test: Added new test cases. Also manually tested component installer on
Change-Id: I0222136c76682db51bcf021c6bd5db3c467c271e
Reviewed-on: https://chromium-review.googlesource.com/c/1241569
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600638}