- 24 Jul, 2019 40 commits
-
-
Nigel Tao authored
This fixes `sync_integration_tests --enable-features=AppServiceAsh --gtest_filter="TwoClientAppListSyncTest.Install"`. It fails before and passes after this commit. Note that `sync_integration_tests --gtest_filter="TwoClientAppListSyncTest.Install"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: Ieea9177e60e198307dca9fd13b0a8e73681d33d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708692 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#680282}
-
Chih-Yu Huang authored
Originally we didn't keep the ownership of |gpu_task_runner_| when creating VideoDecoder. When we create the second VideoDecoder, this variable will become nullptr. This CL fixes this bug. BUG=chromium:986752 TEST=reload crosvideo.appspot.com and no crash Change-Id: I8abebd44b7423dff0bcb663ae74fdfe7e958e7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714625Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#680281}
-
Takuto Ikuta authored
Bots are added by https://chrome-internal-review.googlesource.com/c/infradata/config/+/1506829 Bug: 954450, 977061, 956776 Change-Id: Ibffe21b019a0bb90f3f28869a7592f630792e3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714305Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680280}
-
Jay Harris authored
This CL is part of the work on file-handling: https://github.com/WICG/file-handling/blob/master/explainer.md After this CL, websites will be able to access files (if any) that they were launched with. This feature is hidden behind two experimental flags: NativeFileSystemAPI and FileHandlingAPI. Bug: 829689 Change-Id: I503afebb7d5ee00eff3bc032245c57966ca34872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672608 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#680279}
-
Ken Buchanan authored
Currently if an authenticator is being added to the BLE device chooser dialog but it is not yet in pairing mode, it will use a generic display name. This CL causes the display name to be updated to the correct device name when the device enters pairing mode. Bug: 906750 Change-Id: Ic86abf9a055746634b64b5e9043fa37640076d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708917Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680278}
-
Martin Kreichgauer authored
This fixes a regression that caused cancelling out of the native Windows WebAuthn UI would show an error dialog, when the request should have just been ended right away. The error dialog in question contained a "retry" button, which was non- functional because it just returned the UI to an empty transport selection UI. Conceptually, we don't want to offer the "retry" button on Windows, because the Windows UI brings its own retry behavior for certain cases (e.g. user touched the wrong security key). Hence, this change also extends the retry logic on ChromeAuthenticatorRequestDelegate to hide retry buttons after dispatching a request to the Windows API. Bug: 985597 Change-Id: Ie02721068c847156222e81f193fd446929ca996f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710741 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#680277}
-
Sunny Sachanandani authored
This reverts commit d332af51. Fixed crash due to missing member var initialization. TEST=ran failing gl_unittests locally Original change's description: > Revert "gpu: Sync to primary monitor's vblank (windows)" > > This reverts commit bd0cae50. > > Reason for revert: Cause failures in DirectCompositionSurfaceTest.* > Builder: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29?limit=200 > First build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29/22377?blamelist=1#overview-tab > > Crash example: > ...snip... > > Original change's description: > > gpu: Sync to primary monitor's vblank (windows) > > > > DWM composition is limited to primary monitor's refresh rate. Prior to > > GPU vsync we would use DWM composition rate to drive begin frames. > > > > With GPU vsync we started using per monitor vblank to limit begin frames > > in case primary monitor had higher refresh rate, but this might be > > causing draw duration and omnibar latency regressions. MS platform team > > also suggested syncing to primary monitor only. In any case the correct > > approach would be to further limit begin frames based on event queries > > from 2 frames back. > > > > This CL makes the GPU vsync begin frames sync to primary monitor, and > > also makes the vsync thread a singleton since it doesn't have per-window > > state any more. > > > > Bug: 953970 > > Change-Id: Id3d3f043cb847172b1d6ba4bd38b087ceb2d8631 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711215 > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#679832} > > TBR=zmo@chromium.org,sunnyps@chromium.org > > Change-Id: If4a762325952dd33283bf41a13321e759de51025 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 953970 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713510 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679915} TBR=zmo@chromium.org,sunnyps@chromium.org,kolos@chromium.org Change-Id: I743026c218932916aba9d9c7722d8343e9fdbdd9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716211 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#680276}
-
Hiroki Nakagawa authored
Bug: 987108 Change-Id: I7a1c2b89a0ed6cfce4d2b9761b0928a1808ebf39 Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715888Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#680275}
-
Aaron Colwell authored
Converting command-line switch that turns on default SiteInstances into a feature flag so that we can turn it on via a Finch experiment. Bug: 958060 Change-Id: I749c9622978a12344a18aca843188a207651754b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710025Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#680274}
-
dpapad authored
The Closure Compiler issue about typedefs in local scopes [1], which forced us to use cr.exportPath() seems to have been fixed. Removing two TODOs in the code referring to this bug, and also updating a few print_preview files as a proof-of-concept. Remaining cr.exportPath() calls will be removed in follow up CLs. [1] https://github.com/google/closure-compiler/issues/544 Bug: 986481 Change-Id: I1799214184b61a507d864e862d955b90d9a0f245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713339 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#680273}
-
Takuto Ikuta authored
Test from this builder consumes less than 1.27(CQ) + 0.27(CI) machine hour in chrome pool from p99 in recent 30 days. I took the stats from http://shortn/_vS3Df0uFD0 Bug: 954450 Change-Id: I626d6448788c6f449dce98c4ed735aa9915c6850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712603Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680272}
-
Jeremy Chinsen authored
Currently PDFiumEngine::GetPageScreenRect() calculates the area of the |page_index| page, including the area around it such as shadows and separators. In two-up view, when two pages are side-by-side and one page is shorter than the other, the space below the shorter page must be drawn as empty space to match the height of the taller page. This CL refactors PDFiumEngine::GetPageScreenRect() so that when |two_up_view_| is true, it calls draw_utils::GetSurroundingRect() with a copy of the rect for |page_index| page with its height set to the max height of the two pages. It also adds PDFiumEngine::GetAdjacentPageIndexForTwoUpView() which retrieves the index of the page adjacent to the current page. Bug: 51472 Change-Id: I869903f869e926117cd60beb92db0ce96606579a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715116 Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#680271}
-
Malay Keshav authored
Lottie player needs to set a size on the canvas it draws on. To do this the size needs to be provided by the client and set by the worker. Bug: 986954 Change-Id: I3c30885ed0e1e038def113bba427cff6b0b452a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716025 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#680270}
-
Timothy Loh authored
When the Plugin VM has shut down (either via the shelf context menu or from within the VM itself), we should close the window. Also update the tests to always create a ChromeLauncherController so we don't have to handle the null case, which doesn't happen otherwise. Bug: b:134714407 Change-Id: I00dd36c8f61ca6187e118cdbd63ba89d6e357fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688465Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680269}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. NOTRY=true Bug: 977050 Change-Id: I3fef367cfa4a2abb2e5b2f4766ea592ccb8abfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700845Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680268}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. NOPRESUBMIT=true NOTRY=true Bug: 977050 Change-Id: I4d4e552151fcf1803da1153582af3067f9ff9d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700917 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680267}
-
Alexander Alekseev authored
Bug: 975778 Change-Id: Idfba9b707ff815568553cb8d510b99f697764095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710864Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#680266}
-
Hiroki Nakagawa authored
This test and its virtual variants time out not only on Linux but also on Win and Mac. Bug: 986019 Change-Id: I23db9a8d87bffd903f0d5f59cb9fc77f51373ce0 Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715066Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#680265}
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Bug: 968369 Change-Id: I363473451e610c62c2758f6477a51fddeea50929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714195Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#680264}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. NOPRESUBMIT=true NOTRY=true Bug: 977050 Change-Id: Ic878becb6fb504509d91bd99a4c5279c806a833f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699952Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680263}
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Bug: 968369 Change-Id: I0c346feaba300b719fd9ba6e93a9d96ec904e7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714544Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#680262}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. NOPRESUBMIT=true NOTRY=true Bug: 977050 Change-Id: I1a178dd327f0f40c16a4fd6fe9883f8c0c60f7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700937Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680261}
-
Mustafa Emre Acer authored
This CL is effectively a revert of crrev.com/c/1526806. That commit changed the implementation of the lookalike URL navigation throttle to observe WillStartRequest() instead of WillProcessResponse. As a result, the throttle was no longer able to see the redirect chain and did not have a way of allowing certain safe redirects such as elespañol[.]com to elespanol[.]com. This CL goes back to using WillProcesResponse(). Doing this gives WillRedirectRequest() a chance to run and lets the throttle observe the redirect chain. Follow up CLs will allow safe redirects. Bug: 986404 Change-Id: I9b41b9b2c29e12120a0ecb2af6c50d283e915458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713445Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#680260}
-
Jeremy Chinsen authored
Currently PDFiumEngine::FillPageSides() only handles single-up view. For two-up view, FillPageSides() needs to use different inset sizes and not draw certain empty spaces on the sides based on the page’s position in the document. This CL adds logic to determine the proper configuration of inset sizes in FillPageSides(), given the current value of |two_up_view_| and the position of the page in the document. It also prevents the left empty space to be drawn if the page is on the right in two-up view. These two changes allow FillPageSides() to properly draw the empty space around pages in both single-view and two-up view. Bug: 51472 Change-Id: Id233493580e80e1415baa137751cc4d35d76a30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714298Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#680259}
-
Alexander Alekseev authored
Bug: 975463 Change-Id: Ief8805a642a4326dd476ffef84f80d53f4832c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713602Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#680258}
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Bug: 968369 Change-Id: I5350026e7cb705765f3d886a3d4bf10154459aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704636 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#680257}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. NOPRESUBMIT=true NOTRY=true Bug: 977050 Change-Id: Id5048dc293a43b0fb0a56cefe71cfcf27843eae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700940Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680256}
-
Ben Kelly authored
When determining the quota size of cache_storage we would prefer to use the value stored in the index file. This reduces the number of files we need to open and read. We can't use the index value, though, if the index file is stale compared to the data stored in cache_storage. Unfortunately, previous code had a bug that would always consider the index file as stale. It only permitted the index file to be used if the index file's modified time was newer than the modified time of its containing directory. This was an impossible condition to meet, however, because the directory will have the same time or newer than its contents. This CL allows us to use the index file value if it has the same time as its containing directory under certain conditions. Specifically, the index file must also be newer than all cache directories referenced from the index. Bug: 986474 Change-Id: I11bba1edbf78f9cc99f62823f370842c5f291bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712951Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#680255}
-
Steven Bennetts authored
connectionState is gauranteed to be defined in the mojo NetworkState object. Bug: 980659 Change-Id: I6d9022f2e3a6e5517b2748f920a694092a867da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716101 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680254}
-
Eric Foo authored
This reverts commit 63f7fa4c. Reason for revert: PRESUBMIT was being too restrictive and has been updated to allow more than one team per component. Issue fixed. Relanding OWNERS updates. Previously reviewed. Marking TBRs. TBR=charleszhao@chromium.org,primiano@chromium.org,noyau@chromium.org NOPRESUBMIT=true NOTRY=true Original change's description: > Revert "OWNERS files updated with latest COMPONENT and TEAMS." > > This reverts commit 66a1d6a3. > > Reason for revert: "Component UI>Browser>ReaderMode has more than one team assigned to it" > > Original change's description: > > OWNERS files updated with latest COMPONENT and TEAMS. > > > > This is CL is generated by a script. Data is pulled from > > review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 > > for context. > > > > Please review and LGTM before July 16th or the CL will be > > submitted as-is. > > > > TBR=charleszhao@chromium.org, noyau@chromium.org, primiano@chromium.org > > NOTRY=true > > NOPRESUBMIT=true > > > > Bug: 977050 > > Change-Id: Ibfc0305b31607fc9f379be337d4b5e310f094759 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699955 > > Reviewed-by: Charles . <charleszhao@chromium.org> > > Reviewed-by: Eric Noyau <noyau@chromium.org> > > Commit-Queue: Eric Foo <efoo@chromium.org> > > Auto-Submit: Eric Foo <efoo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#678081} > > TBR=primiano@chromium.org,noyau@chromium.org,efoo@chromium.org,charleszhao@chromium.org > > Change-Id: I4ec493de9747c0eb9a160014cd70284ebe8007e4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 977050 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704762 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678196} TBR=primiano@chromium.org,noyau@chromium.org,grt@chromium.org,efoo@chromium.org,charleszhao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 977050 Change-Id: Ibbc4ed432746d3fd205ff78f7e35216291244327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715726 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680253}
-
Eric Foo authored
This reverts commit 7e815ef5. Reason for revert: PRESUBMIT was being too restrictive and has been updated to allow more than one team per component. Issue fixed. Relanding OWNERS updates. Previously reviewed. Marking TBRs. TBR=rockot@google.com NOPRESUBMIT=true NOTRY=true Original change's description: > Revert "OWNERS files updated with latest COMPONENT and TEAMS." > > This reverts commit af947a0a. > > Reason for revert: "Component Platform>Extensions has more than one team assigned to it" > > Original change's description: > > OWNERS files updated with latest COMPONENT and TEAMS. > > > > This is CL is generated by a script. Data is pulled from > > review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 > > for context. > > > > Please review and LGTM before July 16th or the CL will be > > submitted as-is. > > > > NOPRESUBMIT=true > > NOTRY=true > > > > Bug: 977050 > > Change-Id: Ic5ac6a7ab17c5e7c80e2683007aab4142ad315ce > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700847 > > Reviewed-by: Ken Rockot <rockot@google.com> > > Commit-Queue: Eric Foo <efoo@chromium.org> > > Auto-Submit: Eric Foo <efoo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#678086} > > TBR=rockot@google.com,efoo@chromium.org > > Change-Id: I320372ea0958a9cc1fde2d5ab5a7dcf805782d57 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 977050 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705894 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678195} TBR=rockot@google.com,grt@chromium.org,efoo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 977050 Change-Id: I4005a4f59af1d732d11fa535534e7be6a1bfc899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715330 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680252}
-
Eric Foo authored
This is a reland of 2f3a0754 Issue fixed. PRESUBMIT was being too restrictive and has been updated to allow more than one team per component. Relanding OWNERS updates. Previously reviewed. Marking TBRs. TBR=dominickn@chromium.org, piman@chromium.org, bashi@chromium.org NOPRESUBMIT=true NOTRY=true Original change's description: > OWNERS files updated with latest COMPONENT and TEAMS. > > This is CL is generated by a script. Data is pulled from > review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 > for context. > > Please review and LGTM before July 16th or the CL will be > submitted as-is. > > NOPRESUBMIT=true > NOTRY=true > > Bug: 977050 > Change-Id: Ie693cf330e2888ad0a2fb5c57edd095fa516d748 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700846 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Commit-Queue: Eric Foo <efoo@chromium.org> > Auto-Submit: Eric Foo <efoo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678126} Bug: 977050 Change-Id: I35ac2bf6db845b76f8998694e457ba2fcb02dc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716246 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680251}
-
Eric Foo authored
This is a reland of 049f59df Issue fixed. PRESUBMIT was being too restrictive and has been updated to allow more than one team per component. Relanding OWNERS updates. Previously reviewed. Marking TBRs. TBR=yfriedman@chromium.org, tdresser@chromium.org, dvadym@chromium.org NOPRESUBMIT=true NOTRY=true Original change's description: > OWNERS files updated with latest COMPONENT and TEAMS. > > This is CL is generated by a script. Data is pulled from > review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 > for context. > > Please review and LGTM before July 16th or the CL will be > submitted as-is. > > NOPRESUBMIT=true > NOTRY=true > > Bug: 977050 > Change-Id: I0cf30f71d35944216370adc5ac4a3732c474da62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700918 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Eric Foo <efoo@chromium.org> > Auto-Submit: Eric Foo <efoo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678132} Bug: 977050 Change-Id: I36295acb3296d8e13e2c4fb8876dc59eb5666adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716028Reviewed-by:
Eric Foo <efoo@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680250}
-
Eric Foo authored
This reverts commit 2fef847e. Reason for revert: PRESUBMIT was being too restrictive and has been updated to allow more than one team per component. Relanding OWNERS updates. Previously reviewed and LGTM'ed. Marking TBRs. TBR=vasilii@chromium.org NOPRESUBMIT=true NOTRY=true Original change's description: > Revert "OWNERS files updated with latest COMPONENT and TEAMS." > > This reverts commit 737c7516. > > Reason for revert: "Component Build has more than one team assigned to it". Please stop landing these changes with NOPRESUBMIT and NOTRY. > > Original change's description: > > OWNERS files updated with latest COMPONENT and TEAMS. > > > > This is CL is generated by a script. Data is pulled from > > review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 > > for context. > > > > Please review and LGTM before July 16th or the CL will be > > submitted as-is. > > > > NOPRESUBMIT=true > > NOTRY=true > > > > Bug: 977050 > > Change-Id: I14505944f394fd960e1f5cf5e035507ebc7422a6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700839 > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Commit-Queue: Eric Foo <efoo@chromium.org> > > Auto-Submit: Eric Foo <efoo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#678134} > > TBR=vasilii@chromium.org,efoo@chromium.org > > Change-Id: I57d8464b873d0aed3f8f4660908a4cfa492be762 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 977050 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705931 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678192} TBR=vasilii@chromium.org,grt@chromium.org,efoo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 977050 Change-Id: Id7264e12f9575621f2e26d9103e9fdcafb53f9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715117 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680249}
-
Rob Schonberger authored
This adds a palm detection filter that interacts with the concept of "held" items. The filters will be used in TouchEventConverterEvdev to either hold or cancel touches, in addition to the behavior from device firmware. The two implementations are: 1. An always "open" detection, that doesn't mark anything to hold/cancel. 2. A simple heuristic that is based on interaction with stylus touches. Both implementations have unit tests that cover 100% of the code. Bug: 982118 Change-Id: I9f50b98be434ba5c767d9392c0a470262cf5e603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708148Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#680248}
-
Eric Foo authored
Updated component to Chromecast as per comment in CL: https://chromium-review.googlesource.com/c/chromium/src/+/1700938 TBR=mfoltz@chromium.org NOPRESUBMIT=true Bug: 977050 Change-Id: Ib3b13bae8ccd71f301f7817bb0978fb8e1d2c32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716031 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680247}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. TBR=jyasskin@chromium.org, lmattm@chromium.org NOPRESUBMIT=true NOTRY=true Bug: 977050 Change-Id: Ie9bc3a7f21d427c02bf3d1f0664b73d9496b8ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700935 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680246}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. TBR=pwnall@chromium.org NOPRESUBMIT=true NOTRY=true Bug: 977050 Change-Id: I685349ba05edbbed089cbe2ce3ba60d7f3e8ad30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699953Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680245}
-
Sarthak Shah authored
This CL adds a histogram that tracks the difference in input event timestamp based on TimeTicks::Now and timestamp reported via PerformanceCount. It will help analyze the distribution of how far negative or positive TimeTicks::Now is compared to PerformanceCount. This will help guide a decision on what timestamp to use in the future for velocity calculation, input prediction, and gesture recognition. For additional context, please see discussion at input-dev https://groups.google.com/a/chromium.org/forum/#!topic/input-dev/KZMZ6dnzKZQ Change-Id: I20dfee67b0ff959edcb0a81c551675f61b2549a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666298 Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#680244}
-
Hesen Zhang authored
- Start working on all mock objects for scheduler. - Moved this class under scheduler/tests. Bug: 963304 Change-Id: I72ea3ed88028681acde31e4c80bfa8f095b22a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716088 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680243}
-