- 08 Apr, 2020 40 commits
-
-
Nnamdi Theodore Johnson-Kanu authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/2128928 changed the route path name and route constant from kAccessibilitySubPage to kOsAccessibilitySubPage. This change caused the settings tray to not route to the appropriate location. This CL corrects that issue, updating the system_tray_client.cc to point to the right constant name. Bug: 1068971 Change-Id: Ia42ce2d197eb04a4a8a2076defdfd84c81485b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142142Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#757538}
-
Changwan Ryu authored
Currently <input type='password' inputmode='numeric'> shows normal password type virtual keyboard. With this change, it will show numeric password type keyboard. Bug: 1068182 Change-Id: I04f85ff240678b3f8854a84ad9227e1437b3300d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139355 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757537}
-
Mei Liang authored
This CL update tab selection indicator to match the boundary of the card. Change-Id: I41ecdf19ddee921b4fcb85c2fa1d715bdd0860aa Bug: 1042890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140190Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757536}
-
Sinan Sahin authored
Bug: 1068346 Change-Id: Ied07d2d4b0e181a886ece94ad4a763c8ec9d7cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137855Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#757535}
-
Haiyang Pan authored
Bug: 922145 Change-Id: I08d3a9cc3dda9fe4673399c27d07a41d4eeadcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138791 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757534}
-
Aaron Leventhal authored
Bug: None Change-Id: Ie2c29aff27cf942fcbb240294c5baa305ce2577c Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141143Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757533}
-
Oksana Zhuravlova authored
This change removes ContentBrowserClient::BindInterfaceRequestFromFrame since it's no longer used. Bug: 1062403 Change-Id: I010f7fedc22d95517c265140ba56d8dd98633694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134802Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757532}
-
Esmael El-Moslimany authored
Depending on what has focus, mousedown event may not be emitted when a user touches an element. Elements should handle the pointerdown event instead. Change-Id: I255812428698be93b547869f6b2674ad6f86047a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141201 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757531}
-
Pavel Yatsuk authored
Set animation duration to 0 to disable toolbar animations triggered by displaying tab modal dialogs. BUG=1026908 R=twellington@chromium.org Change-Id: Idcc1fe2fc85f8ccccc3dad72a65da886e89fe9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138556Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#757530}
-
Amr Aboelkher authored
Shell-encryption is a simple Homomorphic Encryption Library that uses Ring Learning with Errors (RLWE)-based encryption. This CL does the following: - Adds the required dependent files for the library, to be compiled successfully in chromium - Migrating the library to be compatible with C++14. That was needed as chromium only supports C++14, and the library was Compatible with C++17 - Overrides the include_rules section for SHELL - Adds SHELL lib as a client for abseil-cpp -- Locking the visibility of the library - Remove the possibility of adding SHELL directly from chromium - Adds the owners of the library - Adds README.chromium -- Include explanation about the library -- Include info about updating the library Change-Id: Ibe6117303bd77dfccb7320184960cbe6d9360c9c Bug: 1066937 TBR=thakis Change-Id: Ibe6117303bd77dfccb7320184960cbe6d9360c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106138Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#757529}
-
Gyuyoung Kim authored
This CL moves stretched-simplified-layout.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to abspos-descendent-001.html because it seems like it's a better naming for this test. Bug: 1063749 Change-Id: Ifa4a49ef007edfdd3c30cab3d176696e72b445e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132549 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757528}
-
John Smith authored
This cleans up the double mapping for kColorId_DialogBackground in the color pipeline as well as adds a new kColorId explicitly for button. The new colorid is hooked up as appropriate for button cases and returns the same colors as it did with DialogBackground. Having it be separate would be helpful for cases like high contrast where the button may need greater differentiation from the background and for any downstream consumers who use a different color even in regular modes. Bug: 1067359 Change-Id: I966bb0446c85ba08d8fe9d844544ccd06aff7b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135385Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: John Smith <johnsm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757527}
-
danakj authored
This method is used in the renderer and doesn't need the hole punching to content-internal that web_test_support_renderer was designed for. Move it to web_test/blink_test_helpers.h. R=nasko@chromium.org Bug: 866140 Change-Id: I62f16e813b5eae8aa7b117c992f072b65ebf8be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142512Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#757526}
-
Wei-Yin Chen (陳威尹) authored
The browser customization content provider package is required to be a system package for security. On local builds of Chrome Android, this requirement is lifted for easier debugging. This doesn't affect end users. Bug: None Change-Id: I7aa05fa9d71cbe1e15ae76adce9c579a41d876d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139078 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757525}
-
Reilly Grant authored
This change adds basic support for composite devices to the new Windows USB backend. The set of device paths for each function driver are collected into a map which can be used instead of the root device path when trying to open a WinUSB interface handle. As with the previous patch this still won't work for devices the are enumerated while Chrome is running because the device nodes for each USB function are not yet available. This will be addressed next. Bug: 637404 Change-Id: Ifbda29ef3cbe4dda2adb25fe8454dcc2a7c2036b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138260 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757524}
-
Anqing Zhao authored
Because of the re-org of Chrome OS Commercial team, the reviewers of DeviceLocalAccount have to be changed accordingly. Change-Id: I4702708d641172f4288e28785d6658fda12e7a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141978Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#757523}
-
Aran Gilman authored
This mostly entails the following: * Replace empty constructors & destructors with '= default'. * Replace deprecated DISALLOW_COPY_AND_ASSIGN() with explicit deletions. * Use for-each loops where appropriate. Change-Id: I379c6d4573a529264cc1541e8d157f0b556e5505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128093Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#757522}
-
Jerome Jiang authored
https://aomedia.googlesource.com/aom.git/+log/c25910f6d213..611c58e51104 $ git log c25910f6d..611c58e51 --date=short --no-merges --format='%ad %ae %s' 2020-04-03 chiyotsai Remove an unneeded skip in skip_repeated_newmv 2020-04-03 jzern transpose_sse2.h,cosmetics: fix some comments 2020-04-02 ravi.chaudhary Optimize PC_TREE for lower resolution contents 2020-04-03 vishesh.garg Refactor GlobalMotionInfo from AV1_COMP 2020-04-06 vishesh.garg Refactor ForceIntegerMVInfo from AV1_COMP 2020-04-06 huisu Cleanup and documentation for inter_block_yrd() 2020-04-06 huisu Cleanup / commnets for tx_type_rd and tx_block_rd 2020-04-05 huisu Code improvement in try_tx_block_split() 2020-04-02 yaowu Remove an obsolete TODO 2020-04-02 yjshen Adjust a hyper-parameter used in temporal filter. (...) 2020-02-28 sdeng Use downsized frame in VMAF RDO update 2020-03-18 huisu code cleanup in init_ref_frame_space() 2020-03-19 ravi.chaudhary Cleanup variables in cpi 2020-03-04 jianj RT: Handle variance low flag properly for superblock 64x64 2020-03-16 marpan rtc: Fix to skip mv mode in nonrd_pickmode 2020-02-17 remya.prakasan Clean up hash me code 2020-03-17 jayasanker.j Prune AB partitions based on split and HORZ/VERT 2020-03-16 huisu small optimization in av1_handle_inter_intra_mode() 2020-02-25 mufaddal.chakera Refactor kf and gfu boost calculation in LAP 2020-03-11 mufaddal.chakera Refactor av1_lookahead_init Created with: roll-dep src/third_party/libaom/source/libaom R=jzern@google.com Change-Id: I9ed6250208a60578d2f1b34eed425a90ac393b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140625Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#757521}
-
Frank Liberato authored
Allow video decoders to attach HDR metadata in addition to color space information to a VideoFrame. This will help us to defer tone mapping until later in the display pipeline. Bug: 1068321 Change-Id: I686159905657979d5b6c9fe280c2991e37feeeb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137918 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757520}
-
Anqing Zhao authored
This extension needn't trigger the full-screen warning notification in MGS session. Bug: 1063236 Change-Id: I3cd1f5973d5d265e5aff02627dbc921534f4423b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138412Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#757519}
-
Thomas Tellier authored
Bug: 993653 Change-Id: Icf3cdb322223487a6780a5f20a3c22f9ed22ca5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133972 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#757518}
-
Ben Pastene authored
Due to emergency server maintenance in crbug.com/1069091, we need all tests to not be deduplicated into tests that ran prior to the maintenance. Adding a trivial change to //testing/test_env.py will prevent any task deduplication since most every test includes this file in its inputs. TBR=johnchen No-Try: true No-Tree-Checks: true Bug: 1069091 Change-Id: If99af96b6bce7b00cd982de0234b39dbb9a9ec89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142619 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#757517}
-
sreejakshetty@chromium.org authored
This CL converts UsbTabHelper to use RenderDocumentHostUserData and replaces existing manual tracking of frame lifetime in a map. Currently a map from render_frame_host to the FrameUsbServices is maintained to get the associated FrameUsbServices object instead we use RDHUD to do the same set of operations. BUG = 1068546 TBR=fdoray@chromium.org,reillyg@chromium.org,altimin@chromium.org, haraken@chromium.org Change-Id: I05dc172e511f6b4752a1c138ee3d0cecbb6858ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139814Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#757516}
-
Nathaniel Steinbock authored
Merge-with: eureka-internal/384313 Bug: internal/153204109 Change-Id: Ia56c4c148470fc0f76b73f30a843bdc8bdb39506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135832Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Nate Steinbock <steinbock@google.com> Cr-Commit-Position: refs/heads/master@{#757515}
-
David Van Cleve authored
As part of accommodating requests with Trust Tokens [*] parameters present, a previous CL (https://crrev.com/c/2062869) added a trust token helper argument to URLLoader. Whenever URLLoader was provided a trust token helper, it would call out to the helper before sending its request and after receiving response headers. The previous CL did not include a mechanism for actually giving URLLoader a trust token helper outside of tests. This CL adds logic to construct trust token helpers for requests bearing Trust Tokens parameters, by: - implementing a new factory class, TrustTokenRequestHelperFactory, responsible for making a decision of which TrustTokenRequestHelper to vend (or whether to fail with an error); - modifying URLLoader to take one of these factories instead of a TrustTokenRequestHelper proper, and to use the factory to create a helper when given a request bearing trust token parameters (still calling the helper's Begin/Finalize methods at the same time as before); and - having URLLoaderFactory give created loaders a TrustTokenRequestHelperFactory, when requests bear trust token params. (For now, the helper factory will always return an error, because the underlying Trust Tokens operations are not yet fully implemented.) [*]: https://docs.google.com/document/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit Bug: 1042962 Change-Id: I53743999ff301a832e6a929292d0fb8f0e7df424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097057 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#757514}
-
Ryan Harrison authored
Roll src/third_party/shaderc/src/ 4e3bbd9c5..802636496 (1 commit) https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/4e3bbd9c5f1a..8026364968ac $ git log 4e3bbd9c5..802636496 --date=short --no-merges --format='%ad %ae %s' 2020-04-07 rharrison Add concept of comparison sampler to API (#1036) Roll src/third_party/spirv-cross/spirv-cross/ e58e8d5db..a1d9b474b (6 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/e58e8d5dbe03..a1d9b474b5ca $ git log e58e8d5db..a1d9b474b --date=short --no-merges --format='%ad %ae %s' 2020-04-07 post MSL: Do not use base expression with PhysicalTypeID OpCompositeExtract. 2020-04-03 post Expose a query if samplers or images are comparison resources. 2020-04-03 post Do not add NonWritable/NonReadable decorations for regular images. 2020-04-03 post MSL: Deal with cases where builtin is implicitly needed, declared, but unused. 2020-04-03 post HLSL: Add support for treating NonWritable UAV texture as SRV instead. 2020-04-03 troughton MSL: mark BuiltInFragCoord as implicitly used for subpass reads Created with: roll-dep src/third_party/shaderc/src src/third_party/spirv-cross/spirv-cross BUG=dawn:367 Change-Id: I02882bc2910b5b8f396af72605813ee20ddaff8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141206 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#757513}
-
Darwin Huang authored
Mark PointerLockBrowserTest.PointerLockEventRouting as flaky on Linux. TBR=lfg@chromium.org, gab@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766450 Change-Id: I1932e553b3ae1644241a4e8c8676b121e5710b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142330Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757512}
-
Wei-Yin Chen (陳威尹) authored
Move Finch parameter "tab_switcher_on_return_time_ms" to a more suitable class. Bug: None Change-Id: I1b7b7dba72d2a2d646ba6c1f89e6dc8107c65538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139374 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#757511}
-
Chris Sharp authored
TBR=sebmarchand@chromium.org Bug: 1069043 Change-Id: Icc0aec1af963580139869c86f1d9ff886d387087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142038Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#757510}
-
Dominique Fauteux-Chapleau authored
Bug: 1065880 Change-Id: Ieb3264606cb1188c08e085328ab4e69bd64f3840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132030Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757509}
-
Ted Meyer authored
And, as a use case, logs failure reason for decoders when they can't be initialized. This currently just dumps the status as JSON into the media log. I've not implemented a frontend for this in devtools yet. Change-Id: I3aea5f027078e3f2979eaeeebc08549aa8a393a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141622Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#757508}
-
inglorion authored
tools/clang/scripts/goma_link_tests.py was originally written to work with both Python 2 and Python 3. I intend to add some unit tests that will use unittest.mock, which is not part of Python < 3.3. Instead of complicated workarounds, let's just a modern Python version for the tests. Bug: 877722 Change-Id: I475091b005e1f2e4b804e1c884d255ff60669847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140598Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#757507}
-
Nasko Oskov authored
This test has been disabled on Windows as flaky. Running locally 100 iterations of the test passed successfully, so this CL enables it. Bug: 662160 Change-Id: I21d192e02b157c35cb95e9aa6f5ad40425d16ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141135 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#757506}
-
Corentin Wallez authored
The GN targets have moved in Dawn and the former names are groups that proxy to the name path. Change the paths in Chromium so that the proxy groups can be removed in Dawn. Bug: chromium:1064305 Change-Id: I75abda829d8677699bc0165d2fd27c4466a815cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142213Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757505}
-
David Bokan authored
This is now all dead code, from the ill-fated "touchless" project. This CL is a manual revert of the following CLs: https://crrev.com/c/1490195: Add feature flag for Fallback Cursor Mode https://crrev.com/c/1504845: Add event handler for cursor fallback mode https://crrev.com/c/1517155: Pumping Android cursor visibility state https://crrev.com/c/1515636: Add Tab observer for TouchlessEventHandler https://crrev.com/c/1525468: Mouse event handling for fallback cursor mode https://crrev.com/c/1525353: Call platform API for fallback cursor mode. https://crrev.com/c/1533259: Pumping Fallback Cursor Mode state to render https://crrev.com/c/1532538: Add spatnav back key event handling Bug: 1062457 Change-Id: I3feb32ded7ffcf4ef01bb226873c24a57152967c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108183Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757504}
-
Katie D authored
When a user bookmarks a Reader Mode page, we want to bookmark the original instead. Add page title to Reader Mode URLs so that the bookmark_utils::GetURLAndTitleToBookmark can determine it. This makes page title a required parameter to build a Reader Mode URL. Bug: 1066165 Change-Id: Iff8e0eb421946a36516262425da79190c2dbe037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128930Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#757503}
-
Greg Thompson authored
The multi-install support was deactivated in 2017 but there were still many remnants remaining in the Chromium code base. These remnants have been a source of friction for changes being made in the install and update infrastructure. Some additional house-keeping is included by reviewer request. TBR=rsesek@chromium.org NOTRY=TRUE Bug: 1067489 Change-Id: I75d6f633a5ec2132470e3c88fd64c9d080e5c58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135203Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757502}
-
Daniel Libby authored
We've seen a number of bug reports in Edge of the mouse cursor not showing. There doesn't seem to be much tracing in the area, so adding a few trace events to try and help narrow this down.s Change-Id: I18c01a3847ae1d4cc16c36c9be3a5b9216b65e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140600Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757501}
-
Rohit Rao authored
Breakpad has a 255-byte limit on the size of a single value, but will internally split values up to 10 ways to stay under that limit. Breadcrumbs has similar, redundant functionality, so this CL disables it by increasing the maximum allowed value size. BUG=1068802 Change-Id: Ibb668f7270d6f48fb62844de88789f528b323bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139996Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757500}
-
chrome://discardsSigurdur Asgeirsson authored
Change-Id: I9d984924273755bf0b13a03642af117b99dbbd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142037 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#757499}
-