GitLab

        Unreviewed, rebaseline Chromium Win tests after r83075.

        * platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
        * platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@83093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/qt/editing/pasteboard/paste-text-011-expected.checksum:
* platform/qt/editing/pasteboard/paste-text-011-expected.png:
* platform/qt/editing/pasteboard/paste-text-011-expected.txt:
* platform/qt/fast/css-generated-content/014-expected.checksum:
* platform/qt/fast/css-generated-content/014-expected.png:
* platform/qt/fast/css-generated-content/014-expected.txt:
* platform/qt/fast/css/word-space-extra-expected.checksum:
* platform/qt/fast/css/word-space-extra-expected.png:
* platform/qt/fast/css/word-space-extra-expected.txt:
* platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2123-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug2123-expected.png:
* platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4523-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug4523-expected.png:
* platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
* platform/qt/tables/mozilla/core/bloomberg-expected.checksum:
* platform/qt/tables/mozilla/core/bloomberg-expected.png:
* platform/qt/tables/mozilla/core/bloomberg-expected.txt:
* platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WK2 icon database should be able to get a CGImage of a specific size

Reviewed by Anders Carlsson.

../WebCore: 

* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
(WebCore::Image::getFirstCGImageRefOfSize):
        
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getFirstCGImageRefOfSize): Walk the frames of the image until reaching the
  first frame of the requested size.

../WebKit2: 

* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryGetCGImageForURL): Change this API to take a requested size, and find the first matching
  CGImage in the icon.
* UIProcess/API/C/cg/WKIconDatabaseCG.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@83091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[wx] Fix cursor handling so that we always call the chrome to set it.
        
https://bugs.webkit.org/show_bug.cgi?id=57972


git-svn-id: svn://svn.chromium.org/blink/trunk@83090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, mark Chromium expectations for line-clamp.html to be a known regression.
        https://bugs.webkit.org/show_bug.cgi?id=57975

        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        [chromium] Add settings API to enable accelerated drawing
        https://bugs.webkit.org/show_bug.cgi?id=57863

        If accelerated drawing is enabled we try to render content and
        root layers using GPU. Please note that this setting is ignored if
        accelerated compositing is disabled.

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setAcceleratedDrawingEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@83088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Reviewed by Dan Bernstein.

Visited links painting with black background. Make sure that if the visited style has
the initial background color (transparent) set that we just use the unvisited color.

Source/WebCore: 

Added fast/history/visited-link-background-color.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::visitedDependentColor):

LayoutTests: 

Added fast/history/visited-link-background-color.html
* fast/history/visited-link-background-color.html: Added.
* platform/mac/fast/history/visited-link-background-color-expected.checksum: Added.
* platform/mac/fast/history/visited-link-background-color-expected.png: Added.
* platform/mac/fast/history/visited-link-background-color-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@83087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* WebCore.pro:



git-svn-id: svn://svn.chromium.org/blink/trunk@83086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 2: Implement uniqueSpellDocumentTag and closeSpellDocumentWithTag.

* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
* UIProcess/win/WebTextCheckerClient.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@83085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

       Unreviewed, update Chromium expectations for set-unloaded-frame-location.html as a flaky crasher.

        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

       Unreviewed, rebaseline Chromium linux tests after r83075.

        * platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
        * platform/chromium-linux/fast/text/capitalize-empty-generated-string-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@83083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Chris Marrin.

        https://bugs.webkit.org/show_bug.cgi?id=56936
        Crash in ImplicitAnimation::~ImplicitAnimation

        Make sure the style and start time waiting lists
        are cleared in the CompositeAnimation destructor. This
        way, no running transitions can be left in a state
        where they are destroyed as the AnimationControllerPrivate
        cleans up.

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::~CompositeAnimation):

git-svn-id: svn://svn.chromium.org/blink/trunk@83082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        No change in behavior; no new tests.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::locationAndLengthFromRange): New method from duplicated code in WebKits
        * editing/TextIterator.h:
        * page/Frame.cpp:
        (WebCore::Frame::rangeForPoint): New method from duplicated code in WebKits
2011-04-06  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        * WebView/WebFrame.mm:
        (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
        (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
2011-04-06  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::respondToChangedSelection): Moved duplicated code to WebCore
        * WebProcess/WebPage/mac/WebPageMac.mm: Moved duplicated code to WebCore
        (WebKit::WebPage::getMarkedRange):
        (WebKit::WebPage::getSelectedRange):
        (WebKit::WebPage::characterIndexForPoint):
        (WebKit::WebPage::performDictionaryLookupAtLocation):

git-svn-id: svn://svn.chromium.org/blink/trunk@83081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Andreas Kling.

        Skip tests not passing in the Qt bot.

        * platform/qt/Skipped:


git-svn-id: svn://svn.chromium.org/blink/trunk@83080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Steve Block.

        Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore.
        https://bugs.webkit.org/show_bug.cgi?id=57770

        Create a template from an existing functionality in JSGeolocationCustom.cpp
        to be used by the custom bindings of both Geolocation and the Media Stream API.
        V8 version of this bug: https://bugs.webkit.org/show_bug.cgi?id=57760

        No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/CallbackFunction.cpp: Added.
        (WebCore::checkFunctionOnlyCallback):
        * bindings/js/CallbackFunction.h: Added.
        (WebCore::createFunctionOnlyCallback):
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):

git-svn-id: svn://svn.chromium.org/blink/trunk@83079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Andreas Kling.

        [Qt] Implement fullscreen playback for the GStreamer backend.
        https://bugs.webkit.org/show_bug.cgi?id=56826

        Implement support for fullscreen playback when building the
        Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
        The implementation is done in FullScreenVideoQt alongside with
        the Qt Multimedia support.

        No new tests because layout tests cover it. They are not yet activated
        but will be any time soon.

        * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
        * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
        (FullScreenVideoWindow::FullScreenVideoWindow):
        (FullScreenVideoWindow::setVideoElement):
        (FullScreenVideoWindow::closeEvent):
        (FullScreenVideoWindow::keyPressEvent):
        (FullScreenVideoWindow::event):
        (FullScreenVideoWindow::showFullScreen):
        (FullScreenVideoWindow::hideCursor):
        (FullScreenVideoWindow::showCursor):
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Implement fullscreen playback for the GStreamer backend.
        https://bugs.webkit.org/show_bug.cgi?id=56826

        Implement support for fullscreen playback when building the
        Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
        The implementation is done in FullScreenVideoQt alongside with
        the Qt Multimedia support.

        No new tests because layout tests cover it. They are not yet activated
        but will be any time soon.

        * QtWebKit.pro:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        (WebCore::ChromeClientQt::enterFullscreenForNode):
        (WebCore::ChromeClientQt::exitFullscreenForNode):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
        (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
        (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
        (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
        (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
        (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/FullScreenVideoQt.h:
        (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):

git-svn-id: svn://svn.chromium.org/blink/trunk@83078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        [Gtk] plugins/set-status.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57844

        Unskip a newly-passing test.

        * platform/gtk/Skipped:
2011-04-06  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk] plugins/set-status.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57844

        Allow an empty status text to be dumped.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewStatusBarTextChanged):

git-svn-id: svn://svn.chromium.org/blink/trunk@83077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Bundle lineLeftOffset and lineRightOffset as a class
        https://bugs.webkit.org/show_bug.cgi?id=57851

        Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
        The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
        and only the difference is used to compute the width.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers.
        (WebCore::LineOffsets::LineOffsets): Added.
        (WebCore::LineOffsets::width): Added.
        (WebCore::LineOffsets::setLeft): Added.
        (WebCore::LineOffsets::setRight): Added.
        (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
        (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.

git-svn-id: svn://svn.chromium.org/blink/trunk@83076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Reviewed by Dan Bernstein.

Implement an optimization to the line box tree to cull out most of the intermediate
line boxes that can occur between the root line box and the leaves of the tree (images
and text).

Source/WebCore: 

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.
        
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout
is up to date.

* page/SpatialNavigation.cpp:
(WebCore::hasOffscreenRect):
(WebCore::nodeRectInAbsoluteCoordinates):
Add asserts in spatial navigation code to catch any future bad queries that might be made
for rectangles without layout being up to date.

* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::uniteIfNonZero):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.cpp:
(WebCore::IntRect::uniteIfNonZero):
* platform/graphics/IntRect.h:
Add a new unite function that is useful for the render tree to FloatRect and IntRect.  This
version allows rect unites to happen if either width or height is nonzero.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes
if content inside those inlines is hit.

* rendering/InlineBox.h:
(WebCore::InlineBox::logicalFrameRect):
Fix a bug in this function for obtaining the logical frame rect of an inline box.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
addToLine now also checks line gap in the line box tree optimization checks.
    
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
* rendering/InlineFlowBox.h:
Rewritten to add the text box overflow to the text box itself.

 * rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::destroy):
Destroy has been changed to call a helper function to remove and destroy the line boxes that
is now called from one additional spot.

(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
Text boxes now cache their own overflow in a global hash table.

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
Changed to not assume that the parent line box's renderer is the RenderText's immediate
parent, since intermediate line boxes may have been culled.

(WebCore::InlineTextBox::paint):
Paint now properly checks only the text box overflow instead of the parent line box's overflow.

* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
New accessors to obtain overflow for inline text boxes.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those
text boxes may not have anything in between them and the block that contains the inline first letter
container.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
The culling optimization is done here.  Only if the RenderInline says that boxes are allowed will they
be created.

(WebCore::RenderBlock::layoutInlineChildren):
The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed.
This is done before any lines are built.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
The new m_alwaysCreateLineBoxes flag has been added to the constructor.

(WebCore::RenderInline::styleDidChange):
An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately
(like having a layer, borders, padding, margins or backgrounds).  Some checks that depend on examining
the RenderInline's parent (including first line styles) happen later in layoutInlineChildren.

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
The function called by layoutInlineChildren to check parent and child style differences (e.g., font,
vertical alignment, line height, etc.).

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::culledInlineAbsoluteQuads):
absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::offsetLeft):
(WebCore::RenderInline::offsetTop):
offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineBoundingBox):
lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and
lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop).

(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::clippedOverflowRectForRepaint):
The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox.

(WebCore::RenderInline::dirtyLineBoxes):
dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when
m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::createAndAppendInlineFlowBox):
Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also
when line-box-contain is set to an unusual value.

(WebCore::RenderInline::addFocusRingRects):
Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false.

* rendering/RenderInline.h:
(WebCore::RenderInline::firstLineBoxIncludingCulling):
(WebCore::RenderInline::lastLineBoxIncludingCulling):
Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box
is all that needs checking.

(WebCore::RenderInline::alwaysCreateLineBoxes):
(WebCore::RenderInline::setAlwaysCreateLineBoxes):
Functions for getting and setting the m_alwaysCreateLineBoxes flag.

* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of
lines get dirtied.

* rendering/RenderText.cpp:
(WebCore::RenderText::removeAndDestroyTextBoxes):
New helper invoked by destroy and also from updateFirstLetter.

(WebCore::RenderText::destroy):
Changed to call removeAndDestroyTextBoxes.

(WebCore::RenderText::absoluteRects):
Fixed to be properly physical instead of logical.

(WebCore::RenderText::linesVisualOverflowBoundingBox):
New implementation for RenderText that gives the bounding box of the text boxes including overflow from
shadows, glyphs, text-stroke, etc.  Used by RenderInline::culledInlineVisualOverflowBoundingBox.

* rendering/RenderText.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::RenderSVGInline):
RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization.

* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are
now InlineTextBoxes (the enclosing InlineFlowBoxes got culled).

LayoutTests: 

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

* platform/mac/fast/blockflow/text-orientation-basic-expected.txt:
* platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@83075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed expectations udpate for gtk port that follows r83065.

        * platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
        * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

       Unreviewed, modify Chromium test expectations from r83065.  They need
       rebaselines, but in the meantime they should fail more generally so as
       not to trip the bots.

        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Benjamin Poulain.

        [Qt] Unskip some media LayoutTests.
        https://bugs.webkit.org/show_bug.cgi?id=57855

        Unskip some media tests for Qt.

        * platform/qt/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@83072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        Unskip passed tests.

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundlePageNumberForElementById):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::pageNumberForElementById):
        * WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::pageNumberForElementById):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@83071 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57909
<rdar://problem/9103220>

Reviewed by Darin Adler.

Source/WebCore: 

In WebKit2 we cannot rely on the value returned by platformData() that
on Mac returns an NSDraggingInfo object. This is available only in the UI
process. Therefore we should use m_pasteboard instead.
We cannot change what platformData() returns on Mac, since there are
delegate methods that receive a NSDraggingInfo object (only in WebKit).
        
* platform/DragData.h:
(WebCore::DragData::pasteboard): Added.
* platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().
* platform/mac/DragDataMac.mm:
(WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
(WebCore::DragData::asURL): Same as above.

Source/WebKit2: 

Added _hitTest method to support drag and drop when the drag types cannot be matched.
This is the case for elements that do not place content
in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element).
               
* UIProcess/API/mac/WKView.mm:
(-[WKView _hitTest:dragTypes:]): Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@83070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Carlson.

        fast/layer/video_layer.html has the same text output for all chromium mac platforms.

        [chromium] Fix fast/layers/video_layer.html expectations
        https://bugs.webkit.org/show_bug.cgi?id=57386

        * platform/chromium-mac-leopard/fast/layers/video-layer-expected.txt: Removed.
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Martin Robinson.

        [GTK] DumpRenderTree: do not try to free NULL SoupURIs
        https://bugs.webkit.org/show_bug.cgi?id=57932

        Some Layout tests have invalid URIs that do not generate valid
        SoupURI instances. Do not try to free those NULL SoupURIs.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback):

git-svn-id: svn://svn.chromium.org/blink/trunk@83068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        ClipboardWin has unused variables "ExceptionCode ec"
        https://bugs.webkit.org/show_bug.cgi?id=57952

        Remove the unused variable.

        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::declareAndWriteDragImage):
        (WebCore::ClipboardWin::writePlainText):

git-svn-id: svn://svn.chromium.org/blink/trunk@83067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Split getBorderPaddingMargin into two functions
        https://bugs.webkit.org/show_bug.cgi?id=57947

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin.
        (WebCore::borderPaddingMarginEnd): Ditto.
        (WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd.
        (WebCore::RenderBlock::findNextLineBreak): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@83066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        [Refactoring] <progress> should not have manual layout code.
        https://bugs.webkit.org/show_bug.cgi?id=57801

        Updated progress-bar-value-pseudo-element.html to have wider coverage and
        follow pseudo class change.

        * fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
2011-04-06  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] <progress> should not have manual layout code.
        https://bugs.webkit.org/show_bug.cgi?id=57801

        - Simplified RenderProgress, removing its custom layout code
        - Introducing ProgressValueElement and ProgressBarElement, replacing
          ProgressBarValueElement.

        Now the structure is almost identical to <meter>,
        other than:
        - RenderProgress has animated painting, thus manages its own timer.
        - Both ProgressValueElement and ProgressBarElement has pseudo classes
          which don't changes during its lifetime.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/html.css:
        (progress):
        (progress::-webkit-progress-bar):
        (progress::-webkit-progress-value):
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::~HTMLProgressElement):
        (WebCore::HTMLProgressElement::create):
        (WebCore::HTMLProgressElement::attach):
        (WebCore::HTMLProgressElement::didElementStateChange):
        (WebCore::HTMLProgressElement::createShadowSubtree):
        * html/HTMLProgressElement.h:
        * html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h.
        (WebCore::ProgressShadowElement::ProgressShadowElement):
        (WebCore::ProgressShadowElement::progressElement):
        (WebCore::ProgressShadowElement::rendererIsNeeded):
        (WebCore::ProgressBarElement::shadowPseudoId):
        (WebCore::ProgressValueElement::shadowPseudoId):
        (WebCore::ProgressValueElement::setWidthPercentage):
        * html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h.
        (WebCore::ProgressBarElement::ProgressBarElement):
        (WebCore::ProgressBarElement::create):
        (WebCore::ProgressValueElement::ProgressValueElement):
        (WebCore::ProgressValueElement::create):
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::RenderProgress):
        (WebCore::RenderProgress::updateFromElement):
        (WebCore::RenderProgress::animationTimerFired):
        * rendering/RenderProgress.h:
        (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
        (WebCore::RenderProgress::canHaveChildren):

git-svn-id: svn://svn.chromium.org/blink/trunk@83065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Chris Fleizach.

        [GTK] Do not reference AccessibilityRenderObject from platform dependent code
        https://bugs.webkit.org/show_bug.cgi?id=57955

        Do not reference AccessibilityRenderObject from platform specific code

        Added new virtual functions to AccessibilityObject.h and removed
        explicit references to AccessibilityRenderObject from GTK code.

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::renderer): New virtual method,
        returning 0 by default. Overriden by AccessibilityRenderObject.
        (WebCore::AccessibilityObject::correspondingLabelForControlElement):
        New virtual method, returning 0 by default. It complements the
        already present method correspondingControlForLabelElement().

        * accessibility/AccessibilityRenderObject.h:
        (WebCore::AccessibilityRenderObject::renderer): Made virtual.

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::emitTextChanged): Reference  AccessibilityObject,
        instead of AccessibilityRenderObject.
        (WebCore::AXObjectCache::nodeTextChangePlatformNotification):
        Ditto.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_name): Do not reference
        AccessibilityRenderObject.
        (webkit_accessible_get_description): Ditto.
        (setAtkRelationSetFromCoreObject): Ditto.
        (optionFromList): Ditto.
        (optionFromSelection): Ditto.
        (webkit_accessible_selection_clear_selection): Ditto.
        (webkit_accessible_selection_get_selection_count): Ditto.
        (webkit_accessible_selection_select_all_selection): Ditto.
        (textForObject): Ditto.
        (webkit_accessible_text_get_text): Ditto.
        (getPangoLayoutForAtk): Ditto.
        (webkit_accessible_text_get_caret_offset): Ditto.
        (baselinePositionForRenderObject): Ditto.
        (getAttributeSetForAccessibilityObject): Ditto.
        (accessibilityObjectLength): Ditto.
        (getSelectionOffsetsForObject): Ditto.
        (webkit_accessible_text_set_selection): Ditto.
        (webkit_accessible_text_set_caret_offset): Ditto.
        (webkit_accessible_table_get_caption): Ditto.
        (getInterfaceMaskFromObject): Ditto.

        * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
        (getRangeLengthForObject): Ditto.

        Removed unused renderer() method from AccessibilityMenuList.

        * accessibility/AccessibilityMenuList.h: Removed unused method.
        * accessibility/AccessibilityMenuList.cpp: Removed unused method.

git-svn-id: svn://svn.chromium.org/blink/trunk@83064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        cmake: Fix build for ARMv7

        * CMakeLists.txt: add missing file.

git-svn-id: svn://svn.chromium.org/blink/trunk@83063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: Javascipt warning link expand and overlap with icons in js console
        https://bugs.webkit.org/show_bug.cgi?id=57939

        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: svn://svn.chromium.org/blink/trunk@83062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: Beautify parameter names in Inspector.json (CSS domain)
        https://bugs.webkit.org/show_bug.cgi?id=57931

        * inspector/Inspector.json:

git-svn-id: svn://svn.chromium.org/blink/trunk@83061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        [Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text.
        https://bugs.webkit.org/show_bug.cgi?id=57665
        <rdar://problem/7350477>

        We need to track how user modified an autocorrected word. If he changed it back to original
        text, we want to record AutocorrectionReverted response. And if he changed it to something
        else, we want to record AutocorrectionEdited response.

        To achieve this, we need to distringuish between text replacement caused by autocorrection
        from that due to other causes, such as reversion, text substitution, etc. So we added a new
        marker type "Autocorrected". We also need to be able to check for correction, even when we
        don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption
        value, "CheckForCorrection".

        We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in
        specified range, and of specified type.

        * dom/DocumentMarker.h:
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::markersInRange):
        (WebCore::DocumentMarkerController::hasMarkers):
        * dom/DocumentMarkerController.h:
        * editing/Editor.cpp:
        (WebCore::markerTypesForAutocorrection):
        (WebCore::markersHaveIdenticalDescription):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection):
        (WebCore::Editor::changeBackToReplacedString):
        (WebCore::Editor::markMisspellingsAndBadGrammar):
        (WebCore::Editor::applyCorrectionPanelInfo):
        (WebCore::Editor::unappliedSpellCorrection):
        (WebCore::Editor::textCheckingTypeMaskFor):
        * editing/Editor.h:
        * editing/SpellingCorrectionCommand.cpp:
        (WebCore::SpellingCorrectionCommand::doApply):

git-svn-id: svn://svn.chromium.org/blink/trunk@83060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Benjamin Poulain.

        Correct a include file name.
        https://bugs.webkit.org/show_bug.cgi?id=57839

        * wtf/PageAllocatorSymbian.h: It should be case sensitive. This fix
        builds on Unix hosts.

git-svn-id: svn://svn.chromium.org/blink/trunk@83059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Added property svn:executable.



git-svn-id: svn://svn.chromium.org/blink/trunk@83058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

       Unreviewed, add Chromium snow leopard baseline for meter-boundary-values

        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@83057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hopefully this will make it easier to modify this logic in the future. I also made the
script much quieter than the old logic, since it didn't seem helpful to see long lists of
filenames during the copying phase.

If we like this new style, we could copy it for our other projects.

Fixes <http://webkit.org/b/57950> JavaScriptCoreGenerated's file-copying logic is hard to
modify and noisy

Reviewed by Steve Falkenburg.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Moved logic to copy
files from here...
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: ...to here. (Added.)

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added copy-files.cmd
for convenience.

git-svn-id: svn://svn.chromium.org/blink/trunk@83056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57846

Reviewed by Andreas Kling.

* Scripts/old-run-webkit-tests:

git-svn-id: svn://svn.chromium.org/blink/trunk@83055 bbb929c8-8fbe-4397-9dbb-9b2b20218538