GitLab

    
BUG=111334
Review URL: https://chromiumcodereview.appspot.com/9293016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120056 0039d316-1c4b-4281-b951-d872f2087c98

This test was added as "FAILING" in

http://src.chromium.org/viewvc/chrome?view=rev&revision=119112

However, the test is  passing fine. Please see

http://codereview.chromium.org/9129024

for a discussion explaining why it passes.

BUG=111185
TEST=RenderWidgetHostTest.MultipleInputEvents


Review URL: http://codereview.chromium.org/9235056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23743
TEST=Manual.


Review URL: http://codereview.chromium.org/9159065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run aura_shell_unittests

Review URL: https://chromiumcodereview.appspot.com/9316029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120053 0039d316-1c4b-4281-b951-d872f2087c98

Linux: use the bounds from the most recent BrowserWindowGtk::OnConfigure() call to figure out whether to return early in a later call, rather than bounds that may also be updated by a debounced callback with different (but more accurate, for some window managers) values.

BUG=112041

Review URL: http://codereview.chromium.org/9307018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120050 0039d316-1c4b-4281-b951-d872f2087c98

- Increase line height by 1px so favicon can be visually centered.
- Ensure entry text cap height is centered on the favicon.
- Make checkboxes and drop-down buttons square.

BUG=111941
TEST=Check visual alignment of items on chrome://history.


Review URL: http://codereview.chromium.org/9293011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120048 0039d316-1c4b-4281-b951-d872f2087c98

Close login window after a browser is opened. This is necessary because browser has nested loop which wait for session data.
Don't apply sho/hide animation to lock screen.

This depends on http://codereview.chromium.org/9233044/ and I will run bots after it is landed.

BUG=none
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/9264059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111900
TEST=Verify that the 'Manage extensions' contextual menu invokes the extensions page.
Review URL: https://chromiumcodereview.appspot.com/9318019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104192
TEST=None


Review URL: http://codereview.chromium.org/9121050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120044 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni@chromium.org
BUG=chromium-os:25272
TEST=Open the systems options page, make sure there is only one a11y option


Review URL: http://codereview.chromium.org/9295010

TBR=zork@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9316024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120043 0039d316-1c4b-4281-b951-d872f2087c98

Re-enabled synthesized mouse event for linux aura
Disabled synthesized mouse event for win aura.

TBR=ben@chromium.org
BUG=112222
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9314021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/9309013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120041 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni@chromium.org
BUG=chromium-os:25272
TEST=Open the systems options page, make sure there is only one a11y option


Review URL: http://codereview.chromium.org/9295010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120040 0039d316-1c4b-4281-b951-d872f2087c98

Undo attempt to disable from unit_tests.gtest_mac.txt as it didn't solve the problem.

BUG=51716
TEST=Chromium Mac (Valgrind)(1) bot

Review URL: https://chromiumcodereview.appspot.com/9316020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120039 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben
BUG=112246
TEST=green bots

Review URL: https://chromiumcodereview.appspot.com/9314029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots,manual (build SDK, inspect headers)

Review URL: http://codereview.chromium.org/9309012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120036 0039d316-1c4b-4281-b951-d872f2087c98

* Rename "normal" to "overlapping", since there was some confusion about whether or not compact mode is "normal"
* Remove "--aura-workspace-manager" flag in favor of "--aura-window-mode=managed", as this feature is not compatible with compact mode.
* Change about:flags Window mode to a three-way choice between modes

BUG=112139
TEST=aura_shell_unittests ShellTest, manual check of about:flags


Review URL: http://codereview.chromium.org/9316005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120035 0039d316-1c4b-4281-b951-d872f2087c98

Make Ctrl+Alt+T open Crosh in HTML Terminal on Aura build.
If HTerm is not installed nothing should happen..

BUG=105649
TEST= manual on Stumpy VM with HTerm extension installed.


Review URL: http://codereview.chromium.org/9297008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120034 0039d316-1c4b-4281-b951-d872f2087c98

change labels to -webkit-inline-box. This doesn't change the children but the box itself will behave like an inline element rather than block (won't expand horizontally). Also remove box flex on the span as it's not necessary. Also add some padding on the end of the labels so that there is extra clickable area when the text is short (this doesn't change anything if the span is long enough to wrap).

In native dialogs:
On Linux/GTK, the clickable area extends all the way to the right (our behavior before this patch).
On Mac, the clickable area is only the text and the checkbox
On Windows, the clickable area extends beyond the text but not all the way to the far right.

I'm splitting the difference by matching Windows native behavior, which seems both logical and the middle road.

BUG=112091
TEST=1. Checkbox labels should be clickable on either the text or the checkbox, but not more than 100px from the right edge of the checkbox. 2. Long labels still wrap with indent (see bug 109334)

Review URL: https://chromiumcodereview.appspot.com/9307015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120033 0039d316-1c4b-4281-b951-d872f2087c98

cr.ui.List.ensureAllItemSizesInCache() has manipulate elements and it has sometimes changed the scroll position and/or the client height unexceptionally.

To prevent it, this CL moves reading of the positions before ensureAllItemSizesInCache().

BUG=110140
TEST=manual on taskmanager.

Review URL: http://codereview.chromium.org/9318012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120032 0039d316-1c4b-4281-b951-d872f2087c98

The exit-code from remoting_me2me_host will be used to communicate to the
daemon that the Host ID was rejected as invalid.


BUG=110046
TEST=Run remoting_me2me_host with invalid host.json


Review URL: http://codereview.chromium.org/9301026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120031 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9314027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112137
TEST=sign into Chrome, open settings page, click Google Dashboard link

Review URL: https://chromiumcodereview.appspot.com/9310006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104418
TEST=none


Review URL: http://codereview.chromium.org/9316007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108171



Review URL: http://codereview.chromium.org/9159068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120026 0039d316-1c4b-4281-b951-d872f2087c98

Adds two new observer methods to allow code to be notified when a Window is added/removed from a RootWindow. This allows hierarchy-specific cleanup code to execute when a Window is removed rather than when it is destroyed, necessary for multiple root windows.

http://crbug.com/112131
TEST=see unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119976

Review URL: http://codereview.chromium.org/9315015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120025 0039d316-1c4b-4281-b951-d872f2087c98

The manager sends signals when additional adapters (including the
initial) are added, we may need these to obtain properties before
the default adapter is switched so hook up that signal so the
observer can take it.

BUG=chromium-os:22086
TEST=verified signals are received

Change-Id: I895c699eaef2f77f70ad855601b16e9a7c731ebb


Review URL: http://codereview.chromium.org/9302027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=added unittest.


Review URL: http://codereview.chromium.org/9301016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120023 0039d316-1c4b-4281-b951-d872f2087c98

This is equivalent to GetLastState().error. It saves copying 6 ints. This is temporary until skia does not invoke MakeCurrent for every GL call.

BUG==112187

Review URL: http://codereview.chromium.org/9314020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120022 0039d316-1c4b-4281-b951-d872f2087c98

* Show status area volume control when the command line has --show-volume-status 
* Create AudioHandler::VolumeObserver class and helpers so VolumeMenuButton and VolumeControlView can observe volume changes from key presses.
* Move GetAudioHandler() common code in VolumeMenuButton and SystemKeyEventListener that returns the AudioHandler singleton only if the mixer has finished initializing to AudioHandler::GetInitialized().
* Handle mute in VolumeMenuButton correctly.

BUG=chromium-os:22080
TEST=Should see the volume control in the status area on builds with USE flag is_desktop set. The volume control icon and menu should be in sync with volume key button controls.
Review URL: https://chromiumcodereview.appspot.com/9169033

TBR=achuith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9310018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120019 0039d316-1c4b-4281-b951-d872f2087c98

Revert 120005 - Enabled pressing TAB to traverse through the Omnibox results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs.

This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.

The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message. 

If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.  

Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.

This also addresses some GTK omnibox browsertest flakiness; see bug 112041.

Contributed by aaron.randolph@gmail.com

BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.

Review URL: http://codereview.chromium.org/6731036

TBR=aaron.randolph@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9310017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Run any test.


Review URL: http://codereview.chromium.org/9301025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120016 0039d316-1c4b-4281-b951-d872f2087c98

This test must be run manually for now, and will be used in its current
state only temporarily to compare results across different ChromeOS
devices.

BUG=None
TEST=Verified the test runs successfully on a local Alex device.

Review URL: https://chromiumcodereview.appspot.com/9320001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120015 0039d316-1c4b-4281-b951-d872f2087c98

TBR=acolwell
BUG=109875
TEST=none


Review URL: http://codereview.chromium.org/9317023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120014 0039d316-1c4b-4281-b951-d872f2087c98

This is check-in for mattias.
Original review: http://codereview.chromium.org/9315011/

Note that this hard-wires policy OAuth fetching in login_utils.cc to the
authentication profile. I'm not entirely sure this is a good idea, but
required since the user profile isn't in a state to allow successful
requests at this point (the use-shared-proxies flag is off). Other stuff
in login_utils.cc might need the hack too (sync?).

BUG=chromium-os:25703
TEST=Verify fix for chromium-os:25703
TBR=mnissler@chromium.org,zelidrag@chromium.org,sumit@chromium.org,pastarmovj@chromium.org,kuan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9309024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120013 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120012 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/9233048 for the actual change. 

BUG=109574
TEST=Go to http://i18nl10n.com/chrome/euc_webkit_8EE3.html and make sure there's no alert box popping up.
TBR=tsepez
Review URL: https://chromiumcodereview.appspot.com/9314007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120011 0039d316-1c4b-4281-b951-d872f2087c98

Fix compile error
Fix to show virtual keyboard on linux build

BUG=chromium-os:10620
TEST=build success with GYP_DEFINES="use_virtual_keyboard=1"


Review URL: http://codereview.chromium.org/9200011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120010 0039d316-1c4b-4281-b951-d872f2087c98