- 04 Jul, 2018 40 commits
-
-
Gabriel Charette authored
I'm about to duplicate that line in https://chromium-review.googlesource.com/c/chromium/src/+/1106434 and it feels silly to clobber |recent_time_| since TimeTicks is monotically increasing regardless of nested loops (cloberring it is at best irrelevant and at worse forces an unecessary recomputation of Now()). R=danakj@chromium.org, kylechar@chromium.org Bug: None Change-Id: Ia11ca15fcde850fba5cc33bc1cbac68386495719 Reviewed-on: https://chromium-review.googlesource.com/1125168Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572592}
-
Gabriel Charette authored
MessageLoop::AddTaskOserver now has a thread-affine DCHECK Caught while running base_perftests.exe locally, too bad waterfall doesn't run these (even if not analyzing actual perf results). R=danakj@chromium.org, kylechar@chromium.org Bug: 860252 Change-Id: I6d09f29bea7e56e1b315c1d5789b4c1cd65b9abb Reviewed-on: https://chromium-review.googlesource.com/1126320Reviewed-by:
-
Corentin Wallez authored
Also remove cwallez from gpu_passthrough_cmd_decoder. BUG=chromium:852089 TBR=kainino@chromium.org Change-Id: I621140d8986af6380325a6ce841a7929ae1c63b8 Reviewed-on: https://chromium-review.googlesource.com/1126308Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572590}
-
Ulan Degenbaev authored
This CL fixes a potential race when the user starts navigation at the same time as the bloated renderer is being reloaded. The race may cause the infobar to be shown on user navigation, which is misleading. Now the navigation id is saved for the bloated renderer reload and later on it is matched with the navigation id provided to the DidFinishNavigation event. The infobar is shown only if the ids match. Bug: 808143 Change-Id: I1e3c37e565e1434b6ab5557df44281fb418c6e12 Reviewed-on: https://chromium-review.googlesource.com/1106619 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#572589}
-
Marcin Wiacek authored
Change-Id: Iae40af3d5ab3ecb3a9f41443359a069424ddacb6 Reviewed-on: https://chromium-review.googlesource.com/1126253 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572588}
-
Marcin Wiacek authored
Change-Id: I522d8ef23a39e78c687dfcff6f8e69dd1c5cf662 Reviewed-on: https://chromium-review.googlesource.com/1125067Reviewed-by:
-
Colin Blundell authored
We are shortly going to change the semantics of GaiaCookieManagerService::ListAccounts() to populate its out-params even in the case where it returns false to indicate that the accounts are stale. A search through the codebase shows a minimal number of production callsites that call ListAccounts() outside of an if condition: blundell:src(change_signin_ui_util) $ git grep "\<ListAccounts(" | grep -v "if (" | grep -v unittest (standard input):1:(standard input):3:chrome/browser/signin/signin_ui_util.cc: bool cookie_accounts_valid = cookie_manager_service->ListAccounts( (standard input):2:(standard input):6:components/browser_sync/profile_sync_service.cc: gaia_cookie_manager_service_->ListAccounts( (standard input):7:(standard input):13:components/signin/core/browser/gaia_cookie_manager_service.cc:bool GaiaCookieManagerService::ListAccounts( (standard input):8:(standard input):14:components/signin/core/browser/gaia_cookie_manager_service.h: // to ListAccounts(). The GCMS will delay calling ListAccounts if other (standard input):9:(standard input):15:components/signin/core/browser/gaia_cookie_manager_service.h: bool ListAccounts(std::vector<gaia::ListedAccount>* accounts, An examination of the two production callsites listed above shows that ProfileSyncService actually does guard its usage in an if-condition, just spread over multiple lines. SigninUiUtil, however, does not. This CL changes SigninUiUtil to explicitly depend on the current behavior of GaiaCookieManagerService::ListAccounts() so that its behavior won't change when we change the semantics of GaiaCookieManagerService::ListAccounts(). Bug: 859882 Change-Id: I8ee63b980edc9f6a2980d3a46702a72f93307ee4 Reviewed-on: https://chromium-review.googlesource.com/1126257 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#572586}
-
Vadym Doroshenko authored
Chrome sign-in passwords shouldn't be saved, so Chrome sign-in form sholdn't be skipped. On CL https://chromium-review.googlesource.com/c/chromium/src/+/979932 it was implemented skipping this form in the renderer process. As result password hash can't be saved. This CL implements skipping such form in the browser process. As positive side effects, it adds checking whether to save a password in ShowManualFallbackForSaving, that avoids to show manual fallback for sync credentials for any form. Bug:852205 Change-Id: I4d749aecdb57dab03b7928f551f41c015490da56 Reviewed-on: https://chromium-review.googlesource.com/1120342 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572585}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/233c65202e69..cdefa23a23cf git log 233c65202e69..cdefa23a23cf --date=short --no-merges --format='%ad %ae %s' 2018-07-04 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 539468cef869..517a57f4ba88 (3 commits) Created with: gclient setdep -r src/third_party/skia@cdefa23a23cf The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ia5ece05b68cf6b5806efe2b74f4348e163d3c9c2 Reviewed-on: https://chromium-review.googlesource.com/1126280Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572584}
-
Farah Charab authored
Change-Id: Id0ab1e7275a8254fd6cf44939d3b08258d722a2a Reviewed-on: https://chromium-review.googlesource.com/1118274Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572583}
-
Elodie Banel authored
The behavior that is expected is the current behavior. Remove todo. Bug: 848732 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifc0412d8b0cca13e1b1342195608c7daecdbd46c Reviewed-on: https://chromium-review.googlesource.com/1125733Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#572582}
-
Calder Kitagawa authored
The fuzzer found another pathological case of repeated ZTF regions that causes the patch size check to be violated due to a large number of headers. The solution should be to increase this upper bound or remove it entirely. I've gone with the former but if it continues to cause trouble it might be worth removing as it only finds pathological cases so far. Bug: 860070 Change-Id: I276b51bc909ad0da46d9954aee9c98e03dc1973e Reviewed-on: https://chromium-review.googlesource.com/1126164Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#572581}
-
vitaliii authored
Previously ConsentAuditor did get UserEventService even when the separate consents datatype was used. In this CL, the UserEventService is just not requested from ConsentAuditor factory at all in this case (on all platforms). Also DCHECKs in ConsentAuditor are adjusted to check only the correct dependency based on the feature. Bug: 851438 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I756e595b826e084d1b2f9905d2827cae1160fedd Reviewed-on: https://chromium-review.googlesource.com/1124333Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572580}
-
Tiger Oakes authored
Makes your browser history cleaner by replacing the current query string with Javascript rather than making a new request with the form. Updates the UI inline rather than reloading the page. Additionally fixed the select element so it renders properly on Mac. Bug: 847599 Change-Id: I709cb71b184f271fdcfb7561cc56f9e1d29d059a Reviewed-on: https://chromium-review.googlesource.com/1125284 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#572579}
-
Tibor Goldschwendt authored
As a consequence we limit Chrome component updates to unmetered network connections. By doing so, we will be able to update large components in the background without depleting the user’s cellular data plan. Additionally, the BackgroundTaskScheduler integrates well with Android’s awake state and, thus, we hope it makes component updates more reliable. More details at go/bts-component-updates This feature is gated behind flag #background-task-component-update. Bug: 801229 Change-Id: I3fb3c9850c32575267fd28d224810576631e48dc Reviewed-on: https://chromium-review.googlesource.com/1113777 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572578}
-
Calder Kitagawa authored
A left shift resulting in truncation is undefined behavior on signed int types in C++. It is fine to left shift an unsigned type because there is no issues with two's complement representation or sign bits. To get around this we need to perform the shift on the uint type and recast it to a signed int type. Bug: 860067 Change-Id: Ibace5aceb17c4435d6d37d5e37a16fa781c7dd99 Reviewed-on: https://chromium-review.googlesource.com/1126169Reviewed-by:
-
Oriol Brufau authored
They are implemented behind the CSSLogical runtime flag. Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ Spec: https://drafts.csswg.org/css-logical/#box BUG=850004 TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html TEST=external/wpt/css/css-logical/logical-box-border-color.html TEST=external/wpt/css/css-logical/logical-box-border-style.html TEST=external/wpt/css/css-logical/logical-box-border-width.html TEST=external/wpt/css/css-logical/logical-box-margin.html TEST=external/wpt/css/css-logical/logical-box-padding.html The tests still have some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: Ibe3d7f39e1ce17de465aa635388b3f8510ed82a3 Reviewed-on: https://chromium-review.googlesource.com/1122872Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#572576}
-
Pavel Feldman authored
Bug: 775132 Change-Id: I0cd43942e4cf1c8347332e3c22fae5555b490e4b Reviewed-on: https://chromium-review.googlesource.com/1124936 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572575}
-
Randy Rossi authored
Moving chromevox's closure-library into third_party so it can be shared with chromecast. Bug: 73240963 Test: Local build Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idec6775a8b9a82d301b75261bac3dfd82e5f350c Reviewed-on: https://chromium-review.googlesource.com/1108553 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#572574}
-
Sharon Yang authored
Replace an enum with an enum class, as preferred. Change-Id: I657373e7a4f0d245a930341db7feff27a2f8fda5 Reviewed-on: https://chromium-review.googlesource.com/1118552Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sharon Yang <yangsharon@google.com> Cr-Commit-Position: refs/heads/master@{#572573}
-
Majid Valipour authored
Previously we would allow worklet to access and act on all of worklet inputs. This is bad since it can leak information between different animation worklet global scopes. Summary of the fix: - Introduce WorkletAnimationId which can uniquely identify both the worklet and animation. - Give each worklet animation its own Id generated using its underlying worklet's scope. - Plumb this new Id to cc. - AnimationHost produces input state which is bucketed per scope. - CompositorMutatorImpl only passes to each compositor animator the input. bucket that matches that compositor animator's scope Id. - For additional safety added DCHECK to verify that each scope is receiving only its own input. TEST: compositor_mutator_impl_test.cc Bug: 857479 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib4b8f610ef661bdbf09c4c0252a2b9c4ba04db16 Reviewed-on: https://chromium-review.googlesource.com/1120436Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#572572}
-
Olivier Li authored
Bug: 830892 Change-Id: Ib5d41a5b1a70f4f26752d97096437f489d2fe239 Reviewed-on: https://chromium-review.googlesource.com/1126168Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#572571}
-
Mikel Astiz authored
This reverts commit e6aa52bf. Reason for revert: recent patches fix a related problem, in 23919ce6. We haven't been able to confirm the fix being effective for the flakes observed in bots because they no longer repro locally, but it is definitely related so let's reenable the tests and monitor flakes. Original change's description: > Reland "[iOS] Disabling flaky sync tests" > > This reverts commit 661767b9. > > Reason for revert: tests still flaky. > > Original change's description: > > Revert "[iOS] Disabling flaky sync tests" > > > > This reverts commit fb745f66. > > > > Reason for revert: underlying issue no longer reproduces on > > other platforms after recent improvements, so optimistically > > assuming it was also fixed for iOS. > > > > Original change's description: > > > [iOS] Disabling flaky sync tests > > > > > > Disabling EarlGrey tests from SigninInteractionControllerTestCase: > > > + testSignInSwitchAccountsAndKeepDataSeparate > > > + testSignInSwitchAccountsAndImportData > > > + testSignInSwitchManagedAccount > > > > > > Those tests seem to trigger an issue in the sync code when doing enable > > > disable enable too fast. > > > > > > Bug: 854446 > > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > > Change-Id: I76d10d272297e91650dbe91ef7acee500eac6c75 > > > Reviewed-on: https://chromium-review.googlesource.com/1107881 > > > Reviewed-by: Justin Cohen <justincohen@chromium.org> > > > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#568843} > > > > TBR=justincohen@chromium.org,jlebel@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 854446 > > Change-Id: Ic809289ce4662d099250668d6f23100e52de9587 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Reviewed-on: https://chromium-review.googlesource.com/1114719 > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#570374} > > TBR=justincohen@chromium.org,jlebel@chromium.org,mastiz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 854446 > Change-Id: I2a0a2e9d60988783fca93ef8313594d57b7ab906 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1117578 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570888} TBR=justincohen@chromium.org,jlebel@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 854446 Change-Id: I5874890bed60c173c35e49fe86933a06bd214120 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1126260Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#572570}
-
Marcin Wiacek authored
Change-Id: Ife219da64894fd0d0ff0d299261a498b6f5eba76 Reviewed-on: https://chromium-review.googlesource.com/1125068 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Marcin Wiacek authored
Change-Id: Ic86d4993e9557bbdee628fe37c9631185acde28b Reviewed-on: https://chromium-review.googlesource.com/1125065 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Greg Kraynov authored
Removal of unnecessary includes and narrowing down DEPS come next. Bug: 783309 Change-Id: If413b3d2d64e5a9ad71d613c18fc94fa9fb4988e Reviewed-on: https://chromium-review.googlesource.com/1125852Reviewed-by:
-
sangwoo.ko authored
When removing tabs with mouse button, we'd like to know the next active tab so that we can tailor available_width_for_tabs_. But as PrepareForCloseAt() is called before the next tab is decided, we don't know that. So move this logic to RemoveTabAt() where we know it. And move other logic in PrepareCloseTabAt() is moved to CloseTab(), which triggered PrepareForCloseAt() via TabStripController::CloseTab(). As TabStripController::CloseTab() was invoked only by TabStrip::CloseTab(), it's okay to move them to TabStrip::CloseTab(). Bug: 856289 Change-Id: I5eb7036da4214e92a218f20e8c09891ab9a11955 Reviewed-on: https://chromium-review.googlesource.com/1119616 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#572566}
-
Rayan Kanso authored
Done using the "Edit in Gerrit" option in codesearch Change-Id: I3a04b97abfcd67fb5d4a3eaa93f289341cb22f23 Reviewed-on: https://chromium-review.googlesource.com/1126142 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
This CL adds the consent API that allows the various browser services to check whether the user has consented for personalized URL-keyed data collection (data collection that is keyed by URL and by Google account id). As defined in the PRD, this decision is based on the sync state: * If the Unified consent feature is disabled, then we consider that the user has granted consent for personalized URL-keyed data collection iff sync history is enabled. * If the Unified consent feature is enabled, then we consider that the user has granted consent for personalized URL-keyed data collection iff sync user events is enabled (aka event logger is enabled). BUG: 823809 Change-Id: Idf619b96010064020f36efbd90d54b720b45deec Reviewed-on: https://chromium-review.googlesource.com/1123827 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium db30d751. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20769 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: I5fbf971594c4bdf3e0c3801c84b156adf5508ea0 Reviewed-on: https://chromium-review.googlesource.com/1126019 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#572563}
-
Marcin Wiacek authored
Change-Id: I9a3a58b3ee2207816ac0f2f96fa21e464d1da866 Reviewed-on: https://chromium-review.googlesource.com/1125066 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Reza.Zakerinasab authored
fast/canvas/color-space/canvas-colorManaged-convertToBlob-roundtrip.html virtual/gpu/fast/canvas/color-space/canvas-colorManaged-convertToBlob-roundtrip.html They flakily time out. TBR=fserb NOTRY=true Bug: 851746 Change-Id: Ib32001de56c74350a016e124fb5fa7e8906b5b04 Reviewed-on: https://chromium-review.googlesource.com/1126202Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572561}
-
Fredrik Söderquist authored
Avoids run-tripping TimeDelta -> double -> TimeDelta. Bug: 856082 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If4a6a0626be6341770ef01d368fc8a1ddf00de31 Reviewed-on: https://chromium-review.googlesource.com/1126115Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#572560}
-
Roger Tawa authored
Bug: 859978 Change-Id: Ida88834a11f6b6aec2558e419d23abeabff529b6 Reviewed-on: https://chromium-review.googlesource.com/1125034Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#572559}
-
Matthew Cary authored
This allows, for example, benchmarks in tools/perf/contrib to use subsets of the system health stories. Change-Id: I102722c6c4414e3d3921b288debd2db6a265c04d Reviewed-on: https://chromium-review.googlesource.com/1125843Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#572558}
-
vitaliii authored
Change-Id: I1a8ef527472d65b5f24b7357fe9ac6b153879d03 Reviewed-on: https://chromium-review.googlesource.com/1124848 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
-
Olivier Robin authored
Tbr: xunjieli@chromium.org Change-Id: I8376950bc4120bc8ed3397743fa343d7c849562e Reviewed-on: https://chromium-review.googlesource.com/1125924 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#572556}
-
Mikel Astiz authored
The process of stopping a datatype is asynchronous by nature, most prominently in USS where we want to take special care about sync metadata being cleared. Prior to this patch, ModelTypeController could silently drop stop events, which could lead to the DataTypeManager (effectively the UI) think a datatype is stopped, while in reality it could remain running. This is problematic in multiple ways, most importantly due to the risk of leaking sync metadata or even data. Instead, what we want is that calls to OnSyncStarting() always have a corresponding StopSync(), and guarantee that OnSyncStarting() is not called twice without a StopSync() call in between. In order to do that, ModelTypeController now enters state STOPPING if the Stop() cannot be immediately executed, because it's currently STARTING. Once the start is finalized, stop is immediately issued and the corresponding callback informed, which allows ModelAssociationManager to continue its job. Bug: 855375 Change-Id: I6e22940fcb56816c43181c34e04c4a6e53c70a21 Reviewed-on: https://chromium-review.googlesource.com/1122863 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#572555}
-
Bruno Kim Medeiros Cesar authored
We plan to remove this code in the next release, but for now we'll keep it behind a "live switch" so that we may re-enable in the server if necessary. Bug: 859097 Change-Id: I6c86e92de4b79c1a622a559b30840b9442f76716 Reviewed-on: https://chromium-review.googlesource.com/1122636 Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib286e9a2bb2e3f4d06e0bc1ddb7ee3c5854f333f Reviewed-on: https://chromium-review.googlesource.com/1125290Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572553}
-
