- 04 Aug, 2020 40 commits
-
-
Kunihiko Sakamoto authored
Bug: 1082020 Change-Id: Ib3acbd01711ea781f751714fd0854437b9647896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332148Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794372}
-
Peter Kasting authored
This requires adding a check against divide-by-zero in some net/ code. This also switches a few places from IntDiv() to FltDiv() where the result is obviously an int (e.g. FromSeconds(15) / FromSeconds(1)), which looks odd for now but will look less so as "/". This will allow the next CL in this chain to be trivially mechanical. Bug: 1104532 Change-Id: I0b867cba4498eed8c69bea2d7bf15679823ec61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318483 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794371}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ibf5b02f10668df2837ffa4ff5cb47c5f13bde22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336182 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#794370}
-
Rachel Carpenter authored
Launch bug: crbug/1095838 Change-Id: Ie781b8d65871e97cc42c3f61732a6d15d60c6ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336113Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794369}
-
Sunny Sachanandani authored
We suspect that OOPIF viewport sizes are unnecessarily large which leads to increased memory usage and jank or hangs. This CL splits the ResourcePoolMemoryUsage UMA into browser, OOPIF, and renderer variants. Since this UMA expired in M85, this CL also effectively extends the UMA. Bug: 1047289 Change-Id: Idcfccfae6489b8cde5446225963d7a1ee63696e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316945 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#794368}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ic7e17c936ff5c356ef749a8209c0f9cec819fa96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336277Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794367}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f07b8c19..2b884e02 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3271d5a2758cf2ff224c32257fdb1fea373df052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335954Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794366}
-
Devlin Cronin authored
Some tests still had handling for either js-bindings or native bindings. Since native bindings have been shipped for a long time, remove the old js bindings errors. Bug: None Change-Id: Icd39d40d7be67a17842a2f2242ecc16b43b9be74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334991Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794365}
-
Devlin Cronin authored
WebContents::GetURL() is hugely, amazingly deprecated. Update all extensions tests that use it. Each of these really wanted to use GetLastCommittedURL(). In a few cases, this required waiting for the WebContents before checking the value (using WaitForLoadStop() for convenience). Bug: 237908 Change-Id: I6db31650cf4500437983a42cc6f3ec20d84b4492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327460 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Previously we assumed nullable unions were always encoded as/decoded from pointers, but unions are only encoded as/decoded from pointers when they are nested in another union. This CL changes encodeUnion/decodeUnion to use encodeUnionAsPointer() and decodeUnionFromPointer() when a union field is another union. Fixed: 1101849 Change-Id: I7615207fe4052eadb544749fe89225c37d52fa58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325458Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#794363}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0e6261985136..74cc8ea2b8df 2020-08-04 capn@google.com Remove VK_KHR_16bit_storage support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia2164d214afed36fe06f75d0e1cbfe59807bb587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794362}
-
Yuzu Saijo authored
This CL makes sure that when a tab is created through CreateNewWindow (e.g. window.open / ctrl+click), a page inside the tab establishes PageBroadcast mojo connection. Previously we only established the connection inside RenderViewHostImpl ::CreateRenderView, but with CreateNewWindow, we do not go through CreateRenderView because RenderView is already there and RenderViewHost is created after that. Now we establish a connection after browser responds in CreateNewWindowReply. Bug: 1108035,1108947,1108904 Change-Id: I5e10163ba2326f6b07ea5a044db1eff102fa8c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331959 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794361}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c7e3ee345c3..709472c9dd0c 2020-08-04 m.maiya@samsung.com Vulkan: Fix variable scope bug during vkCreateInstance 2020-08-03 jmadill@chromium.org Vulkan: Add an overlay counter for descriptor writes. 2020-08-03 jmadill@chromium.org Vulkan: Move Resource Serial gen into Renderer. 2020-08-03 jmadill@chromium.org Trace Tests: Disable timestamp queries. 2020-08-03 jonahr@google.com Metal: Enable EGL_KHR_surfaceless_context. 2020-08-03 nguyenmh@google.com Add vertex array serialization capability If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I61df037e5b57fe2cbc1c6b1a3516736053404134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335830Reviewed-by:
-
Reilly Grant authored
When platform-specific logic from UsbDeviceImpl and UsbDeviceLinux was marged into UsbDevice the version from UsbDeviceLinux, which incorrectly iterated over the swapped list of open handles, was used. This change fixes that typo so that handles are once again closed when the device is disconnected. Bug: 1106051 Change-Id: I53eabd25b5799d32d2db7da5665b481abade2d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300880 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#794359}
-
Sangwoo Ko authored
Simplifies SetProfileIdentityInfo() with ui::ImageModel. There's no intended behavior change. Bug: 1100835, 1100034 Change-Id: Iaf692748ebbcae8703e8829bc838cdeba90bdf02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319486 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#794358}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596470392-1db0b1fcfff2e5dea91624929cca8d9002b8d6ad.profdata to chrome-win32-master-1596488085-5cc589a537a51c7f4881b4c0be2ff92ccb84b267.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib758ea96d6f07f9094091963c5530578ccb68470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335831Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: none Change-Id: Ib7e881a73fbdb9ef73e1c94384e1c10cc56511ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334099 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794356}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9dedfc814fbb..7eb25ea3b96d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1108963,chromium:1111132,chromium:1112125 Tbr: yutak@google.com Change-Id: I05f4100a7b90d97a0f719893408f42ba7ff334c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335829Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794355}
-
Keishi Hattori authored
Move WebFrame::SetOpener() to after Frame construction so we can move the WebFrame::opener_ field to Frame in a followup CL. LocalFrame::Init() uses the opener to set the security origin. So SetOpener() needs to be called after Frame construction but before LocalFrame::Init(). Bug: 1100056 Change-Id: Ic3967eaff904342983b561ce31889a301cfc8742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331957Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794354}
-
Yuheng Huang authored
This change makes close tab more responsive. Since TabStripModel::CloseWebContentsAt() mostly return false, how fast TabsChanged() is sent to the web/js side depends on the debounce timeout value. Bug: 1099917 Change-Id: Icd7c2a5bc45ba2b8361f8ccc5d61033ed0103462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335505 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#794353}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6b7d25eed32d..7e30909bf44a 2020-08-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5963c7d6..577fe5ff (794142:794277) 2020-08-03 titovartem@google.com Refactor PC level smoke test for adding new network stats reporter 2020-08-03 titovartem@webrtc.org Revert "Stop using RTPFragmentationHeader in sdk/android as unneeded" 2020-08-03 marinaciocea@webrtc.org Revert "Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader" 2020-08-03 philipp.hancke@googlemail.com sdp: reject sdp with malformed b= lines 2020-08-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision adcdc473..5963c7d6 (794031:794142) 2020-08-03 danilchap@webrtc.org Stop using RTPFragmentationHeader in sdk/android as unneeded 2020-08-03 philipel@webrtc.org Revert "Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory." 2020-08-03 philipel@webrtc.org Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory. 2020-08-03 danilchap@webrtc.org Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader 2020-08-03 nisse@webrtc.org Delete old name ProcessAllMessageQueues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4afa3bbb44c4f80e2e4b5c47692e3140b528de4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335342Reviewed-by:
-
Xinghui Lu authored
Move the FillRequestProto function into the base class. Add a virtual function named GetDMTokenString. For consumer requests, GetDMTokenString always returns an empty string; for enterprise requests, GetDMTokenString returns the value of the dm token. Bug: 1085261 Change-Id: I79e1ae6cdabb7e5024ef77798c8a608ac1c1ce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321725Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794351}
-
Victor Costan authored
This CL removes some small differences in the plumbing used by //chrome/browser unit tests that use MockQuotaClient, and fixes clang-tidy warnings. This will make future changes around adapting Quota for the Storage Service easier to review. Change-Id: I16bec46206021629c615ed094f5335e454c393af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330073 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Aaron Colwell authored
This change refactors the extension code so that it stops relying on site URLs to get the StoragePartition for a specific extension ID. This is part of a larger effort to remove site URL usage around the codebase. - Added HasIsolatedStorage() to ExtensionsBrowserClient so that code in extensions/ could access the chrome/ specific logic for determining whether an extension requires isolated storage. - Moved StoragePartitionConfig logic into extensions/browser/ so it could be used by GetStoragePartitionForExtensionId(). - Reworked extensions::util::SiteHasIsolatedStorage() and extensions::util::HasIsolatedStorage() so that the latter has the real logic, and the former just extracts the extension_id from the site URL and calls the HasIsolatedStorage(). - Updated ChromeContentBrowserClient logic in terms of these new functions. Bug: 1085275 Change-Id: I9924e36137ccc7d9667e5040b7647b5bd7a8d067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328211 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
Bug: 1014174 Change-Id: Ia5271e8dff20c316e5ca0391238c27480e83f602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332064Reviewed-by:
-
Alexey Baskakov authored
Minor fix for detection if transformation required. This was found while investigating the blurry icons bug. Bug: 1108889 Change-Id: I52514900d5c154983139a1a08c75b3505824a2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331962 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This includes: (1) Adding 4 new mojom::Feature values: one for the top-level feature, and 3 for sub-features. (2) Adding new preferences for enabled/disabled state as well as enterprise policy state for these features. (3) Integrating these new values into FeatureStateManagerImpl. This process included adding some edge cases (e.g., disabling Phone Hub notifications implicitly disables the Phone Hub notification badge). (4) Adding relevant histograms and updating enum values. Note: Phone Hub will be opted out by default for existing users, but this CL just opts all users in by default. A future CL will implement this functionality. Bug: 1106937 Change-Id: Ia00c814bf81a2a3eaa2238c6caa95ab9a5332dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334398 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Tom Sepez <tsepez@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#794346}
-
Maria Villarreal authored
Change got reverted since SessionRestoreTest.Basic failed on Mac. Since the test relies on focus, moving it to interactive_ui_tests. Description from original change (https://chromium-review.googlesource.com/c/chromium/src/+/2284382): Issue: - When On startup setting is set to "Continue where you left off", the initial focus is not set after launching the browser. - Users have to press Tab to focus the window. - This affects users who rely on screen readers since the window information is not announced on launch (on UIA mode). More context: - The line calling SetInitialFocus was previously in the code but got removed after a startup focus refactor: https://chromium-review.googlesource.com/c/chromium/src/+/1313728 - The refactor added the call to RestoreFocus on BrowserView::OnWidgetActivationChanged if the property restore_focus_on_activation_ is set to True. This property gets set during BrowserView::Show, but only in the case of session restore, Show gets called after OnWidgetActivationChanged so RestoreFocus is never called. - The inverted call stack on session restore is because AddRestoredTab on browser_tabrestore calls Activate before showing the window. Fix: - Similar to what we currently have for MacOS, only call Activate in AddRestoredTab if it is not |from_session_restore|. This way Show will be called before Activate and thus focus will be set as expected. - This change is only made on Windows due to a couple of reasons 1) crbug.com/1102685 is only present on this platform. 2) Making this change on Linux would re-introduce crbug.com/1019048. Bug: 1102685, 1110239, 1110240 Change-Id: Idc61e8ba713bf5a2deb23f085c0cdd08de30eb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324482 Commit-Queue: Maria Villarreal <mavill@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794345}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1d22c8786c90..1e1d958fbd8d 2020-08-03 joselea@microsoft.com Logic to log event for panel closed. 2020-08-03 jalyn@microsoft.com Fix Custom Shortcuts styles for narrow screens If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1074732,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0b69b895ca26a0095f018950dcd01c28619c6969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335818Reviewed-by:
-
Rakina Zata Amni authored
It's now possible to disable bfcache through an enterprise policy (and command line) as of crrev.com/c/2329107. We should track this on bfcache's NotRestoredReason metrics. We're also adding another NotRestoredReason for disabling due to low memory device. Bug: 511340 Change-Id: Iee9023549d6e57966362beebc8ccdfc1a2fba6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331994 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Mehrdad Hessar authored
Change-Id: I5130c97e01eaa7a8fe260058fe9c98740f1028b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321717 Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#794342}
-
Evan Stade authored
The functionality provided is the same across all three delegates. Fold it into SecurityInterstitialPageController. Bug: 1073624 Change-Id: I060e9bf2a92bbd39e68ca8d2b431041a1acdc621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329156Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#794341}
-
Wei Li authored
LabelButtonLabel class is only used by LabelButton class. To be used in tests, it is still exported. This makes it clearer that this class should not be used externally. Bug: none Change-Id: I3ccf4adb118075dc57db3041f6de7018f5534c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324208Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#794340}
-
Tsuyoshi Horo authored
Bug: 1082020 Change-Id: I8c285e2638c88a3846d7456c341e12f9561b01b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332059Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
minch authored
See spec at: https://drive.google.com/file/d/1R6AdSe7kIYzeVceTmVYN5jx567kQbdAh/view See pic with Japanese: https://drive.google.com/file/d/1tRNTMTzIHl-12bVsB0NXKzy5x_6-Zrun/view?usp=sharing Bug: 1076313, 1103952, 1104007, 1104008 Change-Id: I2a3515c6b4c7e8817acaf76fc87e9db9d83f6391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333489Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2dc2064dda5..093de4eb2ca9 2020-08-03 reed@google.com Use more of pathbuilder 2020-08-03 jvanverth@google.com Revert "Revise GrMtlGpu::onUpdateBackendTexture." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I7a1e94ea52f50b4fe8cc50d7ddb771ac48b03e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335798Reviewed-by:
-
Joel Hockey authored
Follow up with test for crrev.com/c/2316182 Bug: 1108710 Change-Id: I1e13c07dc4afb2d3f762d9361166a5005509326b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316966 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#794336}
-
Kenichi Ishibashi authored
The method is used by ServiceWorkerRegistry and it creates a ServiceWorkerVersion in DidGetRegistrationsForOrigins(). The method should pass a ServiceWorkerLiveVersionRef so that a ServiceWorkerVersion can keep it during the lifetime of the ServiceWorkerVersion. This CL: * Merges SerializedServiceWorkerRegistration into ServiceWorkerFindRegistrationResult as these are almost the same. * Moves |status| out of ServiceWorkerFindRegistrationResult because it doesn't much make sense for GetRegistrationsForOrigin() * Tweaks ServiceWorkerStorageControlImpl to create ServiceWorkerLiveVersionRef for GetRegistrationsForOrigin() This CL doesn't pass a live version reference to ServiceWorkerVersion yet. A follow-up CL will pass the reference to it. Bug: 1055677 Change-Id: I408f741e7f6a199fdc162f4e68c98233b2b6a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331961 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f80ffe327978..ce6a663ce577 2020-08-03 bsheedy@chromium.org [Devil] Retry forwarder pkill on -9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789 Tbr: skyostil@google.com Change-Id: I4fb6325dc9aeffc1691bb07e8387d394ed154e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334681Reviewed-by:
-
Melissa Zhang authored
This CL adds app icons to the Sharesheet. It also removes the default margin in ShareActionView. Bug: 1097623 Change-Id: Ia9f58543d89863b97472fbbb11c6d499cad2ee25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331759Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
