- 04 Nov, 2020 40 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7aa75755bd7c5148fa2b29f9e944f2768427830a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518797Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#824148}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8a275449c2e8..4989667a9c4c 2020-11-04 syoussefi@chromium.org Vulkan: Make ImageHelper::flushStagedUpdates take gl::LevelIndex 2020-11-04 jmadill@chromium.org Trace Gold Tests: Fix filter name. 2020-11-04 lehoangq@gmail.com Metal: Enable dEQP GLES3 tests on AMD 2020-11-04 ianelliott@google.com Vulkan: VVL errors once again cause dEQP tests to fail 2020-11-04 m.maiya@samsung.com Vulkan: Add support for VK_KHR_image_format_list extension If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I83756de45dff316dd4811bd70faffdb587eeef0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518396Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824147}
-
Kevin Babbitt authored
This CL plumbs CSSTokenizedValue down to CSSVariableData and uses it to keep a copy of the original text of the custom property. CSSVariableData also gains a Serialize method that returns the original text if available. Bug: 661854 Change-Id: Ieb2978b926671819b854ac04ff3a571b2989c73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346856Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#824146}
-
Peter Kasting authored
Nearly all of this CL is removing the unused |event_flags| parameter everywhere, which allows for a simpler binding syntax at the lone callsite I'm functionally changing. Bug: 772945 Change-Id: Ia31f872d1fc58e102c9c185cf8d593176d06c6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519855 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824145}
-
Michael Checo authored
Screenshot: http://shortn/_BdvyNYw4ov Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I1433ac215c770c9f30e043b77345b371a0d93d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517902Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#824144}
-
cfredric authored
be as obvious and early as possible. This also makes some simplifications in the implementation, namely: * Using a single set to track all FPS elements, rather than separate sets for owners and members; * Building the mapping directly, rather than building a vector to be transformed into the map. Change-Id: Ia5d45e8d728e85f7831e7930021fa9bfaec45240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517702Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#824143}
-
Yue Zhang authored
This reverts commit 3474d136. Reason for revert: Try to fix the failed test. Original change's description: > Revert "Suppress TabStrip IPH when bottom sheet shows" > > This reverts commit fffc75e9. > > Reason for revert: New test consistently fails Marshmallow 64-bit Tester bot. > See: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester > > Original change's description: > > Suppress TabStrip IPH when bottom sheet shows > > > > This CL hides TabStrip IPH when bottom sheet shows and reshows IPH > > right after bottom sheet hides. This CL is gated by Finch parameter > > "enable_launch_bug_fix" under flag "enable-tab-grid-layout", with gate > > function TabUiFeatureUtilities#isLaunchBugFixEnabled. > > > > Bug: 1135926 > > Change-Id: I97c80177b3fabf82aab751c6bf95a1c9b1e27432 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506618 > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823416} > > TBR=mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > Change-Id: I942224058529eb3e2eda72ca531f30d61d984724 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1135926 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518083 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823643} TBR=nyquist@chromium.org,mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1135926 Change-Id: I9dba86c6464f53ef76a8613af759258eee6f3931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518262Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824142}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604491008-5013724a12e21f5f9a4783fc91443d2909a128dc.profdata to chrome-mac-master-1604512659-45eb42cef0308750e2a844fa6affa8130c8ae0d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I40304dbd69fddb735bd9e80f73c42c58eb5ebede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518928Reviewed-by:
-
James Hollyer authored
This CL enables the Pointer Lock Options flag by default. Bug: 1124396 Change-Id: I8667dcba40dae0a62ac90d7e6453ee9776e158fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518107Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#824140}
-
David Black authored
The views for holding space items are inserted at a calculated index during item finalization. This requires us to determine which section of holding space UI these views belong to which is based on type. The previous calculation which returned whether or not two types belonged to the same section of holding space UI was flawed which could result in mis-calculation of index during item finalization. Bug: 1130625 Change-Id: Ib2211531c3281d525dd2bf2a5eac0ae985d94755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519057Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#824139}
-
Caitlin Fischer authored
Histograms that are whitelisted because they have expired should mention in their summaries the period for which there is incomplete data. Change-Id: I95f4e6946a0cab3fe3b3a92557385fa11c9d8a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519398 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824138}
-
My Nguyen authored
Bug: None Change-Id: Icd11d5edca583b42c7d63b79d679936aad2e8e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517343 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Alex Turner authored
base::Bind, base::Callback and base::Closure are deprecated and should be replaced with the more explicit base::Bind{Once,Repeating}, base::{Once,Repeating}Callback and base::{Once,Repeating}Closure. This cl finishes the conversion started by crrev.com/c/2493044 and removes the directory from the legacy exception list in PRESUBMIT.py. Bug: 1141564 Change-Id: Iaac5f197d740c806ded30ddbaea5c32015a118a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518030Reviewed-by:Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824136}
-
Jesse McKenna authored
This change moves function GetSanitizedFileName(), used to sanitize web-app names for use as filenames on Windows, to the Windows-specific file web_app_shortcut_win. This also removes logic for non-Windows operating systems from the function. GetSanitizedFileName() is only used on Windows: its only callers are in web_app_shortcut_win.cc and web_app_handler_registration_utils_win.cc. Change-Id: I06aff89548636c986de0eca637b5a9c54d699505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508362Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#824135}
-
Matt Reynolds authored
chrome://bluetooth-internals used HTML imports, which have been deprecated along with other Web Components V0 APIs. The imports have been replaced with regular <script> tags. Bug:1110954 Change-Id: Ie7041825896a316af9617cb44dd9eeffc0a33de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487688 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824134}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604491008-3c33d4506f1877c8f5c193fdb795c1a4d1ae6438.profdata to chrome-linux-master-1604512659-4b84fe5629f68a4167b75a88f505e98c0dbfa654.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If8d8684a4468ecada1e3f6dba195c68da2d2063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518927Reviewed-by:
-
Sahel Sharifymoghaddam authored
Example failure: """ Test that Inspector.targetReloadedAfterCrash is not fired when service worker just created(not restarted) Started and attached to service_worker target Stopped service worker and received Inspector.targetCrashed event FAIL: targetReloadedAfterCrash received for a new service worker """ TBR=yurys@chromium.org Bug: 1046784 Change-Id: I2415e6918957050273640c03e9d6a3b670eb4177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519735Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#824132}
-
Olivier Robin authored
Metric reports the time a NTP is on screen. Incognito NTP are not reported. Bug: 1131209 Change-Id: I25fb6bb004efd89cbef855e2455c71f616986e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487105 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#824131}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ib78e6fbdb96503f4ce6687b07300f0421fb3d26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519834 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Joel Hockey authored
Change drag and drop to also use callbacks for data fetching like how clipboard does. Ensure callbacks are only invoked once with data cached, and pending receive requests managed. Files drag and drop will require this to allow file sharing to be done inside FileHandler at the point where a client calls data_offer_receive, rather than when FileHandler is currently invoked when data is offered. This change provides performance improvements particularly for when an image is requested multiple times from the clipboard since we now only do the encoding once. Bug: 1144138 Change-Id: I56c7d3b55a3365a591829313462af23e71e172b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509833Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824129}
-
Peter Wen authored
Explicitly match only on literal . characters instead of any characters. Add explanatory comment. Bug: 1078229 Change-Id: I1f248d270ebd22f17aebaad55750d5bed9a275a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519897 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824128}
-
John Williams authored
Bug: 1137962 Change-Id: Id19178ecc46231eef71ccb9e16d27e1aafdd1470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468567 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#824127}
-
Shawn Quereshi authored
Test coverage for public MessagePort interface and its interactions with MessagePort::Receiver. Includes conversion to and from the underlying platform type of MessagePortCast or MessagePortFuchsia. Bug: 1135377 Test: //components/cast/message_port:message_port_test added Change-Id: I5e51aa5e08eb1e3e8957963b033497a94fe0bdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515208 Commit-Queue: Shawn Quereshi <shawnq@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824126}
-
Sahel Sharifymoghaddam authored
TBR=rmcilroy@chromium.org Bug: 1145641 Change-Id: I73febb2d64caf8c1c8b678f67e50c6102bcf50df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519580Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This CL removes the last references to webprotect.proto in SafeBrowsingUI, so the proto file and include statements can be removed. Bug: 1103390 Change-Id: I8a991c5331b052f6438203bc41a9be6487029c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510791Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#824124}
-
Sigurdur Asgeirsson authored
Also move ScopedObservation into the base namespace. It's an oversight that it wasn't there in the first place. Change-Id: I854bc0c96af72dff096894cd3b82cd7710f6add3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519271Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824123}
-
Fredrik Söderqvist authored
Replace VisualRectInLocalSVGCoordinates() with StrokeBoundingBox() since they are now returning the same value. Drop the out-of-date comment for the same reason. This also means that the special treatment of containers can also be simplified to just consider if the object bounding box is valid. Bug: 1028061 Change-Id: Ic0bcdc5376f253980dbf2448a5ad6330fea414b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517527Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#824122}
-
Joon Ahn authored
Bug: 1059779 Test: autoninja -C ${OUT} chrome/test/data/webui:closure_compile Change-Id: I8b6ea9a5290e7d203344fbd42041332dc4a6fc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514594 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by: -
Fredrik Söderqvist authored
Since most resources - markers excepted - no longer influence layout, we can burn down most of SVGLayoutSupport::LayoutResourcesIfNeeded, only leaving the essential bits (marker layout). Move the remnant of the function closer to its single user. Move the |is_in_layout_| member field from LayoutSVGResourceContainer to its LayoutSVGResourceMarker subclass. Bug: 1028061, 1028063 Change-Id: I87188dd6673df3b3eba3e5a49deb61669ce9b249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517501 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: If7c1862ff6b88af98be69d09722e3a086bd030e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516251 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#824119}
-
Matt Reynolds authored
This CL adds standard mapping functions for Sony DualSense Wireless Controller on Mac, Windows, Linux, and Chrome OS. (No Android support is included.) The device has advanced haptics features that are not yet supported. BUG=1144906 Change-Id: Id2985d18fe426db93e870fcc55351347cb9de78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515099Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#824118}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9d6265bc0725..6564890116fd 2020-11-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from de6938789ccb to 77f7bb5b005d (18 revisions) 2020-11-04 cwallez@chromium.org Reenable DepthBias tests on Swiftshader 2020-11-04 enga@chromium.org Support sampling depth and stencil of combined d/s formats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibeba13c6ff83edefd16bfce4c5e10e5912a5c628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519579Reviewed-by:
-
Victor Costan authored
This CL replaces the following pieces of custom infrastructure with standardized pieces. 1. A custom callback pump consisting of ScheduleNextTask(), PushNextTask(), and TestFinishedUnwound() is replaced by base::RunLoop and base::TaskRunner::PostTask(). 2. A custom threading setup consisting of a base::test::TaskEnvironment, a base::Thread simulating the IO thread, a base::WaitableEvent, and TestFinished() is replaced by content::BrowserTaskEnvironment and base::RunLoop::QuitClosure(). This CL also moves the following shared methods from the test area to the shared methods area. * WriteOneBlock * WriteOutBlocks * ReadInBlocks * ReadOneBlock * VerifyOneBlock Last, this CL moves OnReadInfoComplete() from the shared methods area to the area of the only test that uses it. The CL leaves the file's overall structure in place, to facilitate review by offering anchoring points for the diffing algorithm. The motivation for this refactoring is that the QuotaClient mojofication benefits from having this test use a content::BrowserTaskEnvironment. Bug: 1016065 Change-Id: I10945be179fa705b4048011dfda27be3e696d4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518726Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824116}
-
Meilin Wang authored
This CL removes confirmation button on Bluetooth disabled screen to reflect the spec change. Screenshot: https://screenshot.googleplex.com/zYMuE9QXvJbEDkr.png BUG=1145315,1106937 Change-Id: I95f6ea75c9ce0b381467d8515a69faabea42057d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518249Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#824115}
-
shivanigithub authored
This CL makes the cache key for an iframe document different from that of a sub-resource with the same URL, to mitigate the following cache attack that can happen due to cross site timing leak. 1) Top-level site a.com loads sub-resource a.com/img. The current cache key for the resource is (a.com, a.com, a.com/img) 2) If an evil.com iframe on the page then iframes a.com/img, the key for that iframe's navigation resource will also be (a.com, a.com, a.com/img) even though in step 1) a.com/img was a subresource and in step 2) it was an iframe document resource. Adding a bit to differentiate the 2 cases will help mitigate the attack so that evil.com cannot time a.com/img onload handler to see if it was retrieved from the cache. Note that this attack is possible because the subresource and it's frame are same-site. Bug: 1135149 Change-Id: Ic1cabdda72657f5cbcc0109da557c538b2a8b143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487704 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#824114}
-
Ian Barkley-Yeung authored
The WebUI WebContentsObserver wants to report error messages from the main frame but not subframes. Add the generating frame to DidAddMessageToConsole and OnDidAddMessageToConsole to allow us to determine which frame generated each message. Bug: chromium:1121816 Change-Id: I7a4ab8f4043f6b7df562505a5fd475cb1e206fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518792Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#824113}
-
Peter Kasting authored
Bug: 772945 Change-Id: I51af3cf1070b81f8458dec3a6e28cb1625944dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518711 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Tim Song authored
The onboarding screen has two separate flows that need to be logged distinctively for metrics. BUG=1144056,1106937 Change-Id: If36d91a2f734c1f89f49fe2eae500283151ed184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519155Reviewed-by:
-
Corentin Wallez authored
WebGL2Compute was a prototype of a way to run GPU compute workloads on the Web but is superseded by the WebGPU API being standardized in the "GPU for the Web" W3C group. Since WebGPU has been available behind a flag for a while now, we remove the Blink code for WebGL2Compute that's essentially dead at this point. This CL: - Removes the WebGL2Compute interfaces and canvas context type. - Updates some of the common WebGL code to remove WebGL2Compute specific code. - Removes the --enable-webgl2-compute-context flag. - Updates the WebExposed test with the API's removal. Note that the CL doesn't remove GLES 3.1 support from //gpu/command_buffer that's still useful for fuzzing ANGLE. In a follow-up CL the ability to start a GLES 3.1 command buffer will be put behind a build flag. Bug: chromium:1131991 Change-Id: Ib43fbda4da7962a7261b8b8eae36c225b666d795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505795 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#824110}
-
Yuke Liao authored
Stop isolating prebuilt ash-chrome because builders have switched to build ash-chrome from tot. Bug: 1129223, 1145628 Change-Id: I3d6894e9359473b415ea40d5511541aed89c5b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519833 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#824109}
-
