GitLab

disable_outdated_build_detector_unittests only builds on 32-bit so having it
as a target on a 64-bit bot makes no sense.

BUG=640667
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2268823005
Cr-Commit-Position: refs/heads/master@{#414195}

There is an old tab_state file in the tabbed mode state directory. If
it is not deleted and the new tab state is written to the new
tab_state0 file, then when it comes time to run the migration code in
TabPersistentStore the old tab_state file will be given preference
and overwrite the new one with all the document mode tabs that were
just migrated. Thus we need to delete the old tab_state file if it
exists.

BUG=640625

Review-Url: https://codereview.chromium.org/2274943002
Cr-Commit-Position: refs/heads/master@{#414194}

BUG=626752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2264673002
Cr-Commit-Position: refs/heads/master@{#414193}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bf97a9b56b2e52c181449842c6661bff57f7bed9 [Skia] Handle Gerrit patches in swarm_trigger for the Infra-PerCommit bot. (rmistry@google.com)
  https://crrev.com/5c8f9ca183558efd72da8de33fc764f2083ff054 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/da7d759d2b8a6a43fbbc882bd6e0fb5f6847f4d2 Make webrtc recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/48c9aab3cb53a5c254ec5d2d6fcf62e8c6d6fd0e Make bisection recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/12067f7d61f048f13b41feb9a59635df911af6af Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/a6d4645baf26287ae6c0870a1206624bfa59fd83 Make skia recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/ecde496f342028076fcfe127b34955524824b477 Created a line of summary and enabled suite name onclick function. (hzl@google.com)
depot_tools:
  https://crrev.com/eab3c0431157226b2638af23545d3f17bd04a25d Change "tryjob" -> "try job" in git_cl.py and trychange.py. (qyearsley@chromium.org)
  https://crrev.com/12fa6ff69b21737c315ccad0d92f1bccf83fee6c Run auto-spell-checker (codespell) on files in depot_tools. (qyearsley@chromium.org)
  https://crrev.com/92bec4f56f991d35ddcf9c4d8a0bdd8ce1b10735 Delete gcl, drover, and trychange (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=475321,640251,skia:5627

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2271243003
Cr-Commit-Position: refs/heads/master@{#414192}

R=sebmarchand@chromium.org
BUG=314403

Review-Url: https://codereview.chromium.org/2278713002
Cr-Commit-Position: refs/heads/master@{#414191}

Removed unused histograms.

BUG=639365

Review-Url: https://codereview.chromium.org/2270183002
Cr-Commit-Position: refs/heads/master@{#414190}

Implement GetScreenInfo() and UpdateDeviceScaleFactor() for
InterstitialPageImpl so that interstitial pages get the correct device
scale factor both when they're initially created, and also if the window
they're in gets dragged between displays with different device scale
factors.

BUG=637462
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2265213002
Cr-Commit-Position: refs/heads/master@{#414189}

Update the close button image and fix tapping-not-working issue
since making changes to the file.

BUG=640399
BUG=b/30814819
BUG=b/30917629
TEST=Manual. Verify new close button image on arc notifications.
    And tapping to close works.

Review-Url: https://codereview.chromium.org/2269143004
Cr-Commit-Position: refs/heads/master@{#414188}

BUG=636405
R=skyostil@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2274933002
Cr-Commit-Position: refs/heads/master@{#414187}

There was some hope that the ui::CompositorVSyncManager could be removed
once --enable-begin-frame-scheduling was turned on.  Unfortunately, the
vsync manager is used by two additional systems that can't be easily
removed: DelegatedFrameHost::AttemptFrameSubscriberCapture as well as
components/exo/wayland/server.cc.  The latter may go away eventually.
If so, then the frame capture could then be changed to more simple
polling as needed instead of vsync manager and observer system that
needs to be plumbed everywhere.

In the medium term, the vsync manager needs to live on in all paths.
This means that BrowserCompositorOutputSurface and ui::Compositor always
need to update the vsync manager with changes.  Conditionals for
whether or not to send vsync information to renderers just get moved
down the pipeline from the output surface to DelegatedFrameHost.

Review-Url: https://codereview.chromium.org/2277883002
Cr-Commit-Position: refs/heads/master@{#414186}

BUG=633489

Review-Url: https://codereview.chromium.org/2262343002
Cr-Commit-Position: refs/heads/master@{#414185}

https://chromium.googlesource.com/skia.git/+log/3bf7509c3f68..168261287136

$ git log 3bf7509c3..168261287 --date=short --no-merges --format='%ad %ae %s'
2016-08-24 caryclark mark fuzz test flaky since it may fail on some platforms
2016-08-24 halcanary gyp/sfntly: set SK_SFNTLY_SUBSETTER uniformly
2016-08-24 mtklein GN: guard tools (except fiddle) by skia_enable_tools.
2016-08-24 mtklein SkPngCodec: voidp instead of forward-declares for png.h types.
2016-08-24 ajuma Fix leak in GrTextureStripAtlasTest
2016-08-24 bungeman s/invertable/invertible
2016-08-24 caryclark tiny line breaks gl render
2016-08-24 fmalita Fix SkTLazy(const T*) initialization
2016-08-24 mtklein GN: Fuchsia probably cannot link without this.
2016-08-24 halcanary SkPDF: vector canvases can't hint!
2016-08-24 mtklein GN: more optional components: jpeg, pdf, png, xml
2016-08-24 caryclark remove point aliases
2016-08-24 halcanary SkPDF: vertical writing: draw nothing
2016-08-24 bungeman Add simple font fallback on Mac.
2016-08-24 ajuma Make GrTextureStripAtlas flush pending IO on newly acquired texture
2016-08-24 msarett Parse ICC profiles from webps
2016-08-24 egdaniel Add addtional resolve calls to vulkan backend

BUG=637678,640176,637571,637678

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bungeman@google.com

Review-Url: https://codereview.chromium.org/2274283002
Cr-Commit-Position: refs/heads/master@{#414184}

When MojoRendererService::OnError is called (e.g. for a decoder error),
state_ becomes STATE_ERROR, but the media player next pauses playback,
calling SetPlaybackRate(0), and hitting this DCHECK.

BUG=

Review-Url: https://codereview.chromium.org/2276663003
Cr-Commit-Position: refs/heads/master@{#414183}

getDownloadEntryFromIntent() always assume intent is for regular
download.
This causes chrome to use DownloadManagerService rather than
OfflinePageDownloadBridge when clicking on a notification.
This change fixes the issue by adding an extra field for offline page.

BUG=640467

Review-Url: https://codereview.chromium.org/2278663002
Cr-Commit-Position: refs/heads/master@{#414182}

Previous routes must now have equal or lesser depth.

BUG=640323
R=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2271003003
Cr-Commit-Position: refs/heads/master@{#414181}

When deleting cache in settings, the user-requested pages shouldn't be
deleted. Adding a check for namespace in the method called by browsing
data remover, filtering out the user-requested pages.

BUG=640416

Review-Url: https://codereview.chromium.org/2275833002
Cr-Commit-Position: refs/heads/master@{#414180}

BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2270873002
Cr-Commit-Position: refs/heads/master@{#414179}

BUG=none

Review-Url: https://codereview.chromium.org/2278673003
Cr-Commit-Position: refs/heads/master@{#414178}

Behind --enable-experimental-web-platform-features flag.
Not yet hooked up on Android.

Intent to implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FQxPB5GEQjo/discussion

Screenshot: https://imgur.com/a/mUdgu

BUG=614456

Review-Url: https://codereview.chromium.org/2261283002
Cr-Commit-Position: refs/heads/master@{#414177}

If a frame that contains the focused plugin is destroyed,
we leave a dangling pointer in the RenderWidget.

BUG=640733

Review-Url: https://codereview.chromium.org/2276053002
Cr-Commit-Position: refs/heads/master@{#414176}

BUG=611981

Review-Url: https://codereview.chromium.org/2266353005
Cr-Commit-Position: refs/heads/master@{#414175}

BUG=

Review-Url: https://codereview.chromium.org/2270063004
Cr-Commit-Position: refs/heads/master@{#414174}

Adding nullability support for the ImageBitmap parameter passed to ImageBitmapRenderingContext.transferImageBitmap

BUG=588243

Review-Url: https://codereview.chromium.org/2251493003
Cr-Commit-Position: refs/heads/master@{#414173}

GbmBuffer::CreateBuffer assumed that the buffers allocated by minigbm
contained only one plane.

This patch let GbmBuffer::CreateBuffer create multi-planar buffers.

BUG=618516
TEST=gl_unittests. crrev.com/2262353002 for a YUV test.

Review-Url: https://codereview.chromium.org/2279553002
Cr-Commit-Position: refs/heads/master@{#414172}

This is in preperation for CodeMirror-based console

BUG=607690

Review-Url: https://codereview.chromium.org/2269183003
Cr-Commit-Position: refs/heads/master@{#414171}

Although key path evaluation is always done against clones (so getters
are flattened into simple data properties), property lookups were
not restricted to inherited properties, allowing getters on prototypes
to be executed. This allows evaluation to be observable, and cause
side effects.

Restrict the lookup to own properties, and introduce special-case code
for those non-own values identified in the spec[1] as special cases.

[1] https://w3c.github.io/IndexedDB/#key-path-construct

BUG=637963
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2255413004
Cr-Commit-Position: refs/heads/master@{#414170}

Chrome has been using the readonly field returned by GetDeviceProperties in cros_disks API to tell whether a disk device is wriatble or read-only. However, the field is based on the physical writablilty of the block device, not reflecting the "ro" flag passed to the mount command. This will be an issue once we introduce read-only mount policy.
DiskMountManager needs to remember it because neither the "mount completed" and "disk profile got" DBus messages doesn't convey that information at the moment.

TEST=chromeos_unittests, and manually see that Files app shows no-entry icon when you drag a file to an external storage device from Drive. Apply patch 2248033003 locally to simulate the external_storage_read_only option.
BUG=629945,640579

Review-Url: https://codereview.chromium.org/2230713003
Cr-Commit-Position: refs/heads/master@{#414169}

BUG=none

Review-Url: https://codereview.chromium.org/2250883003
Cr-Commit-Position: refs/heads/master@{#414168}

On MD user menu, vertical spacings in the profile card used to be
hardcoded, hence causing some display problems on certain locales
(see first bug for how Hindi names would get chopped off).

This CL calculates the spacing needed given the height of the profile
name label and/or username label in the profile card, hence fixing
the chopped-off problem - see a new screenshot here: https://screenshot.googleplex.com/FHK5snyG0PH.

BUG=636321
BUG=615893

Review-Url: https://codereview.chromium.org/2230963004
Cr-Commit-Position: refs/heads/master@{#414167}

They only flake on mac_chromium_rel_ng. I couldn't reproduce locally.

BUG=632816

Review-Url: https://codereview.chromium.org/2277893003
Cr-Commit-Position: refs/heads/master@{#414166}

Temporary code path that invokes fullscreen in lieu of proper VR presentation.
Also includes VRDisplayEvent and related code + casing change to VRPose "timestamp" attribute to match spec.

BUG=389343

Review-Url: https://codereview.chromium.org/2265053004
Cr-Commit-Position: refs/heads/master@{#414165}

This restriction is artificial; or at least I can't make it fail
when the profile changes. The hardware decoders I've tried (Android,
Windows, Mac) don't seem to care if the profile actually changes.

In fact, MSE has always lied about the h264 profile (!), it always
specifies H264PROFILE_MAIN regardless of the actual profile. The
only parser sending this information correctly is the TS parser
used by Chromecast -- which then hits this check.

If the profile is actually unsupported we will still fail during
the check of SupportedProfiles.

BUG=640269
TEST=http://storage.googleapis.com/dalecurtis/mse_profile_change.html

Review-Url: https://codereview.chromium.org/2273793002
Cr-Commit-Position: refs/heads/master@{#414164}

This is a refactoring change that shouldn't affect behavior.

Pros:
 - Removes a method; makes set-up of Command classes simpler.
 - Net decrease in lines of code.
Cons:
 - Requires explicitly setting self._tool in all subclasses
   of AbstractRebaseliningCommand in the execute method.

Review-Url: https://codereview.chromium.org/2276713002
Cr-Commit-Position: refs/heads/master@{#414163}

* Adding observer of Request Coordinator (as user data)
* Forwarding the notifications from observer to OPNotificationBridge
* Making RequestCoordinator capable of supporting user data
* Minor fixes to interfaces (virtual destructors added)

BUG=630817
R=dimich,petewil

Review-Url: https://codereview.chromium.org/2260963003
Cr-Commit-Position: refs/heads/master@{#414162}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae022b60c580..5bcf2c70f4dd

$ git log ae022b60c..5bcf2c70f --date=short --no-merges --format='%ad %ae %s'
2016-08-24 nednguyen Show trace's url in CSV output formater.
2016-08-24 oysteine Added a demo mapper for the trace processor
2016-08-24 rmcilroy [memory-metric] Extract v8:code_and_metadata from all memory dumps
2016-08-24 erikchen Add CPU metrics for Chrome on Mac.
2016-08-24 petrcermak [merge-traces] Support multiple sub-traces in a vulcanized HTML trace
2016-08-24 benjhayden Fix single-sample Histogram sample diagnostics
2016-08-24 nednguyen [Telemetry] Add browser_test_runnner.LoadAllTestsInModule method

BUG=640054,636153

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2277473005
Cr-Commit-Position: refs/heads/master@{#414161}

BUG=

Review-Url: https://codereview.chromium.org/2275843003
Cr-Commit-Position: refs/heads/master@{#414160}

s/stringResultHandler/completionHandler

BUG=None

Review-Url: https://codereview.chromium.org/2272133002
Cr-Commit-Position: refs/heads/master@{#414159}

BUG=615157

Review-Url: https://codereview.chromium.org/2198613002
Cr-Commit-Position: refs/heads/master@{#414158}

Prior to ArrayDataView, during deserialization, we read latency components outs
into a mojo::Array and then read the mojo array out into LatencyInfo's
latency_components_. This results in an unnecessary extra copy and is not
compatible with usage in blink. This CL moves us towards using ArrayDataView.

BUG=629566

Review-Url: https://codereview.chromium.org/2276743002
Cr-Commit-Position: refs/heads/master@{#414157}

Also adds some basic integer overflow checking and fixes undefined
pointer arithmetic in preexisting bounds checks.

BUG=631375

Review-Url: https://codereview.chromium.org/2182873003
Cr-Commit-Position: refs/heads/master@{#414156}