- 05 Dec, 2017 40 commits
-
-
Markus Heintz authored
- virtual/gpu-rasterization/images/color-profile-clip.html - virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb.html - virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb.html BUG=791941 NOTRY=true Change-Id: Id70d34e000a38280738b7937d108c082ad8d56ab Reviewed-on: https://chromium-review.googlesource.com/807932Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521655}
-
Gauthier Ambard authored
The toolbar has a shadown below it. Bug: 791469 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaf6ee9fe5190d2c4d5b6243bca3282d01ecba7ca Reviewed-on: https://chromium-review.googlesource.com/806175 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#521654}
-
Findit authored
This reverts commit d298a4dd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 521649 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyOThhNGRkNzMyZjA5YzlhMWMzMDZhMjA2NTA3YzEyM2EzNzYxZTIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/24801 Original change's description: > Replace WTF::Function with base::OnceCallback. > > This patch makes WTF::Function an alias of base::OnceCallback. After > this, all the single-threaded callbacks in Blink will become base > callbacks. > > This patch doesn't remove the WTF::Funtion type nor ConvertToBase- > Callback() function. The use sites of those names will be removed > individually. > > Bug: 771087 > Change-Id: I15e7758c29bb9f63b7db7ad7aba6c9cb2d9ae7d1 > Reviewed-on: https://chromium-review.googlesource.com/807672 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Yuta Kitamura <yutak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521649} Change-Id: I60fec5e188923122bb3b090acc49cfd0f0363df1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771087 Reviewed-on: https://chromium-review.googlesource.com/808224 Cr-Commit-Position: refs/heads/master@{#521653}
-
Greg Thompson authored
This reverts commit e1ccd581. Reason for revert: Widespread "Check failed: false. Observers can only be added once!" failures. Original change's description: > Enable interactive_ui_tests on Windows that now run mostly reliably. > > r516772 was the last of many commits that resolved a number of problems > that made this test suite flaky on Windows. This CL enables tests that > had been disabled over time due to flakes, yet now seem to run okay. > > BUG=133341,751031,751543,764415,789913 > This CL was uploaded by git cl split. > > R=sky@chromium.org > > Change-Id: I753c741a9194f489f072cd86d72407a1294150c3 > Reviewed-on: https://chromium-review.googlesource.com/784937 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521416} TBR=sky@chromium.org,grt@chromium.org Change-Id: I33b192c628fdfebe9cfd93b71abd3b394faad9e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 133341, 751031, 751543, 764415, 789913 Reviewed-on: https://chromium-review.googlesource.com/808204Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521652}
-
Koji Ishii authored
Following bot results are included. new-expected 0 lines were removed by consecutive passes since 0. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I522a7a341c807b38c8a72369e377495bbec06d4b Reviewed-on: https://chromium-review.googlesource.com/807756 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521651}
-
Kenneth Russell authored
Needed to get this bot green again. BUG=791733 TBR=ynovikov@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If14d4b875f650c2d7c4fb82393d4b3c3aad509cb Reviewed-on: https://chromium-review.googlesource.com/808124Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521650}
-
Yuta Kitamura authored
This patch makes WTF::Function an alias of base::OnceCallback. After this, all the single-threaded callbacks in Blink will become base callbacks. This patch doesn't remove the WTF::Funtion type nor ConvertToBase- Callback() function. The use sites of those names will be removed individually. Bug: 771087 Change-Id: I15e7758c29bb9f63b7db7ad7aba6c9cb2d9ae7d1 Reviewed-on: https://chromium-review.googlesource.com/807672Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#521649}
-
Jungshik Shin authored
1. Map Malaylam U+0D1F to 's'. 2. Map 'small-cap-like' Cyrillic letters to "look-alike" Latin lowercase letters. The characters in new confusable map entries are replaced by their Latin "look-alike" characters before the skeleton is calculated to compare with top domain names. Bug: 784761,773930 Test: components_unittests --gtest_filter=*IDNToUni* Change-Id: Ib26664e21ac5eb290e4a2993b01cbf0edaade0ee Reviewed-on: https://chromium-review.googlesource.com/805214Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521648}
-
Morten Stenshorne authored
It doesn't seem too interesting (given that we have other tests that test column-fill:auto), and the reference it's paired with has nothing to do with the test. Bug: 788337 Change-Id: Ic98b339219bee74fe07ebfa5778869cdd2bfa28e Reviewed-on: https://chromium-review.googlesource.com/806277Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521647}
-
Eddy Mead authored
This CL: - creates a new generator that creates AtRuleDescriptors.h/cpp in a very similar way to CSSPropertyNames.h/cpp. - creates a new "AtRuleDescriptorParser" to hold all the @rule parsing logic. - creates a new method in CSSParserToken that parses it as an AtRuleDescriptorID. - adds new templated methods in CSSPropertyValueSet to handle AtRuleDescriptorIDs. - updates the relevant parsing methods For now, descriptors appear both as AtRuleDescriptorIDs and in CSSPropertyID. This means I don't need to refactor CSSPropertyValueSet yet. Bug: 752745 Change-Id: I81df46b43cdac0835c918764254834873d45591f Reviewed-on: https://chromium-review.googlesource.com/754762 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#521646}
-
Kenneth Russell authored
This will help prevent breakage of the ANGLE CQ by running currently non-default configurations. BUG=none TBR=jmadill@chromium.org NOTRY=true Change-Id: Ib49f1a0911f7a1430f6dc513fea4573c5720a8b0 Reviewed-on: https://chromium-review.googlesource.com/808089 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521645}
-
Xi Cheng authored
Bug: 734095 Change-Id: Ie533f1b07f6bf8d284c199a1595258e1a6f887e9 Reviewed-on: https://chromium-review.googlesource.com/767848 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521644}
-
Kenneth Russell authored
Everything's now just a "machine". Absence of the test_suites key is no longer an error. Fixed two builders which were actually running the check_network_annotations.py script. BUG=662541 TBR=dpranke@chromium.org NOTRY=true Change-Id: I7c28088676974cdda402cf020d097e69614ecf12 Reviewed-on: https://chromium-review.googlesource.com/808084 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521643}
-
Gauthier Ambard authored
This CL removes GoogleLandingMediator/Consumer and moves their functionalities in NTPHomeMediator/Consumer. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iae7ca5707afd04933c189391a50e384940303eb2 Reviewed-on: https://chromium-review.googlesource.com/801012Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521642}
-
Patricia Lor authored
Follow up to r475019, which dismisses the (non-internal) page info bubble when using global browser hotkeys. This fixes the same issue, but for the internal page info bubble. Bug: 786361 Change-Id: If0a04f057e023871ff2b665d98941b836920625a Reviewed-on: https://chromium-review.googlesource.com/799651 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#521641}
-
mallikarjun82 authored
Bug: 504160 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Id1eeeb429ae3ca4bd28b44d731515c070bb7fec7 Reviewed-on: https://chromium-review.googlesource.com/790270 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521640}
-
Matt Giuca authored
This is to support https://crrev.com/c/792315, which adds a new observer for logging engagement-type UMA in PWA app windows. The major interface changes are: - Renamed OnEngagementIncreased to OnEngagementEvent to indicate that it is now for all events that modify engagement, not just increases. - OnEngagementEvent is now called on launch (so now every place where an engagement UMA is logged also corresponds to an OnEngagementEvent). - OnEngagementEvent now takes an EngagementType enum, indicating what caused the engagement event. Because the engagement type is now exposed through the observer (and can therefore be used for non-metrics purposes), it has been moved out of SiteEngagementMetrics into SiteEngagementService. Also refactored SiteEngagementService to record UMA from the OnEngagementEvent method, rather than in many places. Bug: 785661 Change-Id: I352d0363c9ee3a40293e7b99d5b8f6e75c0e999b Reviewed-on: https://chromium-review.googlesource.com/802661Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#521639}
-
Greg Thompson authored
It times out quite frequently. BUG=419468 TBR=grt@chromium.org NOTRY=true Change-Id: Ie8b8658dbad3e13c496267d8555c60b9e0a23702 Reviewed-on: https://chromium-review.googlesource.com/807905Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521638}
-
Prashant Malani authored
BUG=chromium:785338 TEST=fuzzer works. Change-Id: I2c51a5a5280079f08a012b409f616ac4112f4d6e Reviewed-on: https://chromium-review.googlesource.com/804832Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Prashant Malani <pmalani@google.com> Cr-Commit-Position: refs/heads/master@{#521637}
-
Klaus Weidner authored
The WebKit/Source/modules/vr/ code uses gfx::GpuMemoryBufferHandle and gpu::MailboxHolder for transferring frame images, these symbols shouldn't block presubmit checks. BUG=763980 Change-Id: I2f9fdd173f0173bdb51337d3943b590f42550528 Reviewed-on: https://chromium-review.googlesource.com/804742 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521636}
-
Shanmuga Pandi M authored
Bug: 771800 Change-Id: I7d5eb8b4049aaa3536723fd377a54b76929837a5 Reviewed-on: https://chromium-review.googlesource.com/800090Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521635}
-
Kenneth Russell authored
Add a new generation script, and a description of these waterfalls and the test suites that run on them. This CL subsumes the maintenance of 21,000+ lines of hand-written JSON. Many simplifications are now possible. The initial goal here was to replicate the existing JSON files verbatim, in order to guarantee that the behavior of the waterfalls would be unmodified. Many exceptions have been identified with various test suites and bots that can now be easily removed. The new script is unit tested and has 100% code coverage modulo a few exceptions. New presubmit checks will enforce this rigor going forward. Follow-on work will autogenerate the remainder of Chromium's waterfalls and unify with the GPU bots' generation script. BUG=662541 NOTRY=true Change-Id: I9a916d6f341bbd1495f0a61761628d7f4fb227ff Reviewed-on: https://chromium-review.googlesource.com/789793 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521634}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/218a522b36c1..3337fb647c42 $ git log 218a522b3..3337fb647 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 eakuefner [TBMv2] Fix deduplication for >2 histograms in JS Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3906695d5d478fed5febf540eb2020ae399ecb07 Reviewed-on: https://chromium-review.googlesource.com/807752 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521633}
-
Gauthier Ambard authored
If the omnibox expansion should be done without animation, stop the animator in its final position right after it begins. Bug: 791033 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7af68d6dcd43a0643365003f2b7fff70fec3dc72 Reviewed-on: https://chromium-review.googlesource.com/803714Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521632}
-
Yuzu Saijo authored
This CL depends on https://chromium-review.googlesource.com/c/chromium/src/+/721402. Bug: 777765 Change-Id: I887fc1db28c8b048a334bfe936635b29de431280 Reviewed-on: https://chromium-review.googlesource.com/743164 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521631}
-
Jan Krcal authored
This CL updates the testing config for the next round of Stable experiments. Bug: 738007 Change-Id: Icc30529156bdc9b8149aae1f1cbfbd4527e98c18 Reviewed-on: https://chromium-review.googlesource.com/806534Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#521630}
-
Yutaka Hirano authored
We can cause frame a detach event in a onclose handler (as in the added layout test), and that led to an inconsistent state. This change fixes the issue. Bug: 788890 Change-Id: I229336d89f7c9863f7d8a9770e5410ab76dc3dc9 Reviewed-on: https://chromium-review.googlesource.com/805594Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#521629}
-
Filip Gorski authored
Ensures that Metadata store closes itself after few seconds of inactivity. Updates tests for store, tasks and task-based model to use base::TestMockTimeTaskRunner Bug: 790566 Change-Id: I629835df8907320fcb86a54463f5b36e64fce9d1 Reviewed-on: https://chromium-review.googlesource.com/801330 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#521628}
-
sczs authored
Moves locationBarContainterView contents into a StackView. This way we don't need to juggle constraints related to iPad only Buttons ,Expanded toolbar buttons or locationBarView conditional constraints. Bug: 791203 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If04b58731c3042e450d0e2516917f89afae4698f Reviewed-on: https://chromium-review.googlesource.com/804940Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#521627}
-
Stuart Langley authored
This changes is for files in the path //t_p/WebKit/Source/core/frame/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I8753284e767ccaceabdbd3a67c935c1bcde71a04 Reviewed-on: https://chromium-review.googlesource.com/806736Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#521626}
-
Yoichi Osato authored
This reverts commit 895571d6. Reason for revert: This causes HUA. Original change's description: > Remove redundant SelectionState reassignment. > > Xor invalidation was shipped: > https://chromium-review.googlesource.com/c/chromium/src/+/720817 > > Then there is no inconsistency SelectionState in layout tree thus > we can just DCHECK its start/end state. > > Bug: 739062 > Change-Id: I6bb791568a76d47f7088c692d2960eddc34f570a > Reviewed-on: https://chromium-review.googlesource.com/798995 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520869} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 791484, 791293 Change-Id: Ie9679e069bbecc633a5c3818b8c8256598acb433 Reviewed-on: https://chromium-review.googlesource.com/807489Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#521625}
-
Tomasz Mikolajewski authored
Bug: None Test: All tests pass and everything compiles. Change-Id: Ic803b150499e20ed576c70a6b398eff4ab62109d Reviewed-on: https://chromium-review.googlesource.com/802845 Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#521624}
-
Koji Ishii authored
Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic7afbc244552c74ba9f9eb60a045112d621cfb31 Reviewed-on: https://chromium-review.googlesource.com/790170 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#521623}
-
Xiaochu Liu authored
Skip imageloader RegisterComponent (component copy) in OnCustomInstall and loads the copy in chrome. Additions: Add LoadComponentAtPath in ImageLoaderClient. Save the (compatible) component path in browser_process. BUG=chromium:780575 TEST=unittest; install/load component successfully. Change-Id: Ic14f7d33ee6c8971dd6326f39fda546c94959e14 Reviewed-on: https://chromium-review.googlesource.com/801535Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521622}
-
Alice Boxhall authored
Bug: 514674 Change-Id: I122ca163f9738e825e80c179e5dff803b488295d Reviewed-on: https://chromium-review.googlesource.com/807336 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521621}
-
Lei Zhang authored
Also mark some PrivetJSONOperation::ResultCallback usage as RepeatingCallback, as determined earlier in r515600. Change-Id: I88e8389b6967dabaef036446814d1f70e1ab61e4 Reviewed-on: https://chromium-review.googlesource.com/804753 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521620}
-
Giovanni Ortuño Urquidi authored
Clicking on links in the New Tab Page results in the same type of navigation as launching an app. So, sometimes, we try to move the WebContents to a regular browser window even though the WebContents is in a regular browser window already. To solve this, check if we are in a browser window before moving the WebContents. Bug: 790773 Change-Id: I331c4b9c5d59d1e44d2e21d322ee2bfde6775f59 Reviewed-on: https://chromium-review.googlesource.com/802334 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#521619}
-
Scott Violet authored
Tests configure an environment this is a bit different than real code, so need some early outs. BUG=786453 TEST=none Change-Id: I44621add71a17821293949aa837c39c2b5394d9d Reviewed-on: https://chromium-review.googlesource.com/807168Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521618}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/f5be5bafa6f6..614dd0f537d4 $ git log f5be5bafa..614dd0f53 --date=short --no-merges --format='%ad %ae %s' 2017-11-22 kainino Replace TCache with static TType instances 2017-11-28 geofflang GL backend: Only synchronize transform feedback state when it changes. 2017-11-29 bryan.bernhart WebGLCompat: Fix depthstencil query results. 2017-12-01 oetuaho Test multiview extension warning 2017-11-30 oetuaho Fix handling matrix qualifiers on block members 2017-12-01 geofflang Improve documentation about selecting intial CL reviewers. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I5c35e284fcaed34fc4f1bb60e39fcfaf06978d23 Reviewed-on: https://chromium-review.googlesource.com/807488Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521617}
-
Miriam Gershenson authored
This reverts commit c24c3e90. Reason for revert: Turned a functional bug into a security bug Bug: 788131 Original change's description: > Save TTL to cache if in SOA of NXDOMAIN or NODATA results > > When we get an NXDOMAIN results, this will look at the last result > processed and extract the TTL from the SOA record if it exists (possilbe > TODO: look at all the results and get the shortest TTL). For NODATA > results with an rcode of NOERROR and zero answers, again record a cache > entry with the TTL of the SOA if present. > > R=mgersh@chromium.org > > Bug: 115051 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I6fe029760f4ecfd3b3a91667e95b403a9f37a228 > Reviewed-on: https://chromium-review.googlesource.com/562037 > Commit-Queue: Brad Lassey <lassey@chromium.org> > Reviewed-by: Miriam Gershenson <mgersh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518461} TBR=mgersh@chromium.org,lassey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 115051 Change-Id: I791068c205931c25f4aa9fd6f073476dbb034f7f Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/807149Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#521616}
-