GitLab

Dependencies are correct, successful triggered task on 4 core laptop:

https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10

BUG=chromium:633253

Review-Url: https://codereview.chromium.org/2290373002
Cr-Commit-Position: refs/heads/master@{#416255}

The following two methods defined in process.mojom are not needed anymore
because oom_adj setting and lowmemorykiller are disabled by default on Android side.
- DisableBuiltinOomAdjustment()
- DisableLowMemoryKiller()

BUG=b:30971151
TEST=minnie

Review-Url: https://codereview.chromium.org/2282053005
Cr-Commit-Position: refs/heads/master@{#416254}

Review-Url: https://codereview.chromium.org/2300233003
Cr-Commit-Position: refs/heads/master@{#416253}

Enhance the chrome.app.window API for shelf integration with the possibility of
pinning the showInShelf=true windows.

Based on https://codereview.chromium.org/1914993002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299
TEST=interactive_ui_tests
Implement a simple extension that creates windows with showInShelf property set
to true. Pin a newly created window that has its own icon in the shelf, then
close it and open it again by clicking the pinned icon.
TEST= https://codereview.chromium.org/2297633002

Review-Url: https://codereview.chromium.org/2290603002
Cr-Commit-Position: refs/heads/master@{#416252}

Reland of [ios] Implemented LoadHtml w/o using data:// URLs. (patchset #1 id:1 of https://codereview.chromium.org/2306053002/ )

Reason for revert:
False alert. This was not the root cause. Relanding. Sorry for the noise.

Original issue's description:
> Revert of [ios] Implemented LoadHtml w/o using data:// URLs. (patchset #4 id:60001 of https://codereview.chromium.org/2295053003/ )
>
> Reason for revert:
> Breaking iOS build.
>
> Original issue's description:
> > [ios] Implemented LoadHtml w/o using data:// URLs.
> >
> > This allows loading HTML and setting a specific URL (last part is needed
> > by suggestions tests, which currently use private API to set the URL).
> >
> > BUG=619687
> >
> > Committed: https://crrev.com/7d93683d73e6bb131651275c752a0792f2733410
> > Cr-Commit-Position: refs/heads/master@{#416151}
>
> TBR=jyquinn@chromium.org,eugenebut@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619687
>
> Committed: https://crrev.com/e04917c2cced1a397c9f959f6f27a1b44e245899
> Cr-Commit-Position: refs/heads/master@{#416246}

TBR=jyquinn@chromium.org,eugenebut@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619687

Review-Url: https://codereview.chromium.org/2309433002
Cr-Commit-Position: refs/heads/master@{#416251}

And change a few checks from != NONE_ACTIVE to == WORKER_CREATED
where it's guaranteed (i.e. in code that can only run after a
Worker is created).

BUG=639812

Review-Url: https://codereview.chromium.org/2295323004
Cr-Commit-Position: refs/heads/master@{#416250}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/f06e6138edadc92d4cab98507a3b874979da5a61 Revert "Avoid to use environment." (shinyak@chromium.org)

R=shinyak@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2300343003
Cr-Commit-Position: refs/heads/master@{#416249}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9c99a304..d9e7b3b2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2302913004
Cr-Commit-Position: refs/heads/master@{#416248}

CL includes the header defining base::Bind in order to fix
the following build error for Ozone/Wayland:

ui/ozone/platform/wayland/wayland_window.cc:156:27: error:
 no member named 'Bind' in namespace 'base' native_event,
 base::Bind(&PlatformWindowDelegate::DispatchEvent,
                    ~~~~~~^
ui/ozone/platform/wayland/wayland_window.cc:157:38: error:
no member named 'Unretained' in namespace 'base'
base::Unretained(delegate_)));

BUG=578890
R=spang@chromium.org

Review-Url: https://codereview.chromium.org/2297743003
Cr-Commit-Position: refs/heads/master@{#416247}

Revert of [ios] Implemented LoadHtml w/o using data:// URLs. (patchset #4 id:60001 of https://codereview.chromium.org/2295053003/ )

Reason for revert:
Breaking iOS build.

Original issue's description:
> [ios] Implemented LoadHtml w/o using data:// URLs.
>
> This allows loading HTML and setting a specific URL (last part is needed
> by suggestions tests, which currently use private API to set the URL).
>
> BUG=619687
>
> Committed: https://crrev.com/7d93683d73e6bb131651275c752a0792f2733410
> Cr-Commit-Position: refs/heads/master@{#416151}

TBR=jyquinn@chromium.org,eugenebut@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619687

Review-Url: https://codereview.chromium.org/2306053002
Cr-Commit-Position: refs/heads/master@{#416246}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/a74f612ef99de4de59320e5f390e16bf6934cf88 Add step to show goma stat in goma module (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=544330

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2302723004
Cr-Commit-Position: refs/heads/master@{#416245}

Added first MSA optimized function of WebGL image conversion module. More functions to follow.

BUG=642653

Review-Url: https://codereview.chromium.org/2289693002
Cr-Commit-Position: refs/heads/master@{#416244}

This test pass locally and we want to run it on the webrtc build bots.

This reverts commit f472eb57.

BUG=626556
NOTRY=true
TBR=phoglund@chromium.org

Review-Url: https://codereview.chromium.org/2302763003
Cr-Commit-Position: refs/heads/master@{#416243}

Now that we have memory-infra, I expect we can remove debug code under
MEMORY_CACHE_STATS.

This CL removes printf() debug code that cause presubmit warnings
(follow-up of a comment in https://codereview.chromium.org/2254593003/).

BUG=603791

Review-Url: https://codereview.chromium.org/2299603002
Cr-Commit-Position: refs/heads/master@{#416242}

BUG=564674

Review-Url: https://codereview.chromium.org/2298733003
Cr-Commit-Position: refs/heads/master@{#416241}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e86f94ed0b0ccb94fee3d6f27c1b45932d904c6b Avoid to use environment. (yyanagisawa@chromium.org)

R=yyanagisawa@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2307723002
Cr-Commit-Position: refs/heads/master@{#416240}

Addressing my own nits expressed in review of:
https://codereview.chromium.org/2293153002/
    (Remove stl_util's STLDeleteContainerPairFirstPointers.)

BUG=555865

Review-Url: https://codereview.chromium.org/2301403002
Cr-Commit-Position: refs/heads/master@{#416239}

We're selecting between two rectangles given by the intrinsic aspect ratio:
(defaultWidth / aspect ratio, defaultHeight) or (defaultWidth, defaultHeight x
aspect ratio). One rectangle is 'contained' and the other one 'covers'. Select
the 'contained' rectangle by trying out the first to see if its width fit, and
if so we're done. Otherwise compute and select the other rectangle.

Due to how floating point math works, it's possible that both computed
rectangles, or neither computed rectangle, will fit the case when the two ratios
are equal. See https://bugs.chromium.org/p/chromium/issues/detail?id=641221 for
one example. However, in this case it doesn't matter much which rectangle we
choose, the contained and and cover rectangle would be the same rectangle and
the floating point discrepancy has no known practical implication.

BUG=641221

Review-Url: https://codereview.chromium.org/2294683002
Cr-Commit-Position: refs/heads/master@{#416238}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/05e534a6043b..324d39a894c0

$ git log 05e534a60..324d39a89 --date=short --no-merges --format='%ad %ae %s'
2016-09-02 achuith Increase timeout for launching guest browser.

BUG=631640

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2304903002
Cr-Commit-Position: refs/heads/master@{#416237}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7c1ee6be..9c99a304

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2303253002
Cr-Commit-Position: refs/heads/master@{#416236}

Currently, `<script src="whatever"></script>` will execute the resource
at `whatever` as long as it returns a non-`image/*` MIME-type (and doesn't
opt-in to additional protection by sending an `X-Content-Type-Options:
nosniff` header). This patch tightens that to exclude `text/csv` as well
as `audio/*` and `video/*` by default.

Spec: https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-mime-type?
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AHsFvhHzh1o/GHj6QCdMAAAJ
Discussion: https://github.com/whatwg/fetch/issues/337

BUG=433049

Review-Url: https://codereview.chromium.org/2294283002
Cr-Commit-Position: refs/heads/master@{#416235}

Update code in android_webview to use JavaRef when calling Java methods
via JNI, instead of passing bare jobject. Various function parameter
types are converted from jobject to JavaRef to enable calls to obj()
higher up the call chain to be removed.

BUG=506850

Review-Url: https://codereview.chromium.org/2295693004
Cr-Commit-Position: refs/heads/master@{#416234}

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747,447810

Review-Url: https://codereview.chromium.org/2242213008
Cr-Commit-Position: refs/heads/master@{#416233}

These histograms will no longer be accurate and prevent code
refactoring and improvements.

Also fixes the presubmit check: cannot assume that the first element of
sys.path is '.', and tools/python doesn't contain __init__.py.

BUG=631966

Review-Url: https://codereview.chromium.org/2301093002
Cr-Commit-Position: refs/heads/master@{#416232}

This patch converts "editing/style/smoosh-styles-00[13].html"
to use w3c test harness to simplify test script for improving readability, and
consolidates into "smoosh_styles.html" since these test scripts verifies
"smoosh style".

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2294193002
Cr-Commit-Position: refs/heads/master@{#416231}

This patch is a preparation for removing the update layout call from
|plainText()| (DOM tree traversal version).

BUG=590369

Review-Url: https://codereview.chromium.org/2302263002
Cr-Commit-Position: refs/heads/master@{#416230}

The test is flaky. It fails with:
[ RUN      ] BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
[5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed: !argument_filter_predicate_.is_null().

Backtrace:
	base::debug::StackTrace::StackTrace [0x02022B17+23]
	logging::LogMessage::~LogMessage [0x01FCA911+49]
	base::trace_event::TraceLog::FinishFlush [0x01FF104F+255]
	base::internal::Invoker<base::internal::BindState<void (__thiscall base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void __cdecl(void)>::Run [0x01FF2B06+22]
	base::debug::TaskAnnotator::RunTask [0x0203EF90+256]
	base::MessageLoop::RunTask [0x01FE101B+1211]
	base::MessageLoop::DoWork [0x01FE034E+606]
	base::MessagePumpForIO::DoRunLoop [0x02033FBC+188]
	base::MessagePumpWin::Run [0x02034DCA+74]
	base::MessageLoop::RunHandler [0x01FE0B57+103]
	base::RunLoop::Run [0x01FDCEA9+41]
	base::Thread::Run [0x020133AC+92]
	base::Thread::ThreadMain [0x02013D55+469]
	base::PlatformThread::Sleep [0x01FDE9C2+290]
	BaseThreadInitThunk [0x7693338A+18]
	RtlInitializeExceptionChain [0x772B9F72+99]
	RtlInitializeExceptionChain [0x772B9F45+54]

TBR=oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639706, chromium:639706

Review-Url: https://codereview.chromium.org/2307813002
Cr-Commit-Position: refs/heads/master@{#416229}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4355e3b3..7c1ee6be

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2308483002
Cr-Commit-Position: refs/heads/master@{#416228}

This is no longer necessary after https://codereview.chromium.org/2291053002

TBR=zea

BUG=none

Review-Url: https://codereview.chromium.org/2301063002
Cr-Commit-Position: refs/heads/master@{#416227}

Revert of Paint solid color backgrounds which are equivalent to locally attached into scrolling contents layer (patchset #9 id:160001 of https://codereview.chromium.org/2264663002/ )

Reason for revert:
This CL breaks paint/selection/selection-within-composited-scroller.html on WebKit Win7 (dbg).
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)

01:07:46.923 1952 worker/0 paint/selection/selection-within-composited-scroller.html crashed, (stderr lines):
01:07:46.923 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=0 y=1170 47ffffff vs ffd3d3d3
01:07:46.923 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=1 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=2 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=3 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=4 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=5 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=6 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=7 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=8 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:drawingdisplayitem.cpp(100)] x=9 y=1170 47ffffff vs ffd3d3d3
01:07:46.924 1952   [2516:5320:0902/010745:4409539:ERROR:paintcontroller.cpp(621)] "" under-invalidation: display item changed
01:07:46.924 1952   [2516:5320:0902/010745:4409555:ERROR:paintcontroller.cpp(623)] New display item: "{client: \"35B71898 Scrolling Contents Layer\", type: \"DrawingBoxDecorationBackground\", rect: [0.000000,0.000000 200.000000x1620.000000]}"
01:07:46.924 1952   [2516:5320:0902/010745:4409555:ERROR:paintcontroller.cpp(624)] Old display item: "{client: \"35B71898 Scrolling Contents Layer\", type: \"DrawingBoxDecorationBackground\", rect: [0.000000,0.000000 200.000000x1620.000000]}"
01:07:46.924 1952   [2516:5320:0902/010745:4409555:ERROR:paintcontroller.cpp(628)] See http://crbug.com/619103.
...
01:07:46.924 1952   [2516:5320:0902/010745:4409555:FATAL:paintcontroller.cpp(674)] Check failed: false.
01:07:46.924 1952   Backtrace:
01:07:46.924 1952   	base::debug::StackTrace::StackTrace [0x01F0ADC7+23]
01:07:46.924 1952   	logging::LogMessage::~LogMessage [0x01F5844B+59]
01:07:46.925 1952   	blink::PaintController::checkUnderInvalidation [0x0AE6ACB7+839]
01:07:46.925 1952   	blink::PaintController::processNewItem [0x0AE6F1D6+1558]
01:07:46.925 1952   	blink::PaintController::createAndAppend<blink::DrawingDisplayItem,blink::DisplayItemClient const &,enum blink::DisplayItem::Type const &,WTF::PassRefPtr<SkPicture>,bool &> [0x0AE566C2+114]
01:07:46.925 1952   	blink::DrawingRecorder::~DrawingRecorder [0x0AE56B2E+302]
01:07:46.925 1952   	blink::BoxPainter::paintBoxDecorationBackgroundWithRect [0x1578E899+1001]
01:07:46.925 1952   	blink::BoxPainter::paintBoxDecorationBackground [0x1578E49E+334]
01:07:46.925 1952   	blink::LayoutBox::paintBoxDecorationBackground [0x15927EC4+36]
01:07:46.925 1952   	blink::BlockPainter::paintObject [0x1577E854+116]
01:07:46.925 1952   	blink::LayoutBlock::paintObject [0x158F27D4+36]
01:07:46.925 1952   	blink::BlockPainter::paint [0x1577E329+233]
01:07:46.925 1952   	blink::LayoutBlock::paint [0x158F2774+36]
01:07:46.925 1952   	blink::PaintLayerPainter::paintFragmentWithPhase [0x157D17A2+658]
01:07:46.925 1952   	blink::PaintLayerPainter::paintBackgroundForFragments [0x157D09B2+130]
01:07:46.925 1952   	blink::PaintLayerPainter::paintLayerContents [0x157D2550+2976]
01:07:46.925 1952   	blink::CompositedLayerMapping::doPaintTask [0x15A04F13+579]
01:07:46.925 1952   	blink::CompositedLayerMapping::paintContents [0x15A06224+996]
01:07:46.925 1952   	blink::GraphicsLayer::paintWithoutCommit [0x0ACDD0F3+499]
01:07:46.925 1952   	blink::GraphicsLayer::paint [0x0ACDCC3C+44]
01:07:46.925 1952   	blink::FrameView::synchronizedPaintRecursively [0x1552F746+38]
01:07:46.925 1952   	blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952   	blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952   	blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952   	blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952   	blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952   	blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952   	blink::FrameView::synchronizedPaintRecursively [0x1552F7F6+214]
01:07:46.925 1952   	blink::FrameView::synchronizedPaint [0x1552F689+601]
01:07:46.925 1952   	blink::FrameView::updateLifecyclePhasesInternal [0x15530B8A+1306]
01:07:46.925 1952   	blink::FrameView::updateAllLifecyclePhases [0x155301D6+38]
01:07:46.925 1952   	blink::Internals::layerTreeAsText [0x00534AA2+146]
01:07:46.926 1952   	blink::Iterable<unsigned int,int>::keysForBinding [0x00568FE6+1814]
01:07:46.926 1952   	blink::Iterable<unsigned int,int>::keysForBinding [0x0056904C+1916]
01:07:46.926 1952   	v8::internal::FunctionCallbackArguments::Call [0x093DFE93+179]
01:07:46.926 1952   	v8::internal::Isolate::typed_array_prototype [0x09475B48+1800]
01:07:46.926 1952   	v8::internal::Builtin_HandleApiCallAsFunction [0x09476828+552]
01:07:46.926 1952   	v8::internal::Builtin_HandleApiCall [0x09476505+165]

Original issue's description:
> Paint solid color backgrounds which are equivalent to locally attached into scrolling contents layer
>
> If we have a solid color background whose bounds / visible rect is equivalent to the padding-box we can treat it as locally attached and paint it into the scrolling contents layer. This enables composited scrolling with sub-pixel text anti-aliasing.
>
> BUG=381840
> TEST=CompositedLayerMappingTest.ShouldPaintBackgroundOntoScrollingContentsLayer
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/3a79cf9764213b54bf9e5a0be2198f029a3540c8
> Cr-Commit-Position: refs/heads/master@{#415973}

TBR=chrishtr@chromium.org,flackr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=381840

Review-Url: https://codereview.chromium.org/2308503002
Cr-Commit-Position: refs/heads/master@{#416226}

BUG=643104

Review-Url: https://codereview.chromium.org/2301023002
Cr-Commit-Position: refs/heads/master@{#416225}

Revert of Reland [Telemetry] Convert long running user stories to the System Health format. (patchset #1 id:1 of https://codereview.chromium.org/2297783005/ )

Reason for revert:
The long running gmail test enabled by the CL is failing and turning all the Android perf bots red. See crbug.com/643110/

Original issue's description:
> Reland [Telemetry] Convert long running user stories to the System Health format.
>
> BUG=639315
>
> Committed: https://crrev.com/1e7e98e048508e3c158244c409830f5a4ebc0630
> Cr-Commit-Position: refs/heads/master@{#415996}

TBR=nednguyen@google.com,petrcermak@chromium.org,perezju@chromium.org,charliea@chromium.org,rnephew@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=639315,643110

Review-Url: https://codereview.chromium.org/2294913010
Cr-Commit-Position: refs/heads/master@{#416224}

This test ensures that the change in cl/2267353002 is maintained in the correct order.

BUG=613883,638076

Review-Url: https://codereview.chromium.org/2276253002
Cr-Commit-Position: refs/heads/master@{#416223}

Revert of Make TrayDetailsView a ViewClickListener and ButtonListener (patchset #5 id:80001 of https://codereview.chromium.org/2289223002/ )

Reason for revert:
This CL breaks TrayDetailsViewTest.HoverHighlightViewTouchFeedback on:
Linux ChromiumOS Tests (dbg)(1)
and
Linux Chromium OS ASan LSan Tests (1

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15828
[ RUN      ] TrayDetailsViewTest.HoverHighlightViewTouchFeedback
Xlib:  extension "RANDR" missing on display ":9".
=================================================================
==5332==ERROR: AddressSanitizer: heap-use-after-free on address 0x616000324580 at pc 0x0000007871d6 bp 0x7ffe4d468250 sp 0x7ffe4d468248
READ of size 1 at 0x616000324580 thread T0
    #0 0x7871d5 in hover ash/common/system/tray/hover_highlight_view.h:89:31
    #1 0x7871d5 in ash::test::TrayDetailsViewTest_HoverHighlightViewTouchFeedback_Test::TestBody() ash/common/system/tray/tray_details_view_unittest.cc:205
    #2 0x24fe1bb in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    #3 0x24fe1bb in testing::Test::Run() testing/gtest/src/gtest.cc:2474
    #4 0x250024b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
    #5 0x2501006 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    #6 0x2515006 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    #7 0x2514667 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #8 0x2514667 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255
    #9 0x1b28b8b in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #10 0x1b28b8b in base::TestSuite::Run() base/test/test_suite.cc:246
    #11 0x1b2c5b4 in Run base/callback.h:388:12
    #12 0x1b2c5b4 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1> const&) base/test/launcher/unit_test_launcher.cc:206
    #13 0x1b2c26e in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1> const&) base/test/launcher/unit_test_launcher.cc:445:10
    #14 0xcab0de in main ash/test/ash_unittests.cc:14:10
    #15 0x7fe83864e7ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226

Original issue's description:
> Make TrayDetailsView a ViewClickListener and ButtonListener
>
> Some initial changes in preparation for implementing
> the material design version of the detailed views
> in the Ash system menu:
>
> * Make TrayDetailsView extend ViewClickListener
>   and ButtonListener instead of having each of
>   TrayDetailsView's subclasses extend these.
>   The aim is to place common code in TrayDetailsView.
>
> * Rename the TrayDetailsView "footer row" to be
>   the "title row"; for material design this row
>   appears at the top of the detailed view, not
>   the bottom.
>
> * For material design (--ash-md=experimental), show
>   the title row at the top of the detailed view
>   and do not instantiate or show any non-MD
>   buttons in this row. Further improvements to
>   the appearance and functionality of the title
>   rows to be handled in subsequent CLs.
>
> BUG=642136
> TEST=ash_unittests
>
> Committed: https://crrev.com/bd26b635c2b1e5ad8287a4f87d87f5ce2c697267
> Cr-Commit-Position: refs/heads/master@{#416134}

TBR=varkha@chromium.org,oshima@chromium.org,tdanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642136

Review-Url: https://codereview.chromium.org/2300353002
Cr-Commit-Position: refs/heads/master@{#416222}

This code wants to compare the prefix of two strings together, we can
do that with StringView and use the much faster string equals methods
that use memchr.

BUG=615174

Review-Url: https://codereview.chromium.org/2304023002
Cr-Commit-Position: refs/heads/master@{#416221}

RuleFeatureSet::add now verifies that we aren't adding to ourselves.

Our hash sets now verify during insertion that our keys are
not empty strings or PseudoUnknown (0).

BUG=412572,640486

Review-Url: https://codereview.chromium.org/2303443003
Cr-Commit-Position: refs/heads/master@{#416220}

Remove UMA 'Platform.WebRtcNEONFound These lines where last touched by me in a cl two years ago when I moved it,  https://codereview.chromium.org/294043015. There is no owner for this and does not exist in histograms.xml.

BUG=643555
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2300313002
Cr-Commit-Position: refs/heads/master@{#416219}

https://chromium.googlesource.com/chromium/src/+/0c98c82a5

BUG=625533
TBR=yosin@chromium.org

Review URL: https://codereview.chromium.org/2304873002 .

Cr-Commit-Position: refs/heads/master@{#416218}

Revert of Add groupid for media devices. Group audio devices. (patchset #5 id:80001 of https://codereview.chromium.org/2273653002/ )

Reason for revert:
Breaks webrtc FYI bots on mac https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/59143. I'll have to figure out what's up with that ¯\_(ツ)_/¯

Original issue's description:
> Add groupid for media devices. Group audio devices.
>
> At present, the renderer tries to use matched_output_device
> to assign groupids to audio devices. matched_output_device isn't set
> before devices are sent to the renderer, and we wouldn't be able to
> handle all the cases with it anyways.
>
> BUG=636300, 627793
>
> Committed: https://crrev.com/f07d1047986130ef0277a87b5b0b6175c4362c98
> Cr-Commit-Position: refs/heads/master@{#416140}

TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636300, 627793

Review-Url: https://codereview.chromium.org/2296393004
Cr-Commit-Position: refs/heads/master@{#416217}

This CL adds ClearHistory implementations:
1) for OfflinePageSuggestionsProvider and
PhysicalWebPageSuggestionsProvider remove dismissed suggestions;
2) for NTPSnippetsService remove all suggestions (including dismissed);
3) for BookmarkSuggestionsProvider remove all last visit dates and
dismissed suggestions.

BUG=641321

Review-Url: https://codereview.chromium.org/2303713002
Cr-Commit-Position: refs/heads/master@{#416216}