- 14 Jan, 2020 40 commits
-
-
Richard Knoll authored
To reuse all logic inside SharingMessageSender (metrics, timeouts and acks) this introduces a SendMessageDelegate which is implemented once for FCM and will be implemented for WebRTC in a future CL. This allows us to dynamically choose the send implementation in the SharingService. Bug: 1041032 Change-Id: Ib8abc2cf0c963a511ced12b71e09acde6fc0fa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995332 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#731652}
-
Thomas Guilbert authored
The AudioTrackOpusEncoder runs into an CHECK when |converter_| calls ProvideInput() twice in a row, and the ATOE underflows. This happens because the amount of frames converted at a time is bigger than |resampler_.ChunkSize()|, which means multiple reads can be issued for a single call to resample. This issue is similar to the one in recently fixed in AudioRendererAlgorithm. This CL generalizes that fix by adding SincResampler::GetMaxInputFramesRequested(), and fixes ATOE by making sure it has enough data to cover all reads. In practice, this means that ATOE needs a slightly bigger FIFO, and carries one more buffer's worth of frames in memory. Bug: 1025246 Change-Id: I0caae8f3725dbcce92e076ad246f2870db82c84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992358Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#731651}
-
Clark DuVall authored
This can be used to unblock other features that depend on permissions while the real permissions implementation is being worked on. It is enabled by passing the --weblayer-fake-permissions flag. Bug: 1025609 Change-Id: Ibafe00d47a0b8d84c99e0c1e3029d0a4a55d4922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999063Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#731650}
-
Karan Bhatia authored
TestRenderFrameHost (created from TestRenderFrameHostFactory) implicitly assumes that the TestNavigationURLLoaderFactory is the current factory for navigation url loaders. However this might not be true for clients which set up a RenderViewHostTestEnabler but fail to call BrowserSideNavigationSetUp, leading to segfaults. Hence, ensure RenderViewHostTestEnabler appropriately overrides the NavigationURLLoaderFactory. Also delete browser_side_navigation_test_utils.[cc/h] as it doesn't provide any functionality over TestNavigationURLLoaderFactory. BUG=None. TBR=sky@chromium.org Change-Id: I9b16ac0f25d6a060204514b2ee8460ee64c60b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999086Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#731649}
-
Matthew Mourgos authored
Bug: 975710 Change-Id: If7659037d3d9932cdb16112c89cbc1ec6ba2ad1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999331Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#731648}
-
John Budorick authored
Slight tweak to hopefully ensure a more orderly shutdown when keeping snapshots. Bug: 922145 Change-Id: Icda1414bea7432ece426ac373e365da7a436c81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999263Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#731647}
-
Xing Liu authored
This CL enables the build flag for Chime, so it will deploy to play store on next Canary. We still have a feature flag to control if the user will register to Chime. Bug: NONE Change-Id: I464f463e821db1d3a12579df4ccbf4e2dc596006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996127Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#731646}
-
Martin Kreichgauer authored
As a response to a authenticatorBioEnrollment CTAP command, an authenticator may send a response with a status of CTAP2_ENROLL_FEEDBACK_NO_USER_ACTIVITY if it timed out waiting for the user to touch a fingerprint sensor. The BioEnrollmentHandler reports this to the UI layer by invoking its SampleCallback and then immediately sends another authenticatorBioEnrollment command to request the next sample. Change BioEnrollmentHandler to not invoke the SampleCallback for the timeout responses so that the UI layer doesn't have to ignore them explicitly. This fixes a bug where receipt of a timeout response would make the enrollment progress bar flash. Change-Id: I3247169f7a21fcb61b0ed9ba727810f7bf6125f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999087Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#731645}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12b2c2703838..118df7cf62ab git log 12b2c2703838..118df7cf62ab --date=short --first-parent --format='%ad %ae %s' 2020-01-14 halcanary@google.com skottie_ios_app: Add OpenGL. 2020-01-14 reed@google.com clean-up 3d sample's use of matrices 2020-01-14 mtklein@google.com remove obsolete presubmit checks 2020-01-14 egdaniel@google.com Update GrSurface/RenderTargetContexts to take and store GrSurfaceProxyViews. 2020-01-14 mtklein@google.com try running public API checks early Created with: gclient setdep -r src/third_party/skia@118df7cf62ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Id72076a9d5771c142787ff50a73c9797c05868c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731644}
-
Philip Rogers authored
This patch uses LayoutObject::AdditionalCompositingReasons as direct compositing reasons for paint properties. With this patch, video, canvas, iframes, and plugins have composited layers with CompositeAfterPaint (CAP), and expectations more closely match pre-CAP. This patch will let us add a compositing reason for cross-origin iframes in a followup. Bug: 1014273 Change-Id: Ib9beb56566591e418412e2445d076434a2dfc0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998824Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#731643}
-
Yue Zhang authored
Currently, we try to show tab strip when tab model restore completed. However, when return-to-clank is enabled, we are not in tab page when restore completed, and therefore the strip should not show. This CL fixes this issue and adds a test. Bug: 1030606 Change-Id: I01df83b15682b353eb4e5eabada97d457384969e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000965 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731642}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pfeldman@chromium.org Bug: 1041419 Change-Id: Ie03b6a1b55a20bc3e5d9e82aa3a0b9550dbf1c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997943 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731641}
-
Mohammad Refaat authored
Bug: 783777 Change-Id: Iaa2c19fb306db1be538a45280e9899a834ca3d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996166 Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#731640}
-
Darin Fisher authored
Change-Id: Ib2472502dfd59ea9697733432e4846f5fe5c74c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993492Reviewed-by:
Ben Goodger <ben@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731639}
-
behdad authored
Pixel_PaintWorkletBasics skiped on android nvidia no-skia-renderer. TBR=xidachen@chromium.org Bug: chromium:1041572 Change-Id: Ia32d292baf7ab84182cf9b87db145f60ad8cb2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001110Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#731638}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1041419 Change-Id: I47e645f0f9da05e7ad5daacb64c565fab498585c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998680 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731637}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/13d8a54a705c..c8083d168105 git log 13d8a54a705c..c8083d168105 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 khokhlov@google.com [Telemetry] Simplify the timeout condition in CollectTraceData Created with: gclient setdep -r src/third_party/catapult@c8083d168105 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039726 Tbr: wenbinzhang@google.com Change-Id: I7fb3c28d79bb5065d0b69d079e6b3706a526b723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001100Reviewed-by:
-
Evan Stade authored
Change-Id: I9ce0ac3a281391941c8195cc3508512c9f5c2669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977740Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#731635}
-
Becca Hughes authored
Remove deprecated fields and purge them from storage if they are present. Since we no longer have a difference between AudioContext and MediaElement playbacks I am going to clean that up in a follow up CL. BUG=998892 Change-Id: I2ae77b62e5a6282c6689f827ad7825f083a00823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776770 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL changes the hange expiry of UnifiedConsent.SyncAndGoogleServicesSettings to never. Bug: 1024545 Change-Id: Idd786f8a577ee358c6b6374f01e709bf0b6fc5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000027 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731633}
-
Manu Cornet authored
Bug: 1016823 Change-Id: Ia746987fc8e4f3b4e955f51e0771a541cee90a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001187 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#731632}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=fhorschig@chromium.org Bug: 1041419 Change-Id: Icec751dca4a2e208e7b20ddc334d64db92b3958e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998357 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#731631}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kkhorimoto@chromium.org Bug: 1041419 Change-Id: Ifa8fa323f2567bb6a05debc5dec7e259207e7cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997552 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731630}
-
Erik Chen authored
Wayland will not provide presentation feedback for destroyed buffers. We have to manually remove it. To accomplish this, I had to change the data structure from a base::queue to a std::vector. I used a std::vector because for small numbers of entries [e.g. 1-2], it has better performance characteristics than std::deque. Bug: 1039428 Change-Id: Icf9744649d5a8fd40d8f54206df1028f0867896b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998582 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731629}
-
Peter Boström authored
Removes ExtensionsToolbarContainer::ShowActiveBubble by using ::ShowWidgetForExtension in ::ShowToolbarActionBubble. This removes one implementation of popping out an extension and showing a bubble anchored to it. Bug: chromium:1039847 Change-Id: I8f33d72082a833fbb3f427b84e3b8e247ff34b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999445 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#731628}
-
sreejakshetty@chromium.org authored
Introduce HideFillingUI method to hide manual filling popup immediately after navigating away. At the moment it is closed due to a mojo message being send from the renderer when the document is shutdown, which has the following problems: - Is not triggered for back-forward cache, - Is not sent when the old renderer is killed during navigation or not responding BUG=1031076,1017693 Change-Id: Ie1b8d74a1008226b852404e864deb2aecb694b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995173 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Auto-Submit: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731627}
-
Stepan Khapugin authored
Updates AppLaunchManager to accept variations, both regular and trigger, alongside features. This is used downstream to test interaction with Google search backend. Bug: none Change-Id: I52d363d9c84018ba3f8a0a41180d8b8c77a0066d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981609 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731626}
-
Abhijeet Singh authored
Removing the redundant fallback HTML card which was displayed when user clicks "What's on my screen?" suggestion chip and nothing is returned in the server response, as a helpful fallback text is already displayed alongside it. Bug: b:139210908 Test: Tested and verified locally on atlas test device. Change-Id: Ifb7ba341e6be655ddeb49600418fc45807b0a618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997717Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#731625}
-
Olivier Li authored
Set browser state builder dir to avoid file leaks in ios tests in /ios/chrome/browser/ui/browser_view/browser_view_controller_unittest.mm This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 546640 Change-Id: Ic6e410770cb48e19eb7018153a46e7d9a28b0eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991756Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#731624}
-
Michael Spang authored
This reverts commit 07dd9f6f. Reason for revert: This breaks the sandbox for a number of //content embedders (content_shell, cast_shell) by changing the name to a binary that will not exist. Original change's description: > Derive name of the Linux SUID sandbox executable from the main one. > > Bug: 1037808 > Change-Id: I0319edefde8c7faee772f350d6b183f9dc6e3073 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981751 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Francois Marier <francois@brave.com> > Cr-Commit-Position: refs/heads/master@{#730661} TBR=jorgelo@chromium.org,palmer@chromium.org,thestig@chromium.org,rsesek@chromium.org,thomasanderson@chromium.org,francois@brave.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1037808 Change-Id: Ic994fa680ae2ece6f2dba08711c42455de785045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001417 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#731623}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1041419 Change-Id: I0c6d3b7bcb1abb7baac57d501cd12d3fac90fc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994072 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=shaseley@chromium.org Bug: 1041419 Change-Id: I73d9da6db7cf7347a1f22c13958c5f3723a6c8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998164 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731621}
-
Scott Violet authored
This way WebLayer can use it. ENABLE_SESSION_SERVICE case is handled in chrome side by supplying a null SessionService if ENABLE_SESSION_SERVICE is false. BUG=1033924 TEST=none Change-Id: I334274270d3e06e829d6f67e132467f0f8b9c73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999152 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#731620}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aa610e24. With Chromium commits locally applied on WPT: bc899bf6 "DOM Overlay: update API to match current draft spec" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic0550a0f972579decc38e601bb4df1b481c12ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000521Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731619}
-
Saman Sami authored
This CL fixes two issues: - |evdev_bound_| is never set, so we keep rebinding |evdev_cursor_| on every cursor move. - |evdev_cursor_| was initially bound on the UI thread so calling Unbind() on the evdev thread for the first time triggers a DCHECK. Instead keep the pending remote unbound until it's time to bind it on the evdev thread. Bug: 620927,1039834 Change-Id: Iea19d5e32b0cbc9396f7b5e178e8e4ab6001f8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997646 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/395b69e99301..d85dc3874aaa git log 395b69e99301..d85dc3874aaa --date=short --first-parent --format='%ad %ae %s' 2020-01-14 aerotwist@chromium.org Migrates object_ui/ to ESM internally 2020-01-14 tvanderlippe@chromium.org Revert "Use typescript-eslint instead of tslint" 2020-01-14 tvanderlippe@chromium.org Migrate snippets/ to ESM internally 2020-01-14 tvanderlippe@chromium.org Fail on changed files before commit 2020-01-14 tvanderlippe@chromium.org Migrate inspector_main/ to ESM internally 2020-01-14 petermarshall@chromium.org [fix-it] Add more unittests for TextUtils.js 2020-01-14 almuthanna@google.com Add Karma tests for Throttler.js 2020-01-14 tvanderlippe@chromium.org Run the linter before the formatter 2020-01-14 mathias@chromium.org Add unescapeCssString tests 2020-01-14 aerotwist@chromium.org Adds PRESUBMIT check for .only calls in Karma tests 2020-01-14 tvanderlippe@chromium.org Migrate network/ to ESM internally 2020-01-14 tvanderlippe@chromium.org Migrate inline_editor/ to ESM internally 2020-01-14 varuncvarada@gmail.com Fix units to be consistent with the SI 2020-01-14 aerotwist@chromium.org Migrates profiler/ to ESM internally 2020-01-14 petermarshall@chromium.org [fix-it] Add unittests for TextUtils.js 2020-01-14 tvanderlippe@chromium.org Use typescript-eslint instead of tslint 2020-01-14 tvanderlippe@chromium.org Update node_modules to include typescript-eslint 2020-01-14 tvanderlippe@chromium.org Add typescript-eslint to node_modules 2020-01-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d85dc3874aaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561,chromium:1033910,chromium:1041811,chromium:1983391 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I408edb9bf4df45989822283040e4c45d99fddae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001112Reviewed-by:
-
Sadrul Habib Chowdhury authored
Avoid unnecessary conversion from enum to int when getting the name of the FrameSequenceTrackerType enum. BUG=none Change-Id: Ib7e8400f9af128575a99446a8e6a4a4caa3d11c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996153 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
-
Tom Anderson authored
Explanation copied from comment added by this CL: XFlush() flushes all requests and *also* reads events. It's unclear why it does this, but there's no alternative Xlib function that flushes the requests and *doesn't* read any events, so this workaround is necessary. In |event_task_runner_|'s message loop, poll() is called on the underlying XDisplay's fd to dispatch toplevel events. When the fd is readable, poll() exits and we (via Xlib) check for new events by read()ing from the fd. But if the event dispatcher is currently dispatching an event, then our call to XFlush() may read events into the event queue which will make the fd blocking since there's no more data to read, so poll() won't wake up until a new event comes, which may take a long time. Forcing the event loop to wake up with a dummy event fixes the race condition. BUG=1036742 R=msisov Change-Id: I4ce5dd1bbfd9c31a5e1adc992241937251fc3822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999436Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 1041419 Change-Id: I2999fd57be53f68bd82b8d431f659d49a4efc436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998507 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731614}
-
Alan Screen authored
The PDF Compositor is being updated to perform composition for both PDF and XPS documents. Rename the service to more accurately reflect this expanded scope of the service. This CL is just to do the rename without any new XPS functionality yet; that will come in later CLs. Bug: 1008222 Change-Id: I2233e1590f5862da8f4bc50025f699e4dc1fbad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981135Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731613}
-
