GitLab

AVX2 version of H010ToAR30_Opt is 42% faster on Broadwell.
Add ABGRToAR30 fully optimized for AVX2 and SSSE3.
Add AR30ToABGR, unoptimized,

1000 iterations of 720p:
Was SSSE3 H010ToAR30_Opt (635 ms)
Was SSSE3 I420ToAR30_Opt (635 ms)

Now AVX2  H010ToAR30_Opt (448 ms)
Now AVX2  I420ToAR30_Opt (446 ms)

ffec313 ABGRToAR30 used AVX2 with reversed shuffler
ff8ab9b AR30ToABGR for 10 to 8 bit RGB on Android
ed96b7b AVX2 port of H010ToAR30_AVX2
c95fd57 AVX2 port of I010ToAR30_AVX2
3f43ecc Add H420ToAR30 and a test that does a histogram

Bug: 797347, libyuv:751
Test: try bots passed for local libyuv build
Change-Id: I2ea965b65b6757dc31ab1cdb706dc02c68afeab3
Reviewed-on: https://chromium-review.googlesource.com/892340
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532876}

Bug was closed as WontFix, so removing the corresponding commented
out code.

Bug: 228014
Change-Id: I9d4e389d319523b40b79b21ac94497ff2c0241d6
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/893265Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532875}

Bug: 177475
R=xlai@chromium.org

Change-Id: Iaf7e65f74a55a20591ee49809210ef00548beb2d
Reviewed-on: https://chromium-review.googlesource.com/889784Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532874}

This is necessary to resolve a use-after-free issue: the CanvasFontCache is promptly freed on heap tear down but not unregistered from TaskObserver.


Change-Id: I0a048bfd8dcae79d57a882ec553eb4aa9877a77a
Reviewed-on: https://chromium-review.googlesource.com/893140Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532873}

Fixes a bug where if we received png data and then failed to decode
that, we'd try to decode it as jpeg too unintentionally, cf
https://codereview.chromium.org/2943363003/diff/120001/chrome/renderer/chrome_render_frame_observer.cc

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 177475
Change-Id: I1fbfc4b8b1fa009e10ace632a09619f463305cb6
Reviewed-on: https://chromium-review.googlesource.com/891899
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532872}

Fixes a bug where device ordinal 5 would fall through to device ordinal 6
after resetting the name, cf
https://codereview.chromium.org/2440043002/diff/120001/device/bluetooth/test/bluetooth_test_bluez.cc

This CL was uploaded by git cl split.

R=ortuno@chromium.org

Bug: 177475
Change-Id: I93fd60b42f634c4b84c464452861f2cf3aa32f37
Reviewed-on: https://chromium-review.googlesource.com/891502
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532871}

This CL fixes typo password_inputs->explicit_password_inputs. Which in some rare situations
leads to crash.

Bug: 805892
Change-Id: Ibe76806154e7172a4d433d51ec92fb20ba0d900c
Reviewed-on: https://chromium-review.googlesource.com/893298Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532870}

This will allow next_protos_expected_in_ssl_config to test for
ssl_config.alpn_protos being empty.

Bug: 801564
Change-Id: I05ee7803b7ffb5add8ef0a16f0a00c7572967041
Reviewed-on: https://chromium-review.googlesource.com/891445
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532869}

Will help understand why the DCHECK is hit.

Bug: 803056
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibd00659e0ae1024cb863d90cd4e32e3f3f542a7c
Reviewed-on: https://chromium-review.googlesource.com/893318Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532868}

This is fixing a bug where methods returning all scores would
sometimes have two entries when the incognito profile received new MEI
related events. This is due to some unexpected behaviour from content
settings (in `GetSettingsForOneType`).

Bug: 807269
Change-Id: Id6b8be8ddd2dac6e1b1fec1922896d760e78d31f
Reviewed-on: https://chromium-review.googlesource.com/893260Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532867}

The account consistency is now injected in the component by the embedder.
Chrome determines the current account consistency using the AccountConsistencyManager.

Note: After this CL, the meaning of the AccountConsistencyMethod values is slightly different:
- kDiceMigration means that the migration is ongoing but not completed yet.
- kDice means that Dice is enabled, either because it is forced or because the migration completed.

Bug: 777774
TBR: noyau, pkasting, treib, zea
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I82a6464bb2fa76ca219a5fe419cdc26dfe9ffdfa
Reviewed-on: https://chromium-review.googlesource.com/787231
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532866}

Restore code to clean up the test instance of the PolicyProvider, so unit tests
that set the PolicyProvider no longer crash when run in succession.

Bug: None
Test: Run unit_tests --gtest_filter=ProfilePolicyConnectorTest*
Change-Id: I3a90fb04f3736c7e1351791b52886d726913aeed
Reviewed-on: https://chromium-review.googlesource.com/893098Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532865}

This CL was uploaded by git cl split.

R=sdefresne@chromium.org

Bug: 177475
Change-Id: Iae7090f66ed567d16e3c3174949a4399b3ca6ad9
Reviewed-on: https://chromium-review.googlesource.com/891879Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532864}

https://webrtc.googlesource.com/src.git/+log/f61b3ba65e3d..49456a5b3327

$ git log f61b3ba65..49456a5b3 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic8f028383bc7ceaa82be7c88a1b72a81f3bc849e
Reviewed-on: https://chromium-review.googlesource.com/893118
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532863}

This helps with debugging, as the thrown exception will get mangled by
the test runner script.

Bug: 807237
Change-Id: I74677e491c0115521b9b79c051f5213e832545ae
Reviewed-on: https://chromium-review.googlesource.com/892863Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532862}

This CL adds a check in SoundContentSettingObserver to avoid unmuting a
tab if muted by the audio indicator.

Bug: 806482
Change-Id: I433c1fcb7a8e8034a9b100077e2f876e88a7d409
Reviewed-on: https://chromium-review.googlesource.com/891259Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532861}

Previously, RenderFrameHostImpl::DidCommitProvisionalLoad required that
a non-null |interface_provider_request| was supplied for all cross-
-document navigation commits if a real load had already committed in the
FrameTreeNode.

The check was performed for all commits, including those that the
DidCommitProvisionalLoad method itself later ignored, which led to
false-positive renderer kills in the following scenario with
browser-side navigation and site-per-process enabled:

 1) http://foo.test/main.html is loaded in a main frame.
 2) Either statically in HTML, or dynamically by JS, a frame is added:
      <iframe 'src=http://foo.test/f.html'/>.
 3) The initial byte of the response for `f.html` arrives, causing
    FrameMsg_CommitNavigation to be sent to the same renderer.
 4) Just before processing this message, however, `main.html` navigates
    the iframe to http://bar.test/g.html, which results in a mojom::Frame::
    BeginNavigation call being made to the RenderFrameHost.
 5) Suppose that immediately afterwards, `main.html` enters a busy-loop.
 6) The cross site navigation in the child frame starts, the first response
    byte arrives quickly, and thus the navigation commits quickly.
 6.1) FrameTreeNode::has_committed_real_load is set to true for the child.
 6.2) The same-site RenderFrame in the child FrameTreeNode is swapped out,
      i.e. FrameMsg_SwapOut is sent.
 7) The renderer for site instance `foo.test` exits from the busy loop,
    and starts processing messages in order:
 7.1) The first being processed is FrameMsg_CommitNavigation, so a
      provisional load is created and immediately committed to
      http://foo.test/f.html.
 7.2) Because at the time the same-site child RenderFrame was created,
      there had been no real load committed in the child frame, and because
      the navigation from the initial empty document to the first real
      document was same-origin, the global object is reused and the
      RemoteInterfaceProvider of the RenderFrame is not rebound.
 7.3) The obsoleted load in the same-site child frame commits, calling
      mojom::Frame::DidCommitProvisionalLoad, however, with
      |interface_provider_request| being null.
 8) RenderFrameHostImpl::DidCommitProvisionalLoad sees that a real load was
    already committed in the frame, but |interface_provider_request| is
    missing, so kills the renderer.
 9) RenderFrameHostImpl::DidCommitProvisionalLoad also sees that the frame
    was waiting for a swap-out ACK, so ignores the commit.

Instead, step 8 and step 9 should be reversed: RFHI::DidCommitProvisionalLoad
should first check if the frame already IsWaitingForUnloadACK(), and, if so,
return immediately, without checking |interface_provider_request|.

Bug: 793228
Change-Id: I3e833502ff43d603f1e063098df07a16b5d4b7ec
Reviewed-on: https://chromium-review.googlesource.com/877239
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532860}

The toolbar coordinator shouldn't access implementation details like
the specific view managed by the location bar.
Instead, make it use location bar coordinator, and move the few
protocols that are mostly forwarded by TC to LB straight to LB.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I244d39a065c7f0a03d9821b0c84fd5bddc421208
Reviewed-on: https://chromium-review.googlesource.com/883462
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532859}

This reverts commit 38feaec8.

Reason for revert: commit-git-patch flakily fails on LUCI, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/21881

Original change's description:
> [CQ.cfg] 50% of chromium_presubmit builds will now run on LUCI.
> 
> R=​dpranke@chromium.org, jbudorick@chromium.org
> 
> No-Try: True
> Bug: 731553
> Change-Id: I12cd97bfee4d1cc7bf81f5c990014a27335a1c50
> Reviewed-on: https://chromium-review.googlesource.com/891666
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532539}

TBR=dpranke@chromium.org,tandrii@chromium.org,jbudorick@chromium.org

Change-Id: I5ea0844f22c10335ffb0de5a360d76a792442781
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731553
Reviewed-on: https://chromium-review.googlesource.com/893418Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532858}

https://skia.googlesource.com/skia.git/+log/2f5b8d81c231..7f861927fcd4

$ git log 2f5b8d81c..7f861927f --date=short --no-merges --format='%ad %ae %s'
2018-01-30 robertphillips Revert "Drop support for unused MSAA extensions"

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I83a934681b38ec6526357ac1769298ea613235ff
Reviewed-on: https://chromium-review.googlesource.com/893199
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#532857}

This feature is to run a finch experiment to measure the performance
of requesting code cache after execute.

Bug: chromium:783124
Change-Id: I7cc90c3f341c19e3727ad84903a774f8197663f2
Reviewed-on: https://chromium-review.googlesource.com/829093
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532856}

This is a new test failing on NetworkService.

TBR=shimazu
NOTRY=true

Bug: 807271
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibd72f25ad253a5d4231d3082b84d717eddde63e3
Reviewed-on: https://chromium-review.googlesource.com/893242Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532855}

This reverts commit 6e548ee1.

Reason for revert: DCHECK at content_verify_job.cc:192 occasionally fails (see crbug.com/806586).

Original change's description:
> Fix extraneous call to ContentVerifyJob::DispatchFailureCallback.
> 
> If ContentVerifyJob receives hashes (ContentVerifyJob::OnHashesReady)
> after the content is read (ContentVerifyJob::DoneReading), then it
> was possible for DispatchFailureCallback to be called more than once.
> This causes a DCHECK failure in DispatchFailureCallback
> (DCHECK(!failed_)).
> 
> Bail out early in OnHashesReady if call to ContentVerifyJob::BytesRead
> leads to a ContentVerifyJob failure.
> 
> Note that this isn't harmful in Release builds as
> DispatchFailureCallback tests ContentVerifyJob::failure_callback_
> before calling the callback, which is reset once it is called.
> Nevertheless, this is incorrect behavior and this CL fixes that.
> 
> 
> Bug: 804630
> Test: See bug description for repro steps.
> Change-Id: Icf3a5c8b4c0d01cb20e02de14b11aca4aeff03e5
> Reviewed-on: https://chromium-review.googlesource.com/879961
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531755}

TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 804630,806586
Change-Id: Ia5c67f60e95ddb607cb364c745f31dde465d3c4f
Reviewed-on: https://chromium-review.googlesource.com/893258Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532854}

Factor out FakeWebSocketBasicHandshakeStream and
FakeWebSocketHandshakeStream into websocket_test_util.

Bug: 801564
Change-Id: I093667de806f7d4879144bac447e45663219c5a1
Reviewed-on: https://chromium-review.googlesource.com/891444
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532853}

https://chromium.googlesource.com/catapult.git/+log/52dc3feb012c..857b65094956

$ git log 52dc3feb0..857b65094 --date=short --no-merges --format='%ad %ae %s'
2018-01-30 vitaliii Disable some telemetry.i.p.t.c.CpuTracingAgentTest tests on Win (flaky).

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I2e8f554c93d279e0e42b2afe77b5dddbed5a70b2
Reviewed-on: https://chromium-review.googlesource.com/893119
Commit-Queue: <catapult-deps-roller@chromium.org>
Reviewed-by: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532852}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bf50906e..9ea6a24f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I6a630733985087ee59c7ba42ee5d56a1bf281c21
Reviewed-on: https://chromium-review.googlesource.com/893058Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532851}

We need to check if there is a frame before calling CanExecuteScripts.

Bug: 806681, 806705
Change-Id: I717cbb92478806b8f2687b099c62558f5abc7f03
Reviewed-on: https://chromium-review.googlesource.com/891304Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#532850}

Adds analysis of phased lightweight instrumentation, that is
instrumentation which records several memory dumps for different
phases of program execution, such as startup or interaction.

Bug: 758566
Change-Id: Id84b2bd8f5a48865e3175d9164e8a6575d5be819
Reviewed-on: https://chromium-review.googlesource.com/883448Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532849}

Bug: 806057
Change-Id: Ida24c4484fa417cc413e512a845103e5bcef7d2d
Reviewed-on: https://chromium-review.googlesource.com/891687Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#532848}

This allows to observe how many WebRTC users use the deprecated
SDES key agreement style and how many use the DTLS style.

Bug: 804275
Change-Id: I0220328a0897e67fde387288ad6ec1475dca3de3
Reviewed-on: https://chromium-review.googlesource.com/891224
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532847}

WebTaskRunner is being deprecated. Use SingleThreadTaskRunner instead.

Bug: 794845
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7e4235744a65aaee263e388960366ed2cbebd941
Reviewed-on: https://chromium-review.googlesource.com/893018Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532846}

This CL was uploaded by git cl split.

R=bauerb@chromium.org

Bug: 177475
Change-Id: I83ec9e5eab7e96de49808c6ce1506aef1ea9bd55
Reviewed-on: https://chromium-review.googlesource.com/891902Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532845}

This CL was uploaded by git cl split.

R=treib@chromium.org

Bug: 177475
Change-Id: I0bda56f41b13861fec0c2b0ffb604fce759d35f8
Reviewed-on: https://chromium-review.googlesource.com/891878Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532844}

[Media Engagement]: Add copy to clipboard button and fixed nits described below in about:media-engagement

Nits:
- "Visits" have been renamed to "Sessions"
- "Playbacks" have been updated to "Playbacks per session"
- Rows text will never wrap to the next line.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia8892d1ef7ca9a64e196b569d623d03724392706
Reviewed-on: https://chromium-review.googlesource.com/886706Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532843}

This CL was uploaded by git cl split.

R=mkwst@chromium.org

Bug: 177475
Change-Id: I82a3074bce458d21c5a12300d54c8bf421a5b4de
Reviewed-on: https://chromium-review.googlesource.com/889948Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532842}

Bug: 177475
R=mkwst@chromium.org

Change-Id: I1494c1b0bdacea56c741bb0ec2734cff0d5e94ba
Reviewed-on: https://chromium-review.googlesource.com/889758Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532841}

The work for reporting has already been done, this only pipes into the
content layer CSP the relevant info and then pipes it back down to
webkit CSP when reports need to be submitted.

Reporting spec: https://wicg.github.io/reporting/

Related: https://chromium-review.googlesource.com/c/chromium/src/+/629083

Bug: 726634
Change-Id: I5d598840e3170fc91de4f9169b66774cbe407ede
Reviewed-on: https://chromium-review.googlesource.com/788855
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532840}

Mirror account consistency can be required by an enterprise policy
or in case the signed in user is a child account.
This is done by adding the
"X-Chrome-Connected: enable_account_consistency=true" header to the
request. For regular requests, this is done by
chrome/browser/signin/chrome_signin_helper.cc's
FixAccountConsistencyRequestHeader, but the local new tab page uses
a different code path.

Bug: 790970
Change-Id: I81c86075c2b7488639beb4e919d429d53411c6fb
Reviewed-on: https://chromium-review.googlesource.com/879141
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532839}

IdentityManager currently is informed of signin and signout events by
observing SigninManager. This is problematic when incrementally
converting the codebase to use IdentityManager rather than directly
using SigninManager: other consumers also observe SigninManager, and
the order of receiving observer notifications is not defined between
these consumers and IdentityManager. This lack of ordering can result
in consumers receiving (e.g.) a notification from SigninManager that
signin has occurred while the IdentityManager still believes that the
user is signed out.

In the long term this won't be a problem, because there will be no
direct consumers of SigninManager. However, for the conversion period
we need to ensure that IdentityManager is notified of signin and signout
events before any SigninManager observers. This CL makes that change
by
(a) adding a SigninManager::DiagnosticsClient interface whose callbacks
fire just before the SigninManager::Observer callbacks
(b) changing IdentityManager to modify its internal view of the primary
account in response to the DiagnosticsClient callbacks rather than
SigninManager::Observer callbacks.

This CL also adds IdentityManager unittests of this property that fail
before the production change is made.

Bug: 796544
Change-Id: I089813d458e122e93b143099ba2a284f972e42fa
Reviewed-on: https://chromium-review.googlesource.com/883347Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532838}

reame CSSRotation to CSSRotate for consistency with others.

https://github.com/w3c/css-houdini-drafts/pull/598
https://drafts.css-houdini.org/css-typed-om-1/#cssrotate

Bug: 806736
Change-Id: Ibb62074598d1840b11be0b03cdeb253377038ccf
Reviewed-on: https://chromium-review.googlesource.com/890157
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532837}