- 29 Jul, 2019 40 commits
-
-
François Beaufort authored
WebGPU spec says GPUTextureDescriptor.size is required when creating a texture. Bug: 877147 Change-Id: Ie0f68f7dd54c55b6d4aab826dc52274af386b54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724090 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#681754}
-
Balazs Engedy authored
Add engedy@ and hkamila@, and remove alumni. Bug: None Change-Id: I8a8e8b0c2c33cbe7d7241fa5cecff52fcb5ea097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718965 Auto-Submit: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681753}
-
Leon Han authored
This CL renames the wpt test NFCReader.html to NFCReader.https.html because WebNFC API is available only in secure contexts, then fixes the code to make it pass. BUG=520391 Change-Id: Id8f584c7ced901f15b087aec5f96fd83ba8f6d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720154Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#681752}
-
Victor Hugo Vianna Silva authored
Currently LargeIconService allows callers to decide the size of the favicon they wish to download from the favicon server. Depending on which UI surface the user opens first, a different size is downloaded, which can cause displaying upscaled icons and decrease in quality. We solve this by downloading a single sufficiently big size (chosen based on existing values used by callers), aiming to only have downscaling. Bug: 982810 Change-Id: Ibad636d4c4d63791e9eb62d99221d9f35c9cb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695268 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#681751}
-
Yutaka Hirano authored
...with a StrongAlias. StrongAlias is now recommended for replacing bool params. Discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GF1Wg0JbEhw Bug: None Change-Id: Ic9d31b68f0ead9609997dd6c5c430134dea7d85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722467 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#681750}
-
Matthew Cary authored
This replaces a legacy base::SharedMemory member with a base::UnsafeSharedMemoryRegion and base::WritableMemoryMapping pair. Functionality is unchanged, other than having separate error messages for failure on region creation and region mapping. Bug: 849207 Change-Id: I7f0123fddb02aa6f1cd093d1c142a780728822e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697601Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#681749}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f54b8653dd9d..9559cdbdf011 git log f54b8653dd9d..9559cdbdf011 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 dnovillo@google.com Fix #2609 - Handle out-of-bounds scalar replacements. (#2767) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9559cdbdf011 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I289bd7cf9b2b847ace74c7fb9ec19a5e1a4ac890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681748}
-
Monica Basta authored
Add a histogram to record the value of |kTokenServiceDiceCompatible| preference on every startup. Bug: 983983 Change-Id: I47ce649509cd4c50a498540e5efa2d241de74043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719352Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@google.com> Cr-Commit-Position: refs/heads/master@{#681747}
-
Marc Treib authored
The corresponding data types have been migrated to USS, which uses GROUP_NON_BLOCKING (which essentially means "don't use a ModelSafeWorker at all"). So the workers for FILE and HISTORY were still instantiated, but never actually used. This also lets us remove the whole HistoryModelWorker class. TBR=sky for trivial updates to components/history/core/browser/BUILD.gn (removing the deleted sync files). Bug: 923287 Change-Id: Ief4ed46fce41346ea35ea46535b8d06d6c4d212e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720709 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a96b79f90940..d7e0a36ac618 git log a96b79f90940..d7e0a36ac618 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src f54b8653dd9d..9559cdbdf011 (1 commits) Created with: gclient setdep -r src/third_party/angle@d7e0a36ac618 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I7a9e5eef47c20950397751d69e3f3b8040620f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723837Reviewed-by:
-
Kenichi Ishibashi authored
For service/shared workers, NullWorkerResourceTimingNotifier was created on the main thread and then passed to worker threads. This CL moves NullWorkerResourceTimingNotifier creation from the main thread to worker threads. The motivation behind this CL is to prepare for off-the-main-thread service worker start up. We can't create GarbageCollected objects on the IO thread. We plan to start service worker thread on the IO thread and NullWorkerResourceTimingNotifier is a GarbageCollected object. This doesn't have behavioral changes. Bug: 988335 Change-Id: I212f36f30192d3acfe52376c10afc4feabc49daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722535Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This reduces memcpy by only storing incomplete header bytes that are only needed to store for next round decoding rather than whole data. This make the perf faster a bit: (Win10, local release build not fully optimized on Z840) ToT: 147 MB/s This: 154 MB/s (+4.5%) Bug: 865001 Change-Id: I52de6b178034d69d7ff538d31c2ed660504e04a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715921Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#681743}
-
Matthew Cary authored
This change replaces uses of the legacy SharedMemoryHandle with base::UnsafeSharedMemoryRegion or base::subtlePlatformSharedMemoryRegion as appropriate. Bug: 849207 Change-Id: I7397c3485ae8bfebdbbcaca67232fbcc37593fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696963 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Currently, I don't have time to investment this further. Also after switching to lld, compile step time is not so large on the builder. Let me remove this until I found this is really plausible for CQ performance improvement. Bug: 779440 Change-Id: Ied4e7ea6daa54837383d0364779e4522c5b22604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722271Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#681741}
-
Matthew Cary authored
This replaces a use of the legacy UnalignedSharedMemory ctor taking a SharedMemoryHandle with the current ctor taking a PlatformSharedMemoryRegion. Bug: 849207 Change-Id: Iea24ebdcd941cf2fa97e19cf2aeac1a18f9773d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697602 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
-
Abhishek Bhardwaj authored
This change adds a test for testing rollover logic i.e. a monthly update starting from 31st January is scheduled on the last day of the following months i.e 28th/29th February, 31st March and so on. It also fixes bugs in the implementation caught while developing the test. It achieves the aforementioned changes by refactoring the core delay calculation loop. BUG=924762 TEST=Unit tests. Change-Id: Icc0448149398c8ff19e3221e18496e706acbdfd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711212Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681739}
-
Leo Zhang authored
We are going to experiment 2 decoder new features: - fst for non-english - hmm decoder And removed unused flag "imeservice" Bug: 937152 Change-Id: I91b2ed114b9e6d330a0d2baf278a235199eeee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722165 Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#681738}
-
Kenichi Ishibashi authored
Before this CL WebContentSettingsClient was indirectly passed to WorkerOrWorkletGlobalScope via WorkerContentSettingsClient. This was an unnecessary abstraction. We can just pass WebContentSettingsClient as a part of GlobalScopeCreationParams and keep it in WorkerOrWorkletGlobalScope. This eliminates creating a GarbageCollected object. This CL doesn't have behavioral changes. Bug: 988335 Change-Id: If740aebdb33aa0bffd1ed8c9659d3a0c92c8e20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722464Reviewed-by:
-
Rakina Zata Amni authored
Add timeout expectation for http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-3.js No-try: true No-presubmit: true No-Tree-Checks: true Bug: 988170 Change-Id: I0d164fc704bfc04541f59a6db2a7da7ac712befe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724109Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#681736}
-
Rakina Zata Amni authored
This reverts commit 1f56d90b. Reason for revert: Causes build failures on *-archive-rel, for example: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel Original change's description: > Move IPAddressSpace from blink::mojom:: to network::mojom:: > > We'll eventually need to access this from the network stack in order to > decide whether to block requests. This patch just moves the value from > its existing home in Blink to a new abode in the network service. It's > mostly the result of the following command: > > ``` > git gs IPAddressSpace -l | xargs -L1 sed -i '' \ > -e 's/third_party\/blink\/public\/mojom\/net\/ip_/services\/network\/public\/mojom\/ip_/g' \ > -e 's/\([ \(<{]\)mojom::IPAddressSpace/\1network::mojom::IPAddressSpace/g' \ > -e 's/blink::mojom::IPAddressSpace/network::mojom::IPAddressSpace/g' \ > -e 's/blink.mojom.IPAddressSpace/network.mojom.IPAddressSpace/g' > ``` > > Bug: 986744 > Change-Id: I5afebde58ccf2108db4ed7d32a4ee6484aab625e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718329 > Commit-Queue: Mike West <mkwst@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681729} TBR=kinuko@chromium.org,mmenke@chromium.org,tsepez@chromium.org,mkwst@chromium.org Change-Id: Ie5e043de160c1d327eb1575bc79efa788a71c3bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724149Reviewed-by:
-
Dominic Farolino authored
There are no blink::ResourceFetcher::PrepareRequest (this is where SetReferrer is called) crashes after build 77.0.3855.0, which is when the crash fix landed. We can remove the debugging info now and make more progress on the overall goal of the original issue. R=kinuko@chromium.org, yhirano@chromium.org Bug: 863769 Change-Id: Id4f3f4042d690cfda30d48160a963d6ec4ae1616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722164Reviewed-by:
-
Omer Katz authored
I added a worklist for registering ephemeron callbacks. ThreadHeap previously used a HashMap for that. The HashMap remains since it is also used to verify callbacks are consistent. MarkingVisitor adds entries to the worklist instead of the HashMap. ThreadHeap then reads from the worklist to the HashMap, invoking callbacks as it goes. Bug: 986235 Change-Id: Ie716281ba216a083146bff7a78abe06621befcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718371Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I2af748891280364d954e3d8198e9b95d76a74602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700865 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#681732}
-
Omer Katz authored
The pre-finalizer was used to unregister the Scrollbar from the theme. The only implementation of the UnregisterScrollbar method that did anything was that of ScrollbarThemeMac, which removed the scrollbar from a HashSet and a HashMap. Both data-structures actually held weak members, so the gc can automatically remove the ScrollBar from the data-structures and the pre-finalizer is not needed. The method UnregisterScrollbar was only called from the pre-finalizer, so I removed it as well. Bug: 981414 Change-Id: Ief15a9df658a12568de9fabdabd2950419835b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720774Reviewed-by:
-
Martin Robinson authored
AXNodeRange can include the node that we are currently calculating spelling attributes for, so we should be careful to avoid infinite recursion here. Bug: 987675 Change-Id: If3a85191e70edb87f26166fe0e043d58715ae494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720869Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#681730}
-
Mike West authored
We'll eventually need to access this from the network stack in order to decide whether to block requests. This patch just moves the value from its existing home in Blink to a new abode in the network service. It's mostly the result of the following command: ``` git gs IPAddressSpace -l | xargs -L1 sed -i '' \ -e 's/third_party\/blink\/public\/mojom\/net\/ip_/services\/network\/public\/mojom\/ip_/g' \ -e 's/\([ \(<{]\)mojom::IPAddressSpace/\1network::mojom::IPAddressSpace/g' \ -e 's/blink::mojom::IPAddressSpace/network::mojom::IPAddressSpace/g' \ -e 's/blink.mojom.IPAddressSpace/network.mojom.IPAddressSpace/g' ``` Bug: 986744 Change-Id: I5afebde58ccf2108db4ed7d32a4ee6484aab625e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718329 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Maksim Sisov authored
The Wayland spec says that explicit grab of popups can be set on mouse press, keyboard press or touch DOWN event. However, Chromium reacts (creates windows, opens windows and etc) on touch UP events, which results in closed popups by a Wayland compositor. Thus, stop using explicit grab if a parent window (which was the source of the event) is not touch focused, but keyboard or mouse pointer focused. Last, there is a bug in gnome/mutter, which results in crashing entire wayland session if a popup is not explicitly grabbed and unmapped. Thus, just continue using explicit grabs with it to avoid crashing. In this case, only context menus work in this environment. Bug: 973015 Change-Id: I149b4f91378305f984c72d13161cadd29e7f7753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715079 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#681728}
-
Alexandre Courbot authored
With the V4L2SVDA ported to V4L2Queue, we don't need these old methods anymore and can remove them. At the same time, the release callback argument of the new constructor methods was never used, so remove it as well. Bug: 987852 Test: video_decode_accelerator_unittest passes on Minnie. Test: video_decode_accelerator_tests passes on Minnie. Change-Id: I7f54d3adbfc5a9b8149872b43a4507efbbcefdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720235 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681727}
-
Alexey Baskakov authored
More cleanup CLs to follow. Bug: 973288 Change-Id: Ibe24dfee03f3428850866c5025de4b7e4136b406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722134Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#681726}
-
Piotr Pawliczek authored
The internal structure of BulkPrinterCalculator called Restrictions was destroyed by posting to an internal TaskRunner a Delete task. Unfortunately, during cleaning after a unittest the internal TaskRunner didn't accept any new tasks, what resulted in memory leak. This patch solved this problem by replacing deletion through posted Delete task by synchronized reference counting. BUG=chromium:977617 TEST=on my workstation Change-Id: I0bf94005fadeec4627978c7fbbc82238d58c3fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718771 Commit-Queue: Sean Kau <skau@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#681725}
-
Koji Ishii authored
This patch changes Element::LocalNameForSelectorMatching() to use LowerASCII instead of DeprecatedLower. DeprecatedLower has partial Unicode conversions, such as converting U+212A to 'k', but lowering only ASCII is mandated by the spec: https://www.w3.org/TR/selectors-4/#case-sensitive Currently, there are 6 usages of AtomicString::DeprecatedLower and 37 usages of String::DeprecatedLower. This patch reduces one of the 6 usages. Bug: 627682 Change-Id: I49bdbbae645a287bf6dacdcb0a6481f7eb93c022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720642 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#681724}
-
Rakina Zata Amni authored
Disable flaky SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/play:media:soundcloud:2018 TBR=perezju@chromium.org Bug: 987858 Change-Id: I7dbd4dc300f38c9aacad4a214a6618c8120e0dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722578Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d00c75153395..d188f3a9613d git log d00c75153395..d188f3a9613d --date=short --no-merges --format='%ad %ae %s' 2019-07-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fab397e5acde..a96b79f90940 (15 commits) Created with: gclient setdep -r src/third_party/skia@d188f3a9613d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: I7c7c05ae0f5977b8fe9ffc488a3132c7411b2089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722781Reviewed-by:
-
Vaclav Brozek authored
As discussed in https://crrev.com/c/1698401 and recorded in the design doc [1], CSVPassword needs to stop being copyable and moveable to prevent some ways of use-after-free. This CL just removes the respective constructors (including the default one) and operator=. It also stops marking the (now only) 2-argument constructor as explicit, because the implicit construction will later be needed in CSVPasswordIterator (see the discussion on the other CL and [1]). [1] https://docs.google.com/document/d/1wsZBl93S_WGaXZqrqq5SP08LVZ0zDKf6e9nlptyl9AY/edit?usp=sharing Bug: 934326 Change-Id: I2e1aea9b7fa9d4fbdb76cb12f13ee82a6ff87651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722533 Auto-Submit: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#681721}
-
Takuto Ikuta authored
This is followup for https://chromium-review.googlesource.com/c/chromium/src/+/1714485 to fix presubmit error like https://ci.chromium.org/p/chromium/builders/try/chromium_presubmit/536124 Change-Id: I911370e31c3e3fe9675ca91c903ef147a3d69c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723510 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681720}
-
Yutaka Hirano authored
This is a reland of 1ccc5eee Original change's description: > Unify allow_credentials and credentials_mode on network::ResourceRequest > > Remove allow_credentials, map allow_credentials: false to > credentials_mode: kOmit and map allow_credentials: true to > credentials_mode: kInclude. > > network::URLLoader cannot handle kSameOrigin. This CL doesn't change > that. CORSURLLoader translates the value to either kOmit or kInclude. > > This works correctly even when OOR-CORS is disabled because in that > case load flags are set in the renderer. One caveat is we will not > be able to remove the load flags until we remove the blink-side CORS > code (M78? M79?) with this change. > > This CL removes a validity check for credentials related settings in > CorsURLLoaderFactory. Originally the check was introduced to check the > inconsistency between credentials_mode and load flags. After that > allow_credentials was introduced, and at > https://crrev.com/c/chromium/src/+/1443976 the logic was changed to > check the inconsistency between credentials_mode and allow_credentials. > Now they are merged and we don't need the check. > > Bug: 799935 > Change-Id: Ic05b2d41456d91fd3f48416a3a3e8fc98e235756 > Tbr: bsimonnet@chromium.org, dimich@chromium.org, groby@chromium.org, markusheintz@chromium.org, olka@chromium.org, satorux@chromium.org, tbansal@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695341 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Greg Levin <glevin@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Michael Martis <martis@chromium.org> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681698} TBR=sky@chromium.org,horo@chromium.org,mpearson@chromium.org,davidben@chromium.org,thakis@chromium.org,toyoshim@chromium.org,nyquist@chromium.org,markusheintz@chromium.org,vasilii@chromium.org,jrummell@chromium.org,asvitkine@chromium.org,groby@chromium.org,bsimonnet@chromium.org,noel@chromium.org,rsorokin@chromium.org,glevin@chromium.org,yhirano@chromium.org,dimich@chromium.org,mmenke@chromium.org,nhiroki@chromium.org,sdefresne@chromium.org,tsepez@chromium.org,treib@chromium.org,estark@chromium.org,tbansal@chromium.org,gogerald@chromium.org,mattreynolds@chromium.org,wychen@chromium.org,olka@chromium.org,satorux@chromium.org,rbpotter@chromium.org,pnoland@chromium.org,fhorschig@chromium.org,martis@chromium.org,kmilka@chromium.org,jselover@chromium.org,nicolaso@chromium.org,mcarlen@chromium.org Bug: 799935 Change-Id: Iec8067b3fed29bd6845077f5dc9c564d6640b6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722274Reviewed-by:
-
John Abd-El-Malek authored
Bug: 934009, 818445 Change-Id: I56554d416137100e31b1d225abcd9312524e4c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722569 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/642b6ad99ffc..7fc868349143 git log 642b6ad99ffc..7fc868349143 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 johnkslang@users.noreply.github.com Merge pull request #1813 from jeffbolznv/compositeconstruct Created with: gclient setdep -r src/third_party/glslang/src@7fc868349143 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I6f6cb1399c57555a026a3a5f030a45a54a78da0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723297Reviewed-by:
-
Alexandre Courbot authored
Port the V4L2SVDA outpu queue to V4L2Queue, in order to reduce the amount of code in this messy class and make it overall more secure. With both the input and output queue ported, we can now make use of the new V4L2DecodeSurface constructors and remove some more members. Bug: 987852 Test: video_decode_accelerator_unittest passes on Minnie. Test: video_decode_accelerator_tests passes on Minnie. Change-Id: I300bbbfbafb8c86ad89d23c45e7702dca0876660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720234 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Bug: 973324 Change-Id: I34739c8808443f2657a83e90d72db60436ccd6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715497 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
