- 24 Aug, 2020 40 commits
-
-
Kevin Ellis authored
The flake is caused by limited precision of timeline times. When comparing times with >=, the boundary time needs to factor in error tolerance. The virtual/threaded-no-composited-antialiasing variant of this test had a recent flake score of 954. Bug: 623434 Change-Id: I44b41da1326849da4b3dec30cea76be6673e0b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368500Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#801013}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /content/browser/font_unique_name_lookup This CL was uploaded by git cl split. R=drott@chromium.org Bug: 1110266 Change-Id: I6e746e1ed90bf2bab026c0c159ebd926d7411979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371289 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#801012}
-
Sorin Jianu authored
Remove the --single-process command line switch. After this CL, Windows is using COM RPC for all client server interactions. Bug: 1060807, 1060800 Change-Id: Ib3582d56ee01724e176ac04f0d6c2600fbf1bb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321330 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#801011}
-
ckitagawa authored
If a launch is backgrounded before TimeToFirstBitmap we shouldn't record it. This CL is a very simple change to enable that and mirror the behavior of FirstContentfulPaint. Bug: 1109991 Change-Id: Ic1624516d55ded2eb74fa140d9f0d57865b11a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372722 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801010}
-
Henrique Nakashima authored
This should fix the failure in the builder and allow the script to be run from any directory. Bug: 1111056 Change-Id: Ibecfbe763a18bf4fcc5f227d23ce42edee3a2ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369011Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#801009}
-
Sébastien Séguin-Gagnon authored
In some cases the model and table were not in sync, which caused a crash when trying to get the visibleCells of the table. The reload should not be too expensive since we only call it when we're on the root bookmark page. Bug: 1116408 Change-Id: I41e3f1c6d09ca5b92f2bbb0494d426e04f2db539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370605Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801008}
-
ckitagawa authored
This CL defers the subframe transform until serializing so as to not affect the position of the sub-picture in the paint preview if embedding into a single SkPicture. Change-Id: I613e713e08ea453dd7999f06810f7481501b0658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364171Reviewed-by:
-
Etienne Pierre-Doray authored
Jobs API causes longer running concurrent marking task. Since marked bytes is only recorded when the task exists, this causes the mutator thread to underestimate progress and spend more time marking. To avoid such regression, this CL makes concurrently_marked_bytes_ atomic and updates it more frequently. Drive by: Remove unused kConcurrentMarkingStepDuration param that was previously used for yielding. Bug: 1119552 Change-Id: Ia91c994a4ad417456bbe07bd3f4190f69cba5c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368498Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#801006}
-
Sigurd Schneider authored
DevTools change: https://crrev.com/c/2367940 Bug: chromium:1011811 Change-Id: Ib3725b572313baf56bbcde3783c2bc6094c02e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372483Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#801005}
-
Frédéric Wang authored
This is a follow-up of [1] where the validation on the web and browser processes have been unified. Tests for 'web+' have been added to ProtocolHandlerRegistryTest (browser process). This CL adds similar and more complete checks to the existing WPT test (web process). The relevant section from the specification says [2]: * Set scheme to scheme, converted to ASCII lowercase. * If scheme is neither a safelisted scheme nor a string starting with "web+" followed by one or more ASCII lower alphas, then throw a "SecurityError" DOMException. Bug: 971917, 952974, 627682 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2362802 [2] https://html.spec.whatwg.org/multipage/system-state.html#normalize-protocol-handler-parameters Change-Id: I769048bd4db6883a75d4237f20f23aa61452d732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371632Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#801004}
-
Leonard Grey authored
We've had longstanding issues with interrupted tab drags not cancelling the move loop, often causing a crash when the loop is ended belatedly. A recent repro (issue 1119714) theorizes that a NSLeftMouseUp event is not reaching the move loop. Another repro case from a while ago (right clicking the tab while dragging) had a similar proximate cause. This change causes the move loop to also look at mouse moves while it's active. If it receives one (and the left mouse button is not down), it assumes we missed a mouse up and terminates the loop. (As a side note, with this change, I can no longer repro the behavior in 119714 where a single full-screen tab drag can flakily unfullscreen the tab. I'm thinking this behavior itself was due to move loop shenanigans.) Bug: 1119714,1030987 Change-Id: Idd4c765e1abfc87099fa6be82ae2e22f8dc9c55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368172 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801003}
-
Scott Violet authored
The coordinates need to be converted if zoom-for-dsf is enabled. BUG=1119725 TEST=see description in bug. Change-Id: Ic70a77cb726fb1458a1bbb5304d8ec518176901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370654Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#801002}
-
Andy Paicu authored
TBR=raymes@chromium.org Bug: 1016730 Change-Id: I6c00d5179fb1013c3b171281ea82e6baef961385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372563 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801001}
-
Nico Weber authored
Bug: none Change-Id: Idd7520386dbb7965dc357619fc850e6b2949ef19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372723Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#801000}
-
Charlie Hu authored
Bug: 1113375 Change-Id: Ic20b0900ab8ad07792454a1bbc2e2cf5ea1b9b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333499Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#800999}
-
Raphael Kubo da Costa authored
Introduce the same changes added to the regular Permissions API implementation in r756753: instead of having a "wake-lock" permission with a |type| field set to either "screen" or "system", the spec now uses two separate permissions with no |type| field, "screen-wake-lock" and "system-wake-lock". Fixed: 1121076 Change-Id: Ib050a1efa82143c177e32bb6a39cad9203198dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372365 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800998}
-
Monica Basta authored
Bug: 1063856 Fixed: 1121142 Change-Id: I8471310b8c0c3e8fb139ba5f48ee6d2f90176a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367834Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#800997}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/856f8c9f..97cc41d3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bc9e0e5fb604438c5e4e79b162422fdd28c40a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372113Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800996}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ecc4ecb65cd8..6702add20dd3 2020-08-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-24 tvanderlippe@chromium.org Fix contextmenu for console view messages If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7d06cf9b8d0a1c1d72d1dbac6ba2c466d04ae487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800995}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1z78dkOIi7FbwSXuOzOhC-mpcnuw4JsFl/view?usp=sharing Bug: 1115056 Fixed: 1121137 Change-Id: I46bb7b3bbd41a7ced628681e84026442a5d414fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366938 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
-
Evan Stade authored
No behavior change is intended for Chrome. This simply relocates code and assets and updates references. One fairly major change for WebLayer is that Base.Theme.Chromium is folded into Theme.BrowserUI, which means that WebLayer may get some slightly different theming in some places. This is necessary because the photo picker uses Theme.Chromium.Fullscreen, which builds on Base.Theme.Chromium. For now, DecoderService and the aidls live alongside the other code, although they won't be usable by WebLayer as-is. They will have to be shuffled around some more. Bug: 1110930 Change-Id: I7a5c730b0dd67cb63f9323bcd6f98eb187745b57 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363639Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#800993}
-
Tom Anderson authored
After [1], multiple MessagePumpGlibs may be created, so the workaround for Ozone/X11 is no longer necessary. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2343314 BUG=1078392 R=rjkroege CC=spang Change-Id: I985c83e21a17e802fe9356c6cbd6c16513487907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364796 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#800992}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3cdc259008b5..216b984d3946 2020-08-24 mtklein@google.com delete nullptr,0 section of style guide If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I68bea69ab6d59cf36c5d8ac37632bb10f19ed7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371335Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/ui/views/profiles This CL was uploaded by git cl split. R=pbos@chromium.org Bug: 1110266 Change-Id: I7d6a1987ecc2507b95f9ec03cb7c90235fa17d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371261 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#800990}
-
Jacobo Aragunde Pérez authored
Created AXEventCounter class to help tests counting accessibility events. Instead of writing their own observers, tests can create an instance of AXEventCounter and check how many events of each type have been registered. Bug: None Change-Id: I3b07a077a680b98415f5ed6bee1c4e6528237a22 AX-Relnotes: no user-facing changes. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336603 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800989}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: I59c9d81e6c9a4af56a2770ac854e7809caadda19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359559 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800988}
-
Ian Kilpatrick authored
This piece of code was originally introduced in: https://chromium.googlesource.com/chromium/src/+/493129de0e666cb0b6fd6bf966a0993aa3d64be5 This had the effect of considering the margin-block-end of a LayoutBox as scrollable overflow. This wasn't in any specification. This appears to be trying to replicate an effect from FF, however this only occurs for FF on the root scroller, not arbitrary scrollers like this does. Fortunately Safari never shipped this behaviour. Bug: 34224 Change-Id: I1a2d45f598fb44955cc39017d70b126221d57a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371203Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#800987}
-
Rohit Rao authored
If a user force-quits the app during launch (while the splash screen is still visible), it's possible for the app to receive applicationWillTerminate: without first receiving application:didFinishLaunchingWithOptions:. In this scenario, invoking the normal shutdown logic will lead to crashes, because the app was never started up. This CL adds logic to detect this case and return early from applicationWillTerminate. BUG=1115863,983504,1086396 Change-Id: I453f0ecae35a4431dc51490c6e38bbfd0d224f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367986 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800986}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c86f0d91767..09b5e6b1950b 2020-08-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 0d6b4440549b to 76e8dee41452 (3 revisions) 2020-08-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b79773a35d52 to 4dd122392f3a (1 revision) 2020-08-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44e1791f100c to 622558b02e1a (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I6fafc6778695c0acffa5a5443dd901b120a4be97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371330Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9c0864ef. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" 2519d6aa "[SanitizerAPI] Change function name to match latest discussion" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I0f48290ac55694767723fd63bfff26ffc7959c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372109Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800984}
-
Maksim Sisov authored
it's revealed when use_x11 && use_ozone config is used. Change-Id: Ic09cd74a6b424d0430f4eb6bda1e0d8be1b9fd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372482Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598226952-0b51be5d3acf41b4d5c1d696ddf01b10602a88d4.profdata to chrome-mac-master-1598270291-b801bf78b6b55c941ccf8675be0d44cb7bb468ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9420b7860a4d926c0b37efe6c42302fcbcce24d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371334Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/media/webrtc/webrtc_disable_encryption_flag_browsertest.cc This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 1110266 Change-Id: I0fc68995d831e7b6317f1b949c5bbf4298978702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371248 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#800981}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f7cf133ad5f0..70b2cf8b368d 2020-08-24 danilchap@webrtc.org Delete deprecated version of EncodedImageCallback::OnEncodedImage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I89f27e4c9cf50b9f3c0ce9c9c78747b6c0e4144e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371332Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01f7fadf76bf..ecc4ecb65cd8 2020-08-24 tvanderlippe@chromium.org Update Mocha and rollup-plugin-terser If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieb099222e319b09a3c54525341520a9f8e1322d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370523Reviewed-by:
-
sauski authored
Previously all generated preferences were created along with the service. As the SettingsPrivateEventRouter is created along with the profile, all generated preferences and all services they may depend on are also created. Preferences are only actually required to exist when they are observed, which may never occur during the lifetime of the browser. e.g a user never opens settings. This CL moves the creation of all generated preferences to only occur when an attempt is made to interact with a generated preference. Bug: 1112454 Change-Id: I82a565fd4181be018b9714d8c7a18b85e6bb988d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343076Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#800978}
-
Nazerke authored
As a tabmodel needs to be deprecated, this CL extracts ClosingWebStateObserver into a browser agent to remove its usage in TabModel. Bug: 1050111,1045575,1045142 Change-Id: Ic6c5b65ff55bd211d38752b274c4dcbb9d854bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287434 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1ca34252..856f8c9f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0da88b406fe6bf448aac9d611d60b75fcb48536d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372342Reviewed-by:
-
Peter E Conn authored
TBR=wuwang@chromium.org Change-Id: Ibdaa1324d29bc989f2e18e34891a632e121b11f9 Bug: 1096656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372364 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#800975}
-
Mihai Sardarescu authored
There is a single implementation of a GaiaAuthFercherIOSBridge, so the code is more readable if all the logic in this bridge lives only in the implementation class. Bug: 1101748 Change-Id: Ie7aaebb3f32323dd3310f273cda06d1225e3550d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368553 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#800974}
-
