- 05 Sep, 2013 40 commits
-
-
lazyboy@chromium.org authored
a. Expand/shrink <webview> element when 'sizechange' event fires, to match with the new view size (in shim). b. For SW mode, fix a bug where damage buffer would remain smaller than the view size and would result in crash. Added test for this case. BUG=173238, 282116 Test=WebViewTest.AutoSize.*, <webview>.autosize=true now should autosize webview container within the constraints (minwidth/maxwidth/minheight/maxheight). Review URL: https://chromiumcodereview.appspot.com/23691039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221402 0039d316-1c4b-4281-b951-d872f2087c98
-
ricea@chromium.org authored
TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/23685005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221401 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This moves the views parts out of cross-platform omnibox_view_browsertest.cc into a views specific file (c/b/ui/views/omnibox_view_views_browsertest.cc). BUG=125846 TEST=interactive_ui_tests --gtest_filter=OmniboxViewViewsTest.SelectAllOnClick R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/23494016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221400 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
requestAutocomplete displays a splash screen as well as an interstitial while communicating with wallet using the overlay shield. The current dialog is hidden behind the shield for the duration, and the shield can contain images as well as text messages. R=sail@chromium.org BUG=157274, 260951 Review URL: https://chromiumcodereview.appspot.com/23674004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221399 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221398 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
R=rmistry@google.com Review URL: https://codereview.chromium.org/23526018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221397 0039d316-1c4b-4281-b951-d872f2087c98
-
primiano@chromium.org authored
Right now the <select> dialogs use directly R.layout.select_dialog_(multi|single)choice defined in the Android framework. Adding an extra level of indirection to them through attrs since other builds need to override these two layouts. BUG=285270 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23523025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221396 0039d316-1c4b-4281-b951-d872f2087c98
-
posciak@chromium.org authored
Webrtc unfortunately likes to sleep in BaseChannel::Send on the renderer's ChildThread while directly or indirectly calling into HW encoder and we end up in a number of deadlocks of varying complexity in one way or another, while trying to also use the ChildThread to allocate shared memory to service those calls. The only way to avoid this is to not get onto the ChildThread while servicing webrtc requests, so we use the static ChildThread::AllocateSharedMemory() to send the request directly from the current thread. Also add VEA::RequireBitstreamBuffers() to the initialization sequence, so that RTCVideoEncoder::InitEncode() will only return after we've allocated requested buffers. VEA::RequireBitstreamBuffers() is effectively a part of initialization sequence anyway, because we can't really call VEA::Encode() without knowing the VEA impl's coded size requirements. This could also potentially reduce the latency of the first Encode() call. And separately, zero out header structures sent to the client. TEST=apprtc.appspot.com with HW encoding BUG=260210 Review URL: https://chromiumcodereview.appspot.com/23440015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221395 0039d316-1c4b-4281-b951-d872f2087c98
-
nona@chromium.org authored
BUG=None TEST=None, just working fine. Review URL: https://chromiumcodereview.appspot.com/22909048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221394 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
Switch from text insertion to key press and release events on the virtual keyboard. First step in integration the virtual keyboard with IMEs. BUG=257093, 257098 Review URL: https://chromiumcodereview.appspot.com/20145004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221393 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
Broke http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28daisy%29&number=12452 and maybe http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=55236 http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder&number=9603 > Use Finch to compare the performances of CLD1 and CLD2 > > Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used. > > By this CL, each platform will have the below status: > > Linux: Use both CLD1 and CLD2 (and use Finch). > Mac OS X: Use both CLD1 and CLD2 (and use Finch). > Windows: Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap. > iOS: Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.) > Android: Still use only CLD1. (The same reason as iOS) > > So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.) > > BUG=240647 > > Review URL: https://chromiumcodereview.appspot.com/22867032 TBR=hajimehoshi@chromium.org Review URL: https://codereview.chromium.org/23766011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221391 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221390 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
> Blink roll 157169:157224 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157170:157224&mode=html > TBR= > BUG= > > Review URL: https://chromiumcodereview.appspot.com/23960002 Blink commit r157177 broke builds for ChromeOS, because of a missing include: third_party/WebKit/Source/core/platform/audio/DenormalDisabler.h:114:27: error: 'FLT_MIN' was not declared in this scope See also http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12414/steps/cbuildbot/logs/stdio TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/23458024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221389 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221388 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
> Blink roll 157224:157244 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157225:157244&mode=html > TBR= > BUG= > > Review URL: https://chromiumcodereview.appspot.com/23681008 TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/23530037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221387 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221386 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
> Blink roll 157250:157284 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157251:157284&mode=html > TBR= > BUG= > > Review URL: https://codereview.chromium.org/23536027 Blink commit r157177 broke builds for ChromeOS, because of a missing include: third_party/WebKit/Source/core/platform/audio/DenormalDisabler.h:114:27: error: 'FLT_MIN' was not declared in this scope See also http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12414/steps/cbuildbot/logs/stdio TBR=eustas@chromium.org Review URL: https://codereview.chromium.org/23749005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221385 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
- Re-post callbacks only if they are called synchronously - Always return a valid operation ID (even if it's finished immediately) - Fix cancel callbacks ordering BUG=279288 TEST=existing tests TBR=hidehiko@chromium.org, tzik@chromium.org Review URL: https://codereview.chromium.org/23898002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221384 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
BUG=240165 Review URL: https://chromiumcodereview.appspot.com/23618029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221383 0039d316-1c4b-4281-b951-d872f2087c98
-
ikarienator@chromium.org authored
Enable the exit observer for NOTIFICATION_APP_TERMINATING. Review URL: https://chromiumcodereview.appspot.com/23483014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221382 0039d316-1c4b-4281-b951-d872f2087c98
-
Hokein.Wu@gmail.com authored
[SystemInfo API] Implement DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform method for Linux GTK. Also rename display_info_provider_x11 to display_info_provider_linux for better understand. BUG=None Review URL: https://chromiumcodereview.appspot.com/22891026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221381 0039d316-1c4b-4281-b951-d872f2087c98
-
hajimehoshi@chromium.org authored
Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used. By this CL, each platform will have the below status: Linux: Use both CLD1 and CLD2 (and use Finch). Mac OS X: Use both CLD1 and CLD2 (and use Finch). Windows: Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap. iOS: Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.) Android: Still use only CLD1. (The same reason as iOS) So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.) BUG=240647 Review URL: https://chromiumcodereview.appspot.com/22867032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221380 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221378 0039d316-1c4b-4281-b951-d872f2087c98
-
eustas@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157251:157284&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/23536027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221377 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221375 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
> Blink roll 157244:157250 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157245:157250&mode=html > TBR= > BUG= > > Review URL: https://codereview.chromium.org/23499009 Blink commit r157177 broke builds for ChromeOS, because of a missing include: third_party/WebKit/Source/core/platform/audio/DenormalDisabler.h:114:27: error: 'FLT_MIN' was not declared in this scope See also http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12414/steps/cbuildbot/logs/stdio TBR=aboxhall@chromium.org Review URL: https://codereview.chromium.org/23956005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221374 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
Replace directly use of DriveIntegrationService to drive::util::Get{DriveService,FileSystem}ByProfile. As preparation to start returning DriveIntegrationService instance always by DriveIntegrationServiceFactory::GetForProfile, this reduces its direct usage. BUG=284972 TEST=Ran unit_tests R=satorux@chromium.org Review URL: https://codereview.chromium.org/23531027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221367 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
This allows us to disable extension garbage collection for the kiosk mode screensaver extension. See associated bug for details. R=asargent@chromium.org BUG=280363 TEST=Screensaver plays through and loops in retail kiosk mode. Review URL: https://chromiumcodereview.appspot.com/23629027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221366 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Previously it was waiting for the full Drive tree to load, which takes unnecessarily long time. BUG=283901 R=hidehiko@chromium.org Review URL: https://codereview.chromium.org/23861006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221365 0039d316-1c4b-4281-b951-d872f2087c98
-
phoglund@chromium.org authored
The bug we were working around has been fixed, so we can safely revert this workaround. BUG=285051 > Worked around bug with gtest filters on Linux. > > We have temporarily disabled all WebRTC content_browsertests on Linux. This causes our custom build steps to hang because they no longer select any test cases on Linux, triggering bug 285051. This works around that bug so we don't have to disable the step and restart all our masters. > > BUG=285051 > TBR=tommi@chromium.org > NOTRY=True > > Review URL: https://codereview.chromium.org/23513014 TBR=phoglund@chromium.org Review URL: https://codereview.chromium.org/23601014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221364 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
- Remove unused ContinueGetFileListRequest. - Remove unused Parse functions from drive_api_service. - Rename remaining "Parse" functions in drive_api_service to "Convert" functions to adapt its behavior more. BUG=277253, 275233 TEST=Ran unit_tests R=kinaba@chromium.org Review URL: https://codereview.chromium.org/23477038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221363 0039d316-1c4b-4281-b951-d872f2087c98
-
sukolsak@chromium.org authored
When the framework tried to uninstall Chrome, it would prompt the user with a dialog box saying that "Are you sure you want to uninstall Google Chrome? [ ] Also delete your browsing data?". This required a user action. Make it uninstall Chrome silently by using the --force-uninstall option. NOTRY=True BUG=264859 1) Uninstall Chrome (if it's installed.) 2) Build Chrome with Release mode and make sure that mini_installer.exe is created. 3) Go to src\chrome\test\mini_installer 4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass without requiring you to click anything. Review URL: https://chromiumcodereview.appspot.com/23950004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221362 0039d316-1c4b-4281-b951-d872f2087c98
-
sukolsak@chromium.org authored
The framework ran commands from the current working directory. Make it run commands from the framework's directory. NOTRY=True BUG=264859 1) Uninstall Chrome (if it's installed.) 2) Build Chrome with Release mode and make sure that mini_installer.exe is created. 3) Go to src\chrome\test\mini_installer 4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass. 5) Go to src\chrome\test 6) Run "python mini_installer\test_installer.py mini_installer\config\config.config --build-dir=<build-dir> --target=Release". The test should pass. Review URL: https://chromiumcodereview.appspot.com/23557009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221361 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://extensionszhchbin@gmail.com authored
BUG=131612 Review URL: https://chromiumcodereview.appspot.com/23523019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221360 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
The --fake-cloud-policy-type flag has also been enabled for iOS, for testing purposes. BUG=285084 Review URL: https://chromiumcodereview.appspot.com/23475018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221359 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
- remove the suppressions that won't be needed after https://codereview.chromium.org/23602005/ is landed - add a suppression for race in base::HistogramSamples::IncreaseSum Suppress a race in media::TestInputCallback::OnData (issue 239359) BUG=46840,239359 TBR=jar@chromium.org,timurrrr@chromium.org Review URL: https://codereview.chromium.org/23477019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221357 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
This is preparation to start returning DriveIntegrationService always from DriveIntegrationServiceFactory::{Get,Find}ForProfile. BUG=284972 TEST=Ran unit_tests R=kinaba@chromium.org, satorux@chromium.org Review URL: https://codereview.chromium.org/23523022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221356 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
The user deserves a chance to override. Now that we've made the UI subtle, it's not like users are going to hit the button by accident. BUG=285376 R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/23971005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221355 0039d316-1c4b-4281-b951-d872f2087c98
-
etienneb@chromium.org authored
This issue was found by a linter. R=danakj@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/23944006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221354 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
Forgot to move them in crrev.com/221334. BUG=273386 TEST=none R=hidehiko@chromium.org Review URL: https://codereview.chromium.org/23723005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221353 0039d316-1c4b-4281-b951-d872f2087c98
-