GitLab

CBR is required for cyclic refresh.

BUG=134202

Review URL: https://codereview.chromium.org/1079593004

Cr-Commit-Position: refs/heads/master@{#326881}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1091093006

Cr-Commit-Position: refs/heads/master@{#326880}

TCPListenSocket will be removed, use TCPServerSocket instead.

BUG=472766

Review URL: https://codereview.chromium.org/1053343002

Cr-Commit-Position: refs/heads/master@{#326879}

Revert of Encrypt certificate reports before uploading to HTTP URLs (patchset #20 id:400001 of https://codereview.chromium.org/1083493003/)

Reason for revert:
This CL broke the Win8 GN bot:

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/6514

Original issue's description:
> Encrypt certificate reports before uploading to HTTP URLs
>
> This CL introduces a new protobuf to store encrypted
> CertLoggerRequests. Serialized certificate reports are encrypted with an
> AES-CTR-128-HMAC-SHA256 AEAD (from BoringSSL, thus encrypted reports are
> only supported on BoringSSL platforms) before being uploaded to HTTP
> endpoints. |CertificateErrorReporter::IsHttpUploadUrlSupported| allows
> users of the class to set an HTTP URL if supported.
>
> BUG=461590
>
> Committed: https://crrev.com/0a3351c2a7c81284f82e6531380a21d079f55056
> Cr-Commit-Position: refs/heads/master@{#326876}

TBR=agl@chromium.org,felt@chromium.org,mattm@chromium.org,estark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461590

Review URL: https://codereview.chromium.org/1073913004

Cr-Commit-Position: refs/heads/master@{#326878}

screen rotations on inactive displays.

TEST=ScreenOrientationControllerTest, RotateInactiveDisplay

BUG=479503

Review URL: https://codereview.chromium.org/1108473002

Cr-Commit-Position: refs/heads/master@{#326877}

This CL introduces a new protobuf to store encrypted
CertLoggerRequests. Serialized certificate reports are encrypted with an
AES-CTR-128-HMAC-SHA256 AEAD (from BoringSSL, thus encrypted reports are
only supported on BoringSSL platforms) before being uploaded to HTTP
endpoints. |CertificateErrorReporter::IsHttpUploadUrlSupported| allows
users of the class to set an HTTP URL if supported.

BUG=461590

Review URL: https://codereview.chromium.org/1083493003

Cr-Commit-Position: refs/heads/master@{#326876}

This just happened to work before due to prior includes.

BUG=472862

Review URL: https://codereview.chromium.org/1054963009

Cr-Commit-Position: refs/heads/master@{#326875}

Review URL: https://codereview.chromium.org/1052993012

Cr-Commit-Position: refs/heads/master@{#326874}

It's being moved to a different repo, see https://codereview.chromium.org/1100783002

BUG=433338

Review URL: https://codereview.chromium.org/1105963002

Cr-Commit-Position: refs/heads/master@{#326873}

Interestingly, it is very similar to
https://codereview.chromium.org/277943002 !

BUG=440843, 362521

Review URL: https://codereview.chromium.org/1093223006

Cr-Commit-Position: refs/heads/master@{#326872}

Haven't been able to repro this locally, but it's apparently possible for a
calculation to return a negative value for an animation duration, resulting in
a crash.

BUG=481031

Review URL: https://codereview.chromium.org/1108653002

Cr-Commit-Position: refs/heads/master@{#326871}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1100223002

Cr-Commit-Position: refs/heads/master@{#326870}

for all alert dialogs.

BUG=463576

Review URL: https://codereview.chromium.org/1096263005

Cr-Commit-Position: refs/heads/master@{#326869}

This fixes a test failure on clang bots.

BUG=480546
R=anthonyvd@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1108643002

Cr-Commit-Position: refs/heads/master@{#326868}

These browser tests should end the need for constant manual testing.
These have been a long time coming.

BUG=475688

Review URL: https://codereview.chromium.org/1088763002

Cr-Commit-Position: refs/heads/master@{#326867}

It should fix the following error:
FAILED: cd ../../gpu; python ../tools/isolate_driver.py check --isolated
"../out/Release/gpu_unittests.isolated" --isolate
"gpu_unittests.isolate" --path-variable DEPTH .. --path-variable
PRODUCT_DIR "../out/Release " --extra-variable
"version_full=44.0.2383.0" --config-variable
"CONFIGURATION_NAME=Release" --config-variable "OS=linux"
--config-variable "asan=0" --config-variable "branding=Chromium"
--config-variable "chromeos=0" --config-variable
"component=static_library" --config-variable "disable_nacl=0"
--config-variable "enable_pepper_cdms=1" --config-variable
"enable_plugins=1" --config-variable "fastbuild=1" --config-variable
"icu_use_data_file_flag=1" --config-variable
"internal_gles2_conform_tests=0" --config-variable
"libpeer_target_type=static_library" --config-variable "lsan=0"
--config-variable "msan=0" --config-variable "target_arch=x64"
--config-variable "tsan=0" --config-variable "use_custom_libcxx=0"
--config-variable "use_instrumented_libraries=0" --config-variable
"use_prebuilt_instrumented_libraries=0" --config-variable
"use_openssl=0" --config-variable "use_ozone=0" --config-variable
"use_x11=1" --config-variable "v8_use_external_startup_data=1"
Failed to find an input file: Input file
/b/build/slave/linux_clobber/build/src/out/Release/xdisplaycheck doesn't
exist

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/19419/steps/compile%20%28with%20patch%29/logs/stdio

BUG=481110
TEST=trybots
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/1095203007

Cr-Commit-Position: refs/heads/master@{#326866}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/aa31ee7..9d9725c

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1060583010

Cr-Commit-Position: refs/heads/master@{#326865}

See https://docs.google.com/document/d/1AZmbifXOirRdIcAkhgXT_u1wam5FRxy-Wt7I-kv3CCg/edit?usp=sharing for details.

BUG=479306

Review URL: https://codereview.chromium.org/1099313003

Cr-Commit-Position: refs/heads/master@{#326864}

Review URL: https://codereview.chromium.org/1099713005

Cr-Commit-Position: refs/heads/master@{#326863}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1102573006

Cr-Commit-Position: refs/heads/master@{#326862}

Adds a gyp and gn build target: base_junit_tests
Adds test suite: base_junit_tests

Depends on https://codereview.chromium.org/1048153002/
BUG=448030,472152

Review URL: https://codereview.chromium.org/1051343002

Cr-Commit-Position: refs/heads/master@{#326861}

Review URL: https://codereview.chromium.org/1100803004

Cr-Commit-Position: refs/heads/master@{#326860}

To fix PresentationServiceImplTest.DefaultSessionStartReset timeout
in  Android Tests (dbg).

TEST=git cl try + linux_android_dbg_ng
----

Added DefaultSessionStartContext for coordinating sending default
session back to PresentationDispatcher.

When ListenForDefaultSessionStart is called, DefaultSessionStartContext
will be installed on PresentationServiceImpl. When both the default
session and PresentationDispatcher's callback are available, the
callback will be invoked with the session.

On Reset(), if a callback is available, it will be invoked with null.
Changed PresentationDispatcher to not update Blink in that case.

Also, PSImpl now keeps track of the corresponding RFH's ID instead of
RFH* since most of the time we only need to use the ID.

Changed PresentationServiceDelegate's Add/RemoveObserver interface,
since the PresentationServiceDelegate need to be able to correlate
an Observer with a RFH. (at most 1 per RFH, as it stands today).

Added OnDefaultPresentationStarted to
PresentationServiceDelegate::Observer interface and implemented it
in PresentationServiceImpl.

Added tests in PresentationServiceImpl.

BUG=459001

Review URL: https://codereview.chromium.org/1055053004

Cr-Commit-Position: refs/heads/master@{#326859}

WebRTC 9068:9084
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/51fb6e4..324d972

Libjingle 9069:9081
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/c37efc9..d8bca77

TBR=
BUG=

Review URL: https://codereview.chromium.org/1051353006

Cr-Commit-Position: refs/heads/master@{#326858}

BUG=478428
TEST=Hover mouse over Back and Close buttons in new GAIA login (for Add person,
Create new account, etc).  Cursor should change to pointer hand.

Review URL: https://codereview.chromium.org/1097053008

Cr-Commit-Position: refs/heads/master@{#326857}

Most importantly, this passes cflags_cc to the C++ compiler.

This fixes some flag differences with the GYP build, especially when running on 64 bit.

It disables a TLS test on static debug x64 builds which also fails in GYP. This configuration is not run on the bots but is the standard GN Windows build.

BUG=251251
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1062743005

Cr-Commit-Position: refs/heads/master@{#326856}

This adds a new top level trace span for work resulting from I/O
notifications. Currently I/O triggered work may not show up at all in
tracing (unlike work resulting from PostTask).

BUG=none
TEST=chrome://tracing on Chromebook Pixel. Input thread shows I/O spans
  rather than showing nothing.

Review URL: https://codereview.chromium.org/1097283004

Cr-Commit-Position: refs/heads/master@{#326855}

This patch includes the changes that enables
<webview>.addContentScript/removeContentScript API  work on WebUI.

-- Introduce WebUIURLFetcherGroup to manage a set of
WebUIURLFetcher and response after all fetches are
done.
-- Move WebUIURLFetcher from web_view_internal_api.cc to a
separate file.
-- A refactoring is done in UserScriptLoader and
ExtensionUserScriptLoader. Since webUI has different ways
to load user script as extension does, so I revert some old
refactoring in ExtensionUserScriptLoader and move all the
loading related code from UserScriptLoader to
ExtensionUserScriptLoader.

This is the second patch in a series of patches:
1) Implement <webview>.addContentScript/removeContentScript API [1] (https://codereview.chromium.org/959413003)
2) Implement <webview>.addContentScript/removeContentScript API [2] (https://codereview.chromium.org/1056533002)
3) Implement <webview>.addContentScript/removeContentScript API [3] (https://codereview.chromium.org/1058113002)

BUG=461052

Review URL: https://codereview.chromium.org/1056533002

Cr-Commit-Position: refs/heads/master@{#326854}

This CL provides a cleaner way to report session state changes with the following:
1. Removes onError() callback on ClientSession Handler.  Instead, if an error
   is encountered before the session connects, onConnectionFailed() will be called,
   and similarly, onDisconnected() will be called for errors encountered after
   a session is connected.
2. Removes the sessionStateChanged event on clientSession, so session state
   are reported consistently through the ClientSession.EventHandler interface.

BUG=477522

Review URL: https://codereview.chromium.org/1093373005

Cr-Commit-Position: refs/heads/master@{#326853}

The tests weren't actually destroying the adapter when they claimed.
As a result, the final read/rewind call could happen on the "network"
thread between starting the destroy task in Shutdown and actually
tearing down the network thread, at which point the
TestUploadDataStreamHandler network thread pointer is NULL, resulting in
a crash.

The fix is just to destroy the adapters when they should be, at which
point there should be no messages pending on the network thread.  May be
worth revising how thread checks are done if more tests are added.

BUG=480623

Review URL: https://codereview.chromium.org/1098253005

Cr-Commit-Position: refs/heads/master@{#326852}

As discussed in https://codereview.chromium.org/1070433002/, this CL
allows arbitrary scale factors, which works because chromium uses the
resource most closely matching the scale factor (e.g. 1x for 1.25x,
but 2x for 1.9x) and scales it.

BUG=143619

Review URL: https://codereview.chromium.org/1078423002

Cr-Commit-Position: refs/heads/master@{#326851}

nacl_io::Path::Part returns a temporary string. The code that hashes the path
to create a phony ino calls this, and stashes a pointer to the memory.

The real issue with nacl_io_demo is that the quota was too low. I've upped it
to 5 megs now.

BUG=478230
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/1062463004

Cr-Commit-Position: refs/heads/master@{#326850}

BUG=480919

Review URL: https://codereview.chromium.org/1102063002

Cr-Commit-Position: refs/heads/master@{#326849}

BUG=451073

Review URL: https://codereview.chromium.org/929353002

Cr-Commit-Position: refs/heads/master@{#326848}

And renames one to better indicate what it is expected to do.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1052103005

Cr-Commit-Position: refs/heads/master@{#326847}

This CL only implements non-ChromeOS features; AboutSigninInterals and the AccountReconcilor. ChromeOS features will come later, as they require more support. This CL also removes the ReconcilorSource as a parameter to ListAccounts. Changes the observed cookie from the LSID cookie to the APISID cookie at nickk@'s suggestion.

Design doc: https://docs.google.com/document/d/1FfmSS7M87L_2tkVuHO3NuruborFm6qHXe2VdktZg-HQ/

BUG=466799, 463611, 471210

Review URL: https://codereview.chromium.org/1075273002

Cr-Commit-Position: refs/heads/master@{#326846}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

NOTRY=true
BUG=417463

Review URL: https://codereview.chromium.org/1101013002

Cr-Commit-Position: refs/heads/master@{#326845}

Also add the first parts of the Search settings UI in MD-settings, namely the 'default search engine' dropdown. Follow-up CLs will fill in the remaining functionality.

(Disabling presubmit because it requires a manual confirmation that permission_message.h looks ok. I confirmed this.)

BUG=479359
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1096143003

Cr-Commit-Position: refs/heads/master@{#326844}

These were removed in https://codereview.chromium.org/969973002
Please see that CL for why.

Review URL: https://codereview.chromium.org/1059803003

Cr-Commit-Position: refs/heads/master@{#326843}

Changes Client destructor to be override instead of virtual to conform with chromium-style.

BUG=417463

Review URL: https://codereview.chromium.org/1108613002

Cr-Commit-Position: refs/heads/master@{#326842}