- 08 Mar, 2018 40 commits
-
-
Sammie Quon authored
Notify click wont work because it fires after the release event. We need to observe both press and release events to mimic keyboard press and release. Test: none Bug: none Change-Id: I314aed2dcc870c8579a48c8abed45b0065737819 Reviewed-on: https://chromium-review.googlesource.com/954048Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541723}
-
Yury Khmel authored
We need to distinguish logout and restart in app push install logger. Currently there is no easy way to get this information. At this moment only BootTimesRecorder is explicitly notified. This CL makes this information public and let log collector use it. Bug: b/73277923 Test: Manual + unit test Change-Id: I64eea3b748e4ad089365fe3453e9c5fc0e6c3162 Reviewed-on: https://chromium-review.googlesource.com/949826Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#541722}
-
https://chromium.googlesource.com/angle/angle.git/+log/40dba69082bd..ed8b49195844 $ git log 40dba6908..ed8b49195 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 jmadill Vulkan: Fix missing depth/stencil access flags. 2018-03-02 jmadill Add RenderTargetCache helper. 2018-03-07 ynovikov Revert "Add NPOT validation to copyTextureCHROMIUM" 2018-03-06 tobine Roll (2/2) to latest LVL as of 3/6/18 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ia569df5da9d8c64bf0ae27133237b8586e9e789e Reviewed-on: https://chromium-review.googlesource.com/954051Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541721}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I310daa91088a4eacbf0a56ea19d512f3c76fc105 Reviewed-on: https://chromium-review.googlesource.com/954782Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#541720}
-
Yutaka Hirano authored
We've attached the header to requests initiated by sendBeacon() but it is not spec conformant. Let's stop doing that. Bug: 755725 Change-Id: Ia8b85a27b84c77b35edc211c325490467c853330 Reviewed-on: https://chromium-review.googlesource.com/952104Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#541719}
-
https://skia.googlesource.com/skia.git/+log/88df8d2e5a87..df04ce29490a $ git log 88df8d2e5..df04ce294 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 csmartdalton ccpr: Draw curves in a single pass 2018-03-07 fmalita [skottie] Reduce parser verbosity 2018-03-07 reed add TrimPathEffect 2018-03-07 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ da8c41528..e5ac7a7c8 (2 commits) 2018-03-07 fmalita [sksg] Cache transformed TrimEffect geometry 2018-03-07 bsalomon Make ProxyUtils::MakeTextureProxyFromData use wrapped textures when origin is kBottomLeft Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ic90bcf59454676f4c2eab16fb6da1db3d256b13f Reviewed-on: https://chromium-review.googlesource.com/954047Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541718}
-
Toni Barzic authored
Adds DetachableBaseNotificationController that observes DetachableBaseHandler in order to detect when a detachable base different than the last base used by the active user changes. When a detachable base change is detected, it shows a system notification. The notification serves a security purpose - it warns the user that the detachable base they are using has changed, and that the base could be compromised (to steal their keystrokes). Note that the notification is shown only if the session is unblocked at the time - lock screen and login screen will implement their own UI to notify the user about the base change. If/when the session is unblocked, the attached base is set as the last one used by the user to prevent the notification from showing up next time the user attaches the same base. Bug: 796300 Change-Id: I7ff8fdf3e02e5833df2a709169fdd076285f3a4b Reviewed-on: https://chromium-review.googlesource.com/952477Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#541717}
-
Chris Nardi authored
Tests that were duplicates of those already existing in web-platform-tests were deleted. Other tests were either moved to the CSSOM directory in WPT, or appended to already existing tests. The README was also deleted, as it is no longer accurate. Change-Id: I0acb41c6102a572a1fc2401630732a8ff1c5263d Reviewed-on: https://chromium-review.googlesource.com/945135Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541716}
-
Kurt Horimoto authored
This CL exposes the previous named layout guide API via a UILayoutGuide subclass called NamedGuide. In addition, this CL adds the ability to reset the view to which the named guide is being constrained, as this will be necessary for voice search, as it can be launched by a variety of buttons. Bug: 805120 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I054c3072cf59ce8ec84eb9002aa228c3a70b2167 Reviewed-on: https://chromium-review.googlesource.com/941407 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541715}
-
Erik Luo authored
The console prompt currently listens for ArrowUp/ArrowDown and loads the next/previous command from history, if the cursor is on the first/last line. Since a logical CodeMirror line may wrap onto multiple visual rows, this may unintentionally load the next command. This CL adds a check whether the cursor is truly on the first/last visual row. Problem gif: https://imgur.com/a/s7gPL Bug: 808130 Change-Id: I04363e25206cece28b32b80dfc548340413112cf Reviewed-on: https://chromium-review.googlesource.com/927690 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#541714}
-
Esmael El-Moslimany authored
Bug: 819317 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iee782ed92e4f3b5ec21239718b75f2d8f1a4188d Reviewed-on: https://chromium-review.googlesource.com/953123Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#541713}
-
Benjamin Pastene authored
TBR=jbudorick@chromium.org Bug: 817779 Change-Id: I99e51513bc6279ba98409952f20b0dec66a62cd4 Reviewed-on: https://chromium-review.googlesource.com/954607Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#541712}
-
Giovanni Ortuño Urquidi authored
After this patch, Desktop PWAs should no longer capture links without users enable the kDesktopPWAsLinkCapturing flag. Final patch to disable link capturing by default: [1] Specify that throttle and tests are for experimental feature (https://crrev.com/ba5d9af) [2] Extract tests that should run when link capturing is off (https://crrev.com/e3aa04a) [3] Handle out-of-scope navigations and stop link capturing by default (https://crrev.com/c/942597) [4] Disable link capturing by default (This patch) Bug: 814102 Change-Id: I0d03c93c2594c3da7d5139496502244e299c8e84 Reviewed-on: https://chromium-review.googlesource.com/950484Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541711}
-
Kenneth Russell authored
These exist only to be mirrored into the optional tryservers, but their existence breaks on LUCI, where the triggers were silently ignored on Buildbot. The same will have to be done for the other optional Windows and Android trybots. Also, let the GPU FYI service account trigger jobs. TBR=nodir@chromium.org Bug: 815092, 819899 Change-Id: I263dcfc4e95b99aac5dee9466c341f1c552b145d Reviewed-on: https://chromium-review.googlesource.com/954587Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541710}
-
https://pdfium.googlesource.com/pdfium.git/+log/749b609d11e8..04d792fb7510 $ git log 749b609d1..04d792fb7 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 dsinclair [formcalc] Consider width along with depth of tree Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I950aa2cc06b39f07b958f6d727b641c9411e2815 Reviewed-on: https://chromium-review.googlesource.com/953261Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541709}
-
Sasha Morrissey authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4b0931917ec864739843a72d7de2dd430362db93 Reviewed-on: https://chromium-review.googlesource.com/952803Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#541708}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c29602466dc2..53014653d8eb $ git log c29602466..53014653d --date=short --no-merges --format='%ad %ae %s' 2018-03-07 ehmaldonado gclient: Give priority to URL over paths when specifying revisions. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic2f3f206a74848933a49ec124de4f28ab862f560 Reviewed-on: https://chromium-review.googlesource.com/953974 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541707}
-
Megumi Hattori authored
MessageCenterScrollView need not be focused. This CL also fixes a bug, tab focus missing on the UI. BUG=807534 TEST=manual Change-Id: I5427e84c49c2bbfbfa90944c334ffa5aa805d8d9 Reviewed-on: https://chromium-review.googlesource.com/946068Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#541706}
-
Tommy C. Li authored
Per pkasting@ sugestion, DeleteAtEnd is dead code and can be deleted. TBR=jdonnelly@chromium.org Bug: NONE Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie1149a3f7b2aecd88252eeda7ff366e9504249da Reviewed-on: https://chromium-review.googlesource.com/954222 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541705}
-
Ken Rockot authored
This test is timing out on Windows debug, where even on very fast devices it can take 35+ seconds to run. The runtime grows linearly with the size of the test message used, so this cuts that size to one tenth (512 kB instead of 5 MB). TBR=jcivelli@chromium.org Bug: 819046 Change-Id: Ib4598981856566dc8ae54de1060840b52e30b959 Reviewed-on: https://chromium-review.googlesource.com/954045Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#541704}
-
tzik authored
This updates //chrome/browser/extensions/activity_log to use base::OnceCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //chrome/browser/extensions/activity_log from 69 to 0 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I4fe44c7fada907f3a1c70971067c29f0d5492e8f Reviewed-on: https://chromium-review.googlesource.com/952953 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541703}
-
Shuotao Gao authored
TBR=penghuang@chromium.org Bug: 819778 Change-Id: I23e847c1bd5b1b3ffffb1679fd91bb67d36ec16d Reviewed-on: https://chromium-review.googlesource.com/954017Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#541702}
-
Xing Liu authored
Currently we do a disk IO and network IO with large chunk of memory in ParallelDownloadTest, which cause stack underflow issues on certain platform. This CL fixed the disk IO by writing to file with 64KB buffer. The tests will be enabled after the network IO part is fixed. Bug: 817801 Change-Id: I49431cf0b66dc76ed893217126f189bb44f2e839 Reviewed-on: https://chromium-review.googlesource.com/952763Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#541701}
-
Kenneth Russell authored
BUG=chromium:811811 BUG=chromium:811905 BUG=chromium:811815 BUG=chromium:811796 BUG=chromium:811831 BUG=chromium:811789 BUG=chromium:811809 BUG=chromium:811821 BUG=chromium:811869 BUG=chromium:811866 BUG=chromium:811781 BUG=chromium:811799 BUG=chromium:811814 BUG=chromium:811864 BUG=chromium:811835 BUG=chromium:811834 TBR=estaab@chromium.org Change-Id: I8ddae02f706affb0198d12835baa421b74e8e462 Reviewed-on: https://chromium-review.googlesource.com/954416 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#541700}
-
Sorin Jianu authored
Bug: 819803 Change-Id: Ie40504523f779c3fcb1063f68445222aef837126 Reviewed-on: https://chromium-review.googlesource.com/953593 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#541699}
-
Emircan Uysaler authored
This test creates a WebRTC peer connection between two tabs and measures the trace events added on the tab receiving remote video. It does connection with different codecs to create the different scenarios of HW decode(texture) and SW decode(memory). Based on these events, it provides stats about the lifetime of a video frame that is played in a MediaStream backed <video> tag. The plan is to run this test on WebRTC Chromium bots and make it available for other projects that are very sensitive about display latency. Bug: 818352 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I023bea19c9e2271d153f1062d0ec73624c96148b Reviewed-on: https://chromium-review.googlesource.com/947418Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541698}
-
tzik authored
This updates //rlz to use base::OnceCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //rlz from 3 to 0, as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I4a016a47acfae635ff4ed0c3b2f22c0ca62b8f5c Reviewed-on: https://chromium-review.googlesource.com/952729Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#541697}
-
Michael Spang authored
Make each buffer management object responsible for holding a ClientNativePixmapFactory, removing the need for a global one. This simplifies a number of initialization and ownership scenarios. This makes it impossible for MUS to race to initialize the object, since each object that needs it will have its own (sharing the factory globally is not actually necessary). To make this work, this moves GpuMemoryBufferImpl factory to a new object GpuMemoryBufferSupport, since the majority of objects which should own a ClientNativePixmapFactory used it via GpuMemoryBufferImpl::Create(). Bug: 807781 Test: browser_tests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icde20b247905555e80767b8c3eb77af6be9bbce1 Reviewed-on: https://chromium-review.googlesource.com/899949 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#541696}
-
Dmitry Gozman authored
This will make it easier to support multiple models in PerformanceMonitor. Bug: none Change-Id: I7ea678fba1e4f634cd26ef05638cac2a8ec3414b Reviewed-on: https://chromium-review.googlesource.com/953713Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541695}
-
Pavel Feldman authored
Change-Id: I00e8c2f3a14e6adec6a85ccff2d68adcf41f1d6a Reviewed-on: https://chromium-review.googlesource.com/953964Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541694}
-
Adam Langley authored
These are probably no longer useful. BUG=782084,771030,753209,722663,673605,673603,619807 Change-Id: Ic302e42508386ea7a4a01d937509a6ab29711ed1 Reviewed-on: https://chromium-review.googlesource.com/953482Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541693}
-
Giovanni Ortuño Urquidi authored
Introduces BookmarkAppNavigationThrottle to handle out-of-scope navigations in app windows and puts BookmarkAppExperimentalNavigationThrottle behind kDesktopPWAsLinkCapturing. Changes kDesktopPWAsLinkCapturing to be on by default, so there should be no change in behavior for users. A follow up patch will change kDesktopPWAsLinkCapturing to be off by default. BookmarkAppNavigationThrottle and BookmarkAppExperimentalNavigationThrottle share some functionality that has been extracted into bookmark_app_navigation_throttle_utils.h [1] Specify that throttle and tests are for experimental feature (https://crrev.com/c/940824) [2] Extract tests that should run when link capturing is off (https://crrev.com/c/939883) [3] Handle out-of-scope navigations and stop link capturing by default (this patch) [4] Disable link capturing by default (https://crrev.com/c/950484) Bug: 814102 Change-Id: I7d394899d85922fce9e51831bf8705e31d8a53bf Reviewed-on: https://chromium-review.googlesource.com/942597Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541692}
-
Nico Weber authored
Standard C++ doesn't allow implicit conversion between function pointers and void*. MSVC does allow that, so clang-cl also allows it but emits a -Wmicrosoft-cast warning. We want to enable this warning to make the compiler behave more similar on different platforms, so add an explicit cast to void*. Bug: 550065 Change-Id: Ib370ef07bf5f2df00814aa063833486e30ecde6f Reviewed-on: https://chromium-review.googlesource.com/954202Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541691}
-
Sammie Quon authored
Animations into overview has changed so that non visible windows do not need to animation. Previous rounded edges code relied on animation end to apply mask, this cl applies mask to all cases, and removes before animations, and reapplies after animation. Test: ash_unittests WindowSelectorTest.RoundedEdgeMaskVisibility Bug: 817860 Change-Id: I9da0e2a56e991a7c3073a4c2c0de79d8e3799915 Reviewed-on: https://chromium-review.googlesource.com/953135Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541690}
-
wutao authored
WindowGrid::PositionWindows is called at multiple places to animate windows in overview mode. Reset the should_animate_when_entering_ flag in order to animate in other situations. Bug: 817888 Test: WindowSelectorTest.WindowItemCanAnimateOnDragRelease Change-Id: I14a773033982c47823e6a0e331b7b8df4baa1791 Reviewed-on: https://chromium-review.googlesource.com/952671 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541689}
-
Becky Zhou authored
+ Using material icon for expand/collapse + Remove 10dp top padding from header view Bug: 818368 Change-Id: I7d9318e1a8c9b1edcf7b51aa9e4804eb82f38ea9 Reviewed-on: https://chromium-review.googlesource.com/952542Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541688}
-
Sunny Sachanandani authored
This broke because the direct composition path doesn't use swap interval set by eglSwapInterval in ANGLE. Since we only care about disabling via command line, it's ok to just handle that instead of SetSwapInterval. This will still not work when we use a direct composition surface instead of swap chain but that only happens when we use overlays. There may be no way to make this case work since the swap chain is not controlled by Chrome. Tested with vsynctester.com on my home desktop. R=kbr,piman BUG=480361,787485 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ife5804b4e9bcede41bb29cd01e54e81f0d278b62 Reviewed-on: https://chromium-review.googlesource.com/954020Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#541687}
-
Jeffrey Kardatzke authored
This is for automated testing. During testing, we need to automatically click on approval in the permissions dialog. This allows Android to have a mechanism by which it calls into Chrome and requests that it accepts the permission. This is ONLY allowed when the build is of type 'testimage'. This then allows the automatic test to proceed. It also disables showing the notification that screen capture is activate since during Android testing that is also not expected to be part of the screen. Bug: b:38452042, b:73045468 Test: CTS tests pass now Change-Id: I87d46b1d4859e3fe6b1b034e6a020ceafc9b7357 Reviewed-on: https://chromium-review.googlesource.com/909299 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541686}
-
Han Leon authored
As opposed to WebKit/public/mojom:mojom_platform, the gn target WebKit/public/mojom:mojom includes mojom interfaces which do use types that are typemapped to a type in Source/core, and its C++ bindings for Blink variant is embedded inside blink_core component. So, to avoid any confusion, this CL renames it to WebKit/public/mojom:mojom_core to announce explicitly the close relationship with Source/core. BUG= Change-Id: I3a9e68e8f7da5bf0c085d11e9a8cbd273247c638 Reviewed-on: https://chromium-review.googlesource.com/952113Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#541685}
-
David Tseng authored
Rich editables should be skipped entirely (and not fall through to output). Original change: - value change events often fire on richly editable text fields. We do not really use this in the state machine for rich text, so ignore it. It often causes poor state transitions e.g. speaking "deleted" in crosh when typing. - use the AutomationRichEditableText class in more cases. This acknowledges the usage in the wild where a page author can set role textbox on any node. When they do this it is assumed they manage a DOM selection unless they set the role on either an input or textarea where the browser does this on their behalf. TBR=dmazzoni@chromium.org, dtseng@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If555f157a7eeafe836929e9433891b2e7ae181df Reviewed-on: https://chromium-review.googlesource.com/953980 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541684}
-