- 10 Mar, 2020 40 commits
-
-
Takumi Fujimoto authored
Record the results of CreateRoute(), JoinRoute(), and TerminateRoute() calls to the native Cast and DIAL MRPs in new histograms separate from the one for the extension MRPs. Bug: 1044259 Change-Id: Id4dd5faa26601523f43053b8ebb140f26b93d2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078976 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#748892}
-
Mikel Astiz authored
This removes BookmarkPermanentNode::set_visible(), which was misnamed in the sense that it didn't directly determine what BookmarkNode::IsVisible() returns, but instead the returned value for the case where the node has no children. As it turns out, none of the callers need to change this attribute (i.e. the visibility when empty) dynamically. For the managed node, it needs to always be false, and the remaining permanent nodes take this value from BookmarkClient upon construction. BookmarkClient gets a minor refactoring to adopt more accurate names and to allow evaluating the visibility of permanent nodes prior to their construction. Change-Id: I4435140e80216800ce1dcee5604e8370bcc2cedc Bug: 1060311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095125 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748891}
-
Gary Kacmarcik authored
The Mac doesn't always support full desktop capture (e.g., it is not support unless the DPIs of all displays match). This check is not necessary on other platforms. Change-Id: I444732f153b706bb1615b8c3cd1798b15cc66540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096095 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#748890}
-
Thomas Lukaszewicz authored
Pushed color calculation logic in GetTabBackgroundColor() down into ThemeHelper. Bug: 1056916 Change-Id: I6c6b5a204554b825887b1c306b766e4403609279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092199 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#748889}
-
Tom Anderson authored
This removes the dependency of //c/b/u/gtk on //c/b/u. This will allow us to move //c/b/u/gtk out of //c/b to a better home like //ui/gtk once the //content dependency is removed in a separate CL. This also removes some select file dialog tests which had all of their tests disabled and never added any value. R=sky BUG=None Change-Id: I38403a967593c76ea55c14315a63a8190e5cae33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093015Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#748888}
-
Allen Bauer authored
TBR=jamescook@chromium.og Bug: 1044687 Change-Id: Ib31fbf481e215eb6eb7a7af43369a343e322faf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095566 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#748887}
-
Kai Ninomiya authored
This is a reland of 2eb368c0 Changed to not allow long paths for the root of the tree being rmtree'd, so it works on Windows 7. Original change's description: > Implement FileSystem.rmtree for long paths on Windows > > Changes blinkpy filesystem tests to use remove_contents instead of > rmtree. remove_contents calls into rmtree, but > (1) retries several times to delete the files, and > (2) throws by default instead of silently swallowing errors. > This improves all of the tests. Additionally, the retrying was > actually necessary to pass many tests (files were otherwise still > locked during teardown). > > Extends the test_long_paths test to check spaces and apostrophes. > > FileSystem.rmtree is now implemented on Windows by just calling > a shell with "rmdir /s /q". This is necessary, because > shutil.rmtree doesn't work for \\?\C:\ style "extended-length" paths > on Windows, and several other implementations I tried didn't work: > - Loop using os.walk. os.walk doesn't support long paths, and > though it seemed to work on the bots, it failed tests locally. > - Recursive using os.listdir. os.listdir also doesn't support long > paths. > > Tested on dawn-win10-* try job on crrev.com/c/2050036/17. > Found in dawn-win10-* try jobs on crrev.com/c/2050036/4. > > Change-Id: I7c67bb12305a41244829e35293edfc88901b76f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058065 > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742961} Bug: 1054331 Change-Id: Ib1f7a7ac0109fb77e1d26f1bdb292ad2c95cea24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092946 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#748886}
-
Nate Fischer authored
Previously all WebView providers on the device would use the same (global) taskAffinity for developer UI. This means launching Dev UI from one channel would obliterate the previous Dev UI session, re-using the original channel's icon for the task (which may no longer be correct). The simplest solution to ensure we always have the right icon is to let different channels launch in different tasks. We achieve this by using the package name as part of the taskAffinity. This uses a "." instead of a ":" delimiter because ":" is apparently an illegal character for taskAffinity (can't compile). Fixed: 1060013 Test: Manual - build 2 local builds and verify I can launch each Test: side-by-side Change-Id: If8b1def9a4d8af9187a117f39816dcce2c77913b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095930Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748885}
-
Rushan Suleymanov authored
Currently if sync is turned off (but keeps metadata) the sharing message bridge will invoke a callback but continue sending messages after sync is turned on. In this patch the bridge stops tracking of entities when sync is turned off in all cases. Bug: 1060169 Change-Id: Id5ba8305b3e492cd99d2f4929911ac521972f98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095104 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#748884}
-
Thomas Lukaszewicz authored
Simplified GetFrameColor() logic to a single GetColor() call to the browser frame's ThemeProvider. GetFrameThemeProvider() will return the app's ThemeProvider if the AppBrowserController is present. The AppBrowserController's ThemeProvider will query the AppBrowserController's ThemeSupplier first as part of its GetColor() method before falling back to the default. The effect of this is that the desired GetColor() functionality can be simplified down to the single call. Bug: 1056916 Change-Id: I44cfc977c4fb651732a02f5badc688c621889da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091940 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#748883}
-
Ben Pastene authored
Looks like I missed one in crrev.com/c/2083919. Bug: 812428 Change-Id: Ic82e09beb4c60799ab6381854849d3cc6d196339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095609 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748882}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/84a1b3e9ba0d..dd14a955967b git log 84a1b3e9ba0d..dd14a955967b --date=short --first-parent --format='%ad %ae %s' 2020-03-10 minyue@webrtc.org Allow TimestampAligner to translate timestamp without new observation of system clock. 2020-03-10 mbonadei@webrtc.org Revert "Fix for out-of-bounds write in square test frame generator." 2020-03-10 brandtr@webrtc.org Add MID/RID configurability to RTPSender. Created with: gclient setdep -r src/third_party/webrtc@dd14a955967b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1054403 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib4b3b5d99631d62efec3d8229b97de03fdc52dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095728Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748881}
-
Side Yilmaz authored
when called incognito. This CL update the profile passing to TrackerFactory from ToolbarButtonInProductHelpController. Currently, it is always regular profile, however it is not safe because of possible data leakage from incognito to regular profile. Therefore, this CL uses the profile (i.e., regular or off-the-record profile) belong to active tab in ToolbarButtonInProductHelpController, then passes it to TrackerFactory. Bug: 1041781 Change-Id: Ia140d6a63b63325515af9164c2cc89b7fe559ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078477Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748880}
-
Liquan (Max) Gu authored
Before Change: * AndroidPaymentApp owns mPayIntent, mIsReadyToPayIntent. * AndroidPaymentApp is responsible for creating the Intent. After Change: * The two intents become temporary variables. * WebPaymentIntentHelper is responsible for creating the Intent. Bug: 1057488 Change-Id: I9510c9bf50b697c3809c31445cea5ff99805e45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096109 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748879}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c0bae98fece..aee432d7489e Created with: gclient setdep -r src-internal@aee432d7489e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059105,chromium:1059996,chromium:988512 Tbr: jbudorick@google.com Change-Id: Ib5beff1f9603f62a96e889c45fc9f2e28bc75911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096930Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748878}
-
Kyle Milka authored
This test is flaky on Linux bots TBR=waffles@chromium.org, crouleau@chromium.org Bug: 1060068 Change-Id: I715072f596a0a7d6ed2cbf3b20b608ba0a2743f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095614Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#748877}
-
Mugdha Lakhani authored
to url_bar to match the naming of files within. Bug: 1025607 Change-Id: I4d627e53b0117e0953dded2b2a4789909bfc4880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096564 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#748876}
-
David Tseng authored
Bug: 1057904 Test: browser_tests --gtest_filter=ChromeVox*.* Change-Id: I0f858a0a0d3fc2a34177446cb702212b6ededa84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095915 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#748875}
-
Martin Kreichgauer authored
A FidoRequestHandler currently reports a FidoTransportProtocol to its Observer (i.e. the UI layer) as available, even if the FidoDiscovery for that transport invoked DiscoveryStated() with success=false. It seems logical in this case to act as if the discovery never had been instantiated in the first place. Change-Id: I50c2832f3b5bc321f2b9454e90770204c229b311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087955 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#748874}
-
Owen Min authored
Few DCHECK in comments are misspelled as DHCECK. Fix these typos. Change-Id: Ic9e6da8ef5b1c7ac20425d0597a3e8a347dc9311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096979Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748873}
-
Yoav Weiss authored
Bug: 1060079 Change-Id: If115a07824df9de2ab5af91e91ca9e91bf8c4f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095590Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#748872}
-
Kenneth Russell authored
conformance/extensions/oes-texture-half-float-with-video.html is flaky on Win10 x64 Debug NVIDIA and needs the "debug-x64" tag. Bug: 1045339 Change-Id: I0f6068b11851fed28dfb185c52312c8ae0104c83 Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096883Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748871}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4599cc694fd8..7cdf69dbbf43 git log 4599cc694fd8..7cdf69dbbf43 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 szuend@chromium.org [utilities] Remove call-site of Array#remove from CSSModel 2020-03-10 tvanderlippe@chromium.org Add custom ESLint rule to check ES import statements 2020-03-10 tvanderlippe@chromium.org Fix incorrect imports caught by ESLint rule 2020-03-10 tvanderlippe@chromium.org Add eslint-plugin-rulesdir to node_modules 2020-03-10 tvanderlippe@chromium.org Add testonly support for ts_library Created with: gclient setdep -r src/third_party/devtools-frontend/src@7cdf69dbbf43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1060003,chromium:1060123 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I125989ce042d820f71fb5071470e84739e19c584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097045Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748870}
-
John Budorick authored
Bug: 1034648 Change-Id: I622b68ad3d410b2eb4e528ef705acdc7b5b1d8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090730Reviewed-by:
Eric Foo <efoo@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#748869}
-
Mugdha Lakhani authored
If the navigation state of the active state changes such in a way that indicates the URL has changed, we should update the URL bar. Also adds a browser test to verify the expected behavior. Bug: 1025607 Change-Id: I58431ac15fbb04d516f4a2637d4717431346fb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094134 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#748868}
-
Bo Liu authored
Requested by internal client. Note the API is added in 82, so there is currently no backward compatibility requirements. Bug: 1035469 Change-Id: I471da6a83a2aa156aa8441e5d033478d8416840f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095877 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#748867}
-
mhasank authored
BUG=b/149874690 TEST=None Change-Id: I8390efa1df473a1c3a79726c01b75498aeaab989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087958 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#748866}
-
mark a. foltz authored
This API is unused since the launch of Cast Harmony. Bug: 1058528 Change-Id: I6ac2df2e21a5a3bdf68a4ae0bcc70ec907305763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088230Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748865}
-
Hailey Wang authored
Tab properties will be used for upcoming Performance Manager session restore policy. Bug: 1059341 Change-Id: I81214143b55d747cfbde02d6a6959f5c83c36323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091653Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#748864}
-
dpapad authored
flattenhtml is sub-optimal for a few reasons: 1) Makes the HTML code being evaluated larger than necessary. For example when both light and dark mode images are inlined, they increase the HTML code size, even though only one of the two is used at a given moment. 2) flattenhtml does not work with Polymer3 (polymer_modulizer). Instead, images are registered with the Settings data source, so that they can be served by dedicated URLs for example from chrome://settings/images/cookies_banner.svg Bug: 1026426 Change-Id: I0c77b3bad2f27e9c810833aa153faab884954775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095555 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#748863}
-
Ahmed Mehfooz authored
This will be enabled by a finch experiment to reduce timeouts to 6 seconds for a specific group of users. Bug: 1059017 Change-Id: Ie2a22c1b7f39856c57133df0992238419439f1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096901Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748862}
-
Yi Xu authored
In the previous CL, https://chromium-review.googlesource.com/c/chromium/src/+/2063733, I added mode change for Canvas, such that it discard the content of canvas from the previous frame if canvas needs a full repaint in the current frame. In this Cl, I added the mode change feature for OffScreenCanvas. Bug: 1054666 Change-Id: I2b685641c40f2a31b50e04ee739f3ef26423297c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088021 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748861}
-
Adrienne Walker authored
This is some more "pre cleanup" of code that the linter complains about when moving code into storage service. Doing this ahead of time to make the future gigantic move CL easier to reason about. Bug: 1015214 Change-Id: I7dcd977b7906710a7516412a11d83d64661d19fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093051 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#748860}
-
bttk authored
Bug: 1046181 Change-Id: Ide50b7bf6332e2c162a2aba1e255498ab986bf68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067721Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#748859}
-
S. Ganesh authored
This is how the code was earlier, but I changed it recently in CL 2071387 to do a Create instead, which is likely causing the side-effect of leaving a stale key out there. Bug: 1059314 Change-Id: I48f07e30621b61a7db2b60495c3b0b286323b0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095919 Commit-Queue: S. Ganesh <ganesh@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748858}
-
Jonathan Backer authored
We are field trialing SkiaRenderer on Windows and Android. We want to keep some smoke test coverage of GLRenderer during the field trial in case we need to stop the SkiaRenderer field trial and fallback to GLRenderer. Bots with updated test suites: testing/buildbot/chromium.android.json android-pie-arm64-rel testing/buildbot/chromium.win.json Win10 Tests x64 Bug: 1019787, 809722 Change-Id: I8ee553426539ed43d1a98cde74d4d458bc273fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083391 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748857}
-
Sorin Jianu authored
This change moves the initializing of the crash reporter sooner, before the command line modes are being handled. There is still some code that executes outside of the crash handler, such as command line parsing and logging initialization. Bug: 1060326 Change-Id: I2631d7ba1be18a33ca4984a127dd3b4f56f47003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096902Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748856}
-
Eric Lawrence authored
When the browser is in kiosk mode, the user is unlikely to be able to act upon or dismiss infobar notifications, so they should be suppressed when the browser is started in this mode. The only exception is the Automation info bar, still shown for anti-abuse reasons. Bug: 445256 Change-Id: Ie49572e5a548e70ce83cd4defafb76510fe384b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095714 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#748855}
-
Antonio Gomes authored
This is a follow up of [1], where the last actual override of this hook, does it no more: web_contents_view_mac.mm|h. [1] https://crrev.com/c/2092096 BUG=1051155 R=avi@chromium.org Change-Id: Ieeb5862e9c467343d5844c156a1be40e5a205103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093535Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#748854}
-
Kevin Ellis authored
The handling of iframe load events is finicky as indicated in the open WHATWG issue: https://github.com/whatwg/html/issues/490 This patch switches the wait mechanism to one that is well behaved across browsers. The new process arms the listener before inserting the iframe into the document. Bug: 1059963 Change-Id: I372d4fdae3b270699aedf2c5a4de4429e62f42a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096782Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#748853}
-