- 20 Jul, 2020 40 commits
-
-
Robert Ma authored
This roll fixes the flakiness introduced in https://crrev.com/c/2304298 where some test changes needed accompanied tools change (#24617). All expectations/baselines for fetch/api/abort/general.any.js were recreated in this roll. Commits in wpt tools/ rolled in this change: 0d31626e52 Part 16 - Update web-platform tests to support unrooted android devices using mozdevice 4.0.0, ? 0fe99651ed Python 3: Port three files in fetch/ (#24617) b448d547b6 Fix wpt rev-list failure-handling in epochs_update.sh (#24560) d301b89a96 [wptserve] Allow more headers in Python 3 (#24619) 370f9d815f [lint] Implement EarlyTestdriverVendor lint (#24608) 165779e785 [wptserve] Make Request.GET.get return a value (#24614) 00b7aebbbc Update psutil from 5.7.0 to 5.7.2 (#24605) b2a666d935 Update mozrunner from 7.8.0 to 8.0.0 (#24579) f10f2ba614 Add Servo dependency to docker. Bug: 1106861 Change-Id: If161ef2f6f88fbaa62e05bc28fe8abac1578d3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306249 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#790023}
-
Xi Han authored
Disable ServicificationBackgroundServiceTest#testHistogramsPersistedWithServiceManagerOnlyStart. Bug: 1096833 Change-Id: Ibe6092357b4081061f094fcaa82c4822397ffd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297312Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790022}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08c4d09493bf..55e855496d00 2020-07-20 jmadill@chromium.org Lift warning from trace tests. 2020-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 412b1b7dd18c to b1346703979e (3 revisions) 2020-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 858b13a1220a to 83825d55c7d5 (1 revision) 2020-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0a8f44c514ce to ea6f21a052c9 (9 revisions) 2020-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from d093d9723b7c to 50e737c82347 (1 revision) 2020-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 680c77fa6c81 to 717e7877cac1 (6 revisions) 2020-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f3cb1896971f to 9eef54b2513c (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I2661ca1a5b7f53ed10bdc88ce842c8c34b9459c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790021}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9d3a5ac24e4d6961aad7a66deabf798202b4a8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790020}
-
Omid Tourzan authored
Bug: 953308 Change-Id: Id81ab64bb319cc6be2e9aae2dbdb6bf1a04550c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306491 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#790019}
-
Becca Hughes authored
This is a reland of 9b0c684e Original change's description: > Reland "Reland "Turn on Media History by default"" > > This is a reland of c670ba45 > > Original change's description: > > Reland "Turn on Media History by default" > > > > This is a reland of ccf0e2f9 > > > > Fixes TSAN issue in the constructor of sql::Database > > by moving it to the main thread. > > > > Original change's description: > > > Turn on Media History by default > > > > > > BUG=1024351 > > > > > > Change-Id: Id01595e63f5f776a226087741ef602ba30b80328 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295224 > > > Auto-Submit: Becca Hughes <beccahughes@chromium.org> > > > Commit-Queue: Tommy Steimel <steimel@chromium.org> > > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#787954} > > > > Bug: 1024351 > > Change-Id: I19be665637f5c28261f7197547ddc5fe6671127e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296884 > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#788312} > > Bug: 1024351 > Change-Id: Ie371d56df987c19a10017050ead02922a530f2ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300224 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788721} Bug: 1024351 Change-Id: I91cc6ee379d46ab5ef0b30436aeda90695629f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307485Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790018}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Id90e9d0efa854f4bcf9bf723ba1c6a5c067d0c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293007Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#790017}
-
Raymond Toy authored
NEON version of the SSE2 optimizations for the a-rate OscillatorNode. We see about a 23% increase in performance with these changes according to Spotify's Web Audio Bench on a Pixel 2. Without CL TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Oscillator.frequency-linear-a-rate 5640 5640 5923 6170 6780 7800 6354.266667 511.6527827 With CL TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Oscillator.frequency-linear-a-rate 4355 4355 4588 4732 5258 6408 4929.9 474.3852906 Manually ran the oscillator tests on a Pixel 2 and update the thresholds. Bug: 1013118 Change-Id: I37fbb995ec6bef55ae5195f579356b97adb94347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293424 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#790016}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39d317835bd0..8b4eeffd4628 2020-07-20 dmcardle@chromium.org git-cl: Fix "git cl tree" issues with Python 3. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie8290d5733778d3809fe90624c2ed7c29e35600b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790015}
-
David Tseng authored
R=akihiroota@chromium.org Fixed: 1107449 AX-Relnotes: ChromeVox does not automatically turn off sticky mode when moving by form fields (pressing f/shift f). Change-Id: I5535c7bfa03ec11bb68b6650f7caebac3da8006a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307469 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#790014}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/16fbc2477205..0dee9b0c410f 2020-07-20 johnstiles@google.com Use input FPs as the base layer for processor tests. 2020-07-20 robertphillips@google.com Revert "Reland "ICU API: only in SkParagraph, simplified (relanding reverted)."" 2020-07-20 jvanverth@google.com Create shared method for creating D3D MSAA textures. 2020-07-20 brianosman@google.com SkRuntimeEffect: Always include GrTypesPriv, clean up variable type code 2020-07-20 mtklein@google.com don't divide by zero when colorCount=1 2020-07-20 johnstiles@google.com Factor out random fragment-processor generation into a helper class. 2020-07-20 adlai@google.com Revert "Remove more GrContext imports & usage" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I32c9a9e2544d5600fbea8a87290a8f367b4b2201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790013}
-
Sammie Quon authored
Think it has something to do with subpixel rendering, and/or the damage on the bookmark bar is incorrect. It seems like a harmless and logical enough fix I did not investigate further. This can happen to any transformed browser window for instance the drag from shelf feature. I didn't fix that one because its harder to notice during a drag, and rounding during a drag can cause other visuals that are less desirable. Test: manual Change-Id: Icc680063c3aed19e7811c918b622fb0da5a20d57 Fixed: 1035223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307615 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#790012}
-
Paul Moy authored
Add a new Mojo method to cros_healthd's probe interface for retrieving information about a particular process. Plumb this new method through the ServiceConnection object, and add support to the fake for testing. Bug: chromium:1102518 Change-Id: I73d6377565c0b5f45fe9b85f585093cc972f80b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305549Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#790011}
-
Wez authored
Failure to load the DataPack, if a pak path is specified, should be surfaced more visibly. Bug: 1078365 Change-Id: I63b331b3bc58cd51843df6c8be5f16efb0647c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1018165Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#790010}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c3a81f99020d..a7bd9cbfeffa 2020-07-20 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-19 dianders@chromium.org licensing: Allow Google-TOS for chromeos-bsp-trogdor-private for now 2020-07-19 vapier@chromium.org licensing: add amd fsp to the deprecated Google-TOS list 2020-07-18 vapier@chromium.org licensing: add better error checking for tools 2020-07-18 vapier@chromium.org licensing: check for deprecated licenses at build time 2020-07-18 vapier@chromium.org licensing: split deprecated check out for reuse 2020-07-18 bpastene@chromium.org cros_test: Add an arg to flash a 'full' image to the device. 2020-07-18 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-18 saklein@chromium.org portage_util: Fix HasPrebuilt check. 2020-07-18 bhansknecht@chromium.org chromite: Update generated protos 2020-07-17 mmortensen@google.com query_build_logs: Add --join to find two stages from the same build run. 2020-07-17 briannorris@chromium.org qemu: s/EEXISTS/EEXIST/ 2020-07-17 ahassani@chromium.org auto_updater.py: Remove double-reboot scenario 2020-07-17 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-16 vapier@chromium.org cros lint: only allow one of pylintrc or .pylintrc 2020-07-15 mmortensen@google.com lib/locking.py: Log lock/unlock with lock type. 2020-07-15 tbegin@google.com packages: combine termina uprev handlers 2020-07-15 igorcov@chromium.org usergroup_baseline: Add attestation to policy-readers 2020-07-15 mmortensen@google.com cros_sdk.py: Add better logging around delete/unmount. 2020-07-15 tcwang@google.com toolchain_util: Create unique names for fatal Clang warnings 2020-07-15 zhuohao@chromium.org puff: add firmware branch builder 2020-07-14 mmortensen@google.com query_build_logs: Add -ef/-es flags to limit to successful/failing steps. 2020-07-14 lamontjones@chromium.org Further disable drallion hw tests due to rework on drallion360 DUTS. 2020-07-14 bgoodwin@google.com Add wshwos boards to the config for builds launched from rapid. 2020-07-13 tcwang@google.com afdo: Schedule AFDO verifier to run daily again (for branches) 2020-07-13 saklein@chromium.org cros_workon: Move to cros workon. 2020-07-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-13 yamaguchi@chromium.org Add script to fetch a file from CIPD. 2020-07-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-11 navil@google.com build_api: Allow BuildTargetUnitTest to specify packages to be run. 2020-07-11 navil@google.com chromite: Update generated protos 2020-07-10 saklein@chromium.org Revert "portage_util: Fix HasPrebuilt check." 2020-07-10 pbond@google.com deploy_chrome: copy swiftshader 2020-07-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-10 mikenichols@chromium.org config_lib: Add a RAPID builder for Rapid executions 2020-07-10 sanikak@chromium.org auto_updater_transfer: add metrics to track fallback devserver calls 2020-07-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-09 seanabraham@chromium.org OWNERS: update testplatform inclusion for generated protos 2020-07-09 dburger@chromium.org Make GomaConfig.DEFAULT map to a Goma RBE prod build. 2020-07-08 seanabraham@chromium.org OWNERS: add OWNERS.testplatform file 2020-07-08 saklein@chromium.org workspace build image: Skip eclean. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Id3ae910eac3b7d3dc1c2663cc56cdb6f5aa34201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790009}
-
Michael Crouse authored
This change creates the initial UKM event that logs metrics about the decision and blocklist reason for applying LiteVideos. The change also enables counterfactural experiments run on the per navigation level via a coinflip feature. A future change will add the remaining UKM metrics about the result of throttling media requests as well as debugging metrics regarding the resulting resolution when videos are throttled. Bug: 1097792 Change-Id: Ib2f1332b0c55a58dfaa50421999f23217149ed7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296014Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#790008}
-
Mounir Lamouri authored
Initially written to reduce flakiness but kept the changes to make the test matching modern web_tests expectations. Bug: 1099997 Change-Id: Iae5c66e73b4255691f6e72e6126e8ade001bf937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304535Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#790007}
-
Ioana Pandele authored
This feature will not be ready for a few milestones. Bug: 1104972, 1104947 Change-Id: Ic917b838f0a3f26f86ff88cc0246473bcdd325ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303399Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#790006}
-
chrome://appsJun Kokatsu authored
Link tag modification happened in crrev.com/c/2239707 caused a blink when reloading chrome://apps. This change move the code on top of head tag so that the blink won't happen. Bug: 1106213 Change-Id: Ic97c83ccf430f41c793ebd4350166b39b6d59445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301400 Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#790005}
-
Lijin Shen authored
The text direction is ltr when there is a non-translatable english word in the rtl language text. Set locale mode so that the text direction and alignment are determined by the system language text direction and alignment. Bug: 1107254 Change-Id: I05c318479e064204e49591ff9861184fabea1ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307480Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#790004}
-
Yuri Wiitala authored
VideoCaptureOracle, which is used by viz::FrameSinkVideoCapturer includes logic to suggest capture size changes in response to bottlenecks in an end-to-end screen mirroring pipeline. This change prevents the oracle from reducing the capture size until after it confirms a downstream consumer of the video capture is providing the necessary feedback signals. Bug: 1092854 Change-Id: Iadf059548cc1ae705cbcf1e40283fd115563a8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298579 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Auto-Submit: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790003}
-
Lily Chen authored
Cookies that are excluded for reasons (e.g. mismatching path or domain) other than a user's cookie blocking settings (i.e. content settings) should not be reported as "blocked". Bug: 1104451 Change-Id: I8bf6dbd3367fcb5f01655dac0e7c20ee52b34c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296009Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#790002}
-
Andrew Grieve authored
We use Desugar to desugar default interface methods, so do not need to pay attention to these D8/R8 messages. Sadly, -dontnote does not work for them, and there is no way to disable desugaring of default interface methods without also disabling method backporting (which we do want D8/R8 to perform. Bug: 1029357 Change-Id: Icb73b0d7f4233d7402c681bd30e3bcfdb101db33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304969Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790001}
-
Joshua Bell authored
During key conversion, where JS values are converted to IDBKey objects, arrays are converted an element at a time. At the start of the process an array is allocated and sized. While sparse arrays are invalid, a sparse array with a ridiculous length could cause OOMs in the allocator. Mitigate this by imposing an arbitrary limit on array keys, much as there is already an arbitrary depth limit. In practice, the limit should not be hit unless the conversion was going to eventually fail with OOM anyway. Bug: 1106710 Change-Id: If2da02a2fc736bead0e962d4ff37ba6aaef0a617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304445 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#790000}
-
Oleh Lamzin authored
Sort CSP directives in url_data_manager_backend.cc. Change-Id: I1e094121c210458300521a47b949c4dc0228b925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302891 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#789999}
-
Joshua Pawlicki authored
Bug: 1092503 Change-Id: Ic2ed8e9aa94380dc5fe0b1624f13866913d89ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307413 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789998}
-
Vladimir Levin authored
The default constructor doesn't initialize the variables, and we have a DCHECK operator= which may fire if context_provider_ is not null. I think this isn't currently failing on anything due to the way this class is created by the caller, but changes in OverlayTexture in https://chromium-review.googlesource.com/c/chromium/src/+/2305189 expose this bug making the bots fail a lot of the tests. E.g. https://test-results.appspot.com/data/layout_results/mac-rel/432713/blink_web_tests%20%28with%20patch%29/layout-test-results/results.html R=weiliangc@chromium.org Change-Id: Ia96fc4e9efce2763ffde30d11af0c8482757242a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305516Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789997}
-
ckitagawa authored
Break cyclic dependency of PlayerFrameMediator with - PlayerFrameScaleController - PlayerFrameScrollController BitmapState is tightly coupled to PlayerFrameMediator with good reason so a cyclic dependency there is somewhat unavoidable. This is achieved by having PlayerFrameCoordinator instantiate everything and then introducing a new class that handles dispatch of gestures. A helper for scaling is also added to break the two-way interdependence that existed in the mediator. Bug: 1099722 Change-Id: I13b258d973a5ff81cdf75505f59aabb02d66a6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295751 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#789996}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: Ife06c03e0de7ee59cd74c1d65c67e4465928b85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303876 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789995}
-
Collin Baker authored
This removes code left from in-product help for new tabs, bookmarks, and incognito mode. These were last used in 2017. A new approach is taken for recent in-product help. Bug: 1106523 Change-Id: I893c3c53ef44a7a37f169fde6d3db2880935c5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303969 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#789994}
-
Deepanjan Roy authored
We have a lab metric to track console error messages in telemetry stories, and when the count changes it is quite difficult to figure out what the new message is. This CL adds the error message and the url to the trace event. We will surface this information in the UI for easier debugging. Bug: 1086962 Change-Id: Ibeb739c7624941f7437f39e5087fbe574a782cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302837 Commit-Queue: Deep Roy <dproy@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789993}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ea6f21a052c9..9e46bb61c5d7 2020-07-20 capn@google.com Support _PACK32 storage image formats and fix asserts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6d8f51afe7d7c35e8e3e53820bd703d631aaff12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789992}
-
Samuel Huang authored
Compile failure in AppServiceAppWindowArcAppBrowserTest.LogicalWindowId arises from signed / unsigned comparison: std::count_if() returns a signed type, but the EXPECT_EQ used an unsigned value. This issue has been causing Builder chromeos-kevin-builder-perf-fyi to fail since start of 2020-06. Bug: 1106626 Change-Id: I4278161ad2533ac566bf78851ceedbada841fa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302834Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Philipp Weiß <phweiss@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#789991}
-
David Bertoni authored
This tests were previously flaky, crashing during shutdown. Waiting for the storage partition cleanup tasks to finish fixes these crashes, which were happening because the temp directory for the test was being deleted while cleanup tasks were trying to run. Also, global state needs to be cleared between tests, since it could cause tests to fail, depending on run order. Bug: 836332, 839371 Change-Id: Ie440f035ac6778c723d7ae63d8f4f9f640158230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288354 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789990}
-
Himanshu Jaju authored
Updates wire_format to latest internal version, will be used by upcoming changes for nearby share. Bug: 1085068 Change-Id: I7ac7796e9fb89f5efda5c950a3662ab6d8ab21a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306046Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#789989}
-
Tim Volodine authored
Do not enable real-time URL checks functionality when Safe Browsing is disabled. Also add documentation regarding this in WebLayer API. Note: Real-time URL checks can technically be enabled separately from the standard safe browsing, but this applies to enterprise users using Chrome Browser Cloud Management. This use case is currently only supported on Desktop platforms. It does not apply to Chrome on Android and WebLayer. BUG=1106358 Change-Id: Ib181aec6ed9466958d2a36eca83553fd33dc662b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302854Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789988}
-
Robbie Gibson authored
Bug: 1098722 Change-Id: Icd9da0e758c288a44716fb6f5a505267a76f42b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302756 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789987}
-
Mohamed Heikal authored
Change-Id: Ie52f3a5986fb6f368cddba4449eca3cd2cf0a3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305043Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789986}
-
Mike Dougherty authored
Update the scroll amount to bring the Find In Page menu item more into view. Although it was previously visible, it was at the very bottom edge of the pop over menu which seems to have been a source of flaky failure even when running locally. grey_replaceText sometimes causes a crash locally, so replace with typeText as there is no need to clear the text first in any of these tests. Additionally, there is no longer two accessibility elements with the same ID, and on iOS 12 the item with the accessibilityID is not an accessibilityElement. Simplify typeFindInPageText Fixed: 1029709 , 1030701 Change-Id: I7fca1bc87160b5404c40e592143e6841fee848cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303453 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789985}
-
Kyle Horimoto authored
A recent refactor [1] allowed KerberosCredentialsManager to be null for secondary users. This CL adds a missing null check which fixes a crash for multi-profile users. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2291317 Fixed: 1106721 Change-Id: Ib66eab34c84a6b0b6cce63b4d610af346dbfad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306821 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789984}
-