- 25 Nov, 2020 40 commits
-
-
Boris Sazonov authored
Improves testability of AccountManagerFacadeLacros - mojo::Remote is now passed explicitly to the ctor. Bug: 1117472 Change-Id: I81475ea7bf369a51ff0b0bdf8e43117737d09706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550809 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#830998}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I492fc44a2805ada0577fff025343470e685b653b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830997}
-
Philipp Hancke authored
this will intentionally break when adding new codecs and we can not add new codecs anymore because we do not have enough payload types. BUG=webrtc:12194 Change-Id: Ic1dff5f479377280111729f6443fc60a7d2e2658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550806 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#830996}
-
Jack Franklin authored
It was disabled to allow a DevTools Frontend CL to land, but it should now be able to run again. I thought the test would need updating given the changes in the source file, but it doesn't. There was a legitimate bug in the source CL (which has since been fixed) which I mistakenly took to mean I needed to disable the test before my frontend change could land. Fixed: 1150854 Change-Id: I672b336941e5f9a797a09d3139af1ea61f516ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558338 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830995}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606283471-7d9c21277781bbef8f12040d64fba3a4328552df.profdata to chrome-mac-master-1606305050-ea6ce0091e94442cf03fb928da3568602c7b69e6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iee98d112dc96901b7c15d69d5c5543d643a65680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560861Reviewed-by:
-
Maciek Slusarczyk authored
When the online sign-in flow is executed after password change CrOS shows old password confirmation dialog. If the old password provided by the user is incorrect the dialog is displayed with an error message. The message stays there even if we cancel the flow and start from scratch. This CL introduced a new flag that checks if the flow was restarted anew and if so hides the error message. Bug: 1138083 Change-Id: I8a6c6cafcbedf154f8d0cc008ed0510ed6373e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537639 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#830993}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eaf49c6587ad..16534e267df0 2020-11-25 tvanderlippe@chromium.org Remove Python infrastructure for the Closure Compiler 2020-11-25 jacktfranklin@chromium.org [DarkMode]: rename patchThemeSupport to enableLegacyPatching 2020-11-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-25 jacktfranklin@chromium.org [DarkMode] turn off legacy patching in CSSOverviewStartView 2020-11-25 alexrudenko@chromium.org Allow expanding/collapsing details in the Layout panel using arrow keys 2020-11-25 yiorsi@gmail.com Add copy object context menu in Console and Sources panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1122511,chromium:1148353,chromium:1149859,chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f65ff96ffcc72b7f849ca24d9a58c644d948acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560052Reviewed-by:
-
Pavol Marko authored
The test was failing/flaky on some MSAN bots, presumably because the listener was registered after the event was fired. Introduce a helper class that allows us to easily register the listener, perform the event, then wait for the listener to have fired. TBR=josiahk@chromium.org, dtseng@chromium.org Bug: 1145612 Test: Runs locally but real test will be whether this fixes failures on the 'Linux ChromiumOS MSan Tests bot' Change-Id: I16303d96b101113e80ab4f484b4e604faeab4c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560622Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830991}
-
Ewann authored
PageInfoRefactoring has been launched. This CL removes The Legacy PageInfo implementation as well as the implementation of the PageInfoRefactoring flag. Bug: 1038923 Change-Id: I24d60982ca1de28ef12faa6f2e89d3883c3046d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529162 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#830990}
-
arthursonzogni authored
Merge the DidSetFramePolicyHeaders IPC into DidCommitProvisionalLoad. They were sent together one after the other, but in two separate calls, which caused race conditions. Benefits: 1. Fix a race condition about sandbox flags. This is https://bugs.chromium.org/p/chromium/issues/detail?id=1145139#c5. The first IPC was resetting the sandbox flags, and the second was updating them with the right values. If a navigation is started from the browser process just in between receiving both IPCs, the navigation will use no sandbox, when it should have. 2. Fix https://crbug.com/1093268. It was possible to receive DidSetFramePolicyHeaders for speculative RenderFrameHost. It is logically no more possible, since DidCommitProvisionalLoad is the IPC that will "activate" the speculative RenderFrameHost. 3. Recover from https://crbug.com/1146025. Page with sandbox flags are properly restored after entering the BackForwardCache. 4. Since the IPC doesn't exist anymore. There are no more need to be guarded behind a `IsInactiveAndDisallowReactivation`. A page in the backforward cache can't receive this anymore, since it doesn't exist. Fixed: 1145139, 1146025 Bug: 1145139, 1146025 Change-Id: Ic720dd125a103fa09894a7f5348accc34823e33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536467Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830989}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Id36838b51a8ea1009951b1ccb5e6266df4b16d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560860Reviewed-by:
-
Hitoshi Yoshida authored
Credentials type converter can access a dictionary member[1] when it is not available. This CL fixes the issue. [1] PublicKeyCredentialCreationOptions.extensions.largeBlob.support Bug: 839389 Change-Id: Ica1b43775e221a37a4be0befc920035f32fa214f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558133Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#830987}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I1e918ec96e32fb8c05c9770d5b9e4878edf124bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560858Reviewed-by:
-
Viktor Semeniuk authored
Change-Id: I35e47822676fa88221a4061c3bbf231670a8d02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560299Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#830985}
-
Ewann authored
This CL updates the UITableViewStyle used in the Settings when the kSettingsRefresh flag is enabled, according to: http://slides/1oQp4K1J_Ue0U6Obsy-73PWD9wzuU4OhDEJczu82kXk8#slide=id.g5402559cba_0_413 it also cleans the white theme when the flag is enabled. Bug: 922511 Change-Id: I9d14fba7a46b41563bd1a1c14fbed9aef3cf6152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556965 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd56c5490710..1bb4e5eef6d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmarko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmarko@google.com Change-Id: I6388bf7334ac9608a04604d40d094881041ec6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560051Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830983}
-
Chris Lu authored
When tab closures are undone, the max/min inset ranges are not set in the new WKWebView before loading the page, because the session restoration logic doesn't follow the new tab creation logic. This change sets the max/min inset ranges whenever the Fullscreen model is reset, which covers any change of the active WebState. There will be no-op calls as a result of this since max/min inset ranges change during rotations, but it shouldn't hurt performance. Bug: 1149908 Change-Id: Ic94345d4e01854ab7addb70bf27f215b0f3cb590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552172 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606262372-c93aa4463db3b18479db12ddf45a2403c2ea87d0.profdata to chrome-win64-master-1606283471-0c692a03b66417a93fe8e91b8a0c4f515aaad0a9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I821ddffb7ee1967d9e1916a695850ca977dc8997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560044Reviewed-by:
-
Morten Stenshorne authored
We may re-layout between hit-testing and calculating PositionForPoint(), which may mean that the fragment stored in HitTestResult is from an older fragment tree generation. Fixes the following browser test when LayoutNGFullPositionForPoint is enabled: PasswordAutofillAgentTest.NoRefillOfUserInput And the following web tests: fast/css-generated-content/pseudo-triple-click.html fast/dom/MutationObserver/end-of-task-delivery.html fast/forms/search/search-hide-cancel-on-cancel.html fast/forms/text/input-text-self-emptying-click.html Bug: 1150362 Change-Id: I2717702da635613edb5dea4191a1dffa3cea8422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552865 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#830980}
-
Aya ElAttar authored
- Added unittests for DataTransferDlpController. - Changed some functions in DlpRulesManager & DataTransferDlpController to be virtual, so it'd be possible to override them in tests. Bug: 1140528 Change-Id: I36091bb4bc8d2c55cd0ef8749ce46073e9cac689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550544 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#830979}
-
Boris Sazonov authored
Adds conditional deps on account_manager_core component to chrome/browser and a couple of signin targets. Bug: 1117472 Change-Id: I2da7233c3590f6c2208f5ebcfa7782a3b471a739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547583Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#830978}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7c0b4a32c773..bb4f496d2a32 2020-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 31f74e1a4605 to fc78e93ce895 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I3dd7f51f760904dbc2de026edf945eaa1c07e943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560050Reviewed-by:
-
Liquan (Max) Gu authored
This CL is to implement the WebLayerPaymentRequestService methods necessary to invoke GooglePayPaymentApp. Bug: 1147093 Change-Id: Ief6c6a769ce2ce513ecb3a89e70f97bb3fa3b2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551774 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830976}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 to 88-4314.0-1605523684-benchmark-88.0.4324.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2d5819f2b15bc2e0fb8aae56401f2edefdf2d000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560859Reviewed-by:
-
Egor Pasko authored
This was used for fancy ways to test the chromium native linkers (should have been named "native library loaders") outside of the systems and modes they normally support, which created more moving parts, so we removed those tests a year ago or so. This change removes a few remainders of those tests that were not removed earlier, supposedly by mistake. Bug: 979638 Change-Id: Icda19a37e621659a1437a7f80a08d76bc514bfe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554980Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830974}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8d87e6d1de73..9db3ab201ec7 2020-11-25 landrey@webrtc.org Filter out NaNs before uploading to the dasboard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6e02a70372836127e871677359a061fca61344fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560048Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/5abd252a0a26..3facafa44e2a 2020-11-25 wl@gnu.org .mailmap: Updated and sorted. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I276bc96f2affc540afe7a101dd8c7d44599c80f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560043Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#830972}
-
Pavol Marko authored
This reverts commit 2d0cae27. Reason for revert: The CL caused test failures on PDFExtensionTestWithParam.PdfAccessibilityTextRunCrash Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/10202 The test is only enabled with gn arg is_chrome_branded = true which explains why it got missed in CQ. (when reproing locally, I also ran into crbug.com/1152752 , so if you want to repro make sure to turn dchecks off :-D ) Original change's description: > Reload the PDF accessibility tree on layout changes > > Currently, any layout changes applied to the PDF document (i.e. page > rotation or two-up view) after the accessibility tree has loaded does > not update the page bounds. > > Because the accessiblity tree has read-only nodes, the only way to > resolve the issue is to reload all the nodes of the tree on each layout > change. > > Note: This CL only fixes page bounds and positions. The bounds of page > content such as text or annotations still do not rotate with the rest > of the document. Those issues will be fixed in a follow-up. > > Bug: 1150665 > Change-Id: I2fbf2cb26f38ee3fed076333c0b224a8ede7947e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553217 > Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830918} TBR=raymes@chromium.org,dmazzoni@chromium.org,tsepez@chromium.org,dhoss@chromium.org,ankk@microsoft.com Change-Id: I6c2946592cfcb496c6ed2cd3de6610e2d7c64902 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560263Reviewed-by: -
Silin Liu authored
Reuse Polymer tags used in other parts of the OOBE for consistency. Bug: b:172390062 Change-Id: I8e9e4d522104890fc29536e07989a728d8835bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534290 Commit-Queue: Silin Liu <silinliu@google.com> Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#830970}
-
Ewann authored
This CL adds a method to UI Util to identify small devices. A device is considered as a small if its logical width is less than or equal to 375. Bug: 922511 Change-Id: I3308d770f2ef502a088743ede9e81dcd0cb698ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554997 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This reverts commit 99a42e2d. Reason for revert: Potential culprit for crbug.com/1152712, reverting to check the bot. Original change's description: > [iOS][Thumb Strip] Keep BVC's position fixed when switching to Incognito > > Before, when switching to incognito using the Thumb Strip, the BVC ended > up having a frame.y = 36 (or some other non-zero constant). It looks > like the BVC is currently positioned by frame, and my guess is that > somehow, the position of some other element + constraints caused the > BVC's frame to change after it was set. However, the BVC's frame could > be set by constraint, as it should always be that value. > > Bug: 1094335 > Change-Id: Iedeedadf7ac7c7e842ebe4af02d8e62ed3b6a7c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549947 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830146} TBR=marq@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1094335 Change-Id: I6fd0c59f79f9ac8bbc3cad70476ca3327b0c02e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560116Reviewed-by:
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4ae6730677..5d8fc91922 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4ae6730677..5d8fc91922 Bug: None Change-Id: I1d6cc77b91278d72f4fb2686ee2818bb0f5bad67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560503 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830967}
-
Liquan (Max) Gu authored
This CL moved shouldSkipShowingPaymentRequestUi() from PaymentUiService to PRService so that WebLayer and Chrome can share the logic. Bug: 1025619 Change-Id: If69054ad42b29541e5892998113c7174b0c45bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555560Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3cb4a09389a5..eaf49c6587ad 2020-11-25 yiorsi@gmail.com Add “Duplicate element” context menu in Element panel 2020-11-25 alexrudenko@chromium.org Fix issues in CSS Overview 2020-11-25 jacktfranklin@chromium.org [TS] CodeMirrorTextEditor.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1150797 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I51bcbb2d7ef022a59aedccde7252ac2b77c62a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560046Reviewed-by:
-
Yang Guo authored
Change-Id: Id4a2a9b4b20d6f6c243340159925474eacc5fe6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558404Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#830964}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/33f29ea9b251..a66263753a9f 2020-11-25 cwallez@chromium.org dawn_native: Make CreateView's descriptor default to nullptr 2020-11-25 cwallez@chromium.org Improve the dynamic binding OOB error message when binding.size is defaulted. 2020-11-25 cwallez@chromium.org Remove deprecated BindGroupLayout options. 2020-11-25 cwallez@chromium.org Remove deprecated SetIndexBuffer (without format). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ie24e21acbf1c840914b68c6fba5391e263aba35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560045Reviewed-by:
-
Danila Kuzmin authored
Sometimes there is no status area shown on the screen and we need to check it during tab traversal. Bug: 1008817 Change-Id: If6099f8c020818de62a3bc2bccbe07f077817d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551120Reviewed-by:
-
Alexander Bolodurin authored
Move ResolveToContentUrlOn{IO,UI}Thread into a separate utils file and reuse in both ArcDocumentsProviderStream{Reader,Writer}. Change-Id: I40dd5f345dee50db1d4e9d605175f78920adef67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535965 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#830961}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d894cbc80206..dd56c5490710 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmarko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmarko@google.com Change-Id: Ieb8221c4d9162e855c275d4aa2decc579f0fb833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560041Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0536e3a35b34b5a3f3733acf8a68b11666a8690e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560395Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830959}
-
