GitLab

Will let us show gpu memory usage in a more-intuitive way in frame viewer.

Review URL: https://codereview.chromium.org/447963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287998 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the lexer, parser and also the internal representation of mojom modules. The changes to the generators will be in a separate CL.

This CL doesn't change data_tests.py because it has been broken for quite a while. We could fix it in a separate CL if we think that it is still useful.

BUG=324170
TEST=those updated test files.

Review URL: https://codereview.chromium.org/437643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287997 0039d316-1c4b-4281-b951-d872f2087c98

First steps towards allowing AiS on more platforms.

R=stevet@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/447073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287996 0039d316-1c4b-4281-b951-d872f2087c98

Added function that allows javascript apps using gcdPrivate to get a list of networks with prefetched passwords.

Fixed reland of https://codereview.chromium.org/434733003/ which was reverted due to test failure.

BUG=383167
TBR=asargent@chromium.org,vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/450533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287995 0039d316-1c4b-4281-b951-d872f2087c98

This regressed with the LegacyRenderWidgetHostHWND. It looks like the reason is that the LegacyRenderWidgetHostHWND eats
paint messages which would previously cause an invalidation in the parent when bounds change, etc.

Proposed fix is to pass SWP_NOREDRAW to the SetWindowPos calls used by the LegacyRenderWidgetHostHWND class.

BUG=388690
R=sky

Review URL: https://codereview.chromium.org/440793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287994 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables autosizing for extension options guests using
the built-in autosizing functionality in GuestViewBase.

BUG=386838

Review URL: https://codereview.chromium.org/431503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333201

Review URL: https://codereview.chromium.org/446063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287992 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dbeam@chromium.org

Review URL: https://codereview.chromium.org/444373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287991 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400611

Review URL: https://codereview.chromium.org/446153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287990 0039d316-1c4b-4281-b951-d872f2087c98

This creates a PageManager.Observer class which delegates handling of
page history and title changes to an uber page observer:
- page_manager.js
- uber_page_manager_observer.js

The About page content is separated into its own file so in a future CL
it can be used as an overlay on another page.

The custom overlay implementation in help_base_page.js is no longer needed.

R=dbeam@chromium.org
BUG=313244
TBR=ben@chromium.org (for c/b/browser_resources.grd)

Review URL: https://codereview.chromium.org/423533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287989 0039d316-1c4b-4281-b951-d872f2087c98

Currently, it only adds pylint checks, with a blacklist for all the
files that fail horribly (or in otherwise mysterious ways).

Also fix a few (less mysterious) pylint failures. Remove some pylint
suppressions (since we now add appropriate directories to the python
module path for pylint).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/443293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287988 0039d316-1c4b-4281-b951-d872f2087c98

the real context type, not assume it's BLESSED_CONTEXT_TYPE (which has always
been wrong). This cleans up some other code.

BUG=391944
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/427983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400948
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/449673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287986 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/445133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287984 0039d316-1c4b-4281-b951-d872f2087c98

r172: Respect output_all_resource_defines when generating structures in resource maps.

TBR=tony@chromium.org

Review URL: https://codereview.chromium.org/446693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287983 0039d316-1c4b-4281-b951-d872f2087c98

If |type| in RequestPrintPreview() equals PRINT_PREVIEW_USER_INITIATED_ENTIRE_FRAME and |is_loading_| is true, RequestPrintPreview() returns,
then is called again, right after |is_loading_| is set to false in DidStopLoading(). 


BUG=376969
TEST=See bug for steps to reproduce.

Additional way to reproduce:
Build blink_tests and browser_tests in out/Release. Then in src/webkit/tools/layout_tests run this command:
./run_webkit_tests.py --platform browser_test.linux source_pdf/

you can replace linux with win or mac depending on your platform.

The program will attempt to save a PDF as a PDF through print preview. It will eventually fail because Print Preview will hang due to this bug.
If you want visual confirmation that this will happen open:
src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py.

Then add this line of code to the function cmd_line.
cmd.append('--enable-pixel-output-in-tests')

Then run the script again. Enabling pixel output will also make it significantly more likely for the bug to occur.
Its also more likely to happen on windows for some reason.

This is how I came across the bug.

Review URL: https://codereview.chromium.org/427723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287982 0039d316-1c4b-4281-b951-d872f2087c98

browser_desktop_root_window_host_x11.cc uses g_dbus_proxy_call which
is provided by libgio-2.0, so we should depend on the gio target too.

BUG=265560

Review URL: https://codereview.chromium.org/439613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287981 0039d316-1c4b-4281-b951-d872f2087c98

Website Settings options page.

Image: http://imgur.com/LzbuTsJ

BUG=372607

Review URL: https://codereview.chromium.org/445623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287979 0039d316-1c4b-4281-b951-d872f2087c98

This will be used for the Android preferences UI

BUG=400888

Review URL: https://codereview.chromium.org/440283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287978 0039d316-1c4b-4281-b951-d872f2087c98

Make the Linux implementation of GetFontRenderParams() cache
the ten most recent results to greatly reduce the number of
Fontconfig queries that are performed.

BUG=376077,391830

Review URL: https://codereview.chromium.org/440773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287977 0039d316-1c4b-4281-b951-d872f2087c98

To communicate with whispernet (which needs to be checked in as a pNacl binary),
the only way possible is for us to go through an extension. This code
implements the ChromeWhispernetClient, which uses the whispernet proxy compoent
extension. This extension is implemented on top of a private API that allows it
to communicate back and forth with the ChromeWhispernetClient.

The tests for this code exist only for the ChromeWhispernetClient since they
excersize the full flow back and forth from sending a request to encode a token
to receiving the samples, and then decoding samples and receiving the correct
token.

This is our temporary measure for M38 till we can find a better way to
communicate with the whispernet library.


Owners reviews requested:
xiyuan@ - For the overall review + the whispernet proxy code in
          c/b/r/whispernet_proxy
jochen@ - For adding components/copresence to c/b/DEPS
kalman@ - For the copresence_private API
ben@    - For adding the c/b/copresence directory and the OWNERS file + the
          addition to c/b/browser_resources.grd

R=ben@chromium.org, jochen@chromium.org, kalman@chromium.org, xiyuan@chromium.org
BUG=365493

Review URL: https://codereview.chromium.org/438513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287976 0039d316-1c4b-4281-b951-d872f2087c98

Causing timeout on "Win7 Tests (dbg)(1)"
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/30316

> 1. Adds action-parsing functionality for data reduction proxy header.
> 
> 2. Adds a couple of functions to return different fingerprint value for tamper detection.
> 
> 3. Adds a function to remove Chrome-Proxy header's fingerprint from its header values, and return the rest of header values.
> 
> 4. Changes HasDataReductionProxyViaHeader to also tell 
> whether data reduction proxy Via header occurs at the last 
> or not.
> 
> 
> BUG=381907
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287561
> 
> Review URL: https://codereview.chromium.org/387353003

TBR=xingx@chromium.org

Review URL: https://codereview.chromium.org/445323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287975 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287974 0039d316-1c4b-4281-b951-d872f2087c98

OneClickSigninHelper::HandleCrossAccountError has an input parameter of web contents that may have been killed when the method is called, e.g. signin from the new avatar bubble. Instead this method should just use the current active tab, since it is only used to attach a tab-modal warning dialog.

BUG=388607

Review URL: https://codereview.chromium.org/444083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287973 0039d316-1c4b-4281-b951-d872f2087c98

Add a basic browser test for functions in notification provider API.
This is mainly to test the connection and provide a skeleton for future
tests. The functions are not fully implemented yet, and more tests will
be added as the functions are implemented.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287692

Review URL: https://codereview.chromium.org/416423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287972 0039d316-1c4b-4281-b951-d872f2087c98

 and move it to components/renderer_context_menu/renderer_view_context_menu_base.{h|cc}

BUG=397320
TBR=blundell@chromium.org

Review URL: https://codereview.chromium.org/432003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287971 0039d316-1c4b-4281-b951-d872f2087c98

The data reduction proxy client should be specific about it's capabilities by specifying the version of the proxy client that is being used. 
A version field is now added to the Chrome-Proxy header in requests, but that version is set to zero. 
This corrects the version field in the Chrome-Proxy header to be the chromium build and patch number.

BUG=367268

Review URL: https://codereview.chromium.org/430643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287970 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke some layout tests

Original issue's description:
> Make SingleThreadProxy a SchedulerClient
> 
> This makes ui::Compositor no longer in charge of
> scheduling commits and draws, deferring it to cc::Scheduler.
> 
> Other compositors that use SingleThreadProxy are left calling composite
> synchronously and now pass a flag to indicate that this is their
> intention.  This patch doesn't remove synchronous composite, but now
> makes it mutually exclusive with scheduling.
> 
> BUG=329552, 287250
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287950

NOTRY=true
NOTREECHECKS=true
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/447133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287968 0039d316-1c4b-4281-b951-d872f2087c98

multi-line comment.

BUG=none
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Review URL: https://codereview.chromium.org/445153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287963 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287961 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401218

Review URL: https://codereview.chromium.org/446973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287960 0039d316-1c4b-4281-b951-d872f2087c98

with the same username exist.

I believe r285140 should have fixed any possible underlying issue here.
Unfortunately even before this I could not devise a test that would fail in the
expected way, but we should still have a test verifying this behavior going
forward.

BUG=395190

Review URL: https://codereview.chromium.org/431893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions:unittsts
R=brettw@chromium.org,kalman@chromium.org
TBR=keybuk@chromium.org # for device

Review URL: https://codereview.chromium.org/434243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287957 0039d316-1c4b-4281-b951-d872f2087c98

The instance owns the engine via its engine_ scoped_ptr, so if the engine is 
being destroyed via the scoped_ptr destructor, it may not be safe to access 
anything in the instance since the instance may be partially destroyed. Instead,
destroy the engine as the first step in the process so the instance is still
intact.

BUG=392956

Review URL: https://codereview.chromium.org/427583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287955 0039d316-1c4b-4281-b951-d872f2087c98

Instantiate RenderFrameProxyHost objects for remote frames when using
--site-per-process.

BUG=357747, 399709, 399775, 400594
TBR=kenrb, creis, kalman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287557

Review URL: https://codereview.chromium.org/444503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287954 0039d316-1c4b-4281-b951-d872f2087c98

The function is called ~20,000 times on a fresh launch of Chrome on my MacBook
Pro. Adding a dumb cache to reduce redundant fetches reduced cpu cycles in the
function by 75% (profiled by DTrace).

The class FontFamilyCache performs the caching, and the observation of the
PrefService to ensure that the cache does not become stale.

The Profile owns the FontFamilyCache to ensure that the cache does not
outlive the PrefService.

BUG=308095

Review URL: https://codereview.chromium.org/439913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287953 0039d316-1c4b-4281-b951-d872f2087c98

Reason for the bug is painting code in the pdf plugin which converts back and forth from pixels to DIP
and back to pixels causing us to draw over the scrollbars. Division and multiplication with fractional scales
Is a lossy operation.


BUG=399150
TEST=Tested manually with fractional scales on Windows.

Review URL: https://codereview.chromium.org/437873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287952 0039d316-1c4b-4281-b951-d872f2087c98

Create an ExtensionActionView class which represents the core of either a
PageActionView or a BrowserActionView. The goal here is to move all logic for
executing the action itself into ExtensionActionView, so that
PageActionImageView and BrowserActionButton (the current implementation classes)
become nothing more than a view wrapper for the ExtensionActionView.

This should allow us to show page actions in the now-incorrectly-named
BrowserActionsContainer and have them render in the same fashion as the current
browser actions.

BUG=397259

Review URL: https://codereview.chromium.org/431173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287951 0039d316-1c4b-4281-b951-d872f2087c98

This makes ui::Compositor no longer in charge of
scheduling commits and draws, deferring it to cc::Scheduler.

Other compositors that use SingleThreadProxy are left calling composite
synchronously and now pass a flag to indicate that this is their
intention.  This patch doesn't remove synchronous composite, but now
makes it mutually exclusive with scheduling.

BUG=329552, 287250

Review URL: https://codereview.chromium.org/134623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287950 0039d316-1c4b-4281-b951-d872f2087c98