- 29 Jan, 2015 18 commits
-
-
abarth authored
Launching Mojo apps on Android is slow because we keep the network cache in memory, which means we lose it every time we launch MojoShell. After this CL, we use a disk cache on Android. Note: We still use a memory cache on desktop because we want to be able to run many instances of mojo_shell in parallel on desktop for testing. R=jamesr@chromium.org BUG=452226 Review URL: https://codereview.chromium.org/883073003 Cr-Commit-Position: refs/heads/master@{#313642}
-
Ryan Sleevi authored
BUG=69557, 147116, 156816, 371734, 436102, 439948, 444504 TEST=Test each of the URLs listed in the diff (Linux or Windows) and ensure EV status is granted. R=davidben@chromium.org Review URL: https://codereview.chromium.org/879183002 Cr-Commit-Position: refs/heads/master@{#313641}
-
jamescook authored
It fails on the official builders. NOTRY=true TBR=kjellander@chromium.org BUG=452623 Review URL: https://codereview.chromium.org/858153004 Cr-Commit-Position: refs/heads/master@{#313640}
-
yyanagisawa authored
If soname is used here, nm cannot find the file if non-default toolchain is used. Review URL: https://codereview.chromium.org/884663002 Cr-Commit-Position: refs/heads/master@{#313639}
-
jialiul authored
(1) make the tile of the denyButton adaptive, such that "Deny" will show on a mouse lock request instead of "Exit full screen." (2) add unittest to verify its behavior. XIB changes: * Remove the default deny button title IDS_FULLSCREEN_EXIT_FULLSCREEN. BUG=139944 Review URL: https://codereview.chromium.org/856253002 Cr-Commit-Position: refs/heads/master@{#313638}
-
jeremyim authored
BUG=374264 Review URL: https://codereview.chromium.org/884713004 Cr-Commit-Position: refs/heads/master@{#313637}
-
jbudorick authored
BUG=452961 Review URL: https://codereview.chromium.org/882093003 Cr-Commit-Position: refs/heads/master@{#313636}
-
tfarina authored
BUG=394382 R=avi@chromium.org Review URL: https://codereview.chromium.org/874073002 Cr-Commit-Position: refs/heads/master@{#313635}
-
sheckylin authored
The CL corrects a bug where clock_gettime was placed in a DCHECK call and thus not executed on release builds. Contributed by sheckylin@chromium.org BUG=chrome-os-partner:35111 TEST=samus ChromeOS build Review URL: https://codereview.chromium.org/884313002 Cr-Commit-Position: refs/heads/master@{#313634}
-
rouslan authored
- Don't hide autofill popup on browser height change on Android. Android keyboard can show or hide a strip of suggestions when user switches between input fields. If the input field triggers showing the autofill popup, the keyboard resize will hide it, which causes a UI flash. - Remove redundant Views code to hide autofill popup on window resize. Browser process now has a cross-platform way to listen to window resize and close the autofill popup. Removed Views-only resize listener was also firing on window move. Removing it means that moving the window without resizing it will not close the autofill popup. The popup stays attached to the field during window move, however. - Let autofill know when a password popup may be showing. This enables autofill agent to hide the popup when the page scrolls. - Re-enable showing username suggestions on first click on Android, which now behaves on par with desktop. BUG=430318 Review URL: https://codereview.chromium.org/870833002 Cr-Commit-Position: refs/heads/master@{#313633}
-
mbarbella authored
BUG=450268 R=inferno@chromium.org,tsepez@chromium.org Review URL: https://codereview.chromium.org/873253004 Cr-Commit-Position: refs/heads/master@{#313632}
-
alexandrec authored
This CL adds the groundwork for a slide-in pane to be used by the OOP PDF Viewer. It adheres to the principles of Material Design, and will be used as a base for the bookmarks pane (which will display a list of bookmarks) as well as an info pane to show metadata of the PDF. BUG=110020 Review URL: https://codereview.chromium.org/864753002 Cr-Commit-Position: refs/heads/master@{#313631}
-
danakj authored
This field is redundant now that we pass a RenderPass* to AppendQuads. A few tests were passing a different id and the same RenderPass* to test DelegatedRendererLayerImpl, so I had to adjust the tests to pass different RenderPass* instead. R=vmpstr Review URL: https://codereview.chromium.org/879423002 Cr-Commit-Position: refs/heads/master@{#313630}
-
spang authored
This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. This splits EventFactoryOzone into two parts: EventFactoryOzone and InputDeviceFactoryOzone. The new InputDeviceFactoryOzone class is now the device I/O-centric part, and is intended to exist on a low-latency thread. Hotplug events still originate on the UI thread, but this is not a problem because hotplug is not latency critical. We're sharing udev with the display code, so its easiest leave that code alone for now. This doesn't add a new thread yet. Everything still runs on the UI thread. BUG=449710 TEST=boot link_freon & move mouse Review URL: https://codereview.chromium.org/863353003 Cr-Commit-Position: refs/heads/master@{#313629}
-
xdai authored
The testing team wants to enable 'Roboto' by default and have real users to help report bugs too. In this CL 'Roboto' is enabled by default and can be disabled by going to chrome://flags and turn 'disable-roboto-font-ui' to on. Also modify the OobeWebUITest to make the tests run in full screen, otherwise the tests will fail due to the incorrect layout of supervised user creation UI (based on xiyuan@'s advice). BUG=448948 TEST=tested on device (Pixel) Review URL: https://codereview.chromium.org/868753005 Cr-Commit-Position: refs/heads/master@{#313628}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/c6b67b8..b02f7f1 TBR=leviw@chromium.org,rjwright@chromium.org Review URL: https://codereview.chromium.org/885743002 Cr-Commit-Position: refs/heads/master@{#313627}
-
huangs authored
The "shadow" App Launcher registry keys are still managed. The code that do this are concentrated to the new files app_launcher_installer.* to facilitate future updates. This CL also significantly reduces the size of setup.exe, presumably due to removal of dependencies. TEST=Windows only. Install and update still work as before. - Right after fresh install, ensure reg key at user level exists: Google\Update\Clients\{FDA71E6F-AC4C-4a00-8B70-9958A68906BF} BUG=297647 Review URL: https://codereview.chromium.org/811283002 Cr-Commit-Position: refs/heads/master@{#313626}
-
posciak authored
BUG=None NOTRY=true Review URL: https://codereview.chromium.org/866263002 Cr-Commit-Position: refs/heads/master@{#313625}
-
- 28 Jan, 2015 22 commits
-
-
garykac authored
BUG= Review URL: https://codereview.chromium.org/884213002 Cr-Commit-Position: refs/heads/master@{#313624}
-
sergeyu authored
When shutting down HostProcess config_watcher_ is supposed to be deleted on the nework thread. Previously ShutdownOnNetworkThread() was deleting it, but that line was mistakenly removed in crrev.com/302162 . Adding it back. Review URL: https://codereview.chromium.org/885693003 Cr-Commit-Position: refs/heads/master@{#313623}
-
smckay authored
Update ImportController to push all updates to a new 'CommandWidget' class. Add more test coverage. BUG=420680 TEST=browser_test: FileManagerJsTest.* Review URL: https://codereview.chromium.org/880303002 Cr-Commit-Position: refs/heads/master@{#313622}
-
kenobi authored
Add calls to hash generation and comparison code so that files being imported into Google Drive are actually deduplicated. BUG=420680 TEST=FileManagerJsTest.DuplicateFinderTest FileManagerJsTest.MediaImportHandlerTest Review URL: https://codereview.chromium.org/885653003 Cr-Commit-Position: refs/heads/master@{#313621}
-
jaekyun authored
BUG=429254 Review URL: https://codereview.chromium.org/882853003 Cr-Commit-Position: refs/heads/master@{#313620}
-
jincheol.jo authored
The following lines are repeated in almost every test cc/scheduler/scheduler_unittest.cc file FakeSchedulerClient client; SchedulerSettings scheduler_settings; scheduler_settings.use_external_begin_frame_source = true; CREATE_SCHEDULER_AND_INIT_SURFACE(scheduler_settings); created test fixture class and clean up to remove duplicate codes. BUG=449028 Review URL: https://codereview.chromium.org/844763008 Cr-Commit-Position: refs/heads/master@{#313619}
-
chrome://settings/passwordshcarmona authored
Updated code so that the first row is focusable. This makes it possible to tab into the first row making it more obvious that it is focused. Applied Dan's feedback from previous CL (https://codereview.chromium.org/834323005). BUG=449110 Review URL: https://codereview.chromium.org/869813002 Cr-Commit-Position: refs/heads/master@{#313618}
-
paulmiller authored
BUG=410900 Review URL: https://codereview.chromium.org/881383002 Cr-Commit-Position: refs/heads/master@{#313617}
-
benjhayden authored
Review URL: https://codereview.chromium.org/877323005 Cr-Commit-Position: refs/heads/master@{#313616}
-
kalman authored
moment there is only total time and time to load all non-component extensions. Time to load component extensions and time to notify all listeners is not instrumented. R=mek@chromium.org, mpearson@chromium.org BUG=453073 Review URL: https://codereview.chromium.org/883023003 Cr-Commit-Position: refs/heads/master@{#313615}
-
kelvinp authored
In Chrome Apps, some platform APIs can only be called from the background page (e.g. reloading a chrome.app.AppWindow). Likewise, some chrome API's must be initiated by user interaction, which can only be called from the foreground. This CL base.IPC that provides helper functions to invoke methods on different pages using chrome.runtime.sendMessage. BUG=452317 Review URL: https://codereview.chromium.org/877993002 Cr-Commit-Position: refs/heads/master@{#313614}
-
spang authored
BUG=417463 TEST=build with chromeos=1 use_ozone=1 Review URL: https://codereview.chromium.org/884233002 Cr-Commit-Position: refs/heads/master@{#313613}
-
benwells authored
This is the first step on support 'add to homescreen' banners for sites that have manifests. BUG=452825 Review URL: https://codereview.chromium.org/884623003 Cr-Commit-Position: refs/heads/master@{#313612}
-
vadimt authored
We want to see how much GPU initialization contributes to startup slowness. BUG=125248 Review URL: https://codereview.chromium.org/860293004 Cr-Commit-Position: refs/heads/master@{#313611}
-
oshima authored
"compositor: Fix texture flipping for SW mirroring with surfaceless" and "Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds." Reason for revert: The original patch breaks software mirroring mode on at least veyron_jerry, and quite possibly all non-freon systems. >Original issue's descriptions: > Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds. > This fixes the GN build on Android after https://codereview.chromium.org/846063002. > > (The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099) > > TBR=bauerb@chromium.org > > Review URL: https://codereview.chromium.org/879543002 > > Cr-Commit-Position: refs/heads/master@{#313074} > compositor: Fix texture flipping for SW mirroring with surfaceless > > Ozone-surfaceless renders the scene flipped, so the texture contents are > inverted from what they should be. This fixes the mirroring logic to > un-flip the texture when needed, and also to send the right sub-buffer > update rect. > > BUG=434115 > > Committed: https://crrev.com/c6a481fe79e0c4851a576495105edf2600bfe5be > Cr-Commit-Position: refs/heads/master@{#312979} TBR=danakj@chromium.org,achaulk@chromium.org,bauerb@chromium.org BUG=434115,451804 Review URL: https://codereview.chromium.org/865673003 Cr-Commit-Position: refs/heads/master@{#313610}
-
jrummell authored
Also renames existing CreateSession to GenerateRequest to better match the purpose of the promise. BUG=351501 TEST=existing EME tests pass Review URL: https://codereview.chromium.org/878633004 Cr-Commit-Position: refs/heads/master@{#313609}
-
fsamuel authored
1. Use auto to improve readability. 2. Rename methods to remove "Extension" prefix. 3. Use const where possible. 4. Use using content::* to improve readability. BUG=none Review URL: https://codereview.chromium.org/880343002 Cr-Commit-Position: refs/heads/master@{#313608}
-
robertocn authored
NOTRY=True Review URL: https://codereview.chromium.org/873313010 Cr-Commit-Position: refs/heads/master@{#313607}
-
jaekyun authored
Java layer needs an exact way to determine whether a URL uses an external protocol or not. is_external_protocol will be true if a URL can't be handled by Chrome's internal protocol handlers. BUG=426751 Review URL: https://codereview.chromium.org/884473004 Cr-Commit-Position: refs/heads/master@{#313606}
-
reillyg authored
When chrome.usb.closeDevice is called the device is explicitly closed in the extension function implementation and then closed again when the UsbDeviceResource object is destroyed. Only the latter is necessary as that covers other ways in which the resource can be released. Review URL: https://codereview.chromium.org/881363004 Cr-Commit-Position: refs/heads/master@{#313605}
-
reillyg authored
This change merges the initial call to SetCommState/tcsetattr with the call to ConfigurePort so that parameters such as baud rate are configured immediately when the port is opened. Default values for these parameters are now always applied. This works around an issue with some serial adapter drivers on Windows that report an invalid baud rate through GetCommState. Having the intended baud rate available for the first call to SetCommState allows an application to provide a valid value so that Chrome does not have to guess. BUG=448407 Review URL: https://codereview.chromium.org/873903002 Cr-Commit-Position: refs/heads/master@{#313604}
-
palmer authored
This is in conformance with the CA/Browser Forum Baseline Requirements for certificate issuance. This CL is adapted from a diff provided by sigbjorn@opera.com. Thanks! BUG=119211 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/724543002 Cr-Commit-Position: refs/heads/master@{#313603}
-