GitLab

Scrolls can have different input modalities: Wheel, Touch, Autoscroll,
and Scrollbar. This CL adds metrics for scroll events in the form of
EventLatency.<event_type>.<input_modality>.TotalLatency.

Bug: 1058162
Change-Id: I0cf063e6537215d89fcc46af912b294d6df21f5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091602
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751224}

The input VideoFrame of ImageProcessor on V4L2VEA is the one given
by the VEA client. The input config of the ImageProcessor should
be multi-planar layout so that ImageProcessor can deal with
arbitrary offsets of the VideoFrame.

Bug: 1033799
Test: appr.tc on kukui
Change-Id: I43df37bb4c2dc9ab1221acd14d19d2413f2c4402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102938
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751223}

The StyledLabel calls two different ctors of Label based on the styled
range, one with |custom_font| and the other one with |text_style|. The
two ctors will create labels with different heights, which causes a
misalignment between normal and bold texts.

This cl adds an ash typography to support semi bold text style to
emphasize a matched search string. Then the label in the styled range
will call a same ctor of Label with |text_style| to eliminate the
difference.

Bug: 1061271
Test: New unittest
Change-Id: I5b7415ef3b7bd06c5ad296fe9e5211ddd18685ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108061
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751222}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I9134b9a8b8313901d256f1deab42c3f2f2ba76fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107906Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751221}

ShouldCustomDrawSystemTitlebar will never change during the runtime of
the browser now so these checks are unnecessary.

Bug: 953982
Change-Id: Icc9e8201a0e23fe0eab9cfe62d1a9d2a2290af88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108128Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751220}

Change-Id: Ib5679894cee1646f1bebc4a079b81df7a72326df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107614Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751219}

Terminal will not be on by default in M82. This CL is created
to be merged in M82 beta, then TerminalSystemApp will be
re-enabled on trunk in a followup CL.

Bug: 1016190
Change-Id: I40f8f0e22d91b90b166703a92ef0652ff7099561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107051
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751218}

This change removes the old serial enumeration code on Windows and
always uses the new enumeration path while listening to window messages
to discover when ports are added and removed from the system.

This will allow us to keep the UI up-to-date in real time when the user
plugs in a device and deliver connection events to web apps.

Bug: 981483
Change-Id: I4126e370b02973458b5c2aac6a230244248b2320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099238
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751217}

When adding a new tab, look at the current active tab to
determine the group the new tab should belong in.

Bug: 1061004
Change-Id: I45905ccb9d57c5293059c9dc10ae7ad539c9fcb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107421
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751216}

Using wpt-import in Chromium 181c9ba9.
With Chromium commits locally applied on WPT:
acbe6d96 "Add timeouts for EventWatchers on CSS animation tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Iaac3e211410bfe191066cc5ee28660c79e0d612d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106325Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751215}

* Added a new ICompleteStatus interface that is an aggregate object of
integral and string types as a parameter to
IUpdaterObserver::OnComplete().
* Added a logging switch to --server for debug builds.
* Fixed an issue with WRL Module lifetime.

Bug: 1053729,1062157
Change-Id: I89c5aa440a70058b9ad66c61f41da8cb18897f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107832
Auto-Submit: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751214}

As we migrate iOS bots to the Chromium recipe, we want the mb
configurations defined under mb_config.pyl to have precedence
over the previous JSON definitions.

There are two checks that trigger the iOS search: 1) when the
config doesn't exist, and 2) when the config is ios_error.

These additions are to be removed once the migration is complete.

Bug: 912681
Change-Id: Ieb04e98724460c2aba3bfd94d37b855f518ba7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106562
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751213}

Bug: 1061509
Change-Id: I097d6fd22524bb2e211c907037dd3e0dcd7fa191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106416
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751212}

This is needed so that the try builder runs can pass ensure xcode recipe
step.

Bug: 943883
Change-Id: I331d53b4bdd8ab815871ef06944db475b3d5c930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108064Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751211}

After we finish the scroll unification, the scrolls happens mainly on
the compositor thread, and the scroll code in the main thread will be
removed. eventSender sends the scroll events to main thread, so it
would not work after the scroll unification. We should replace
eventSender.continuousMouseScrollBy with gpuBenchmarking.smoothScrollBy
in the wheel event tests. In the wheel event tests, there is a check for
wheelDeltaX or wheelDeltaY, which has a multiplier factor of 3, which I
think should change to kTickMultiplier/MouseWheelEvent::kWheelDelta,
120/53.

Bug: 1047176
Change-Id: I534cbd25f2a9c84f6f5d891742438facdcda91ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084091
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751210}

Bug: 986235
Change-Id: Ide481dbd27b7a0531b8fe003c80d15126a405bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105334
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751209}

LLVM D75713 changed llvm-objdump disassembly to display function names
in angle brackets (e.g. "main" becomes "<main>"). This change
modifies goma_link_tests.py to match.

Reviewers: akhuang, gbiv, hans
Change-Id: I2f601a85608561c741c2d4285f17d73b9983faa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106827Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751208}

Thanks to the new set_permission method on test_runner, this CL
makes sure the sensor WPT tests with first granted permission and
adds tests for sensor permission status.

Change-Id: Id72e60f92043986c3fe3517faf0c79716a1f03c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104654Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Cr-Commit-Position: refs/heads/master@{#751207}

When clearing removing elements from a vector, relevant slots are set
to zero. This CL adds a method to atomically set the memory to zero
byte by byte.

Bug: 986235
Change-Id: I1e143498e85e1764c508e6ce82cb56e2a35c56fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105295
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751206}

When laying out items in a column container for flex basis calculation,
we have to subtract inline margins from the container width to get the
right available width for the items.

This also fixes the browser test
PrintPreviewPagesSettingsTest.InvalidPageRanges
which used to crash.

Bug: 845235
Change-Id: Ie9382c0e6cfa89333fc92c2bc4eb8e95c592c923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106821
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751205}

Accessibility is in a good position to review our changes to these
two files, which will help increase our velocity.

NOTRY=true

Bug: None
Change-Id: I1eccb9985aaba10e01b479028fb1a8f69e377f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102638Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751204}

Observers of power state sometimes see DISPLAY_POWER_ALL_OFF state after
SuspendDone is called. It can happen when a suspend event a resume event
happen consecutively (e.g. a user closes and opens a lid quickly).
This CL adds a check not to send outdated state to observers.

Bug: b/134459602
Test: Close and open the lid quickly, only one power state change is
      observed.
Test: A power state change is observed when the screen turns off without
      suspend.
Test: Close the lid and observes one power state change.
Test: display_unittests

Change-Id: I43ede1bc997190155994da9e94f400efeb6ecb1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098805
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751203}

ConvertWebAppToExtension.

WebAppFileHandlers-related testing for ConvertWebAppToExtension is
failing on Windows trunk builds. This seems to be related to a recent
CL (crrev.com/c/2087327). Since the relevant feature hasn't shipped, we
should temporarily disable the test while the issue is fixed.

Bug: 1062239
Change-Id: Iacf866e691b2be49f5f0a4bd304078b26d1ec7cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105671Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Robert Woods <robertwoods@google.com>
Cr-Commit-Position: refs/heads/master@{#751202}

This follows the behaviour of SMB shares mounted using the FSP-based
smbprovider.

Bug: 1054704
Change-Id: I7f1b6419c4de8e327c8fbeba0f753d3df187d7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100553Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751201}

Manages the drag handle nudge during window drag from shelf to home or
overview (which may end up in a gesture the nudge is describing).

If the contextual nudge is shown when the window drag starts, the nudge
will not be hidden until the gesture completes (end it will get hidden
when the gesture completes, even if the user does not end up going
home).

If the contextual nudge is scheduled to be shown when the gesture
starts, the show request will be canceled.

Adds logic that prevents drag handle nudge from showing up, unless it's
a result of an explicit user action - tapping the drag handle.

BUG=1058617

Change-Id: I96fa2748308143ec42295dbfb472dc564da5bd03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107135
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751200}

Bug: 1058993
Change-Id: If476998f7f1a4c616c1929aefa4e5698f44dfcee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095150
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751199}

Fix
- ConditionalFunc
- Parser callback
- FindExe

Bug: 1007643
Change-Id: I0322a98456bc620945da5115fbf32fc703d6e2aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107312
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751198}

The test setup has some code that causes the ExtensionSyncService not
to be created. That code doesn't seem necessary any more -- the test
passes without it.

I'm removing it because it causes the sync system to come up in an
unusual state that we don't see in production. ProfileSyncService
exists, but ExtensionSyncService does not, on platforms that support
extensions. This trips a DCHECK deep inside the apps sync code when
I enable a feature I'm working on. My feature has a slightly different
ModelTypeController for apps sync. The old ModelTypeController just
happened to support a null "SyncableService" but the new one
requires (via DCHECK) that the syncable_service exists.

The code was added here:
https://codereview.chromium.org/907533004

Backtrace for the DCHECK is in the bug.

Bug: 1060289
Test: unit_tests
Change-Id: I25307a7d1d89f04a8d3b5a06bb4635dc14235909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103309
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751197}

Change-Id: I3d3d04bfbc33e7f3e607dbb6ca91d7ea945a3bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614550
Auto-Submit: ssid <ssid@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751196}

EventHandler::HandleMouseMoveOrLeaveEvent has some unused variables,
such as only_update_scrollbars and force_leave. only_update_scrollbars
is removed, because no callers set this to true. force_leave should be
decided from mouse event's type if it is mouse leave type. Also, make
sure the mouse event's type set to "WebInputEvent::kMouseLeave" before
passing to HandleMouseLeaveEvent.

I also add some todo to further clean this class in the future.


Bug: 1016560
Change-Id: I58c1f479602a423fc6e5668c59e78994c633012c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095876
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751195}

These metrics are used to assess pipeline health or planning and should
not ever be deprecated.

Bug: 1053030
Change-Id: I2283c48f0bdca899bbd0c34d327ed337f453734e
Fixed: 1053012, 1055411, 1053020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090715
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751194}

Checks to see if a URL contains a target embedded inside it in a way
that needs to trigger a safety tip. This function will return a "safe
url" which is the embedded target. Currently we consider the following
as Target Embedding: sth-google.com-sth.com, sth.google.com-sth.com,
sth-google-com-sth.com, sth.google.com.sth.com, sth-googlé.com-sth.com
where the embedded target is google.com. In addition to these if a TLD
is used that is considered to be an important TLD but that domain does
not actually exist we consider that a target embedding as well. (e.g.
google.edu instead of google.com in the above examples.)

A more detailed explanation could be found in the project document:
https://docs.google.com/document/d/18YQjj17a820SLVWuIF7cOay_Y8Cq7nt721m67WqCtW0/

Change-Id: Id8ced3db6dc74326dddbe45c0a6c6e8cf53f1c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096026
Commit-Queue: Behnood Momenzadeh <behnoodm@google.com>
Auto-Submit: Behnood Momenzadeh <behnoodm@google.com>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751193}

Its only additional method can be replaced with a free function.

Bug: None
Change-Id: I30837e1488bd3c2e56b0ca58e4a79e1621df7ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107613Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751192}

This is to run tests for
https://luci-milo-dev.appspot.com/p/chromium/builders/ci/linux-rel-swarming-staging/1810

Bug: b/144318226
Change-Id: I95ead7a533f853e0350a5d55fdd9518f86c87989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105692
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Cr-Commit-Position: refs/heads/master@{#751191}

This is based on a comment from robliao@ in https://crrev.com/c/2099238.
This change avoids converting the UTF-16 device path to a UTF-8 path and
therefore makes it possible to call the W versions of Win32 APIs.

Change-Id: I833c2cc7806cd0a61cbad236ebd9fd1985654635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106752Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751190}

This reverts commit 181c9ba9.

Reason for revert: reland by mistake, will reland it together with the fix

Original change's description:
> Reland "[Ash] Simplify AccessibilityControllerImpl to remove duplications"
> 
> This reverts commit 812f314f.
> 
> Reason for revert: culprit found
> 
> Original change's description:
> > Revert "[Ash] Simplify AccessibilityControllerImpl to remove duplications"
> > 
> > This reverts commit 2f2a33d5.
> > 
> > Reason for revert: <INSERT REASONING HERE>
> > It looks like this CL breaks some test case
> > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18262?blamelist=1#blamelist-tab
> > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8885542762262570176/+/steps/exo_unittests/0/logs/Deterministic_failure:_All__x2f_SurfaceTest.AcquireFence__x2f_0__status_CRASH_/0
> > 
> > 
> > Original change's description:
> > > [Ash] Simplify AccessibilityControllerImpl to remove duplications
> > > 
> > > AccessibilityControllerImpl had a lot of duplications. Let's fix that.
> > > Also, now it controls fullscreen and docked magnifiers. Before that,
> > > we have to go AccessibilityDelegate and MagnificationManager to do
> > > this.
> > > 
> > > Change-Id: I6a5d827ded2a88a56eb173fed67e010aa002070d
> > > Bug: 1051892
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050688
> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#751086}
> > 
> > TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com
> > 
> > Change-Id: Ifbd8e25594790d7417af06c84651d3837ad17b5d
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1051892
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107028
> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> > Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#751181}
> 
> TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org
> 
> Change-Id: If1d69e1f28c1e850c55c038ea7138c75da9ea885
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1051892
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107545
> Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751188}

TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org

Change-Id: I382410f4fabc53c4ae5045310b22b729d5ec6cc7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1051892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107546Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751189}

This reverts commit 812f314f.

Reason for revert: culprit found

Original change's description:
> Revert "[Ash] Simplify AccessibilityControllerImpl to remove duplications"
> 
> This reverts commit 2f2a33d5.
> 
> Reason for revert: <INSERT REASONING HERE>
> It looks like this CL breaks some test case
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18262?blamelist=1#blamelist-tab
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8885542762262570176/+/steps/exo_unittests/0/logs/Deterministic_failure:_All__x2f_SurfaceTest.AcquireFence__x2f_0__status_CRASH_/0
> 
> 
> Original change's description:
> > [Ash] Simplify AccessibilityControllerImpl to remove duplications
> > 
> > AccessibilityControllerImpl had a lot of duplications. Let's fix that.
> > Also, now it controls fullscreen and docked magnifiers. Before that,
> > we have to go AccessibilityDelegate and MagnificationManager to do
> > this.
> > 
> > Change-Id: I6a5d827ded2a88a56eb173fed67e010aa002070d
> > Bug: 1051892
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050688
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#751086}
> 
> TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com
> 
> Change-Id: Ifbd8e25594790d7417af06c84651d3837ad17b5d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1051892
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107028
> Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751181}

TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org

Change-Id: If1d69e1f28c1e850c55c038ea7138c75da9ea885
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1051892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107545Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751188}

This reverts commit 7e0c31e0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 751185 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdlMGMzMWUwNTVjNTNmNTdiNGE0OTM2NzI1NGIzZGQxN2RmZGY3MjAM

Sample Failed Build: https://ci.chromium.org/b/8885536633435759808

Sample Failed Step: compile

Original change's description:
> Adding new parameter raster_mode to CreateSharedImageProvider
> 
> Adding a new parameter, raster_mode, that determines if the newly
> created CanvasResourceProvider of SharedImage is GPU or CPU.
> 
> In later changes we need to be able to specify this to be false, while
> it was defaulted to true inside the CreateSharedImageProvider.
> 
> Here we are just adding the new parameter and fixing all callsites with
> true (as it was the earlier value).
> 
> Bug: 1035589
> Change-Id: Ifb640dacf59b0c12ec098645f341bedc93a3ad96
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104213
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751185}


Change-Id: I4256551657c56f8f422dd8870d4cf9c139b81f81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1035589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108065
Cr-Commit-Position: refs/heads/master@{#751187}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f1850bf0..1bf5f826

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I591df630a0e81579def72744be2eaba8424fe9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106324Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751186}

Adding a new parameter, raster_mode, that determines if the newly
created CanvasResourceProvider of SharedImage is GPU or CPU.

In later changes we need to be able to specify this to be false, while
it was defaulted to true inside the CreateSharedImageProvider.

Here we are just adding the new parameter and fixing all callsites with
true (as it was the earlier value).

Bug: 1035589
Change-Id: Ifb640dacf59b0c12ec098645f341bedc93a3ad96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104213Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751185}