GitLab

Change-Id: I43e9f2df360a20f4e1a8641114f897053f47bd60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358600Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798838}

Bug: None
Change-Id: I063f5d074dac5d7c02d50cdc3e8975f30f80a214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357422
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798837}

For elements with will-change:transform or directly composited images
the raster scale is not updated in response to transform scale
changes. Once the scale gets especially large, the interest rect
computed by blink starts to become less than the layer bounds.
This ends up setting a recorded_viewport_ on RasterSource that is also
less than the layer bounds. If the interest rect gets small enough, it's
possible that tiles that are in view are not completely covered by the
RasterSource. This means that we won't create tiles (much less assign
them GPU memory and schedule them) in PictureLayerTiling::CreateTile. We
did not see this with the previous implementation of directly composited
images, since the content layer never had an interest rect computed.

This change fixes this specifically for directly composited images by
always considering its raster source as covering the entire layer. This
is the definition of directly composited images (has a DrawImageRectOp
that draws into the entire layer). This allows the in view tiles to be
created, then rasterized and activated and the image no longer
disappears.

I looked into fixing the general case (see comments in the bug) but
given the regression for the images scenario and the fact that we'd like
to get a fix merged for 85, I took an approach to just fix directly
composited images.

Bug: 1110141
Change-Id: Ice3cf25508585f116edd7317718292ec9ad8a7ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358888Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#798836}

follow up to 8e26d230

Bug: 1097216
Change-Id: Ic65b788010d84c8d2a0282f0bd3a1e2d9680ab3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359746
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798835}

This CL adds Graphics.Smoothness.Jank.* histograms in histograms.xml.

Bug: 1073216
Change-Id: I955cd30c086f0b517be40fd64e830b82ee65271c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359165Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798834}

Add use counter to collect UMA metrics of when postMessage is called
between top-level windows on a same-site and cross-site basis, and
when targetOrigin is not specified. When is called for cross-site,
metrics will be measured in UKM as well.

These metrics will be used to understand how postMessage is used
between sites to come up with future plans for postMessage API changes.

Bug: 1112491
Change-Id: I0b023067c289d0a957c28100cf7c591c97030d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337263
Commit-Queue: Shuran Huang <shuuran@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798833}

This reverts commit f97fae25.

Reason for revert: Fixing the null dereference of Document's loader
which caused the crash in the first place. This crash was similar to
what we saw in crbug.com/931330 and fixed with crrev.com/c/1470543.

Original change's description:
> Revert "Add PerfectHeuristics UKM event, and metric for DelayAsyncScriptExecution"
> 
> This reverts commit 647d93e9.
> 
> Reason for revert: crbug/1116821 - causing crashes
> TBR=ryansturm@chromium.org,falken@chromium.org,rkaplow@chromium.org
> 
> Original change's description:
> > Add PerfectHeuristics UKM event, and metric for DelayAsyncScriptExecution
> >
> > This CL introduces the PerfectHeuristics UKM event, along with a boolean
> > metric for when a blink::ScriptRunner comes across an async script
> > before the script element's node document has finished parsing. The
> > PerfectHeuristics UKM event is logged in the UkmPageLoadMetricsObserver.
> >
> > See the Google-internal UKM privacy review:
> > https://docs.google.com/document/d/1UqkpGXc4LEh5jzzVR8fCVVTuCuG2mwvhQTuCy36zT3g/edit#
> >
> > See the Perfect Heuristics [1] project document (currently
> > Google-internal).
> >
> > [1]: https://docs.google.com/document/d/1Y7uF76Gq0VlJZky2j7x-lbD1_awH64eW0WRg1bNLuFs/edit
> >
> > R=​falken@chromium.org, nhiroki@chromium.org, ryansturm@chromium.org, sophiechang@chromium.org
> >
> > Bug: 1086227
> > Change-Id: I71954491a1a559c2e1244a543092f1b8f38b8136
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340845
> > Commit-Queue: Dominic Farolino <dom@chromium.org>
> > Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#798393}
> 
> TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org,dom@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1086227,1116821
> Change-Id: I0131884d123e2122fa674097381293174795fecf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359573
> Commit-Queue: Sophie Chang <sophiechang@chromium.org>
> Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798738}

TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org,dom@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1086227
Bug: 1116821
Change-Id: I7722da2c17dc34952ea9155d72840708b4eaa5b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359742Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798832}

This change updates the headers' aria role to be 'heading' instead of
'group', which is a more appropriate role given the definitions from w3.
This also improves screen readers' understanding of these text blocks.

Bug: 1116623
Change-Id: Iac4fa60c72da8a130bd28841889a3826a755c8e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357461Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#798831}

After [1], a rebuild is necessary to pull in the libxkbcommon0 and
libwayland-client0 changes.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2352948

BUG=1116999,1116384
R=msisov

Change-Id: I69c9233a3a1d8070565adc217a308497de61c2ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360317
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#798830}

This also refactors OutdatedUpgradeBubbleView to use DialogModel, which
makes use of body text.

Bug: 1106422
Change-Id: Ifae91809fc6c71274ac4c0368d427e7b094d8ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351061Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798829}

The code clearly expects infinity to be possible, but unconditionally
multiplies by it (and discards the result in the infinity case).  This
is UB; avoid the multiplication in this case.

Bug: 1116289
Change-Id: I5b1297e92be68e3477b3dcbb17146d4f7a3d4098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355404
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798828}

Because the field trial testing config is applied to browser_tests,
explicitly disable the "PdfHonorJsContentSettings" feature on tests
that expect the feature disabled.

Bug: 696650
Change-Id: I8b13523b590372230e66c61cf846fca8284112d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350114
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798827}

Also convert the types in NetworkListTypes as well since they are
trivial and NetworkListItem depends on them.

Bug: 1045266
Test: NetworkNetworkListItem*
Change-Id: Iabe3a94bd80a9269215f1298c30e154442014003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359397
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Auto-Submit: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798826}

Change-Id: I3673a9a4411c00b72a3e96b405ce726c9632ca4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359235
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798825}

Change-Id: I35718eeeee57947b54a3e65348af9b1de1ac084c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354305Reviewed-by: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798824}

This CL uses a set::find overload to use the uint32_t type to find
the object to avoid construct another object.

By following the style guide, added a comparator struct.
"For example, if your type doesn't have a natural ordering,
but you want to store it in a std::set, use a custom comparator
rather than overloading <."
https://google.github.io/styleguide/cppguide.html#Operator_Overloading

Bug: None
Change-Id: Ic8b9f51a3b3a50601b1ecfa1ba8039ecf16a22ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358449Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798823}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Ic0dad7aa12b1e1c1e71e500ecddf2f2ce656fe85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360263Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798822}

Bug=CHROMIUM:973963

Change-Id: Ib2fe85abd4fbe5dee7c6da48f7f1f5c25dd17a70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359740Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798821}

In order to make BasicStringPiece API compatible with C++17's
std::basic_string_view this change removes the ends_with() API and
updates call sites to use base::EndsWith instead.

In order to keep this callsites concise, base::EndsWith's
case_sensitivity parameter now defaults to CompareCase::SENSITIVE.

TBR=dcheng

Bug: 1049498
Change-Id: Ie10332e84ae8cc96524c4bf47e5f472a6215eaa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358831
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798820}

Add missing mock for |ObjectProxy::WaitForServiceToBeAvailable| in order
to unittest |ObjectProxy| when this method is called.

BUG=b:164310699
TEST=unit_tests

Change-Id: I0071e6d3987b5881841d3e38432ade6ceaf5eb7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358131Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798819}

cloud.png and success.png under chrome/browser/policy is not used by any
source code.

Change-Id: I13e8a5f56b927de7fb455408e088afb162050cab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356671Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798818}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ffd805115ed6..21b36f736809

2020-08-17 rharrison@google.com Roll 4 dependencies (#1131)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: radial-bots+chrome-roll@google.com
Change-Id: Ied6c561def4ebc0c16c279da171809877eaa5b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360298Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798817}

https://docs.google.com/document/d/1wXOKcgVy5YuGRFWUlBv75bl7j5gNK5bzc-ETr5GVBJw

Bug: 1112872
Change-Id: Ie90cfe5dbb4efbb28e6b9407358556f6b1919cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359747
Auto-Submit: Fred Mello <fredmello@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798816}

This adds basic support for building WebLayer as an isolated split in
WebView. A new gn arg "weblayer_in_split" is added which will move
WebLayer Java code to it's own DFM if true.

Supporting isolated splits required some client changes in WebLayer, so
I added a check in WebLayerFactoryImpl.isClientSupported() to make sure
isolated splits aren't used with an unsupported client.

This also adds the ability to write the version_name and version_code of
a bundle module to the build_config, which allows DFMs to match the base
module version info (an error is thrown if these don't match). This
makes it easy to share version info, since computing WebView
version_code is pretty complicated.

The bundle with isolated splits won't install correctly with the current
version of bundletool we have in Chromium, but I'm working in parallel
on fixing bundletool.

Bug: 1105096
Change-Id: Id5522b42e283dc813fa84aaedc806f7519b586ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353378
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798815}

https://chromium.googlesource.com/angle/angle.git/+log/064bbf297d37..d63bca58a085

2020-08-17 cclao@google.com Vulkan: Add test for RGB texture not break renderpass
2020-08-17 jmadill@chromium.org Update commit ID when the git ref changes.
2020-08-17 cnorthrop@google.com Capture/Replay: Fix 1010102 vertex attrib type name

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Test: Test: Capture and replay first 1200 frames of COD.
Change-Id: I60d25236d52abf81f0e25ccbfc02f275bae323ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359158Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798814}

Change-Id: I711966f27f5d3b317b8ea565117fff27d863ed57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354948
Commit-Queue: Russ Hamilton <behamilton@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798813}

In order to perform more careful rollout this CL disables
SyncTriggerFullKeystoreMigration, that was enabled by default.

Bug: 1094326
Change-Id: I981a4ae364d8f2b807e251e679bc781f9e990c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359084Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#798812}

This reverts commit f2af1ee6.

Reason for revert: I unfortunately suggested the wrong approach for this CL. When we exclude enterprise-enrolled devices in code, these users (including Googlers) can't test the feature even by manually enabling the flags. Instead, we'll exclude enterprise users from the Finch config for this feature.

Original change's description:
> omnibox: Exclude enterprise-enrolled devices from simplified domain display
> 
> For a 1% experiment with simplified domain display, we should exclude
> enterprise enrolled devices to not disrupt enterprise environments when
> collecting data.
> This CL includes the following settings to achieve that purpose:
> - Added a IsEnterpriseManaged() virtual method to OmniboxViewViews, in order to
> filter whether a device is enterprise enrolled or not
> - Added |is_enterprise_managed_for_testing| variable to toggle during
> testing. It is by default FALSE, so, it should not affect previous
> tests
> - Added a SetEnterpriseManagedForTesting() method in TestOmniboxView to manually toggle the
> |is_enterprise_managed_for_testing| flag, which is used in an overrode version of IsEnterpriseManaged()
> - Add an special test to validate that URL is not unelided even when
> field trials are enabled but the device is enterprise managed
> 
> Bug: 1109243
> Change-Id: I79b47374de6c9eb780b5e56bef6408d3130c4168
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348578
> Commit-Queue: Ernesto García <ernestognw@google.com>
> Reviewed-by: Carlos IL <carlosil@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797930}

TBR=tommycli@chromium.org,carlosil@chromium.org,ernestognw@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1109243
Change-Id: I68309155086541d34a3a953437a6ef0224d5f2d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359743Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798811}

This change makes the following base::BasicStringPiece APIs constexpr:
* substr()
* front()
* back()

Bug: 1049498
Change-Id: I4e8694cec4b26b9f677175cb1fe135d8f9d42d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358671Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798810}

This is part of the identifiability study.

Bug: 973801
Change-Id: Iea741169b1066dcfc4db8bd5abdd0e0e44263101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357513
Commit-Queue: Russ Hamilton <behamilton@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798809}

Also remove unnecessary severity="Error" attributes since we always call
lint with -Werror.

Bug: 1116130
Change-Id: Ib9214668ea3e095d358a46daba6bf6df3203f6ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354833
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798808}

A bug was introduced in https://crrev.com/c/2355924 leading to
|semantics_manager_for_test_| being left unitialized, resulting in a
crash in release builds.

Bug: 1117070
Change-Id: I249c232e616145a21edf380077bcd58a1571c085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360315
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798807}

Some Arc app icons are pixelated, e.g. spotify. The reasons is the
background/foreground icon image fetched from the Arc side is pixelated.
The Arc side cl:12384305 modifies the Arc side implementation to fetch
the high quality raw icon foreground/background image:
https://googleplex-android-review.git.corp.google.com/c/platform/vendor/google_arc/+/12384305

This CL implements the chromium side change to generate the adaptive
icon in Chrome OS.
1. The raw foreground/background icon size is not the requested icon
size. So modify ArcAppIcon, adding a flag, extract_subset_allowed_, to
allow other size image to be forwarded to AppService for the
foreground/background image.

(Note: Arc default app icons may have different size
background/foreground as well, but the case should be rare, because we
just enable the flag for 1 week. Also most time the default app icons
should match the size. If there are cases that the current Canary
release is updated, and the default add icons are wrong due to the
migration from last 1 week version, we can suggest disable/enable
the Arc play store to refresh to the new image size.)

2. Modify AppService Arc icon handling to generate the adaptive icon
using the raw background/foreground icon images. The Arc raw
background/foreground image has padding for all 4 sides. So if the
foreground/background icon image doesn't match the requested size, chop
paddings and resize image_rep to the appropriate size. Then combine the
foreground/background images, and apply the mask.

This CL and the Arc side cl:12384305 work together to resolve the Arc
app icons pixelated issue. This CL should be submitted first, and this
CL is backward compatible.

BUG=1114771

Change-Id: I70af928f5b6c81c28f71c54efa102b7b1c617a0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359311
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Long Cheng <lgcheng@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798806}

Roll Chrome Mac PGO profile from chrome-mac-master-1597665194-0d53ac1a851921d9b7ac1e88ae497b998bf9af0d.profdata to chrome-mac-master-1597687171-f7ac758bbaa5d412cea42dd6434f8391401d2bbb.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I0e39d56622952181f47565a6ff937de26aeef67a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360264Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798805}

Bug: none
Test: browser_tests
Change-Id: I392453663d7abe558c65a4f75e3e3c4080ce39f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359391
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798804}

crbug.com/1024598 was closed as wont fix because there is no intention
to add UMA for that purpose.

Bug: None
Change-Id: Id3da27a9035eda136a340341fbb1ecc720e5a132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334348Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798803}

Add support for sentinel tuning version that is used for "control" optimizations where the type should be disabled for the navigation

Bug: 1113287
Change-Id: Id82122c8f2918300bedc151b93b58d5aa9abb1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357558
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798802}

This change enables trybots to validate the Adaptive and Reactive
suggestions.

Bug: 1046863, 1056503
Change-Id: Ifc48bf2b3c120141b8ad4f3b37dfbed77babb1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354722
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798801}

Replace 'whitelist' and 'blacklist' with 'allowlist' and 'denylist' in //chrome/browser/supervised_user

This CL leaves all user-facing or risky uses in place, and leaves them
for followup CLs where they can get more close scrutiny. The remaining
uses are:
 1. SupervisedUserWhitelistInstaller, which lives in
    //chrome/browser/component_udpater. This is tracked in
    http://crbug.com/1097254
 2. The "whitelist" key in the json content of the serialized whitelist
    file. I left this as-is for now because a simple rename would prevent
    existing whitelist files from loading correctly.
 3. ManagedUserWhitelistSpecifics, which is a Message in the protobuf
    used for syncing. I believe this can be renamed without issue, but
    that would be done in a followup.
 4. ManagedUsers.Whitelist.Count, ManagedUsers_Whitelist_Added,
    ManagedUsers_Whitelist_Removed, metrics. We can't rename these
    without decoupling them from their historical data. We may be able
    to create a formula to merge the old and new names, and base any
    alerts/dashboards on the formula.
 5. "BlacklistOnly" trial group in the "SafeSites" field trial. It's
    unclear if this can be safely renamed.
 6. "blacklist-20141001-1k.bin" is a file downloaded from gstatic with
    the default denylist. We can rename this once we copy the file in
    gstatic to a new filename.
 7. "su-blacklist.bin" is the path of the denylist file that's stored in
    the user's data directory. Renaming this will require us to support
    both paths in the future. This also left as a followup.
 8. "Blacklist active", "Blacklist", "Whitelist" in
    about:supervised-user-internals. This can be done in a followup due
    to it being a user-facing change.
 9. "install-supervised-user-whitelists" switch, which is supposedly
    only used for testing. This can be done in a followup.


Bug: 1097253
Change-Id: I7637c1f16a49e1dd7836a3fbe81122a69961270d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316889
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798800}

Flakes were due to race condition in restoring clipboard buffer. This
doesn't solve the issue that we still have a race condition, but should
make the race condition less flaky.

Bug: 1116530
Change-Id: Id0683fc408d48ed6daf795d5ab80ac1095c033d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360222Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#798799}