GitLab

Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
the given path. This makes it difficult to create POSIX compatible API on
top of PPAPI.

This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
That makes a new directory according to the given PP_MakeDirectoryFlags
values. The flags provide exclusive operation option. If exclusive flag
is specified and a directory exists on the given path, the function fails
and returns PP_ERROR_FILEEXISTS.


BUG=314879
TEST=browser_tests

Review URL: https://codereview.chromium.org/113363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243802 0039d316-1c4b-4281-b951-d872f2087c98

This brings in Brotli format change and bug fixes.

dfc5a9f2151a Fix -Wconversion compiler warnings in the brotli decoder.
4c8c7fd31c6a Brotli format change: small improvement to the encoding of Huffman codes
efbc1a896593 Small update to brotli specification.
40955ce409e5 Bug fixes for the brotli encoder and decoder.
b89f3be40b69 Brotli format change: improved encoding of Huffman codes
30625ba238fc Use C-style comments in the brotli decoder.

BUG=307828,329547,329258,331253

Review URL: https://codereview.chromium.org/109283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243801 0039d316-1c4b-4281-b951-d872f2087c98

If the session becomes disconnected, this hides the desktop display
instead of leaving it visible and non-interactive.

BUG=325593
TEST=Disconnect the session by killing the host process.

Review URL: https://codereview.chromium.org/105943010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243800 0039d316-1c4b-4281-b951-d872f2087c98

Public facing APIs should just live in the mojo:: namespace.

R=sky@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/128803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243799 0039d316-1c4b-4281-b951-d872f2087c98

This patch allows streamlined hosted apps to use the apple touch icons
for generating hosted apps.

To use the icons, it is necessary to size them to
extension_misc::kExtensionIconSizes to make the manifest handler agree
to use the icons.

Added TabHelper::ConstrainBitmapsToSizes which finds the
closest, not-smaller bitmap for each size and downsizes it. At most each
bitmap is used for 1 size in order to prevent generating resized icons
which would be stored on disk.

BUG=318607

Review URL: https://codereview.chromium.org/105873009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243797 0039d316-1c4b-4281-b951-d872f2087c98

In some cases, the RenderView performs a history navigation in response to a
reload when the WebFrame does not have the page in question committed. Override
the cache policy so the navigation revalidates the cache, rather than skipping
revalidation altogether.

BUG=331386
TEST=CrashRecoveryBrowserTest.ReloadCacheRevalidate

Review URL: https://codereview.chromium.org/101203007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243796 0039d316-1c4b-4281-b951-d872f2087c98

This is supported since JB-MR1, and doesn't subtract
window decorations etc. like other size metrics do.

TBR=yfriedman@chromium.org
BUG=329439

Review URL: https://codereview.chromium.org/93933016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243795 0039d316-1c4b-4281-b951-d872f2087c98

All migration code has already landed. This is the final CL that carries out the switch.
By this CL, Files.app in multi-profile session starts showing each profile's Downloads folder,
not the primary profile's one. This is a transient state for the future fully-multiprofile-aware
Files.app (ETA: M34) that shows all profile's folder in a single window.

The following is the summary/background why the path switch is needed:

We had used /home/chronos/user/Download as the path to the "Downloads" folder for all users.
This does not hold for multi-profile session. The "real" path for multiple users are
/home/chronos/u-unique-hash-userA/Downloads
/home/chronos/u-unique-hash-userB/Downloads
...
and /home/chronos/user is just an alias to the user who first signed into the session.

To make all user's folder available simultaneously in one multi-profile session,
we need to stop using the alias, and differentiate all folders by the real path.

BUG=309556

Review URL: https://codereview.chromium.org/48903012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243794 0039d316-1c4b-4281-b951-d872f2087c98

Recently this started flaking. The problem was that the exit manager (or the shadowing one if it was there) would run before the in-process utility thread shutdown. Since the thread was holding on to g_one_utility_thread_lock, the exit manager would try to destroy that LazyInstance but it would fail because the lock was still owned by a different thread.

The fix is to ensure that the utility thread is gone. This is done by waiting for all UtilityProcessHost objects to get destructed. This wasn't happening before because the tests would just wait for their app-specific IPC from the utility thread, which is dispatched before the OnChannelError in ChildProcessHost ends up killing the UtilityProcessHost.

BUG=316919
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/128993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243793 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: a bunch of video* layout tests failed http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/24977

TBR=reed@google.com,thestig@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332271

Review URL: https://codereview.chromium.org/130963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243791 0039d316-1c4b-4281-b951-d872f2087c98

See commit message of r232166 for details.

BUG=none
NOTRY=true
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/130873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243790 0039d316-1c4b-4281-b951-d872f2087c98

Most CrOS failing similar to this:

FAILED: c++ -MMD -MF obj/chrome/browser/chromeos/input_method/test_support_common.mock_input_method_engine.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1 -DUSE_XI2_MT=2 -DFILE_MANAGER_EXTENSION=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGL_GLEXT_PROTOTYPES -DLIBPEERCONNECTION_LIB=1 -DUSE_BRLAPI -DGTEST_HAS_POSIX_RE=0 -DNACL_WINDOWS=0 -DNACL_LINUX=1 -DNACL_OSX=0 -DNACL_TARGET_SUBARCH=64 -DNACL_TARGET_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -DNACL_BUILD_ARCH=x86 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DSK_SUPPORT_LEGACY_COLORTYPE=1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_LEGACY_SK64 -DSK_SUPPORT_LEGACY_ONLOCKPIXELS -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DCHROMEOS -DUNIT_TEST -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen -Igen/chrome -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../v8/include -I../../third_party/libpng -I../../third_party/libwebp -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../testing/gmock/include -I../../third_party/zlib -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -Igen/policy -I../../net/third_party/nss/ssl -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/nss -I/usr/include/nspr -O2 -fno-ident -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare  -c ../../chrome/browser/chromeos/input_method/mock_input_method_engine.cc -o obj/chrome/browser/chromeos/input_method/test_support_common.mock_input_method_engine.o
../../chrome/browser/chromeos/input_method/mock_input_method_engine.cc:14:43: fatalerror: chromeos/ime/candidate_window.h: No such file or directory
compilation terminated.
ninja: build stopped: subcommand failed.

> Moves CandidateWindow model to ui/base/ime.
> 
> BUG=325813
> R=komatsu@chromium.org
> TEST=build passes
> 
> Review URL: https://codereview.chromium.org/126363002

TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/130833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243784 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/127103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243783 0039d316-1c4b-4281-b951-d872f2087c98

With this change, `gclient runhooks` creates ninja files by default on
Windows. To build, run `ninja -C out\Release chrome`. The output appears
in out\ instead of build\.

If you need to use a VS build for some reason, you can still
`set GYP_GENERATORS=msvs`. This is no longer a tested configuration.

Bots should automatically pick up the binaries in the new location (out).
If something does break, it should be safe to revert this change, and bots
should then automatically go back to picking up binaries from the old
location (build).

R=thakis@chromium.org
BUG=303291

Review URL: https://codereview.chromium.org/111183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243782 0039d316-1c4b-4281-b951-d872f2087c98

Fix a few instances of HashMap to SparseArray in
AwQuotaManagerBridge.java

Pass null locale to String.format, which implies "no
localization is applied".

Pass Locale.ENGLISH toLowerCase as suggested by the
documentation.

Removed some unneeded supressions.

BUG=

Review URL: https://codereview.chromium.org/126453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243781 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243779 0039d316-1c4b-4281-b951-d872f2087c98

BUG=325813
R=komatsu@chromium.org
TEST=build passes

Review URL: https://codereview.chromium.org/126363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243777 0039d316-1c4b-4281-b951-d872f2087c98

It allows us to know whether the existing hashes dictionary can be trusted on startup (and thus whether seeding should be allowed).

Note: seeding a NULL preference is always allowed.

Review URL: https://codereview.chromium.org/126093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243776 0039d316-1c4b-4281-b951-d872f2087c98

This adds two new policies that will allow to block all or some native
messaging hosts.

BUG=237882

Review URL: https://codereview.chromium.org/118253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243774 0039d316-1c4b-4281-b951-d872f2087c98

Add per-network-technology histograms that will be emitted by
shill whenever a lease expires before it can be renewed.

R=isherman@chromium.org
BUG=216710
TEST=Start chrome, and browse to chrome://histograms to make sure
these enums now exist.

Review URL: https://codereview.chromium.org/124193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243772 0039d316-1c4b-4281-b951-d872f2087c98

As nacl_io does not support

TEST=./build_tools/build_sdk.py
TEST=./build_tools/test_sdk.py

Review URL: https://codereview.chromium.org/125693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243771 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, fix the order in the test service used in unit tests.

BUG=332120
TEST=dbus_unittests pass as before

Review URL: https://codereview.chromium.org/125673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243770 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243769 0039d316-1c4b-4281-b951-d872f2087c98

This adds the gsutil .sha1 files for node.js binaries which are stored in
Google storage. It also updates the DEPS file to pull these binaries.

BUG=

Review URL: https://codereview.chromium.org/125593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243768 0039d316-1c4b-4281-b951-d872f2087c98

The data offset will be dropped from the CDM interface in a later CL.

BUG=298569

Review URL: https://codereview.chromium.org/122683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243766 0039d316-1c4b-4281-b951-d872f2087c98

Added expat_nacl target that compiles expat for PNaCl

BUG=276739

Review URL: https://codereview.chromium.org/120303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243765 0039d316-1c4b-4281-b951-d872f2087c98

Unless you have an existing build with enable_webrtc=1 in place, chrome will fail to compile.

BUG=331550
TEST=None

Review URL: https://codereview.chromium.org/119143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243764 0039d316-1c4b-4281-b951-d872f2087c98

Refactoring around descriptor.  The descriptor representing InputMethodEngine was previously generated in InpuMethodManager.  This patch makes InputMethodEngine generates its own descriptor and manage it.

BUG=N/A

Review URL: https://codereview.chromium.org/119133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243763 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:17801
TEST=Kill Widevine CDM process and we get decode error.

Review URL: https://codereview.chromium.org/116443009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243762 0039d316-1c4b-4281-b951-d872f2087c98

Add a test for the DesktopBackgroundController
wallpaper-switching bug that was fixed by r242579.

BUG=327443

Review URL: https://codereview.chromium.org/115263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243761 0039d316-1c4b-4281-b951-d872f2087c98

This makes ServiceWorkerStorage return to being a mostly stateless class,
at least with respect to jobs, and in fact it is now ignorant of registraiton jobs. This CL is purely mechanical, moving tests and functions around without altering any behavior.
BUG=
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/113133013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243759 0039d316-1c4b-4281-b951-d872f2087c98

Previously, extension windows would have the chrome toolbar. This CL
prevents child app windows from getting a toolbar in streamlined
hosted apps mode which fixes this issue.

BUG=318607

Review URL: https://codereview.chromium.org/112623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243757 0039d316-1c4b-4281-b951-d872f2087c98

- Fixed range removal.
- Fixed shutdown on error.
- Fixed memory limit setting for testing.
- Cleaned up waiting for seek logic and documented behavior.

BUG=230708

Review URL: https://codereview.chromium.org/110693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243756 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327482

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243647

Review URL: https://codereview.chromium.org/109413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243755 0039d316-1c4b-4281-b951-d872f2087c98

This patch enables downloading all rules for a country code. The rules are
organized into a Ruleset tree, where nodes contain region-wide rules,
language-specific rules, and Rulesets for the sub-regions.

For example, the country code of Canada is "CA". The Ruleset for "CA"
contains the general validation rules for Canada in the default language
of the country, which is English, or "en".

One of the child nodes of "CA" is a Rule for "fr" language. This Rule
contains the general validation rules for Canada in the French language.

The rest of the child nodes of "CA" are the Ruleset objects for all of the
Canada's provinces. For example, there's a Ruleset for "BC" for British
Columbia.

Example of a Ruleset for Canada and some of its provinces:

                  CA-->fr
                  |
-------------------------------------
|        |        |        |        |
v        v        v        v        v
AB-->fr  BC-->fr  MB-->fr  NB-->fr  NL-->fr

BUG=327046

Review URL: https://codereview.chromium.org/109323011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243754 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331991

Review URL: https://codereview.chromium.org/108343009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243752 0039d316-1c4b-4281-b951-d872f2087c98

r1832 win ninja: include .pdb in linker outputs

R=thakis@chromium.org
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/130533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243751 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/83433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243750 0039d316-1c4b-4281-b951-d872f2087c98

Failing on main waterfall Vista Tests (1):

[ RUN      ] GpuFeatureTest.MultisamplingAllowed
[4884:2868:0108/183111:2787078:ERROR:desktop_root_window_host_win.cc(757)] NOT IMPLEMENTED
test\gpu\gpu_feature_browsertest.cc(305): error: Value of: GpuDataManager::GetInstance()->IsFeatureBlacklisted( gpu::GPU_FEATURE_TYPE_MULTISAMPLING)
  Actual: true
Expected: expect_blacklisted
Which is: false

> Update GPU feature tests to expect no GPU on Windows <=Vista
> 
> BUG=243476
> 
> Review URL: https://codereview.chromium.org/128893002

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/130693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243749 0039d316-1c4b-4281-b951-d872f2087c98