- 26 Oct, 2018 40 commits
-
-
Alexander Timin authored
Address a common pattern of usage by replacing MessageLoopCurrent comparison with explicit method call. R=gab@chromium.org TBR=gab@chromium.org CC=alexclarke@chromium.org BUG=891670 Change-Id: I0f6a7f2c65c9f39dd26abf592dc59efc14b07f57 Reviewed-on: https://chromium-review.googlesource.com/c/1296499 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#603080}
-
Jeremy Roman authored
It doesn't add any functionality over v8::Date::New. Change-Id: Iec74a51f344309b382ed9170e4de0ed672326454 Reviewed-on: https://chromium-review.googlesource.com/c/1299836Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603079}
-
Stepan Khapugin authored
Changes the shortcuts background color to clear. Change-Id: I72d6ca59600fa29e191cf85144526aa573f828e9 Reviewed-on: https://chromium-review.googlesource.com/c/1296252 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#603078}
-
Alex Clarke authored
This patch adds ScheduleWork / ScheduleDelayedWork deduplication which improves the perf test results. Unlike ThreadControllerImpl this deduplication logic is main thread only because I'm assuming the overhead of the locks isn't worth it. Bug: 897751 Change-Id: I879ad904e41c820180712702c66c4afd66cb3fae Reviewed-on: https://chromium-review.googlesource.com/c/1301462 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Alexander Timin authored
Do not use MessageLoopForIO as it is used to post tasks anyway. R=gab@chromium.org TBR=gab@chromium.org BUG=891670 Change-Id: Ib255c6a5a5dd55c2654eaa284d43d7f78f06b244 Reviewed-on: https://chromium-review.googlesource.com/c/1299239 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#603076}
-
David 'Digit' Turner authored
The header was renamed in a previous CL, this one updates all users under third_party/blink. BUG=898787 R=skyostil@chromium.org, vollick@chromium.org Change-Id: I7af7fb328588132e5047e6c60ccec028fe516dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1301436Reviewed-by:
-
Owen Min authored
Bug: 898673 Change-Id: Ic61ce99371e3b466f4123691e2544e30afb65f0b Reviewed-on: https://chromium-review.googlesource.com/c/1298303 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603074}
-
chaopeng authored
Based on Windows folks reply, this scroll lagging issue is because the message hit test to wrong window (Intermediate D3D Window) and need to forward to the correct window (Chrome Legacy Window), but Chrome Legacy Window is holding the input queue lock so Intermediate D3D Window can not forward the message. This fix adding 3 window extended styles to Intermediate D3D Window: WS_EX_LAYERED | WS_EX_TRANSPARENT | WS_EX_NOREDIRECTIONBITMAP The first two should make the window transparent for input, and the third avoids allocating a bitmap that would otherwise be allocated with WS_EX_LAYERED. WM_PAINT, WM_ERASEBKGD and ClearInvalidContents() also removed because they unnecessary for transparent layered window. Bug: 871257 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic708b4d2a5a37f8e2e98e425c1be8b28de41d001 Reviewed-on: https://chromium-review.googlesource.com/c/1299342 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603073}
-
Daniel Bratell authored
Mostly it's about marking includes inside INSIDE_BLINK as // nogncheck Also some added dependencies on for instance //media to cover an include of "media/base/video_rotation.h" and on various mojo headers. There are five errors left which look like real layer violations. Bug: 800764 Change-Id: Ie63283def2dadc6c0b5933175551e9addb9da5ec Reviewed-on: https://chromium-review.googlesource.com/c/1299142 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Jochen Eisinger authored
This mirrors the calls on OAuth2TokenService::Observer::On{Start,End}BatchChanges. Bug: 897113 Change-Id: I6a436baf28f4bf629da8a9b037cd5ab04c644fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1296249 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603071}
-
Tim Volodine authored
Implement the WebViewClient.onReceivedLoginRequest callback for Android WebView in the Network Service enabled case. This patch makes sure the header is properly parsed and the callback executed. Also updates the test filter with the tests fixed by this patch. Tests fixed: -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginOnGoogleCom -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginOnNonGoogle -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginWithNullAccount BUG=893562,841556 Change-Id: I91bfb1e3d9ffb8783cc0952e0498f2e428976a7e Reviewed-on: https://chromium-review.googlesource.com/c/1292052 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#603070}
-
David Bienvenu authored
Use static initializer for condition_ member var instead of win api call. Bug: 891924 Change-Id: I61860a13f286389cf955a74d8e4b3e5c3d30bbb9 Reviewed-on: https://chromium-review.googlesource.com/c/1299916Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603069}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/954de5bd..cce05b09 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idd81927f8c1bc3605be07c330d3e10aa8988c6ab Reviewed-on: https://chromium-review.googlesource.com/c/1301560Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603068}
-
Xi Han authored
In this CL, the entire ResouceBundle is initialized in the ChromeFeatureListCreator. This prevents loading parts of the data pack earlier and then add it to the ResouceBundle when the full browser starts. Bug: 846846,729596 Change-Id: Ia254252288ead936bde8cb65b12cf2fecbfc106f Reviewed-on: https://chromium-review.googlesource.com/c/1292516 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/95dfa5223ac6..a5d543ce21cd git log 95dfa5223ac6..a5d543ce21cd --date=short --no-merges --format='%ad %ae %s' 2018-10-26 mbonadei@webrtc.org Set minSdkVersion to 16 for AppRTCMobile_stubbed_video_io_test_apk. Created with: gclient setdep -r src/third_party/webrtc@a5d543ce21cd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaa9936e687006c3a5db37a4da4f93e51ee1998ac Reviewed-on: https://chromium-review.googlesource.com/c/1301535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603066}
-
Maks Orlovich authored
Only true is ever passed here now, so this is latent. Change-Id: I1afd9c466aca857a99ac2cf932185aa899a228cc Reviewed-on: https://chromium-review.googlesource.com/c/1300036Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#603065}
-
Gaurav Dhol authored
base/process/memory_win.cc(35,2): error: Unsupported platform Bug: 893460 Change-Id: I207473a8d4dc7c4d5fc01dae10fde51db0bdfab2 Reviewed-on: https://chromium-review.googlesource.com/c/1298832 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#603064}
-
Asanka Herath authored
R=mmenke@chromium.org Bug: 884310 Change-Id: I0f14c7dfcb2a6c54e52ac4f18328095e4af78db2 Reviewed-on: https://chromium-review.googlesource.com/c/1300778Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#603063}
-
Zakhar Voit authored
This is a reland of 75d0995f I've fixed the start-up crashes with DCHECK enabled (see diff from PATCHSET-1 to PATCHSET-3). Original change's description: > Updated AllowedUILocales to handle preferred languages. > > Updated AllowedUILocales to limit not only the ui locales but also the > available preferred languages. Renamed AllowedUILocales to AllowedLanguages to > better indicate that. > > Bug: 579660 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Iae929216e164fe941e5e335a3ce2e7ff47dce0e3 > Reviewed-on: https://chromium-review.googlesource.com/c/1256570 > Commit-Queue: Zakhar Voit <voit@google.com> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597559} Bug: 579660, 695042 Change-Id: I5d499843fb500fa9d2852559dedc08adfd012da0 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/c/1280270 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603062}
-
Ross McIlroy authored
The V8 context shouldn't be accessed when generating context independent code. Convert some string equality operations which require a context to the StringEquals function which does not. BUG=chromium:898076 Change-Id: Ia9a01b27fa9fcfc0c19268a3c862f2174eda7e1d Reviewed-on: https://chromium-review.googlesource.com/c/1301459Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0607ea1bb336..f75bf6c00916 Created with: gclient setdep -r src-internal@f75bf6c00916 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id2397e8ea045abc3ce9f73236197d8de37b33111 Reviewed-on: https://chromium-review.googlesource.com/c/1301534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603060}
-
Alex Clarke authored
We don't need task timing on the UI thread, so this patch arranges for time only to be sampled if we have an observer that needs it. Bug: 897751 Change-Id: I5915efdb903813a574ca05cee316cb30fa75b39c Reviewed-on: https://chromium-review.googlesource.com/c/1297425 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
yoshiki iguchi authored
This reverts commit 3767b2ad. Reason for revert: This CL is innocent. I fixed the issue separately: crrev.com/c/1297853. Original change's description: > Revert "Show notification counter even on lock screen" > > This reverts commit 155c0b00. > > Reason for revert: This breaks the lock screen notification. > > Original change's description: > > Show notification counter even on lock screen > > > > - Unblock notifications in SessionStateNotificationBlocker > > - Hide the message center by seeing the session sate (previously, it > > saw the count of notifications) > > - Change height below scroll, by checking the visibility of message > > center (previously, it checked only the height) > > > > Bug: 893945 > > Test: manual > > > > Change-Id: I39d30d0949d0f44078193ab7e4859f66eeebf880 > > Reviewed-on: https://chromium-review.googlesource.com/c/1282426 > > Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601824} > > TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org > > Change-Id: I5b2ded9c9f3212ab3cd085a3ea0721e69b6fae45 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 893945 > Reviewed-on: https://chromium-review.googlesource.com/c/1296330 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601930} TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org Bug: 893945 Change-Id: Iaee3fc6e7dcb996be1406897b07f571991a7e3db Reviewed-on: https://chromium-review.googlesource.com/c/1301037 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#603058}
-
Christian Dullweber authored
Rebuild leveldb for LocalStorage when deleting all cookies. This will remove traces of deleted data from disk. This change adds a RewriteDB() method to leveldb.mojom and adds handling of error cases, where the database service becomes unusable and closes the mojo connection. TBR: michaelbai@chromium.org Bug: 823071 Change-Id: I639ce21d7578d19e45ea9b7329b6ccbdfab8b527 Reviewed-on: https://chromium-review.googlesource.com/c/1162172 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#603057}
-
Guido Urdaneta authored
It is easy to produce explicit universal cases for discrete sets of boolean values since there are only to possible values. This CL adds an specialization so that the common case of a set with {true,false} is considered universal. This helps simplify some of the constraints processing code for audio, which contains many boolean properties. Bug: 731170 Change-Id: Ie7cd41a161f9de93fbc13273d44d2cccaa217522 Reviewed-on: https://chromium-review.googlesource.com/c/1299004Reviewed-by:Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#603056}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bb69b988..954de5bd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I24da46138da7edfac9d4e51784e0327c58190ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1301555Reviewed-by:
-
Adam Rice authored
https://chromium-review.googlesource.com/c/1262055 introduced CHECK statements to BodyStreamBuffer::CloseAndLockAndDisturb to verify that the stream is not garbage collected during execution of the function. None of the CHECK statements have been hit, so we can reasonably conclude that this is not happening in practice. These CHECKs should not be included in a stable release, so remove them. BUG=882599 Change-Id: I6c132ffd81c6642df7f4d9628b76f108f24bc2ed Reviewed-on: https://chromium-review.googlesource.com/c/1296571Reviewed-by:
-
Adam Rice authored
Copy the the original values of selected DOM constructors, methods and getters to the binding object during global object initialisation. Then access them via the binding object in the V8 extras transferable streams implementation. This protects the implementation from modifications to the global object. Constructors copied: MessageChannel DOMException Methods copied: EventTarget.prototype.addEventListener MessagePort.prototype.postMessage MessagePort.prototype.close MessagePort.prototype.start Accessors copied: MessageChannel.prototype.port1 MessageChannel.prototype.port2 MessageEvent.prototype.data DOMException.prototype.message DOMException.prototype.name BUG=897046 Change-Id: I72e40951e5c45f51c957dfa277044a210b054675 Reviewed-on: https://chromium-review.googlesource.com/c/1291191 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Joshua Bell authored
Now that base::BindLambdaForTesting() can be used, tasks posted to the Indexed DB task runner in tests don't need to explicitly bring along ambient state. Also, use an explicit RunLoop's Run()/Quit() instead of RunAllTasksUntilIdle() where possible, and 'auto' for readability. Change-Id: Iede419cda01c166e8fe2047c901f528f687f940d Reviewed-on: https://chromium-review.googlesource.com/c/1298416 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Koji Ishii authored
fast/writing-mode/border-image-vertical-lr.html produces different results because, in legacy, block direction borders applied to inline boxes affect positioning of the line box in vertical-lr writing-mode, when they should not. This patch rebaselines it, and also adds a minimized test to check such borders do not affect line box positioning. Gecko, and WebKit fail the test. Edge passes this test, though it paints the border at the incorrect position. Testing the border positoin is not ref-testable and that it is not included. Bug: 636993 Change-Id: I2568d19dac7f7ea886a46d45620bc22feb172c53 Reviewed-on: https://chromium-review.googlesource.com/c/1301698Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603051}
-
Sami Kyostila authored
TBR=gab@chromium.org Bug: 891670 Change-Id: I66e545c6bdbf04333cbd9178f8af9f8b2419e543 Reviewed-on: https://chromium-review.googlesource.com/c/1301456Reviewed-by:
-
Fredrik Söderquist authored
All of the 'blink::*' directives should be unnecessary (now that the code is within Blink.) Remove the testing::StrictMock 'using' too, and just "expand" it at its single usage point. Change-Id: I3171d05f41364fa134c2ee781e93178d831d4eab Reviewed-on: https://chromium-review.googlesource.com/c/1301458 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603049}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4fa2f815257c..0d828e8bb275 git log 4fa2f815257c..0d828e8bb275 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 primiano@google.com Merge "trace_processor: Fix MacOS build (attempt two)" 2018-10-26 primiano@google.com Merge "Export symbols of ScatteredStreamWriter::Delegate" Created with: gclient setdep -r src/third_party/perfetto@0d828e8bb275 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib0dcb40563381f7c584d852130548d697c5a5d83 Reviewed-on: https://chromium-review.googlesource.com/c/1301533Reviewed-by:
-
Hitoshi Yoshida authored
Generally we use type names of each member as accessor names in generated union implementations. But for annotated types, the difference from its inner type is the conversion from V8 values to native values. i.e. NativeValueTraits. It means that their C++ accessors for each member work as same with their inner types' ones. And it is annoying to use annotated type's names for other objectives like IsLongClamp() and SetStringTreatNullAsEmptyString("foo"). So this CL makes the generator to use inner type names in IDLUnion member accessors. It means we do not have to consider if a member has extended attributes or not, when we access the members. Bug: 894469 Change-Id: I80a6ea2366405a7ae344d740e1611cea20b88d9e Reviewed-on: https://chromium-review.googlesource.com/c/1280382 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603047}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f6d8fb43536..0607ea1bb336 Created with: gclient setdep -r src-internal@0607ea1bb336 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia9831c1abcd61ddcaf3e05cb216c8f78181a2a70 Reviewed-on: https://chromium-review.googlesource.com/c/1301236Reviewed-by:
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: If241906ba3024ff6f4aa6ef7a5ff06dc682a130b Reviewed-on: https://chromium-review.googlesource.com/c/1293255Reviewed-by:
-
Mario Sanchez Prada authored
Reimplement callbacks GoogleSigninSucceeded and GoogleSignedOut as OnPrimaryAccountSet and OnPrimaryAccountCleared, from IdentityManager. Bug: 887461 Change-Id: I6a0f5758b8c07f21a8b06b4993a9f58528ee7c7e Reviewed-on: https://chromium-review.googlesource.com/c/1261637 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603044}
-
Christian Dullweber authored
The style guide says that static functions shouldn't be in the global namespace. TBR: dschuyler@chromium.org, dtrainor@chromium.org Change-Id: I48230748abf496eb312ad0901bf88cbbf9307bcc Reviewed-on: https://chromium-review.googlesource.com/c/1299233 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#603043}
-
Yi Su authored
Generate a searchable URL when a <form> is submitted. When the Js file is injected, it will add listeners to all the submit element(i.e. <button> and <input type="submit"> in all <form>s. This CL doesn't add listeners on <form>s' "submit" events. Most of the code in this CL is based on code from Blink: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/exported/web_searchable_form_data.cc Bug: 433824 Change-Id: Ib56808281265e5605d48148d4504eee0e51d1743 Reviewed-on: https://chromium-review.googlesource.com/c/1293914 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#603042}
-
Greg Thompson authored
ExternalProtocolHandler::GetBlockState queries for a value in a dict pref. Previously, it was using DictionaryPrefUpdate to get the dict. This causes the pref file to be written out in its dtor. This CL switches to ordinary read-only ops to avoid spurious pref file writes. BUG=none R=benwells@chromium.org Change-Id: I9a42441cdee70e7bd9b0f67afefb67d411bef2dd Reviewed-on: https://chromium-review.googlesource.com/c/1298715Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#603041}
-
