- 09 Jul, 2019 40 commits
-
-
Kyle Milka authored
The hardcoded "Upload from device" and "No background" tiles were slightly misaligned. Partly due to a single character space being inserted between inline-block elements. Fix the issues by moving some properties between elements and setting the font size of the parent to 0px. This fixes some problems with keyboard navigation as well as the slight visual misalignment. Bug: 937570 Change-Id: Iab866d50ae288d9bf4d5dc12280053253e6f3767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691260Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#675696}
-
Gabriel Charette authored
Timings that should remain real-time even under MOCK_TIME are now explicitly using subtle::TimeTicksNowIgnoringOverride(). ThreadPoolClock defaults to DefaultTickClock in this CL but will be overridden under ScopedTaskEnvironment's upcoming multi-threaded MOCK_TIME mode @ https://chromium-review.googlesource.com/c/chromium/src/+/1686776 Ultimately, when MOCK_TIME mode always mocks TimeTicks::Now(), we will be able to remove this and use TimeTicks::Now() again directly for these calls. Bonus #1: Gets rid of a call to DeprecatedGetMockTickClock(). Bonus #2: Added thread annotations to DelayedTaskManager::queue_lock_. R=fdoray@chromium.org Bug: 946657, 789079, 905412 Change-Id: Ief86338388b670ad9ddafb926e6817df6d96a95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687028 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#675695}
-
Aya ElAttar authored
On trying to access the locked screen mode in split screen (tablet mode), the browser crashes due to NULL pointer reference. Bug: b/119853019 Change-Id: Idaf715a9d48f3979243b83bd9fa9e59706f09122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685101Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#675694}
-
Michael Ludwig authored
Bug: 982289 Change-Id: I475fa95c7ed0f31be93a53f99f35b1e56bb710c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692967 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#675693}
-
Ioana Pandele authored
This CL removes the divider between the footer commands and adds one before the footer commands. Screenshots and spec can be found on the bug. Bug: 980455 Change-Id: Ia40e3a3bd83a5e135087eff2a11573dfc944ee1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691031Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#675692}
-
Victor Hugo Vianna Silva authored
Currently, the is_icon_url field in ParsedFaviconPath is only set to true for urls pointing to .ico files. We change the underlying regex used so as to also accept .png files. Bug: 982217 Change-Id: Iab345655eadebe5f279468b0d333b297064338bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692167 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#675691}
-
Xiaocheng Hu authored
The calc unit types no longer make too much sense after we have split CSSMathFunctionValue from CSSPrimitiveValue, as: - They complicate UnitType by introducing some entries that are not really unit types - If a client really relies on these calc types, they can refer to CSSMathFunctionValue::Category() instead Hence, this patch removes them for code health. Bug: 979895 Change-Id: I9c8720bd68d64f756a6c4a251f59666350649b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691554Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#675690}
-
Mandy Chen authored
This patch changes the presubmit script so that when any module.json, .grd, and .grdp files change, the script that autofixes any localizable string inconsistency will run. This is because these files also contain localizable strings, in addition to .js files. Bug: 941561 Change-Id: I3aaba696122757ccb5e4e83f49c50503e459000f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648912Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#675689}
-
Koji Ishii authored
NGFragmentItem is a lighter weight version of NGPhysicalFragment we plan to use for inline boxes and text runs. As seen in InlineBox v.s. LayoutObject, inline boxes and text runs do not need all the information normal block boxes need, and they are easier to handle when presented as a flat list. Design doc: https://docs.google.com/document/d/10vJ6wdyEdeGkmcotKBZ9h3YtDzw5FIpDksa8rCHVFuM/edit#heading=h.iakhx55u4iw4 Bug: 982194 Change-Id: I01c2c7b12ec9c2ef9c866c08f3132eb57d15b7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692109 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#675688}
-
Gabriel Charette authored
Get rid of raw |thread_pool_| member in favor of keeping more const traits around. This makes an upcoming CL cleaner, extracted from it http://chromium-review.googlesource.com/c/chromium/src/+/1686776. R=fdoray@chromium.org Bug: 946657 Change-Id: I26d8675e3e643dd938cff7105232f90fba9c52de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687025 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#675687}
-
Koji Ishii authored
This patch changes |NGOutOfFlowLayoutPart::LayoutCandidate()| not to use a cached result if it has an inline container. |NGLayoutResult::OutOfFlowPositionedOffset()| has an offset relative to the inline formatting context block. When an out- of-flow object has inline contianer, this offset may change without setting |NeedsLayout()| to the out-of-flow object. Bug: 981686 Change-Id: Ib8376f791af0b95f6c2b6e5c2361b6a887c74e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692107 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#675686}
-
Victor Hugo Vianna Silva authored
Bug: 980220 Change-Id: Ib624572d19f5f9ea28b5e2db67374bdfb2fa1e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683518 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#675685}
-
Rakesh Soma authored
Bug: 979927 Change-Id: Ie35300e7fce923490c4885582d2b1ab4b5b53ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688617Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#675684}
-
Xianzhu Wang authored
This reverts commit a0d2f696. Fix crbug.com/980086 by calling MarkAncestorChainForFlagsUpdate() from DirtyStackingContextZOrderLists() to ensure z-order lists are updated in UpdateDescendantDependentFlags() when scrollbar existence changes. Original change's description: > Revert "Implement correct z-order of overlay scrollbars" > > This reverts commit 128c7578. > > Reason for revert: crbug.com/980086 > > Original change's description: > > Implement correct z-order of overlay scrollbars > > > > Previously we implemented z-ordering of composited overlay scrollbars > > in GraphicsLayerTreeBuilder which reparents overlay scrollbar > > GraphicsLayers of scrollers with higher z-order scrollable contents. > > The overlay scrollbar GraphicsLayers are inserted into the > > GraphicsLayer of the stacking context above all scrolling contents > > GraphicsLayers, to ensure the overlay scrollbars to be above any > > scrolling contents. > > > > However, the logic doesn't work for all overlay scrollbars in > > CompositeAfterPaint and non-composited scrollbars in > > pre-CompositedAfterPaint because these scrollbars are not controlled > > by GraphicsLayerTreeBuilder. > > > > This CL let PaintLayerStackingNode also manage z-order of overlay > > scrollbars. If any scroller with overlay scrollbars has any stacked > > contents that have higher z-order than the scroller, the overlay > > scrollbars will be inserted after the highest z-order scrolling > > contents in the z-order list. > > > > Also add a paint phase for overlay scrollbars. This is not strictly > > necessary for now because all scrollers with overlay scrollbars are > > self-painting. However, this allows us in the future to let scrollers > > not self-painting to achieve perfect painting order. > > > > Bug: 918155 > > Change-Id: Iccae1cbcde8de46158267e45bab2a13a027db3ec > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1461536 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#672748} > > TBR=wangxianzhu@chromium.org,chrishtr@chromium.org > > Bug: 918155, 980086 > Change-Id: Icccb9ec7af7ef424306afade0c80015e4c5c5c6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684022 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#674526} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918155, 980086 Change-Id: I5f001477512de5ebbaa7a4fe62c1ef1bb76e442a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691331Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#675683}
-
Chris Lu authored
This change adds coordinator and mediator classes that will manage the badges for the LocationBar. The consumer of BadgeMediator will conform to the BadgeConsumer protocol. Bug: 976901 Change-Id: I70d7f105e707ac38f3d348ed5eea3d62cd2af281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686955 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#675682}
-
Andrew Grieve authored
This tripped me up when trying to use --wait-for-java-debugger, and breakpoints were not being hit. Change-Id: Ic87fe921686aa071d05b6d62984320d1e9865f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691083Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#675681}
-
Monica Basta authored
Deprecated Profile.TimeToOpenUserManager and replaced it with Profile.TimeToOpenUserManager2. The new histogram has a wider range with a minimum of 1 ms and a maximum of 1 min. This historgram is needed at least till M82. Bug: 975562 Change-Id: Idcb21f2f665b2dea49c180208ff1c7254f3e43ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692579Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Monica Basta <msalama@google.com> Cr-Commit-Position: refs/heads/master@{#675680}
-
Kevin McNee authored
This test also fails on Windows. Tbr: bmcquade@chromium.org Bug: 981058 Change-Id: I069ae88e0b4c762db65fa0e6707b0d49cc9bf19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692869Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#675679}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I888d3f5a1fb5f01b36ba5557618c64372d3920ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691938Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675678}
-
Takumi Fujimoto authored
Delete JS/HTML/CSS files for chrome://media-router and its tests. We do not remove files related to chrome://media-router-internals because that is still in use. Bug: 900246 Change-Id: I096205009b1f88d9655e08ff88e56d47917ada36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488058Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#675677}
-
Andrew Grieve authored
Decided it was better to just implement directly in the recipe. Bug: 978942 Change-Id: Ieace5e32fab353a083cfc331b81d6b4dcf77bc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692020 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#675676}
-
Michael Lippautz authored
Bug: 937117 Change-Id: I1be85af0d2c9a20ee139627d591fcb2208735e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692410 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#675675}
-
Jeremy Roman authored
Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Change-Id: I38d61e602571f750c118c1aba3376126a8e2d03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691856Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#675674}
-
Ali Juma authored
CWTChromeDriver treats the current tab as the target for actions such as loading a URL or injecting JavaScript. However, the WebDriver protocol's notion of "current top-level browsing context" doesn't always match the concept of "current tab". In particular, it's possible for a background tab to be the current top-level browsing context. This CL makes CWTRequestHandler keep track of the target tab id for WebDriver actions, and passes this tab id to CWTWebDriverAppInterface methods so that they use the corresponding WebState. The target tab is set to the current tab when a new session is started. After that, the target tab only changes when the WebDriver client sends a "Switch to Window" command (this corresponds to a call to CWTRequestHandler::SwitchToTabWithId). Bug: 673423 Change-Id: I31582253ca571c123573df91b70c7ac71bb32669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685326 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#675673}
-
Reilly Grant authored
This change implements SerialPortUnderlyingSink and hooks it up to the native and V8 extras implementations of WritableStream. There are many potential improvements but this provides the basic necessary functionality. Bug: 893334 Change-Id: I609f580fefa731ce51d4a6ba81849b0c4400ad99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688225Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#675672}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd5a318c..d406d536 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia1be533a2800693d167727492488164332b65f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691966Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675671}
-
Mehran Mahmoudi authored
Bug: 967456 Change-Id: If527a5ea8372b3a2d478d322bbeaac559577ff0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689925Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#675670}
-
Dave Tapuska authored
No behavioural changes are expected. Previously the FrameInputHandler was not reset when the renderer died. This would cause any messages sent on it to go nowhere. It is more applicable to reset it in the InvalidateMojoConnection code. This causes some upstream changes in WebContentsImpl, ImeAdapter to check that the FrameInputHandler ptr is not null. BUG=955171 Change-Id: I9f45b9d3c0b9efec01d1432e056c7e83955c46ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685912 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#675669}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Ifd7365529f76f4de448e8de61e0d328a50e0b7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692204 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#675668}
-
Steven Bennetts authored
Since the Mash effort is on hold, this does not need to use a mojo API, a public interface and singleton getter is the common pattern for chrome implementations of ash interfaces. Bug: 958210 Change-Id: I7e51f39d3d25ce1a4fd388f8ebf053499d0d6ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672169Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#675667}
-
Lukasz Anforowicz authored
Some CORB tests cover quite a few scenarios and were taking over 10 seconds to run on my machine: WithoutOutOfBlinkCors/CrossSiteDocumentBlockingTest.BlockImages/0 (10227 ms) WithOutOfBlinkCors/CrossSiteDocumentBlockingTest.BlockImages/0 (10227 ms) After this CL, these tests are split into slightly smaller tests: WithoutOutOfBlinkCors/CrossSiteDocumentBlockingTest.BlockImagesWithSniffing/0 (5244 ms) WithoutOutOfBlinkCors/CrossSiteDocumentBlockingTest.BlockImagesNoSniffing/0 (2097 ms) WithoutOutOfBlinkCors/CrossSiteDocumentBlockingTest.AllowImagesWithSniffing/0 (5244 ms) WithOutOfBlinkCors/CrossSiteDocumentBlockingTest.BlockImagesWithSniffing/0 (4982 ms) WithOutOfBlinkCors/CrossSiteDocumentBlockingTest.BlockImagesNoSniffing/0 (2359 ms) WithOutOfBlinkCors/CrossSiteDocumentBlockingTest.AllowImagesWithSniffing/0 (5244 ms) Bug: 981376 Change-Id: I0f9a0dc830640c1cc9f9a9e74d91d52f73b6e304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687279 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#675666}
-
Majid Valipour authored
WebAnimations spec has two keyframe concepts: A) keyframes [1] B) computed keyframes [2] A key difference is that in A property values remain unresolved while in B these properties are resolved (e.g., shorthands expand to long hands etc.) KeyframeEffect.getKeyframes() is expected to return (A) but our current implementation only keeps around (B). This CL introduces the following changes to bring us closer to the specified behavior: 1. Introduce a new map <property, value> in StringKeyframe representing (A) 2. CSS property pairs are added to this map as long as they parse correctly [3] 3. Use the new map to produce the result of getKeyframes() There is some additional special handling required for shorthand properties because Blink CSS parser does not really produce any shorthand values. As a shortcut this patch introduces a new type of css value (`CSSKeyframeShorthandValue`) which represents a shorthand by encapsulating all its relevant longhand property/value pairs. Note that we continue our old behavior for SVG and Presentation attrs which will be switch over in follow up patch. [1] https://drafts.csswg.org/web-animations/#keyframes-section [2] https://drafts.csswg.org/web-animations/#calculating-computed-keyframes [3] https://drafts.csswg.org/web-animations/#process-a-keyframes-argument step 8 TEST: - web-animations/interfaces/{Animatable, Keyframes} => PASS previously failing tests - Added two new test cases in above covering animated custom props - external/wpt/web-animations/interfaces/KeyframeEffect/getKeyframes.html => New test to cover serialization Bug: 816956 Change-Id: Icc8e0bc4a0ee3019ad7d2c566aacb9d3aee0ffe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634393 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#675665}
-
Robert Phillips authored
As of the Skia-side CL (which rolled into Chrome at r675395): https://skia-review.googlesource.com/c/skia/+/225720 (Make BGRA_8888 renderable & textureable by default in the mock context) this customization of the mock options in Chrome is no longer required. Skia is switching to having the GrMockOptions be based on the GrColorType. See: https://skia-review.googlesource.com/c/skia/+/225538 (Make Mock GrBackendFormat use GrColorType (instead of GrPixelConfig)) so this utilization of the GrPixelConfig in Chrome must be removed. Change-Id: I08dcaf0b3c425a540ef1799f1953ce8a41713dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689333 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#675664}
-
Rouslan Solomakhin authored
Bug: 980249 Change-Id: Ia90333263e0fb5e8253c8897f3e53967e32015d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687795 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#675663}
-
Fredrik Söderquist authored
Change-Id: Ie303f3a7625cb31070afe4a17f1d67f04f565d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690879Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#675662}
-
Yi Gu authored
The function TransformPointToTargetCoordSpace is no longer used. Bug: None Change-Id: I23a153cb8da555ae50160c8324a8787241dc8ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692446Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#675661}
-
Aran Gilman authored
The most important kind of image for us to invert are icons, since not inverting them can have a significant negative impact on user experience. However, inverting most other kinds of images also results in a negative user experience. In the long-term we want a proper classifier designed specifically for detecting icons, but for now we can adapt the existing classifier by simply not classifying larger images. Bug: 980987 Change-Id: I0c9fbd984eb84b24f5fba4c814878a48c7b3f80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688289 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#675660}
-
Peter E Conn authored
New Tab Page and Webapp Disclosure junit tests are failing on touchless builds. For the Webapp Disclosure these tests are not relevant - we would never show a disclosure on a touchless device. For the New Tab Page tests, they should probably be updated to test the touchless specific functionality, but I'll leave that to their team. For now the tests are just being disabled. Bug: 981871, 981870 Change-Id: I3c88fbd26cad3e67328f4c80c1101b9b7edc65fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692164Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#675659}
-
Sadrul Chowdhury authored
This reverts commit 1189f593. Reason for revert: Broke official builds on Windows. https://ci.chromium.org/p/chrome/builders/ci/win64-builder-perf/91116 https://ci.chromium.org/p/chrome/builders/ci/win32-builder-perf/91061 Original change's description: > Add GN args for using orderfile for Chrome OS > > This patch adds GN args to use an orderfile for linking Chrome. > By default, it's pointing a path will be updated by autoroller. > Chrome ebuild can also override the path to test a custom orderfile. > > This patch also consolidates the efforts across Android and Windows, > to have a configuration of using orderfile in build/config/compiler. > > Bug: chromium:950627 > Test: Chrome builds locally on Chrome OS. Android and Windows is not tested. > > Change-Id: If9fd06368da81e02488cb991c3b7490e6ed91363 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672231 > Commit-Queue: Tiancong Wang <tcwang@google.com> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675412} TBR=llozano@chromium.org,hans@chromium.org,dpranke@chromium.org,agrieve@chromium.org,gbiv@chromium.org,bsheedy@chromium.org,manojgupta@chromium.org,tcwang@google.com Change-Id: Ifca0a426bf7fc616c9e7e0d7033a55da4de9865f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:950627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692238Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#675658}
-
Ella Ge authored
GetFrame can be null Bug: 981232 Change-Id: I25d504a32c1a9d14b9274e861edbadc6eafa6029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691144Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#675657}
-