- 02 Oct, 2020 40 commits
-
-
Alan Cutter authored
This CL updates our preinstalled web app replacement flow to disable the web app if the Chrome app it's meant to replace has been disabled by admin policy. This is to prevent default apps appearing on enterprise devices during web app migration when they were originally being blocked as Chrome apps. Bug: 1131338 Change-Id: I44a5d0c3c9b547c28a5c3b664e53844335ab3da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425549 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813060}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/3c3e8905ad7e..89ec3381ca3d $ git log 3c3e8905a..89ec3381c --date=short --no-merges --format='%ad %ae %s' 2020-10-01 nharper Remove unmatched clang diagnostic pop #pragma 2020-10-01 renjietang Rename QuicSession::OnStreamDoneWaitingForAcks() to MaybeCloseZombieStream(). 2020-10-01 bnc Pre-allocate storage in http2::HuffmanEncode(). 2020-10-01 wub Set initial self address for all server QUIC connections and client connections that know its own address. 2020-10-01 fayang Internal QUICHE change 2020-09-30 renjietang Remove QuicSession::stream_map_size(). 2020-09-30 fayang Explicitly specify the encryption level of processed packets in QuicConnectionTest. 2020-09-30 renjietang Reject HTTP/2 only frames in HTTP/3. 2020-09-30 bnc Use QuicheTest and quiche_test.h in third_party/http2. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: If12d7a76d4d04b8eff02b9bb8ac73f9238eec5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444369 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813059}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b09f16ee7aeb..eb1df14b18a0 2020-10-01 jonahr@google.com Suppress MultisampledRenderToTextureBenchmark on Pixel2/GLES 2020-10-01 syoussefi@chromium.org Skip MSRTT tests on Nvidia/Windows7 2020-10-01 b.schade@samsung.com Vulkan: Change sampleCoverage calculation 2020-10-01 lehoangq@gmail.com Metal: Implement transform feedback If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1134286 Tbr: jonahr@google.com Test: Test: dEQP-GLES3.functional.multisample.fbo*sample_coverage* Change-Id: Ic0c7515d2db65c0059c08578fbd0d278069ba5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444160Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813058}
-
Noel Gordon authored
Linux Puppeteer startup in tests.js can sometimes crash. Fix this: add chrome --no-sandbox arg to send to the Puppeteer browser startup. Test: piex/tests.sh does not crash No-try: true Bug: 1132695 Change-Id: I27cccfdb0d49f46dcb07a343dfb474b0d9878331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442910Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813057}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601575120-46ddcdbe4da420985f324196a05692689b215d89.profdata to chrome-linux-master-1601596804-53a4ffa238a2dd27e204a4d6f101c3543de8d4a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ib033a2bff33e97e7ea90f44a030556a107363881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444709Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL makes the SharedImageBackingFactoryGLTexture notify the GPU watchdog that progress is being made around the code that requests memory allocation or texture upload. This is an attempt to improve the crash rate due to allocation taking a long time (as opposed to it being a GPU hang). Bug: 1082197 Test: added unit test coverage. Change-Id: Ic9530fd53df95d5ce0b675231c0ac52e682c69e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215256 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#813055}
-
Xianzhu Wang authored
Previously rasterize_and_record_micro benchmark measured record time through ContentLayerClient::PaintContentsToDisplayList(), which had mismatched the reality when we switched to synchronized painting which is done as a step of document lifecycle update. It also didn't work in CompositeAfterPaint. Now measure LocalFrameView::RunPaintLifecyclePhase() for record times. It's called from the RasterizeAndRecordBenchmark through LayerTreeHostClient::RunPaintBenchmark(). GraphicsLayer now generates cc::DisplayItemList() during painting, so that it is included in the measured time, also is consistent with what we do in CompositeAfterPaint. Add two new metrics: - raster_invalidation_and_convert_time: it covers raster invalidation and cc::DisplayItemList conversion, which replaces the old record_time. - paint_artifact_compositor_update_time. 'record_time' now means differently than before. Previously it measured cc::DisplayItemList conversion (now measured by 'rasrter_invalidation_and_convert_time'). Now it measures time of forced painting without any invalidation. This is not realistic, but we can see how the caching algorithm work in nearly fully cached situation. Bug: 922642 Change-Id: Ic4e8e50288208f76df4e51ba154bc4a95c60f5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437735 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#813054}
-
Jimmy Gong authored
This is a reland of 3792c739 Reason for reland: This is safe to reland as the original revert was due a merge conflict with crrev/2428735 which has been reverted. This reland will land first. Original change's description: > Add additional states to FindMyDeviceController > > Fully implements the FindMyDeviceControllerImpl class. This change > also features a new state: kRingingNotAvailable. > This state is only set if the DoNotDisturb is enabled. > > Bug: 1106937 > Test: chromeos_components_unittests > Change-Id: Ifeb4dd88ea19ad6949bad2a92d840f392d7ccd47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438773 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812962} Bug: 1106937 Change-Id: Id8400f68f1980dc8288d7c1b2545810721844249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444410 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813053}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ica70ae52f632e5f4236301aa557a5844cec4bb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436412Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813052}
-
Tal Pressman authored
The various AgentSchedulingGroupHost::Create* methods assume that the caller already called InitProcessAndMojos, so there is no need to call SetUpMojoIfNeeded from them. Instead, replace it with DCHECKs to make sure the process is initialized and the mojo remote is bound. Bug: 1111231 Change-Id: I95736b806adaabceae560131dd2a816dfc614f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437993Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813051}
-
Jesse Schettler authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/d5ad6a50d168..5df72efed1de $ git log d5ad6a50d..5df72efed --date=short --no-merges --format='%ad %ae %s' 2020-09-15 fletcherw system_api: add scan dimensions to lorgnette API Created with: roll-dep src/third_party/cros_system_api Also, update the scanning mojom file and type converters to handle the new enum value in lorgnette_service.proto. Bug: None Change-Id: Ib425f99fdacaa85cd9559b567a2d5b15e61d02e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443271 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813050}
-
Nate Fischer authored
No change to logic. This autogenerates GpuFeatures.java from the c++ feature definitions using java_cpp_features. This updates ProductionSupportedFlagList to depend on the new constant. This rewrites some feature definitions to conform to java_cpp_features's supported syntaxes. Fixed: 1132502 Test: autoninja -C out/Default system_webview_apk Change-Id: I9a5b562e7b034d5ed8606bff8dd218ca2d5e0790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432195 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813049}
-
Jie Jiang authored
This patch adds and implements the new interfaces/methods for Bluetooth socket. Compared with the old interfaces, the new ones: - add a sock_type field (RFCOMM or L2CAP); - pass Android socket flags directly instead of parsing those into BlueZ flags on Android side, to avoid expose two groups of constants in Android. Also marks the old methods as deprecated, which will be removed when the corresponding patch(es) are landed in both P and R. Android patch see: http://ag/12418518 BUG=b:163099156 TEST=manually tested on octopus with P to make sure the old code path for RFCOMM still works; also see the TEST line in Android patch for R. Change-Id: Ic35732e4e9ee6a45599f9aecd6b2695b60dd124a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366445 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#813048}
-
Jazz Xu authored
This CL changes the media controls' behavior in system menu such that it will be in an empty state instead of hiding after all media have stopped playing. Bug: 1133871 Change-Id: I5e42410abf121c94756e18e9a2cd0eb14375e2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441678Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813047}
-
minch authored
Bug: 1133952 Change-Id: I843e304131eea6f120be6f32f00b427d1f6477df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444453Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#813046}
-
Lei Zhang authored
Adjust callers to call base::Value::ListStorage::reserve(), or use an alternative method to do what they want. Remove a few more deprecated base::Value calls along the way when convenient. Also update comments in base/values.h to remove references to methods that no longer exist. Bug: 646113 Change-Id: Id28a964676e9119687936050a28a19dfa60bc1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437730Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/110e287f7da0..444cee2905f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com,karandeepb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1098447,chromium:1124873,chromium:1128750,chromium:1132967,chromium:1134049,chromium:912681 Tbr: noel@google.com,karandeepb@google.com Change-Id: Ief77da176d288ae88174acbfbc1ccb46766961ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444159Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813044}
-
Cathy Li authored
clipping. This fixes clipping for feed header IPH. Bug: b/168859910, 1130592 Change-Id: I19efd691190f05826c7e1ecfd288f8d6bf4df6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442361 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#813043}
-
Ian Barkley-Yeung authored
Untrusted input? Complex C++ parsing code? Put a fuzzer on it! Bug: chromium:1121816 Change-Id: Iddb65e2568d88bbd32157bae49ceacaa1755c04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443396 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#813042}
-
Karandeep Bhatia authored
Change it to accept a dictionary instead of individual arguments for better future compatibility. Also rename it to setExtensionActionOptions for further flexibility. Note that this is a breaking change but we'll reach out to the current users to make sure that they update their extensions. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1131746 No-Presubmit: True Change-Id: I6b800985ca2eaff4f52900b984ef5519e3fac266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429260Reviewed-by:
-
Bailey Berro authored
Enables clients to implement the MemoryUsageObserver interface and register themselves as an observer in order to receive periodic updates about the usage of memory on the device. Example use - crrev.com/c/2424505 Bug: 1128204 Change-Id: I17eaf3b8eb58c287e96d8ff217d3356d3d84c06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439475Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#813040}
-
Tomasz Wiszkowski authored
This change introduces a very simplistic MostVisitedTilesProcessor. The only functionality wired up at this point is updating the Omnibox Editing text with the associated URL and very basic keyboard navigation. Bug: 1106109 Change-Id: Iac224b2c625eb11d9e1a99ff21465c2b3680b3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437690 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#813039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b677e985297d..69e30b23c45f 2020-10-01 vadimsh@chromium.org [lucicfg] Update to 1.21.0. 2020-10-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1133442 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I924ca88e53208345b4446a4a55b016a13a19e019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444152Reviewed-by:
-
Jeremy Roman authored
dtapuska already owns and reviews blink/public/common/. (Sorted because these lists get harder to read the longer they get.) Change-Id: I3fb849854948bcaf01847b93add9f133ad7b5026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442632Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813037}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ab4a49259c0e..7f0e83e82ba9 2020-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3211fba0..fa57522d (812728:812874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3a95b2f5523f296e04eaf3c9b63b908f8df3c7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444158Reviewed-by:
-
Akihiro Ota authored
This change: 1. Adds the earcons lesson to the interactive tutorial. Functionality for this is included in buildEarconLesson() in i_tutorial.js 2. Adds a test for the lesson. 3. To reduce flakiness, we needed to change how we wait for the tutorial. Now, we wait for all lesson content to finish loading before we perform commands and make assertions. focused. This change also includes an automated test. Test: Manually verify on-device that earcons are played when text is Change-Id: I89d2f3c050a74b8d35df47091d88ba443105dadb Fixed: 1124078 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426968 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813035}
-
Daniel Classon authored
Turns the swap mouse button toggle into a dropdown with Left button and Right button as options, as per the bug. String screenshots: https://storage.cloud.google.com/chromium-translation-screenshots/0de32bdc0a9e5c95680629877c323c11d242cf03 https://storage.cloud.google.com/chromium-translation-screenshots/037c4cf7a5c655f6e15a4ca3c906230359440d50 Fixed: 1132518 Change-Id: I55836c82115a2fc1473d4863b2f96ed9b94f4a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436750 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
Naoki Fukino authored
Lacros-Chrome and ChromeOS-Chrome use different animation curves for fling scroll. To make them consistent, this disables ExperimentalFlingAnimation flag for Lacros-Chrome as ChromeOS-Chrome doesn't enable it. Bug: 1129263 Change-Id: Ibe4c80f08f077a951e529f3a670f7db914dc1394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439816Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#813033}
-
minch authored
Make UnifiedSliderButton as ImageButton only and decorate it with kIconButtonSmallOrMedium. Bug: 1133748 Change-Id: Ic154c6ef63770d66ae4d09eb4b3cf1190be056cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441190 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813032}
-
Andrew Beggs authored
For AArch64 a restricted ptrace call will result in an error when trying to access PAC keys. Malicious code could derive the key via the system call and potentially defeat any PAC control-flow integrity checks. The ptrace call to set registers, PTRACE_SETREGSET, is already blocked, so they cannot be changed. Change-Id: I6954e3b038912871a964d413a305c69f8a57d543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438130Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#813031}
-
Guillaume Jenkins authored
Adds a metric to record the number of Chrome Siri Shortcuts the user has created in the Siri Shortcuts app. This is recorded once at startup, as a delayed startup task on the IO thread (to avoid hangs while querying iOS for the list of shortcuts). Bug: 935211 Change-Id: I70766050ba7faf5fb343e3515c98ff6ddca98bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429306 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813030}
-
David Tseng authored
R=anastasi@google.com, dmazzoni@chromium.org Fixed: 1127250 AX-Relnotes: n/a Change-Id: Ib716aedf39c80333ef5181cf2a40f6d40e52e298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443535Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813029}
-
Darwin Huang authored
This simplifies the interface a bit, and allows us to avoid any potential issues with argument ordering in RenderFrameHostImpl::FromID, or otherwise. Change-Id: I0c9d9fe921a5b0ca8765e9d7c8ae6196dc329e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419663Reviewed-by:
-
nancylingwang authored
Fix unit tests when the flag is disabled. BUG=1083331 Change-Id: Ic4cdc5a089ca672b4a79b345eff18ebcb4ccd82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442989Reviewed-by:
-
bttk authored
Bug: 1133482 Change-Id: I9745a5d58c3a933e3c59059976f1c47fe210886c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439430 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia5b01e969f167acb60a408fc94eaa772e7c6a951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444157Reviewed-by:
-
minch authored
Bug: 1133748 Change-Id: Ie076a61324e6337e0f5f7c559a592a56f33203d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441287 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Piotr Bialecki authored
Step 3/N of moving ARCore device into device/vr. Previous steps: 1. https://crrev.com/c/2341811 2. https://crrev.com/c/2405538 Changes: - create new target, device/vr/android:vr_android, with mailbox to surface bridge and web xr presentation state - move most of ARCore implementation out of chrome/browser/android/vr:vr_android target, into device/vr/android/arcore:arcore - remove default constructor from ArCoreDevice - it needs to be created by ArCoreDeviceProvider that hands it the ArCoreJavaUtils instance - moved MailboxToSurfaceBridge to a new component, components/webxr, to address the layering violation - it now implements the interface defined in device/vr/android and can be provided to lower layers by the consumers that can depend on content/ - other mechanical changes related to the move Bug: 843374 Change-Id: I039a6e7038e13d6b9f6ab2df9eb734ea2fdf4027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413288 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#813023}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6b79223314a5..8c88c750bd45 2020-10-01 bsheedy@chromium.org [Devil] Add install sanity check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132297 Tbr: skyostil@google.com Change-Id: I4286da640e44824b892e32ca5d699f11bb7afb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443775Reviewed-by:
-
Jie Jiang authored
L2CAP LE socket is added in Android from Q and these two patches implements for ARC++. The code for this new socket is quite similar to the existing code for RFCOMM. Since we cannot just change the name of an existing interface, in the next patch, we will add two new interfaces (listen and connect socket) which can be used for both RFCOMM and L2CAP, and deprecates the old ones, when both P and R get the corresponding patch(es). This patch doesn't change any functionalities. It just refactors the current code a bit, including: - Renaming RFCOMM-specific stuff into more generic ones; - Changing to calling bind() for both listen and connect sockets: calling bind() for RFCOMM connect sockets is not required but needed by L2CAP LE sockets; - Changing type of |channel| in some methods to uint16_t for PSM value; - Fixing a wrong usage of PLOG. BUG=b:163099156 TEST=RFCOMM tests in cts verifier on octopus Change-Id: If09794e00fa60599e8c9e9ec941d06cfdeb28741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368615Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
-
