- 14 Jul, 2017 40 commits
-
-
Josh Karlin authored
Labels frames identified as ads by the SubresourceFilter as ads. Also adds an AdType to each frame tracked by AdsPageLoadMetrics. When it's time to record the metrics, the same logic is applied once to collect stats for each ad type. There is also an additional ad type, "All", which records stats on all of the identified ads, regardless of which detector discovered it. Bug: 708570 Change-Id: Ic0f1f1cfd7176ffdba459b607735a6aa6b4318ff Reviewed-on: https://chromium-review.googlesource.com/567324Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486797}
-
arthursonzogni authored
A bug has been introduced in: https://crrev.com/2834013002. The assumption that Content-ID URLs can't be loaded without an MHTMLArchive doesn't hold. It is possible for instance with the Yahoo Mail app. It embeds chrome as a Webview. The webview load attached image with the Content-ID scheme. This CL allows the load instead of blocking it. BUG=739658 TBR=japhet@chromium.org Review-Url: https://codereview.chromium.org/2975623002 Cr-Commit-Position: refs/heads/master@{#486796}
-
kylechar authored
Make the creation of CompositorFrameSinkSupport go through HostFrameSinkManager. This takes us one step closer to viz architecture without using Mojo anywhere. FrameSinkManager is injected into HostFrameSinkManager if we want this path to be available. Every callsite in the browser process that creates a CompositorFrameSinkSupport goes through HostFrameSinkManager, with the exception of Android webview which doesn't use HostFrameSinkManager at all. This requires adding a dep from //components/viz/host to //components/viz/service again. It also requires adding an interface for DirectLayerTreeFrameSink. Bug: 742374 Change-Id: I22b9fb855b7a16716dccd4d5233c72412f9b2259 Reviewed-on: https://chromium-review.googlesource.com/570504 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486795}
-
Daniel Bratell authored
There are two very small, identical, To16Bit functions in font shaping tests. Since they caused collisions in jumbo builds and I didn't want to exclude the files from jumbo files I've merged them into a utilities file. Bug: Change-Id: I0c7e7d4ee708431a6401de7a01790f78c4e75e08 Reviewed-on: https://chromium-review.googlesource.com/570426 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#486794}
-
Dirk Pranke authored
This is a reland of patchset #1 of https://codereview.chromium.org/2936053003, except that we do not pass the flag when using the ChromeOS custom toolchains, either. TBR=hans@chromium.org, manojgupta@chromium.org, thakis@chromium.org BUG=712797 Change-Id: I14f56c9b29234dd693719b017828c6250202a9d0 Reviewed-on: https://chromium-review.googlesource.com/571440Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486793}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/57f228d75275..21dd189fe50d $ git log 57f228d75..21dd189fe --date=short --no-merges --format='%ad %ae %s' 2017-07-14 npm Use CFX_MaybeOwned in CJBig2_TRDProc Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I372752bccfc8f5b290bf809a9fe3d75b9c835c27 Reviewed-on: https://chromium-review.googlesource.com/571172 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486792}
-
Regan Hsu authored
Allow tether notifications to display blue icons with varing signal strength. Bug: 740686 Change-Id: I2e3477b899ece0a511270c82f48d52d44bfaf608 Reviewed-on: https://chromium-review.googlesource.com/564199 Commit-Queue: Regan Hsu <hsuregan@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#486791}
-
Marc-Antoine Courteau authored
The titles for the PaymentRequestEditViewController and for the PaymentRequestSelectorViewController are now computed in the mediators instead of being set from the coordinators. R=mahmadi Bug: 602666 Change-Id: I6cabdd0920854db1f06a4d6b99952ce49f396b91 Reviewed-on: https://chromium-review.googlesource.com/568264 Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486790}
-
Scott Violet authored
Specifically the following: . TestContextProvider now uses skia_bindings::GrContextForGLES2Interface, without this skia doesn't use the right context and produces ids that aren't expected. . Converts Ash to use TestLayerTreeFrameSinkClient vs FakeContextFactory. TestLayerTreeFrameSinkClient seems closer to what these tests need vs FakeContextFactory. BUG=734811 TEST=test only changes Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4f3d7a432d7f23a9e1e243d045846949b52c51fc Reviewed-on: https://chromium-review.googlesource.com/550587 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#486789}
-
Peng Huang authored
Having one LayerTreeFrameSink for every sub-surface causes synchronizing problem between sub-surfaces, so we decide to only have one LayerTreeFrameSink per toplevel window. Bug: 731742 Change-Id: I6f3e09c33f6f98aab281ce2fab032f9df29f1e7d Reviewed-on: https://chromium-review.googlesource.com/552719 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486788}
-
Mike Case authored
Installing Xcode 9 requires sudo so we are adding a wrapper script so that we will be able to do the installation securely on the bots. BUG=736060 Change-Id: I0bee7dcf9dfe58f27bc77d200d221458fad09a44 Reviewed-on: https://chromium-review.googlesource.com/568667Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Michael Case <mikecase@chromium.org> Cr-Commit-Position: refs/heads/master@{#486787}
-
Ramin Halavati authored
There was a possible race condition between IO and UI threads in this test. It is now prevented by adding an extra wait for task completion. Bug: 739433 Change-Id: If2060e859cfb001218cee909eafb6739a4e5d314 Reviewed-on: https://chromium-review.googlesource.com/568144Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486786}
-
Dominic Battre authored
The PasswordFormMetricsRecorder enforced that a single save/update bubble was shown to users. With manual fallbacks, this restriction is too strong. Therefore, this CL introduces an enum that tracks the currently displayed bubble, which is enough to attribute dismissal reasons to update/save bubbles. Bug: 732846 Change-Id: I84377c4416962dfd0ed1f3e4e601aaa9f87bd042 Reviewed-on: https://chromium-review.googlesource.com/571005 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#486785}
-
proberge authored
Now that Chrome Cleanup has its own opt-in, the SBER/Scout state should not be passed to the Cleaner's command-line to make sure it isn't accidentally used. Bug: 690020 Change-Id: I6f1ecb60f2a9d0bdb5c3f4bbab728621082a2879 Reviewed-on: https://chromium-review.googlesource.com/570349Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#486784}
-
Yipeng Wang authored
This CL also deletes webview_licenses.py and related files. Bug: 734846 Change-Id: Ib1dcdbd10c8c97993811e0c977bfaa68d0562315 Reviewed-on: https://chromium-review.googlesource.com/569075Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
-
chrome://dinoEdward Jung authored
Remove top:0 in CSS and take into account the initial 35px top positioning in the translate calculation. Bug: Change-Id: I7634e2308fa8a18dff35ab9572e8e9f323741696 Reviewed-on: https://chromium-review.googlesource.com/571822Reviewed-by:
-
Matt Falkenhagen authored
This clears the bindings right when the filter is removed, instead of when the filter is destructed. Speculative fix for the bug where apparently Mojo messages arrive after the ServiceWorkerDispatcherHost has been destroyed. Bug: 736203 Change-Id: Ifae0db23a6a17cfa30b558f714916001d37f6571 Reviewed-on: https://chromium-review.googlesource.com/564746 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486781}
-
James Cook authored
session_state_delegate_chromeos.(h|cc) don't exist anymore. TBR=xiyuan@chromium.org Bug: none Test: checkdeps passes Change-Id: I9f258838cf3f5f6e966b53b8954973fa7403e117 Reviewed-on: https://chromium-review.googlesource.com/571963 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#486780}
-
Theresa Wellington authored
Notify BottomSheet, BottomSheetContentController, and BottomSheetNewTabController about activity destruction and do appropriate clean up (including ending animations). BUG=741041 Change-Id: Iee2d185d87e520e99a865cb569cc14a006aba55f Reviewed-on: https://chromium-review.googlesource.com/570719 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#486779}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/cf79ee5626dd..477d0efcf2d9 $ git log cf79ee562..477d0efcf --date=short --no-merges --format='%ad %ae %s' 2017-07-14 bsalomon Make ops in bezier_effects GMs be non-Legacy GrMeshDrawOps 2017-07-14 liyuqian Remove SK_SUPPORT_LEGACY_RECT flag 2017-07-14 ethannicholas fixed sksl static ifs to work for CircleEffect 2017-07-13 bsalomon Make ops used in OnFlushCallbackTest be non-legacy GrMeshDrawOps. 2017-07-13 fmalita Purge cached SkPictureShader entries on shader deletion 2017-07-13 egdaniel Add metal config to tools 2017-07-14 bsalomon init GrDrawAtlasOp::fColor Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: If0d3a27e0068100aae09c4d6e3e0b0b3bc5198c6 Reviewed-on: https://chromium-review.googlesource.com/571509Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486778}
-
mrefaat authored
Set the pendingItemIndex to the last committed item in case of page reload and on the case of application open/tab out of memory reopened. This doesn't solve the PendingItem being null problem entirely there are still couple cases when that can happen and they are not page reloads. CL 1/2 BUG=676129 Review-Url: https://codereview.chromium.org/2931833004 Cr-Commit-Position: refs/heads/master@{#486777}
-
Elly Fong-Jones authored
This code only works when USE_AURA, which is when gfx::NativeView is an aura::Window. BUG=None Change-Id: I6fd619acb4bcf854a111d43295ed20186d47f872 Reviewed-on: https://chromium-review.googlesource.com/565300 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#486776}
-
Emil A Eklund authored
In r484771 the painting logic for table cells and rows with a background image was inadvertently changed as a part of a refactoring. This in turn led to the wrong ImageClient being used in cases where the background is set on the table row as opposed to the cell. The bug was introduced between patch set 3 and 4 of the original change. This CL restores the original behavior by using the correct ImageClient. TEST=fast/table/backgr_on_table_row.html BUG=742053 R=pdr@chromium.org Change-Id: I7316ddf34698ba78d43067dd46610ece628ef7fe Reviewed-on: https://chromium-review.googlesource.com/571158 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486775}
-
Tim Volodine authored
In this patch: - Refactoring in order to use a PrefService for obtaining and updating the preference values related to the interstitials. - Use the pref service for setting the default values (for the display options). - Enable user opt-in (using a check box) for the extended reporting when the interstitial is shown. - Update AwSafeBrowsingUIManager::SetExtendedReportingAllowed to modify the corresponding PrefService preference (instead of keeping a boolean inside the class). BUG=700351, 688629 Change-Id: Ifa2e2c692670213e792d05c5d3cb0ba7facc74f7 Reviewed-on: https://chromium-review.googlesource.com/567144Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#486774}
-
Mostyn Bramley-Moore authored
BUG=741927,735587 Change-Id: Ib95bd85e2f1ad14e27ba8fa76f8b52f8e137e830 Reviewed-on: https://chromium-review.googlesource.com/569159Reviewed-by:
-
Edward Lemur authored
This will make it easier to control what's being updated. Bug: None Change-Id: Ic8509707f1c6448aa897345bd3ea85d1a38bec9e Reviewed-on: https://chromium-review.googlesource.com/570399Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#486772}
-
Jonathan authored
One third of CQ runs of mash_browser_tests are failing when hitting the NOTREACHED in Compositor:DidFailToInitializeLayerTreeFrameSink so I'm disabling it while the cause is researched. TBR=sadrul@chromium.org TEST: mash_browser_tests Bug: 742966, 743028 Change-Id: I9363ebfbdeac594d26696b5426004cbafcec9c9b Reviewed-on: https://chromium-review.googlesource.com/571274Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#486771}
-
Wei-Yin Chen (陳威尹) authored
BUG=733500 Change-Id: Iee053126ab61bdb99ba78bdc74e720ff179febc6 Reviewed-on: https://chromium-review.googlesource.com/567729Reviewed-by:
-
Michael Thiessen authored
Headset NFC scan can pause and resume (without stopping) us while we're already in VR, so we stay in VR while this is happening. However, when we get paused we want to cancel VR entry so we don't enter VR while paused. This CL just adds a check to see if we're in VR before attempting to cancel entry. Bug: 742509 Change-Id: Ib0cdac3c7e10e5206410835f949f318c73e9349f Reviewed-on: https://chromium-review.googlesource.com/570742Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#486769}
-
Dirk Pranke authored
This change may affect the following builders: - chromium.chromiumos - Linux ChromiumOS Builder - Linux ChromiumOS Builder (dbg) - Linux ChromiumOS Full - chromium.fyi - Mojo ChromiumOS - chromium.gpu.fyi - Linux ChromiumOS Builder - Linux ChromiumOS Ozone Builder - chromium.memory - Linux Chromium OS ASan LSan Builder - Linux Chromium OS ASan LSan Tests (1) - Linux ChromiumOS MSan Builder - Linux ChromiumOS MSan Tests (1) - tryserver.chromium.linux - linux_chromium_chromeos_asan_rel_ng - linux_chromium_chromeos_compile_dbg_ng - linux_chromium_chromeos_compile_rel_ng - linux_chromium_chromeos_dbg_ng - linux_chromium_chromeos_msan_rel_ng - linux_chromium_chromeos_ozone_rel_ng - linux_chromium_chromeos_rel_ng The main difference from the last attempt is that this version removes ash_unittests, ash_content_unittests, browser_tests, interactive_ui_tests, and unit_tests from the ASan LSan Tests config, as they appear to be all kinds of busted. From the original CL (crrev.com/7385c63e): > Ozone is now on by default on all CrOS builds, and we don't > need to test the old x11 config any more. This CL flips > all of the CrOS builders to (implicitly) be building for Ozone, > so that we can then remove the explicit Ozone builders in a > follow-up CL. > > This builder also removes the > linux_chromium_chromeos_ozone_rel_ng builder from the CQ > since would otherwise be redundant with the > linux_chromium_chromeos_rel_ng builder. > > This CL also removes a couple of commented-out CQ entries for > builders that were removed as part of the work in bug 669297 > (linux_chromium_chromeos_compile_dbg_ng and linux_chromium_clobber_rel_ng); > at the time I had planned to re-add them once the capacity > issues were resolved, but at this point it's unclear how > important those configs are and we may want to use the > capacity for other things, and so these comments were misleading. BUG=671355, 742623 R=kylechar@chromium.org TBR=achuith@chromium.org, xdai@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng,linux_chromium_chromeos_msan_rel_ng Change-Id: I27377846c8a7ad915b68ca99abb944de58631683 Reviewed-on: https://chromium-review.googlesource.com/571195Reviewed-by:kylechar <kylechar@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486768}
-
Eric Seckler authored
Bug: Change-Id: I9b060df69df9893e65d90a58676d77bd3ec0da42 Reviewed-on: https://chromium-review.googlesource.com/571745Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#486767}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/2b918c8d05c9..57f228d75275 $ git log 2b918c8d0..57f228d75 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 janeliulwq Updated pdfium_test's WriteAnnot() 2017-07-14 npm More unique_ptrs in JBIG2 code part 2 Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I436579b6010f9dac42382eff322824ce7fbdd6ee Reviewed-on: https://chromium-review.googlesource.com/571848 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486766}
-
Dominic Battre authored
This CL introduces a new UKM metric User.ActionSimplified that corresponds to what is recorded in PasswordManagerActionsV3. I have called it ActionSimplified because I want to introduce a more detailed action but don't know whether I can build that before the branch point. Bug: 732846 Change-Id: I766ec456de100e93b61a63c0ede6fd65dbd36156 Reviewed-on: https://chromium-review.googlesource.com/571003Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/90038eee6f25..b63abe05c654 $ git log 90038eee6..b63abe05c --date=short --no-merges --format='%ad %ae %s' 2017-07-14 xunjieli [wpr-go] fix content-encoding check Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5b3512ed3221aae77be46dc5b2a197a6a6dc09e6 Reviewed-on: https://chromium-review.googlesource.com/571502 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486764}
-
ymalik authored
This CL starts CTA for VR with a custom animation to keep it hidden while we enter VR mode. This is needed to hide the 2D Chrome UI while the phone is already in the VR headset (e.g when we're deep-linking from Daydream). The animation alone is not sufficient, so we add a black overlay until we're ready to show the WebVR page. BUG=721857 Review-Url: https://codereview.chromium.org/2969923002 Cr-Commit-Position: refs/heads/master@{#486763}
-
huangs authored
This CL adds main_utils.*, which has the framework to dispatch Zucchini commands and print help messages. This is used by the Zucchini main program, and is not part of Zucchini library. - Add ::Command: A struct containing command name (e.g., "-gen", "-apply"), help message, and a base::Callback containing code for the main command. This allows Zucchini command dispatch without bulky bulky class hierarchy and superfluous instantialization. - Add ::CommandRegistry: A class to manage ::Command instances and dispatch commands, or print help messages. - Add ::ResourceUsageTracker: A class instantiated in main() to track resource usage for valid command invocations, and and print them at end. Specifically: - Zucchini.PeakPagefileUsage (KiB) - Zucchini.PeakWorkingSetSize (KiB) - Zucchini.TotalTime (s) Also add "-quiet" switch to disable this. - Add stubs for Zucchini-gen and Zucchini-apply, to be populated later. - Starting to use LOG(INFO) to display output. This requires updating PRESUBMIT.py to add Zucchini as an exception. Bug: 729154 Change-Id: Id5263435100dc73b2d8917ca2bcd04245ed41934 Reviewed-on: https://chromium-review.googlesource.com/567492 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
-
Bernhard Bauer authored
Bug: 741882 Change-Id: Iac67445a218dd98a3d0a21fdf79588d0682c94e9 Reviewed-on: https://chromium-review.googlesource.com/570168 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#486761}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/83d118550f72..cf79ee5626dd $ git log 83d118550..cf79ee562 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 rmistry Publish uploaded RecreateSKPs CL Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I49e94ec456b566d09c9708f326625548e70782bc Reviewed-on: https://chromium-review.googlesource.com/570733Reviewed-by:
-
Hidehiko Abe authored
While migrating ArcService into BrowserContextKeyedService, it turned out the boilerplate looks much bigger than what we expected. To minimize it reasonably, this CL introduces ArcBrowserContextKeyedServiceFactoryBase and use it for already migrated service classes. BUG=739097 TEST=Ran trybot. Ran on DUT. Change-Id: I13a1e7019c06ea64fa48cec6ecf7a9e589e84b00 Reviewed-on: https://chromium-review.googlesource.com/569847Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486759}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a97abb90..3921afc2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iaa2269f32243c34ca9813ed72c2650a4ab3f34db Reviewed-on: https://chromium-review.googlesource.com/571271Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486758}
-
