GitLab

Bug: 736480
Change-Id: Ia26ce365ebe41af525e74a805da1b139eb43dc85
Reviewed-on: https://chromium-review.googlesource.com/576145
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487628}

Revert "Add a PageLoadMetricsObserver that tracks all observed features and reports a new histogram"

This reverts commit 1423af08.

Reason for revert: 
Broke build 
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/36753

Original change's description:
> Add a PageLoadMetricsObserver that tracks all observed features and reports a new histogram
> 
> For more information, please refer to this doc:
> 
> https: //docs.google.com/document/d/1jaUv28xBPrOrkZV9gck9btEKvgM8u_awO83SXraPbQ4/edit?usp=sharing
> Bug: 716565
> Change-Id: I040ecc5e44df15768649684b4f5ee8d5e828c209
> Reviewed-on: https://chromium-review.googlesource.com/534133
> Commit-Queue: Luna Lu <loonybear@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Rick Byers <rbyers@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487612}

TBR=rbyers@chromium.org,dcheng@chromium.org,mpearson@chromium.org,thakis@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,loonybear@chromium.org

Change-Id: I84cb3780b38511fc84394f81c04c339d0cc3a5fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 716565
Reviewed-on: https://chromium-review.googlesource.com/576569Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487627}

Before this CL, LayoutView of a non-composited sub-frame in non-RLS mode
would report the clipped rect as its VisualOverflowRect(). After this
CL, such LayoutView will report the whole document rect instead.

This change is needed for correctly computing visual rects of
LayoutView display items in SPv2.

Also it is a layering violation for VisualOverflowRect(), which itself
is a compositing input, to depend on compositing state.

Change-Id: I67636aa72318770bbfb810b17eb5a5d176816257
Reviewed-on: https://chromium-review.googlesource.com/566086
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487626}

This change will allow for the detection of tasks running in
TaskScheduler that fail to post their task in a COM STA Task Runner
instead.

BUG=706512
TBR=gab@chromium.org
Previously Reviewed at https://chromium-review.googlesource.com/c/549223/

Review-Url: https://codereview.chromium.org/2978253002
Cr-Commit-Position: refs/heads/master@{#487625}

This reverts logic allowing WebMediaPlayerImpl to ignore all suspend
requests. Now, content embedders can only specify whether they want
idle media players to be suspended automatically after a period of
inactivity. Explicit suspends (such as through the content::MediaSession
API) will still remain functional.

This change is necessary since Chromecast needs to support explicit
media suspension when a tab is hidden.

BUG=internal b/34257330

Change-Id: I4a1e9891b136e987b5677ac1391ca3d2c1dd1bde
Reviewed-on: https://chromium-review.googlesource.com/575513Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487624}

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189

Review-Url: https://codereview.chromium.org/2971073002
Cr-Commit-Position: refs/heads/master@{#487623}

Extract overlay checking status into a stand-alone enum and provide a
corresponding mojo EnumTraits for it.

BUG=620927

Change-Id: I411e5ec402ce580a61478383ac9b2482a33989f0
Reviewed-on: https://chromium-review.googlesource.com/575701Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487622}

Bug: 745877
Change-Id: I05d3fcdbe55509d808f0ab696b159ca22876a0b8
Reviewed-on: https://chromium-review.googlesource.com/576358Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487621}

This CL:

* Makes the build target generate the credits page for the app.
* Adds the credits page to the help view.

Bug: 745233
Change-Id: Id612c7140fbdcc9433854d26f8c33509c28ac3c2
Reviewed-on: https://chromium-review.googlesource.com/575041Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487620}

https://boringssl.googlesource.com/boringssl/+log/14308731e5446a73ac2258688a9688b524483cb6..0e4a448ab8aa66a38593f68d19fa0a2e340833e4

TBR=davidben@chromium.org
BUG=none

Change-Id: Ief8d5002ca44783ef35e4836fa7ea2b34e05b38b
Reviewed-on: https://chromium-review.googlesource.com/575817
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487619}

Bug: 679030
Change-Id: I431e32e5287602fe3321e0ae803a0314e3d87ea2
Reviewed-on: https://chromium-review.googlesource.com/576364Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487618}

https://skia.googlesource.com/skia.git/+log/c432b0ca8a50..312f4b24f96f

$ git log c432b0ca8..312f4b24f --date=short --no-merges --format='%ad %ae %s'
2017-07-18 rmistry Copy over private SKPs during SKP asset create command
2017-07-18 halcanary SkPDF: Re-use Jpeg Image Shaders
2017-07-18 ethannicholas sksl now sees vulkan caps
2017-07-18 jvanverth Add some convexity checks to shadow code.
2017-07-18 mtklein start on raster pipeline 2d mode
2017-07-18 csmartdalton vk: Fix geometry-shader input varying locations

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I4eada1f195c6b4360f99205c87a835834e768ce7
Reviewed-on: https://chromium-review.googlesource.com/576361Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487617}

When we disabled the drag and drop on stylus input devices, we also
disabled the text selections. We should allow text selection on stylus
input devices, so users can copy and paste. 

Bug:742373

Change-Id: I9ea34111f5caef494c6c973a15ee15401b33c603
Reviewed-on: https://chromium-review.googlesource.com/574654Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487616}

Timer is the preferred method to schedule recurring tasks rather than
rescheduling a PostDelayedTask.

Bug: 734280
Change-Id: I2200a9fe636eb7e59bf868dc8227aecc82095bcc
Reviewed-on: https://chromium-review.googlesource.com/575776Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487615}

Revert of Cros Tablet Window management - Split Screen part II (patchset #9 id:160001 of https://codereview.chromium.org/2955203002/ )

Reason for revert:
Broke ash_unittests
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28279

Original issue's description:
> Cros Tablet Window management - Split Screen part II
>
> Wire up the SplitViewController with the overview mode. It's a following
> up CL of https://codereview.chromium.org/2960843004/.
>
> Changes in this CL:
> 1. The split view mode can be initiated by dragging the window in
> overview mode to the side of the screen
> 2. After one window is snapped to one side of the screen, all the other
> overview windows will display in the other side of the screen, allowing
> the user to select another window to snap. When two windows are snapped
> to both sides of the screen, the overview mode will be ended.
> 3. The first snapped window will remain snapped until the user
> explicitly exit the split view mode. All the other windows (incluing
> newly created window) will be open in the other side of the screen.
> Clicking/Tapping on the overview button also open the overview windows
> in the other side of the screen.
>
> Not covered in this CL:
> 1. The highlighted region showing where split will occur is not
>    implemented in this CL.
> 2. The split divider is not implemented in this CL.
>
> BUG=725683
>
> Review-Url: https://codereview.chromium.org/2955203002
> Cr-Commit-Position: refs/heads/master@{#487542}
> Committed: https://chromium.googlesource.com/chromium/src/+/0c6d79c9a3a2bf404ef94220c389924541c92f0b

TBR=oshima@chromium.org,varkha@chromium.org,xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=725683

Review-Url: https://codereview.chromium.org/2978273002
Cr-Commit-Position: refs/heads/master@{#487614}

When creating a new Webstate we hit a DCHECK since SetWebUsageEnabled
is false, this CL fixes that problem by setting the Webstate 
SetWebUsageEnabled to true on creation. 

Bug: 
Change-Id: I0fd5b9d57c9d66d78bc5370d54fe8f38065f5932
Reviewed-on: https://chromium-review.googlesource.com/575841Reviewed-by: Ed Chin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487613}

For more information, please refer to this doc:

https: //docs.google.com/document/d/1jaUv28xBPrOrkZV9gck9btEKvgM8u_awO83SXraPbQ4/edit?usp=sharing
Bug: 716565
Change-Id: I040ecc5e44df15768649684b4f5ee8d5e828c209
Reviewed-on: https://chromium-review.googlesource.com/534133
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487612}

Before this patch, parsing a web app manifest with multiple
"related_applications" would return an empty manifest. Multiple
different "fingerprints" would return the first fingerprint multiple
times. These bugs occurred because of incorrect usage of index "i"
instead of "j" for "fingerprints". The "i" index is used only for
"related_applications".

This patch adds tests TwoRelatedApplicationsWellFormed for parsing two
"related_applications" and TwoDifferentSignaturesWellFormed for parsing
multiple different "fingerprints" in the web app manifest. Before the
fix, the tests fail. The tests pass after the fix, which is to use "j"
instead of "i" index for "fingerprints".

After this patch, parsing a web app manifest with multiple
"related_applications" returns a manifest with two sections. Parsing
multiple different "fingerprints" returns different parsed fingerprints.

Bug: 745765
Change-Id: I43953748a405e5d3ef2329e22ba3ff449b10f104
Reviewed-on: https://chromium-review.googlesource.com/575715Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487611}

The tests added are:
1.) Search google for this image not shown in context menu
    (and doesn't crash).
2.) Search engine preference is disabled in settings (also
    doesn't crash).

BUG=720504

Change-Id: Ib481169f83c789a4aa23aac37d13d5fe512c443f
Reviewed-on: https://chromium-review.googlesource.com/576387Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487610}

Requested by the speed releasing team.

Bug: 
Change-Id: I87228f82856a0fce7034023e90ca18d524af0db1
Reviewed-on: https://chromium-review.googlesource.com/576237
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487609}

Now with unittests!

Also do not try to put non-UTF8 strings into NetLog,
because a DCHECK files as soon as a TestBoundNetLog is used.

Also remove a solitary DVLOG() statement,
since other failure modes do not have one.

Change-Id: I67e82c09a4e73a8561973c3db432e4364d05ad55
Reviewed-on: https://chromium-review.googlesource.com/570627
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487608}

Bug: 
Change-Id: I09d909e626db4212a572d0d854c4af0cebcc9633
Reviewed-on: https://chromium-review.googlesource.com/574905
Commit-Queue: Lukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: David Sehr <sehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487607}

https://pdfium.googlesource.com/pdfium.git/+log/fe1c8e616680..56725242559d

$ git log fe1c8e616..567252425 --date=short --no-merges --format='%ad %ae %s'
2017-07-18 dsinclair Fix CONTINUED spelling
2017-07-18 rharrison Add documentation for code coverage support
2017-07-18 dsinclair Add missing STDCALL annotations

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib38277f1ad87f579aa2de35ecbfe2f40110c024f
Reviewed-on: https://chromium-review.googlesource.com/576332
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487606}

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG=662543
This CL was uploaded by git cl split.

R=sehr@chromium.org

Review-Url: https://codereview.chromium.org/2980653003
Cr-Commit-Position: refs/heads/master@{#487605}

According to crbug.com/714303, testPostFormToSamePage was disabled on
devices due to flakiness, however, I couldn't repro locally as of
today, so I'm marking it as flaky on devices and see if it's still
reproducible on FYI bots.

Bug: 714303
Change-Id: I68bfc9d9771cbb00ac8161eb024cd8c52ee40244
Reviewed-on: https://chromium-review.googlesource.com/576290Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487604}

This allows the Chrome Cleanup WebUI to be consistent when the settings
page is refreshed. It also works around https://crbug.com/740629 by
having the state change immediately rather than the next time a settings
page is opened.

Previously, if a settings page was opened before transition to kInfected,
refreshing the page would not show the card. However, if a new settings
page was opened, refreshing the original one would start showing the
card. This caused some re-layout issue in some edge cases.

Bug: 690020
Change-Id: Ib56c372bbe3f5b63c050abbd26bf7e6e4958eb8a
Reviewed-on: https://chromium-review.googlesource.com/568907
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487603}

There is an option to configure the maximum size of the NetLog. The
default is 100MiB.

Bug: 679030
Change-Id: I9260d7ee895d589c4789a350ca4fe1dfc8617b65
Reviewed-on: https://chromium-review.googlesource.com/571514
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487602}

Bug: None
Test: pass
Change-Id: I97c70f276ccfe7edc5aaa698893e5860bdc4ef6e
Reviewed-on: https://chromium-review.googlesource.com/575025
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487601}

Also give a consistent team mailing list for threaded-rendering-dev@chromium.org

R=flackr@chromium.org, vollick@chromium.org

Change-Id: I1a80a98715af27baf8839caef6ecb4b3b2b25ff6
Reviewed-on: https://chromium-review.googlesource.com/576331Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487600}

Adds a variations param to allow experimentation on tap
suppression after a recent scroll.  This suppression
is on by default, but we may want to increase the value
in a general tap-suppression experiment. This param
existed in a previous version so we're using the same
param name as before to avoid confusion.

Bug: 745970
Change-Id: Ie73f354f5ed799c00034e1d206fffa9e0746c25c
Reviewed-on: https://chromium-review.googlesource.com/576347Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487599}

Bug: 730692
Change-Id: Ia5133f2f31e0411e374a051e6f907df570c252c4
Reviewed-on: https://chromium-review.googlesource.com/576373Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487598}

This CL introduces an alternative rendering thread for WebAudio.
Note that there is no change when the user opt-outs the AudioWorklet
runtime flag*.

When the AudioWorklet runtime flag is set, AudioDestination runs on
the AudioWorkletThread object's backing thread which is the same
thread used for all the other AudioWorklet infrastructure.
(e.g AudioWorkletGlobalScope + V8)

This change will significantly help the future AudioWorklet CLs to
land.

* flag from command line: --enable-blink-features=Worklet,AudioWorklet

Bug: 469639
Change-Id: I43be54ff04fd51d88253fd879a6a5dff566fc4dc
Reviewed-on: https://chromium-review.googlesource.com/565442Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487597}

Adds a HeadlessQuotaPermissionContext.

When the ContentBrowserClient did not return a valid QPC, nullptr
crashes were possible.

Bug: 733569
Change-Id: I082e3953580620b84802dc3330dbae3c113301c4
Reviewed-on: https://chromium-review.googlesource.com/574545Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487596}

- Replace 2 instances of WeakPtr usage in DialServiceImpl with a
CancelableTaskTracker to track thread-hopping calls to obtain network
interfaces.
- Replace the callbacks bound to DialServiceImpl using WeakPtr passed
to DialSocket with a raw pointer DialServiceImpl. This is safe because
DialServiceImpl owns DialSockets.
- Remove WeakPtrFactory from DialServiceImpl.

Bug: 735590
Change-Id: I4965a33a7a706b057ee7d0f4c5cb6fb98b06dbc2
Reviewed-on: https://chromium-review.googlesource.com/574993Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487595}

If the token service has already a refresh token for the authenticated
account before this account is signed in to Chrome, then |OnRefreshTokenAvailable|
notification will not be called after |OnActiveAccountLogin|.

This CL changes the TiclInvalidationService to handle the case when the
refresh token is already present when |OnActiveAccountLogin| is fired.

See bug for the link to the design document.

Bug: 733226
Change-Id: I205e522ebe75c059b9125e113f451cf328a2f564
Reviewed-on: https://chromium-review.googlesource.com/559537Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487594}

After this change, users can define a repeated field in protobuf,
message Message {
  repeated <type> foo;
}

and use
    GetParamSize(sizer, p.foo())
    WriteParam(m, p.foo())
and
    ReadParam(m, iter, r->mutable_foo())
to serialize and deserialize the field.

Serializing and deserializing a RepeatedField / RepeatedPtrField are needed in
change https://codereview.chromium.org/2964613002/.

BUG=650926

Review-Url: https://codereview.chromium.org/2968003005
Cr-Commit-Position: refs/heads/master@{#487593}

Changes:
1. Make the dots of pagination switcher centered vertically on
AppsGridView no matter their number.

Spec: https://screenshot.googleplex.com/QHkyJRGmz46
Screenshot: https://screenshot.googleplex.com/MLduTvsXwcf

BUG=741007

Change-Id: I5305267af35b21ba3446424c3bedc8d2eab8615d
Reviewed-on: https://chromium-review.googlesource.com/576249Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487592}

Only read 64KiB of the events file at a time.

Bug: 679030
Change-Id: If063b547d547240f79024350c1cead13e0f6426e
Reviewed-on: https://chromium-review.googlesource.com/572185
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487591}

BUG=734199

Review-Url: https://codereview.chromium.org/2978443002
Cr-Commit-Position: refs/heads/master@{#487590}

BUG=706512

Change-Id: Ib252b2e692f36494e829eeefdb9664fb82f34909
Reviewed-on: https://chromium-review.googlesource.com/576309Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487589}